Colin Clark [Sun, 13 Jul 2025 10:59:27 +0000 (11:59 +0100)]
Fix #1764: Status bar icon for unsaved metadata always shows "no unsaved metadata"
https://github.com/BestImageViewer/geeqie/issues/1764
JoneKone [Sat, 12 Jul 2025 15:13:09 +0000 (16:13 +0100)]
Metadata icon on status bar
Change metadata icon to indicate when file metadata has been updated.
Colin Clark [Fri, 11 Jul 2025 09:28:51 +0000 (10:28 +0100)]
Bug fix: Memory leak
Fix minor memory leak.
Arkadiy Illarionov [Thu, 10 Jul 2025 19:51:22 +0000 (22:51 +0300)]
Reduce parameters number of menu_spin()
Callback for "value_changed" is always menu_choice_spin_cb().
Parameters value and data are always one variable.
Also add some constants to avoid magic values.
Colin Clark [Thu, 10 Jul 2025 14:35:41 +0000 (15:35 +0100)]
Fix #1782: Add note about debug levels for short help stdout
https://github.com/BestImageViewer/geeqie/issues/1782
- Add debug text to help output
- Fix bug in processing --debug=0 option
Colin Clark [Wed, 9 Jul 2025 15:34:55 +0000 (16:34 +0100)]
Tidy documentation for bash completion and cache maintenance
Remove no longer used text and options.
Bash completion cannot be used with cache maintenance because the cache
maintenance option has to be given to the GtkApplication via an
environment variable, and bash completion does not see the in-line
environment variables.
Colin Clark [Wed, 9 Jul 2025 10:51:33 +0000 (11:51 +0100)]
Update CHECKLIST
Language files do not need updating unless a .po file has been updated,
in which case that will have been done during the pull request for the
updated .po file.
Arkadiy Illarionov [Tue, 8 Jul 2025 19:56:00 +0000 (22:56 +0300)]
Fix crash on drag-and-drop if source has directory
Deduplicate check if FileDataList has directory element.
Arkadiy Illarionov [Tue, 8 Jul 2025 19:01:08 +0000 (22:01 +0300)]
Drop redundant collection_info_free_thumb()
Arkadiy Illarionov [Tue, 8 Jul 2025 18:54:36 +0000 (21:54 +0300)]
Drop static variable collection_list_sort_method
Use sort with data.
Colin Clark [Tue, 8 Jul 2025 12:01:45 +0000 (13:01 +0100)]
Fix #1788: Instructions related to translation update are outdated
https://github.com/BestImageViewer/geeqie/issues/1788
- Update ./README.md
- Create ./po/README.md
- Create script to update a .po file
- Remove redundant files
Colin Clark [Tue, 8 Jul 2025 09:59:35 +0000 (10:59 +0100)]
Fix code correctness warning
Set collection_info_new() to be static.
Arkadiy Illarionov [Mon, 7 Jul 2025 19:57:32 +0000 (22:57 +0300)]
Use collection_add() instead of collection_add_check()
Since value of must_exist parameter is always TRUE.
Make collection_add_check() static for now.
Colin Clark [Mon, 7 Jul 2025 14:09:03 +0000 (15:09 +0100)]
Update documentation - document Collections infotext
- Update help files to describe Collections infotext
- Change occurrences of "info text" to infotext - to make it easier for
users to search help files for this feature
- Remove trailing space
Colin Clark [Mon, 7 Jul 2025 12:38:56 +0000 (13:38 +0100)]
Bug fix: Help html files not generated
After the previous fix for symlinks, ./build/doc/html was not populated.
But even so, /usr/local/share/doc/geeqie/html was populated after
installation.
The only source I could find for these files was /usr/share/doc/html
which still contained old files.
This patch fixes the problem.
Uwe Ohse [Sat, 5 Jul 2025 11:35:18 +0000 (13:35 +0200)]
Allow to show a per-image information text in the collection window, loaded from and re-saved to the .gqv file
Arkadiy Illarionov [Sun, 6 Jul 2025 10:34:07 +0000 (13:34 +0300)]
Drop redundant SearchUi check_* members
Colin Clark [Sun, 6 Jul 2025 11:28:06 +0000 (12:28 +0100)]
Fix #1800: Project targets '>=1.0.0' but uses feature introduced in '1.3.0': follow_symlinks arg in install_subdir
Set required meson version to 1.3.2
Arkadiy Illarionov [Sun, 6 Jul 2025 09:22:43 +0000 (12:22 +0300)]
Drop redundant menu choice callbacks
No need to get combo value until search start.
Also drop unused SearchData::search_exif member.
Move menu_choice_get_match_type() to anonymous namespace.
JoneKone [Fri, 4 Jul 2025 12:26:25 +0000 (13:26 +0100)]
Fix icon theme detection for case-insensitive 'dark'
JoneKone [Fri, 4 Jul 2025 12:09:33 +0000 (13:09 +0100)]
Fix doc symlink install warning
Arkadiy Illarionov [Wed, 2 Jul 2025 19:54:59 +0000 (22:54 +0300)]
Use std::array as items parameter in menu_choice_menu()
Convert some text_search_menu_* constants to references to equal values.
Arkadiy Illarionov [Wed, 2 Jul 2025 07:14:42 +0000 (10:14 +0300)]
Split menu_choice_menu() from menu_choice()
Arkadiy Illarionov [Sun, 29 Jun 2025 09:39:21 +0000 (12:39 +0300)]
Use g_autolist(WindowNames)
Arkadiy Illarionov [Sat, 28 Jun 2025 18:20:14 +0000 (21:20 +0300)]
Use g_autolist(PathData)
Simplify parts_list() and merge with parts_list_add_node_points().
Arkadiy Illarionov [Sat, 28 Jun 2025 16:50:04 +0000 (19:50 +0300)]
Use g_autolist(GtkTreePath)
Simplify related code.
Arkadiy Illarionov [Sat, 28 Jun 2025 12:16:57 +0000 (15:16 +0300)]
Return TRUE/FALSE from keyword_compare() and rename to keyword_equal()
Simplify related code.
Colin Clark [Sat, 28 Jun 2025 10:16:45 +0000 (11:16 +0100)]
Fix Geeqie icon in README
Make sure the Geeqie icon in the README is displayed both when viewed
stand-alone and on GitHub.
Arkadiy Illarionov [Thu, 26 Jun 2025 19:28:46 +0000 (22:28 +0300)]
Bump GLib version to 2.66
Arkadiy Illarionov [Thu, 26 Jun 2025 18:13:08 +0000 (21:13 +0300)]
Fix memory leaks after layout_window_menu_list() calls
Also remove redundant parameter.
Jose Riha [Thu, 26 Jun 2025 10:47:17 +0000 (12:47 +0200)]
Update Slovak translation.
Arkadiy Illarionov [Sat, 21 Jun 2025 10:32:24 +0000 (13:32 +0300)]
Fix pdf formats typo
Looks like formast fixed in
3491a34870c4f0ce89c9e515e0f0decf0693e6bf
was a typo for format, not formats.
Marcel Pol [Thu, 19 Jun 2025 14:38:21 +0000 (16:38 +0200)]
Fix typing mistake.
Marcel Pol [Thu, 19 Jun 2025 14:37:03 +0000 (16:37 +0200)]
Fix typing mistake.
Marcel Pol [Thu, 19 Jun 2025 14:36:20 +0000 (16:36 +0200)]
Fix typing mistake.
Marcel Pol [Thu, 19 Jun 2025 14:33:08 +0000 (16:33 +0200)]
Update Dutch (nl) translation
Arkadiy Illarionov [Mon, 16 Jun 2025 18:44:59 +0000 (21:44 +0300)]
Fix memory leaks after metadata_read_list() calls
Also inline keywords_to_string().
Colin Clark [Sun, 15 Jun 2025 14:59:19 +0000 (15:59 +0100)]
Fix #1771: Deleting (not write protected) symlinks to write protected images gives warning
https://github.com/BestImageViewer/geeqie/issues/1771
Function access() was used, but this function follows symlinks.
Instead use lstat for delete/move/rename operations.
Arkadiy Illarionov [Thu, 12 Jun 2025 12:58:15 +0000 (15:58 +0300)]
Simplify image_osd_mkinfo()
Extract get_osd_name(), get_osd_data(), add_osd_extra() functions.
Merge declaration and definition of variables where available.
Use nullptr for data in case of error in lua script name parsing.
Arkadiy Illarionov [Thu, 12 Jun 2025 14:44:30 +0000 (17:44 +0300)]
Reduce number of parameters in set_osd_button()
Rename to osd_tag_button_new().
Colin Clark [Sat, 14 Jun 2025 13:05:25 +0000 (14:05 +0100)]
Bug fix: Symbolic links are followed for files supplied on the command line
If <file> is a symbolic link, the command:
geeqie <file>
will open Geeqie with the target of the link displayed.
This is not correct.
Use the correct function.
Arkadiy Illarionov [Thu, 12 Jun 2025 14:13:39 +0000 (17:13 +0300)]
Simplify TagData handling
Remove unused title member.
Add image_overlay_template_view member to avoid using GObject properties.
Use g_signal_connect_swapped() to simplify callbacks.
Move callbacks to anonymous namespace.
Arkadiy Illarionov [Thu, 12 Jun 2025 11:22:33 +0000 (14:22 +0300)]
Add string_list_join() to reduce duplication
Arkadiy Illarionov [Thu, 12 Jun 2025 10:58:42 +0000 (13:58 +0300)]
Fix OSD string build
Colin Clark [Sun, 8 Jun 2025 12:29:57 +0000 (13:29 +0100)]
Change algorithm used for search-distance computation
In the Search GPS distance computation use the Equirectangular
approximation.
It is faster and the error is insignificant in this application.
Arkadiy Illarionov [Sat, 7 Jun 2025 18:34:15 +0000 (21:34 +0300)]
Use gtk_container_foreach() to simplify code
Fix couple memory leaks.
Colin Clark [Sat, 7 Jun 2025 11:05:33 +0000 (12:05 +0100)]
Fix #1768: Crash on "keyword autocomplete" command
https://github.com/BestImageViewer/geeqie/issues/1768
Check if the keywords pane has been initialized, and if not send an
application notification.
Colin Clark [Tue, 3 Jun 2025 14:09:04 +0000 (15:09 +0100)]
Fix #1765: No thumbnails shown in browser view on geeqie start
https://github.com/BestImageViewer/geeqie/issues/1765
Not a fix, just a workaround.
Arkadiy Illarionov [Tue, 3 Jun 2025 07:22:14 +0000 (10:22 +0300)]
Fix LTO build
Colin Clark [Sun, 1 Jun 2025 14:20:20 +0000 (15:20 +0100)]
Part fix #1751: MRU list for collections is now missing/useless
https://github.com/BestImageViewer/geeqie/issues/1761
Ensure that when a .gqv file is opened via Open File or Open Recent File
the Collection is opened.
Arkadiy Illarionov [Fri, 30 May 2025 07:07:44 +0000 (10:07 +0300)]
Return value from pixbuf_gdk_known_extensions()
Instead of using out parameter.
Use recommended prepend and sort.
Arkadiy Illarionov [Tue, 27 May 2025 18:49:39 +0000 (21:49 +0300)]
Move secure_save() to ui-fileops
Fix group id getting.
Simplify a bit.
Colin Clark [Tue, 27 May 2025 10:10:36 +0000 (11:10 +0100)]
Fix #1743: Slow since 2.6
https://github.com/BestImageViewer/geeqie/issues/1743
Incorrect init. function used.
Arkadiy Illarionov [Mon, 26 May 2025 20:48:27 +0000 (23:48 +0300)]
Simplify string building for secure_save()
Also remove unused includes and forward declaration.
8d11f52df4eb12b5bd133733fa70d02a662c5921 follow-up.
Arkadiy Illarionov [Mon, 26 May 2025 20:24:56 +0000 (23:24 +0300)]
Use file_data_list_free() in g_signal_connect_swapped
Colin Clark [Mon, 26 May 2025 15:48:51 +0000 (16:48 +0100)]
Update secure_save.cc
- Use g_file_set_contents_full() instead of the "home-built" code.
- Log file output no longer uses secure_save()
Arkadiy Illarionov [Sun, 25 May 2025 12:28:39 +0000 (15:28 +0300)]
Add FileDataList alias for GList with FileData elements
Rename filelist_free() to file_data_list_free().
Use g_autoptr macro to simplify code a bit.
Arkadiy Illarionov [Sun, 25 May 2025 12:42:56 +0000 (15:42 +0300)]
Simplify stop_signal handling in key press callbacks
Arkadiy Illarionov [Sat, 24 May 2025 14:13:50 +0000 (17:13 +0300)]
Drop unused lw parameter from layout_selectable_toolbars_toggle()
Rename to current_layout_selectable_toolbars_toggle()
Arkadiy Illarionov [Sat, 24 May 2025 13:02:38 +0000 (16:02 +0300)]
Use gtk_widget_set_visible() to simplify code
Arkadiy Illarionov [Sat, 24 May 2025 11:47:46 +0000 (14:47 +0300)]
Simplify search_file_do_extra() a bit
Colin Clark [Sat, 24 May 2025 10:32:25 +0000 (11:32 +0100)]
Bug fix: Crash using GQ_DISABLE_CLUTTER=y when config file already has gps map enabled
Fix sequencing error.
Arkadiy Illarionov [Thu, 8 May 2025 11:55:38 +0000 (14:55 +0300)]
Use filetime_set() to reduce dependency on utime
Arkadiy Illarionov [Wed, 30 Apr 2025 20:12:31 +0000 (23:12 +0300)]
Move common code to get_marks_string()
Colin Clark [Wed, 21 May 2025 14:11:08 +0000 (15:11 +0100)]
Eliminate compiler warning - preferences.cc
error: both sides of operator are equivalent
[misc-redundant-expression,-warnings-as-errors]
is issued because PREF_PAD_INDENT = PREF_PAD_SPACE
Create a workaround.
Colin Clark [Wed, 21 May 2025 12:59:36 +0000 (13:59 +0100)]
Update test-all.sh for new meson version
https://mesonbuild.com/Release-notes-for-1-7-0.html
"Test targets no longer built by default"
Call ninja explicitly for tests.
Colin Clark [Tue, 13 May 2025 07:59:32 +0000 (08:59 +0100)]
Fix #1541: MacOS: Crash when exiting fullscreen mode
https://github.com/BestImageViewer/geeqie/issues/1541#issuecomment-
2873652561
This is a blind fix.
Colin Clark [Sun, 11 May 2025 10:38:31 +0000 (11:38 +0100)]
Bug fix: Icon view, filename text not displayed, filename tooltip
If icon view is selected, and filename text is selected to be not
displayed, the tooltip text showing the filename is not displayed.
Ensure the tooltip window has a parent.
Colin Clark [Wed, 7 May 2025 13:45:00 +0000 (14:45 +0100)]
Bug fix: gtk_file_chooser dialog cannot create folders
Make the dialog modal to prevent focus being taken away.
Arkadiy Illarionov [Tue, 6 May 2025 20:42:15 +0000 (23:42 +0300)]
Get search gps once per search
Fix search gps if "Image is not geocoded" is selected.
Colin Clark [Tue, 6 May 2025 17:22:25 +0000 (18:22 +0100)]
Bug fix: --action=<illegal value> results in crash
If a command of the type:
geeqie --action=abcd
is given when geeqie is not running, there is a crash.
Check that window is valid.
Arkadiy Illarionov [Mon, 5 May 2025 19:55:40 +0000 (22:55 +0300)]
Fix readability-math-missing-parentheses warning
Colin Clark [Mon, 5 May 2025 16:35:13 +0000 (17:35 +0100)]
Fix typo
Colin Clark [Mon, 5 May 2025 14:23:30 +0000 (15:23 +0100)]
Release v2.6 files
Colin Clark [Mon, 5 May 2025 11:18:56 +0000 (12:18 +0100)]
Bug Fix #1708: Allow to have more OSD profiles
Remove unwanted text.
Arkadiy Illarionov [Wed, 30 Apr 2025 20:04:35 +0000 (23:04 +0300)]
Get search marks once per search
Arkadiy Illarionov [Wed, 30 Apr 2025 19:53:40 +0000 (22:53 +0300)]
Fix build with GCC 15
Arkadiy Illarionov [Tue, 29 Apr 2025 19:36:23 +0000 (22:36 +0300)]
Get search class once per search
Arkadiy Illarionov [Tue, 29 Apr 2025 17:32:03 +0000 (20:32 +0300)]
Drop unused search_window_list
Arkadiy Illarionov [Mon, 28 Apr 2025 20:01:00 +0000 (23:01 +0300)]
Fix date type search
And determine required FileData datetime member once in search_start_cb().
Arkadiy Illarionov [Sun, 27 Apr 2025 19:24:16 +0000 (22:24 +0300)]
Simplify calculation of search date boundaries
Arkadiy Illarionov [Sun, 27 Apr 2025 12:01:07 +0000 (15:01 +0300)]
Add SearchDate to reduce code duplication
Set values only if match date enabled.
Arkadiy Illarionov [Sat, 26 Apr 2025 11:15:38 +0000 (14:15 +0300)]
Split search UI from data
Arkadiy Illarionov [Sat, 26 Apr 2025 12:32:31 +0000 (15:32 +0300)]
Drop unused TODO
Arkadiy Illarionov [Sat, 26 Apr 2025 11:34:01 +0000 (14:34 +0300)]
Fix g_strdup_printf() memory leaks in search
Arkadiy Illarionov [Fri, 25 Apr 2025 20:36:31 +0000 (23:36 +0300)]
Drop redundant SearchData::button_help member
Arkadiy Illarionov [Wed, 23 Apr 2025 18:59:21 +0000 (21:59 +0300)]
Replace MATCH_IS_BETWEEN macro with template function
Arkadiy Illarionov [Tue, 22 Apr 2025 20:59:04 +0000 (23:59 +0300)]
Fix gtk_combo_box_text_get_active_text() memory leaks
Colin Clark [Tue, 22 Apr 2025 16:55:50 +0000 (17:55 +0100)]
Fix #1708: Allow to have more OSD profiles
https://github.com/BestImageViewer/geeqie/issues/1708
- The Edit/Preferences/OSD tab now allows 4 OSD profiles.
- Minor bug fix involving color scaling.
Arkadiy Illarionov [Sun, 20 Apr 2025 11:24:51 +0000 (14:24 +0300)]
Replace defines in GPS match with constexpr
Simplify a bit.
Arkadiy Illarionov [Sun, 20 Apr 2025 10:36:11 +0000 (13:36 +0300)]
Replace mfd_list_free() with g_list_free_full()
Arkadiy Illarionov [Sat, 19 Apr 2025 18:56:36 +0000 (21:56 +0300)]
Drop unused parameters from print_window_new()
Colin Clark [Sun, 20 Apr 2025 09:29:35 +0000 (10:29 +0100)]
Fix #1722: test failure: geeqie:analysis / Untranslated Text_ preferences.cc
https://github.com/BestImageViewer/geeqie/issues/1722
The problem line is:
"Néstor Díaz Valencia <
[email protected]>"
which contains accented characters.
I do not expect the grep expression to detect accented characters as
part of an alpha-numeric string. Why it does so on another system is not
clear.
Ignore that text line.
Arkadiy Illarionov [Sat, 19 Apr 2025 15:54:49 +0000 (18:54 +0300)]
Drop unused parameters from dupe functions
Also merge pop_menu_export() and dupe_pop_menu_export_cb().
Colin Clark [Fri, 18 Apr 2025 10:30:24 +0000 (11:30 +0100)]
GTK4: Eliminate gtk_dialog_run() call
GTK4 migration
Colin Clark [Thu, 17 Apr 2025 15:35:08 +0000 (16:35 +0100)]
GTK4: Move Sort Manager new collection dialog to gtk_file_chooser
GTK4 migration
Arkadiy Illarionov [Tue, 15 Apr 2025 21:46:00 +0000 (00:46 +0300)]
Fix g_autoptr(GList) memory leak
g_autoptr(GList) doesn't free element’s data. It works like
g_list_free() not g_list_free_full().
Colin Clark [Tue, 15 Apr 2025 09:49:18 +0000 (10:49 +0100)]
GTK4: Move dupes export dialog to gtk_file_chooser
GTK4 migration
Arkadiy Illarionov [Mon, 14 Apr 2025 20:18:04 +0000 (23:18 +0300)]
Fix more memory leaks in pan-view-filter
Colin Clark [Sun, 13 Apr 2025 15:10:33 +0000 (16:10 +0100)]
Bug fix #1706: command line duplicate search
https://github.com/BestImageViewer/geeqie/issues/1706
Fix selection logic.