| commit | 4999201a59ef555f9105d2bb2459ed895627f7aa | [log] [tgz] |
|---|---|---|
| author | Bart Van Assche <[email protected]> | Fri Aug 08 12:35:36 2014 +0200 |
| committer | Ingo Molnar <[email protected]> | Wed Aug 13 10:32:38 2014 +0200 |
| tree | 51148e7d68b8dd47f50344020b489aa20cb459e0 | |
| parent | 0a7cbf9abe3198461de3d3e97268db32a646ba06 [diff] |
locking/spinlocks: Always evaluate the second argument of spin_lock_nested()
Evaluating a macro argument only if certain configuration options
have been selected is confusing and error-prone. Hence always
evaluate the second argument of spin_lock_nested().
An intentional side effect of this patch is that it avoids that
the following warning is reported for netif_addr_lock_nested()
when building with CONFIG_DEBUG_LOCK_ALLOC=n and with W=1:
include/linux/netdevice.h: In function 'netif_addr_lock_nested':
include/linux/netdevice.h:2865:6: warning: variable 'subclass' set but not used [-Wunused-but-set-variable]
int subclass = SINGLE_DEPTH_NESTING;
^
Signed-off-by: Bart Van Assche <[email protected]>
Signed-off-by: Peter Zijlstra <[email protected]>
Cc: David Rientjes <[email protected]>
Cc: David S. Miller <[email protected]>
Cc: Andrew Morton <[email protected]>
Cc: Linus Torvalds <[email protected]>
Cc: Oleg Nesterov <[email protected]>
Cc: Paul E. McKenney <[email protected]>
Link: http://lkml.kernel.org/r/[email protected]
Signed-off-by: Ingo Molnar <[email protected]>