Project

General

Profile

Activity

From 07/28/2014 to 08/03/2014

08/03/2014

10:58 PM Feature #9894: [RFC] README.EXT: document rb_gc_register_mark_object
I tried making rb_gc_register_address work transparently but wasn't able
to measure any difference with unicorn. un...
normalperson (Eric Wong)
07:32 PM Feature #10108: NameError#name and nested constants
A full qualified name would be a more appropriate and natural fit. vipulnsward (Vipul Amler)
02:12 PM Feature #10108: NameError#name and nested constants
Do you want a method to return full qualified name, or an array of names? nobu (Nobuyoshi Nakada)
12:43 PM Feature #10108 (Feedback): NameError#name and nested constants
Hello,
We wanted to bring a discussion around the behavior of NameError#name with nested constants. The result can...
robin850 (Robin Dupret)
04:43 PM Revision 92d58cac (git): merge revision(s) r46585,r46595,r46822: [Backport #9977] [Backport #9978] [Backport #9983]
test_env.rb: rehearsal
* test/ruby/test_env.rb (test_memory_leak_{aset,select,shift}):
have a rehearsal be...
nagachika (Tomoyuki Chikanaga)
04:32 PM Bug #9983: memory leak at ENV.shift on Windows
Backported into `ruby_2_1` branch at r47055. nagachika (Tomoyuki Chikanaga)
04:31 PM Revision 856f4d49 (git): merge revision(s) r46570: [Backport #9983]
* hash.c (env_shift): fix memory leak on Windows, free environment
strings block always. [ruby-dev:48332] ...
nagachika (Tomoyuki Chikanaga)
04:30 PM Bug #9978: memory leak at ENV.select on Windows
r46557 and r46565 were backported into `ruby_2_1` branch at r47054. nagachika (Tomoyuki Chikanaga)
04:28 PM Revision 85c48fdc (git): merge revision(s) r46557,r46565: [Backport #9978]
* hash.c (env_select): fix memory leak and crash on Windows, make
keys array first instead of iterating on ...
nagachika (Tomoyuki Chikanaga)
04:25 PM Bug #9977: memory leak at ENV.[]= on Windows
Backported into `ruby_2_1` branch at r47053. nagachika (Tomoyuki Chikanaga)
04:24 PM Revision d4132b8a (git): merge revision(s) r46550: [Backport #9977]
* hash.c (ruby_setenv): fix memory leak on Windows, free
environment strings block after check for the size...
nagachika (Tomoyuki Chikanaga)
04:21 PM Bug #9903: Regexp#[] doesn't consider capture name encoding
Backported into `ruby_2_1` branch at r47052. nagachika (Tomoyuki Chikanaga)
04:20 PM Revision 3aefb61f (git): merge revision(s) r46345,r46346: [Backport #9903]
re.c: reduce new strings
* re.c (match_aref, rb_reg_regsub): reduce new strings creation
for exceptions.
...
nagachika (Tomoyuki Chikanaga)
04:07 PM Bug #9961: TracePoint can skip c_return with rb_rescue()
もうひとつ [:c_call, :coerce] の直後の [:c_call :to_s], [:c_return, :to_s] が 2.1 では検出されないのですが、こちらは出所がわからなかったのでテストから削って r47051 ... nagachika (Tomoyuki Chikanaga)
03:51 PM Bug #9961: TracePoint can skip c_return with rb_rescue()
バックポート時のメモ。テストでチェックしている TracePoint のフック呼び出しに影響していたため r44610, r44617 も r47050 でバックポートしました。 nagachika (Tomoyuki Chikanaga)
04:07 PM Revision 84091a71 (git): merge revision(s) r46465,r46469,r46484: [Backport #9961]
* vm.c (rb_vm_rewind_cfp): add new function to rewind specified cfp
with invoking RUBY_EVENT_C_RETURN.
...
nagachika (Tomoyuki Chikanaga)
03:50 PM Revision fe45e6b7 (git): merge revision(s) r44610,r44617:
numeric.c: preserve encoding
* numeric.c (coerce_failed): preserve encoding of error message.
git-svn-id: s...
nagachika (Tomoyuki Chikanaga)
03:19 PM Revision 477e28cc (git): * 2014-08-04
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@47049 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
03:19 PM Revision 33e1c86f (git): openssl: constify
* ext/openssl/ossl_asn1.c (ossl_asn1_info): constify.
* ext/openssl/ossl_pkcs7.c (ossl_pkcs7_sym2typeid): constify a...
nobu (Nobuyoshi Nakada)
03:19 PM Revision 98630412 (git): ossl_pkcs7.c: consider length
* ext/openssl/ossl_pkcs7.c (ossl_pkcs7_sym2typeid): consider
length to compare.
git-svn-id: svn+ssh://ci.ruby-lang...
nobu (Nobuyoshi Nakada)
01:33 PM Revision a98c6533 (git): rubygems/util.rb: remove unused variable
* lib/rubygems/util.rb (Gem::Util.silent_system): remove unused
variable, to fix test failures with verbose flag.
...
nobu (Nobuyoshi Nakada)
12:18 PM Feature #10107: [PATCH] cleanup: rb_const_lookup helper function
nice. nobu (Nobuyoshi Nakada)
10:15 AM Feature #10107: [PATCH] cleanup: rb_const_lookup helper function
+1 ko1 (Koichi Sasada)
07:09 AM Feature #10107 (Closed): [PATCH] cleanup: rb_const_lookup helper function
This reduces casting and long lines. This should make it easier to
switch to alternatives to st for constant storag...
normalperson (Eric Wong)
10:13 AM Feature #10096: [PATCH] use khash for fstring and id_str tables
Eric Wong wrote:
> frozen_strings and global_symbols.id_str hashes are two of the bigger
> hashes in Ruby. They ar...
ko1 (Koichi Sasada)
07:10 AM Feature #10096: [PATCH] use khash for fstring and id_str tables
[email protected] wrote:
> Feature #10096: [PATCH] use khash for fstring and id_str tables
> https://bugs.ruby...
normalperson (Eric Wong)
08:20 AM Revision 6959bc50 (git): fix typos [ci skip]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@47045 b2dd03c8-39d4-4d8f-98ff-823fe69b080e znz (Kazuhiro NISHIYAMA)
01:56 AM Revision 4713ace4 (git): strscan.c: encoding in messages
* ext/strscan/strscan.c (strscan_aref): preserve argument encoding
in error messages.
git-svn-id: svn+ssh://ci.rub...
nobu (Nobuyoshi Nakada)
01:56 AM Revision 27c4fb33 (git): ext: get rid of inadvertent ID creation
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@47043 b2dd03c8-39d4-4d8f-98ff-823fe69b080e nobu (Nobuyoshi Nakada)
01:56 AM Revision 1d670ab0 (git): ext: prefer RB_TYPE_P over comparison TYPE with constants
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@47042 b2dd03c8-39d4-4d8f-98ff-823fe69b080e nobu (Nobuyoshi Nakada)
01:55 AM Revision fdfb939d (git): transcode.c: use string
* transcode.c (econv_opts): get rid of inadvertent ID creation,
and preserve argument encoding in error messages.
...
nobu (Nobuyoshi Nakada)
01:55 AM Revision d0987afc (git): make symbol conversion functions public
* include/ruby/encoding.h (rb_check_symbol_cstr): ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@47040 b2d...
nobu (Nobuyoshi Nakada)
01:54 AM Revision 48bb55ed (git): README.EXT.ja: using commas and periods
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@47039 b2dd03c8-39d4-4d8f-98ff-823fe69b080e nobu (Nobuyoshi Nakada)
01:43 AM Bug #10106 (Closed): Segfault when refining BasicObject
Applied in changeset r47037.
----------
vm_insnhelper.c: fix unusable super class
* vm_insnhelper.c (vm_call_method...
nobu (Nobuyoshi Nakada)
01:43 AM Revision a17eb7ba (git): * 2014-08-03
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@47038 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
01:43 AM Revision a6d34e75 (git): vm_insnhelper.c: fix unusable super class
* vm_insnhelper.c (vm_call_method): unusable super class should cause
method missing when BasicObject is refined bu...
nobu (Nobuyoshi Nakada)

08/02/2014

06:39 PM Bug #10106 (Closed): Segfault when refining BasicObject
This works:
~~~ruby
module RefinementBug
refine BasicObject do
def foo
1
end
end
end
u...
mxhold (Max Holder)
06:31 PM Feature #9725: Do not inspect NameError target object unless verbose
> ## Solutions:
>
> * `NameError` should not capture the target object.
> * `NameError` should build a message ba...
josh.cheek (Josh Cheek)
03:25 PM Revision 1760861c (git): merge revision(s) r44577,r45097,r45330,r45331,r45354,r45356: [Backport #10033]
cptr.c: unused variable
* ext/dl/cptr.c (rb_dlptr_inspect): remove no longer used variable.
git-svn-id: svn...
nagachika (Tomoyuki Chikanaga)
03:14 PM Revision 39da0b90 (git): merge revision(s) r46649: [Backport #10005]
* node.c (dump_node): handle nd_value == (NODE *)-1 to mean this
keyword argument is required
git-svn-id:...
nagachika (Tomoyuki Chikanaga)
02:55 PM Revision c3e1258c (git): * properties.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@47034 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
02:55 PM Revision 4e7801a1 (git): * ext/win32ole/win32ole.c: separate WIN32OLE::VARIANT src file
from win32ole.c
* ext/win32ole/win32ole.h: ditto.
* ext/win32ole/win32ole_variant_m.c: ditto.
* ext/win32ole/win32ole...
suke (Masaki Suketa)
02:18 PM Feature #6817: Partial application
Michael Kohl wrote:
> In that case, how about making `Symbol#to_proc` accept additional arguments?
>
> ~~~ruby
>...
nobu (Nobuyoshi Nakada)
08:59 AM Feature #6817: Partial application
Koichi Sasada wrote:
> Basically, I like this proposal.
> But I'm not sure this notation can be acceptable.
In ...
citizen428 (Michael Kohl)
11:04 AM Feature #9781: Feature Proposal: Method#super_method
Yukihiro Matsumoto wrote:
> OK, accepted.
>
> The name should be 'super_method', since 'super' make me feel invoc...
aledovsky (Aleksandrs Ļedovskis)
11:01 AM Revision a52fa3eb (git): * Changelog: fix typo. contribute from @chiastolite.
[fix GH-693]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@47032 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
hsbt (Hiroshi SHIBATA)
05:41 AM Revision cefef1f1 (git): * ext/win32ole/win32ole.c: VERSION 1.7.0 -> 1.7.1
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@47031 b2dd03c8-39d4-4d8f-98ff-823fe69b080e suke (Masaki Suketa)
05:37 AM Revision dde71a3d (git): * ext/win32ole/win32ole.c: add coments for rdoc.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@47030 b2dd03c8-39d4-4d8f-98ff-823fe69b080e suke (Masaki Suketa)
01:30 AM Bug #10105 (Third Party's Issue): Mixed styles for class methods on Tempfile break RDocs.
Rather I think it a bug of RDoc. nobu (Nobuyoshi Nakada)
01:27 AM Feature #6373 (Closed): public #self
Applied in changeset r47028.
----------
object.c: Object#itsef
* object.c (rb_obj_itself): new method Object#itsef....
nobu (Nobuyoshi Nakada)
01:27 AM Revision 963bce15 (git): * 2014-08-02
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@47029 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
01:26 AM Revision 0a0160d6 (git): object.c: Object#itsef
* object.c (rb_obj_itself): new method Object#itsef. based on the
patch by Rafael França in [ruby-core:64156].
[...
nobu (Nobuyoshi Nakada)

08/01/2014

08:27 PM Bug #10105 (Closed): Mixed styles for class methods on Tempfile break RDocs.
I've already made a little pull request here https://github.com/ruby/ruby/pull/691.
The diff is here: https://gith...
eloyesp (Eloy Esp)
06:23 PM Feature #6373: public #self
Here the implementation. This is my first patch to Ruby so I'm not sure it is correct. Let me know if I need to chang... rafaelfranca (Rafael França)
05:18 PM Feature #6373: public #self
We just implemented it on Active Support https://github.com/rails/rails/commit/702ad710b57bef45b081ebf42e6fa70820fdd8... rafaelfranca (Rafael França)
03:17 PM Bug #10103 (Feedback): Unable to refine class with CONSTANT
Constants (and class variables) are not included in refinement modification. Constants still belong to outer class.
...
matz (Yukihiro Matsumoto)
01:32 PM Revision a13944dc (git): * ext/win32ole/win32ole.c (folerecord_inititalize): accept
only 2 arguments. The 2nd argument should be WIN32OLE object or
WIN32OLE_RECORD object.
git-svn-id: svn+ssh://ci....
suke (Masaki Suketa)
11:20 AM Revision 2cce8185 (git): * ext/win32ole/win32ole.c (ole_variant2val): call
folerecord_s_allocate instead of WIN32OLE_RECORD.new.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@47026 b2dd0...
suke (Masaki Suketa)
09:57 AM Bug #10019: segmentation fault/buffer overrun in pack.c (encodes)
This crash only triggers with FORTIFY_SOURCE. When calling rb_str_buf_cat at the end of encodes for the situation whe... pwann (Poul Wann Jensen)
09:41 AM Revision 1e667d5f (git): * test/date/test_date.rb: remove commented-out code.
* test/date/test_date_arith.rb: ditto.
* test/date/test_date_attr.rb: ditto.
* test/date/test_date_parse.rb: ditto.
...
hsbt (Hiroshi SHIBATA)
08:30 AM Bug #10086: [PATCH] Remove exponents calculation from mathn.rb
@Yusuke Endoh さん
よこやりありがとうございます.
はい. 全くもって正しいご指摘だと思います. すみません僕が修正する際に気づくべきでした.
引き合いに出された文全体を
>mathn ser...
gogotanaka (Kazuki Tanaka)
02:09 AM Bug #10086: [PATCH] Remove exponents calculation from mathn.rb
よこやりですが、
> If you need
> more precise rounding with multiple division or exponentiation
> operations, then mathn...
mame (Yusuke Endoh)
07:35 AM Revision 52b59fc9 (git): numeric.c: 0 % Float::NAN returns Float::NAN
* numeric.c (flodivmod): all results are NaN if divisor is NaN.
[fix GH-692]
git-svn-id: svn+ssh://ci.ruby-lang.or...
nobu (Nobuyoshi Nakada)
07:35 AM Revision 528ef3ca (git): add assertions for division NaN
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@47023 b2dd03c8-39d4-4d8f-98ff-823fe69b080e nobu (Nobuyoshi Nakada)
05:40 AM Bug #10102: [PATCH] dir.c: [DOC] Document that Dir.exists? is deprecated
Robert A. Heiler wrote:
> I think the reasoning given here makes sense and is consistent.
>
> matz explained that...
mcfiredrill (Tony Miller)

07/31/2014

11:31 PM Bug #10102: [PATCH] dir.c: [DOC] Document that Dir.exists? is deprecated
I think the reasoning given here makes sense and is consistent.
matz explained that the question that should be as...
shevegen (Robert A. Heiler)
06:22 AM Bug #10102 (Closed): [PATCH] dir.c: [DOC] Document that Dir.exists? is deprecated
I noticed Dir.exists? was undocumented, so I thought Dir.exists? should be marked as deprecated just like File.exists... mcfiredrill (Tony Miller)
10:36 PM Revision 4514516b (git): * 2014-08-01
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@47022 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
10:36 PM Revision bf3d294a (git): * ext/bigdecimal/bigdecimal.c: [DOC] Add description of
`BigDecimal.new` exceptions. Patched by @joker1007 and
@prathamesh-sonpatki [Fixes GH-690]
https://github.com/ru...
Kenta Murata
06:56 PM Bug #10086: [PATCH] Remove exponents calculation from mathn.rb
@Nobuyoshi Nakada さん
コメントありがとうございます.
> alias / quo の変更は不要に見えますが
個人的にaliasを貼る時は(特にoperatorに対して)symbolの方が可読性が高...
gogotanaka (Kazuki Tanaka)
02:09 AM Bug #10086 (Feedback): [PATCH] Remove exponents calculation from mathn.rb
`**`の削除は(`alias / quo` の変更は不要に見えますが)いいと思います。
最後のパッチで"multiple division"から"multiple"という単語が消されていますが、これはいらないのでしょうか。
nobu (Nobuyoshi Nakada)
05:45 PM Bug #10104 (Rejected): Fileutils cp_r fails on sockets or fifes even if File.mknod and File.mkfifo are defined
Briefly, our code uses cp_r to copy a directory structure whose contents seem to occasionally have a Unix domain sock... wpaulson (Bill Paulson)
04:21 PM Bug #10103: Unable to refine class with CONSTANT
I would like to also mention that this impacts class_variables as well
~~~
module Foobar
@@baz = "boom"
...
engineersmnky (Mike Hein)
03:44 PM Bug #10103 (Closed): Unable to refine class with CONSTANT
When refining a class (such as `String` in the following example) it is impossible to assign a constant. The constant... kyledecot (Kyle Decot)
04:00 PM Feature #10090: Display of program name in process listing under AIX
+1 on fixing this.
Is it possible AIX is missing some headers supplied on other systems?
moses (Moses Mendoza)
01:37 PM Bug #9937: Segfault in the TracePoint API
Hi, I'll be fixing this inside byebug. I don't think the assumption that TracePoint API events will always provide a ... deivid (David Rodríguez)
02:38 AM Bug #9937 (Assigned): Segfault in the TracePoint API
Thank you for your report.
ko1 san, could you handle this issue?
nagachika (Tomoyuki Chikanaga)
01:31 PM Feature #6613: VT_RECORD, IRecordInfo Support in WIN32OLE
Sorry for waiting too long. I had implemented VT_RECORD / IRecordInterface features.
Try WIN32OLE_RECORD class in ru...
suke (Masaki Suketa)
01:21 PM Revision 9437332a (git): * ext/win32ole/win32ole.c: add WIN32OLE_RECORD#inspect.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@47020 b2dd03c8-39d4-4d8f-98ff-823fe69b080e suke (Masaki Suketa)
12:15 PM Feature #6265: Remove 'useless' 'concatenation' syntax
I said "useless" in the sense that you can achieve the same using "+" and it makes it easy to introduce common bugs i... rosenfeld (Rodrigo Rosenfeld Rosas)
03:34 AM Feature #6265: Remove 'useless' 'concatenation' syntax
I'm against it, it's not "useless" to me. nobu (Nobuyoshi Nakada)
03:18 AM Feature #6265: Remove 'useless' 'concatenation' syntax
Release Manager of 2.2.0 is naruse san. nagachika (Tomoyuki Chikanaga)
11:38 AM Revision 1069b277 (git): * ext/win32ole/win32ole.c: add
WIN32OLE_RECORD#ole_instance_variable_set and
WIN32OLE_RECORD#ole_instance_variable_get
git-svn-id: svn+ssh://ci...
suke (Masaki Suketa)
09:58 AM Revision 6016da7d (git): symbol.h: move macros
* symbol.h (RSYMBOL): move macros for Symbol from internal.h.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@4701...
nobu (Nobuyoshi Nakada)
06:23 AM Revision 5b0ccdbc (git): win32/configure.bat: revert a commit by accident
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@47017 b2dd03c8-39d4-4d8f-98ff-823fe69b080e nobu (Nobuyoshi Nakada)
05:52 AM Revision 4a2cf2fe (git): * remove trailing spaces.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@47016 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
05:52 AM Revision 7a8836bd (git): * properties.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@47015 b2dd03c8-39d4-4d8f-98ff-823fe69b080e nobu (Nobuyoshi Nakada)
03:05 AM Bug #9979 (Assigned): Regression: BigDecimal::ROUND_HALF_DOWN/ROUND_HALF_EVEN behave incorrectly
Joseph, thank you for your report.
But I think current behavior on trunk is correct as described in #3803.
...
nagachika (Tomoyuki Chikanaga)
01:08 AM Bug #9353 (Closed): Struct setter methods now return the struct object rather than the value
naruse (Yui NARUSE)
12:53 AM Bug #10101 (Closed): Zlib::GzipReader produce different outputs for different methods applied
The methods `read`, `readbyte` and `each_byte` are producing different outputs. Comparing with the unziped file, only... manzo (Rafael Manzo)

07/30/2014

05:06 PM Bug #9964: TracePoint invoke unexpected b_call events with redo
Backported into `ruby_2_1` branch at r47014. nagachika (Tomoyuki Chikanaga)
05:05 PM Revision d2c896e0 (git): merge revision(s) r46471: [Backport #9964]
* compile.c (rb_iseq_compile_node): put start label of block after
trace (b_call).
[Bug #9964]
...
nagachika (Tomoyuki Chikanaga)
04:48 PM Bug #10019: segmentation fault/buffer overrun in pack.c (encodes)
Well the reproducibility issue appears to be a toolset problem. If I build with -O2 the code works fine. I think ul... wkwood (Will Wood)
04:41 PM Bug #10100 (Closed): Document usage of RB_GC_GUARD in README.EXT
I see more and more extensions and ruby code using this and yet it is undocumented. Eric posted this - http://blade.n... gnufied (hemant kumar)
04:38 PM Bug #9959: TracePoint can invoke inconsistent call event with bmethod
Backported into `ruby_2_1` branch at r47013. nagachika (Tomoyuki Chikanaga)
04:37 PM Revision e0c00fcc (git): merge revision(s) r46464: [Backport #9959]
* vm.c (invoke_block_from_c): move call/return event timing for
bmethod. It can invoke inconsistent call ev...
nagachika (Tomoyuki Chikanaga)
04:21 PM Bug #9957: TracePoint catch b_return at rescue/ensure
Backported into `ruby_2_1` branch at r47012. nagachika (Tomoyuki Chikanaga)
04:21 PM Revision d22cfb2f (git): merge revision(s) r46463: [Backport #9957]
* vm_core.h: add VM_FRAME_MAGIC_RESCUE to recognize normal block or
rescue clause.
* vm.c (vm_exec...
nagachika (Tomoyuki Chikanaga)
04:18 PM Revision b1b779fa (git): * 2014-07-31
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@47011 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
04:17 PM Revision 8a22a053 (git): mkmf.rb: try without -ObjC option
* lib/mkmf.rb (have_framework): try without -ObjC option first as
MacPorts GCCs do not support it.
git-svn-id: svn...
nobu (Nobuyoshi Nakada)
03:53 PM Bug #9940: Unexpected throw from TracePoint hooks with recursive checking
r46419 and r46429 were backported into `ruby_2_1` branch at r47009. nagachika (Tomoyuki Chikanaga)
03:52 PM Revision cd1f0078 (git): merge revision(s) r46419,r46429: [Backport #9940]
* vm_trace.c: clear and restore recursive checking thread local data
to avoid unexpected throw from TracePo...
nagachika (Tomoyuki Chikanaga)
02:31 PM Revision e3230f15 (git): * sprintf.c (rb_str_format): like r47006, get rid of
function calls in RSTRING_PTR().
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@47008 b2dd03c8-39d4-4d8f-98ff-823...
ktsj (Kazuki Tsujimoto)
02:27 PM Revision a0dc245f (git): signal.c: preserve encoding
* signal.c (rb_f_kill, trap_signm): preserve argument encoding in
error messages.
git-svn-id: svn+ssh://ci.ruby-la...
nobu (Nobuyoshi Nakada)
01:46 PM Revision e5a7c2db (git): get rid of function calls in RSTRING_PTR
* process.c (rlimit_resource_type, rlimit_resource_value): get rid
of function calls in RSTRING_PTR(), as it evalua...
nobu (Nobuyoshi Nakada)
01:17 PM Revision 3b895e83 (git): * process.c (rlimit_resource_type, rlimit_resource_value):
get rid of inadvertent dynamic symbol pin-down.
* re.c (match_backref_number): ditto.
* signal.c (esignal_init, rb_...
ktsj (Kazuki Tsujimoto)
12:56 PM Feature #10098: [PATCH] Timing-safe string comparison for OpenSSL::HMAC
Matt U wrote:
> - Since Ruby has only the one `String` class for text and data, I think it does make sense to keep t...
cremno (cremno phobia)
02:07 AM Feature #10098: [PATCH] Timing-safe string comparison for OpenSSL::HMAC
Nobuyoshi Nakada wrote:
> `rb_tsafe_eql()` doesn't need to be `VALUE`, `int` is OK.
> Tests for timing-safeness are...
arrtchiu (Matt U)
12:36 PM Revision 00b040b8 (git): thread.c, vm_method.c: avoid inadvertent pin-down
* thread.c (rb_thread_variable_set): get rid of inadvertent dynamic
symbol pin-down.
* vm_method.c (obj_respond_to...
nobu (Nobuyoshi Nakada)
12:36 PM Revision 6db9db48 (git): string.c: rb_to_symbol
* string.c (rb_to_symbol): new function to convert an object to a
symbol.
git-svn-id: svn+ssh://ci.ruby-lang.org/r...
nobu (Nobuyoshi Nakada)
12:36 PM Revision e1b064c5 (git): thread.c: fix indent
* thread.c (threadptr_local_aset): fix indent, remove unnecessary
braces.
git-svn-id: svn+ssh://ci.ruby-lang.org/r...
nobu (Nobuyoshi Nakada)
12:35 PM Revision 1889a5b2 (git): * ext/win32ole/win32ole.c (ole_invoke): pass WIN32OLE_RECORD variant
by reference when invoke OLE methods at first.
* ext/win32ole/win32ole.c (olerecord_set_ivar): release
IRecordInfo...
suke (Masaki Suketa)
09:13 AM Bug #10099 (Rejected): Compiling Ruby 2.1.2 with OpenSSL "recipe for target 'openssl_missing.o' failed"
Use homebrew's openssl instead of OpenSSL.framework. naruse (Yui NARUSE)
06:24 AM Revision f29dae35 (git): * 2014-07-30
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@47000 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
06:24 AM Revision 2cb8ee94 (git): * gc.c: remove unused macros.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46999 b2dd03c8-39d4-4d8f-98ff-823fe69b080e ko1 (Koichi Sasada)

07/29/2014

08:21 PM Feature #10059 (Feedback): [PATCH and SUGGEST] 代数構造を記述する時にメタプログラミングは非常に非常に強力ですが
kosaki (Motohiro KOSAKI)
08:19 PM Bug #10076: 2nd thread can't get mutex even though 1st thread released it (race)
Your code is very artifactual and the patch of comment #2 reduce a performance of normal case. So, until someone prov... kosaki (Motohiro KOSAKI)
07:10 PM Feature #10098: [PATCH] Timing-safe string comparison for OpenSSL::HMAC
I don't like the proposed method name.
`tsafe`? It should be `timingsafe`. Saving some keystrokes isn't worth it t...
cremno (cremno phobia)
04:31 PM Feature #10098: [PATCH] Timing-safe string comparison for OpenSSL::HMAC
`rb_tsafe_eql()` doesn't need to be `VALUE`, `int` is OK.
Tests for timing-safeness are desirable, but it would be f...
nobu (Nobuyoshi Nakada)
10:30 AM Feature #10098: [PATCH] Timing-safe string comparison for OpenSSL::HMAC
What's your thoughts on this new patch?
At the moment I'm using OSX and Linux, unable to test `timingsafe_memcmp()...
arrtchiu (Matt U)
07:35 AM Feature #10098: [PATCH] Timing-safe string comparison for OpenSSL::HMAC
Agree to extract a function, I meant it by "provide timing-safe binary compare function".
But the name `*_memcmp` do...
nobu (Nobuyoshi Nakada)
05:59 AM Feature #10098: [PATCH] Timing-safe string comparison for OpenSSL::HMAC
Nobuyoshi Nakada wrote:
> According to [notes on timingsafe_memcmp](http://www.tedunangst.com/flak/post/notes-on-tim...
arrtchiu (Matt U)
05:47 AM Feature #10098: [PATCH] Timing-safe string comparison for OpenSSL::HMAC
According to [notes on timingsafe_memcmp](http://www.tedunangst.com/flak/post/notes-on-timingsafe-memcmp),
OpenBSD h...
nobu (Nobuyoshi Nakada)
05:26 AM Feature #10098: [PATCH] Timing-safe string comparison for OpenSSL::HMAC
Seems correct.
I made a benchmark for it:
~~~ruby
# bm-tsafe_eql.rb: [Feature #10098]
require 'benchmark'
...
nobu (Nobuyoshi Nakada)
03:56 AM Feature #10098: [PATCH] Timing-safe string comparison for OpenSSL::HMAC
Nobuyoshi Nakada wrote:
> `slow` is not the main concern here, IMHO.
> The latter is more descriptive, but seems le...
arrtchiu (Matt U)
02:01 AM Feature #10098: [PATCH] Timing-safe string comparison for OpenSSL::HMAC
Matt U wrote:
> How about moving this to a method on `String` - e.g. `String#slow_eql?` or `String::timing_safe_eql?...
nobu (Nobuyoshi Nakada)
01:39 AM Feature #10098: [PATCH] Timing-safe string comparison for OpenSSL::HMAC
Thanks for the feedback!
Nobuyoshi Nakada wrote:
> * Indent style mismatch
> * Should try to convert the argumen...
arrtchiu (Matt U)
01:25 AM Feature #10098: [PATCH] Timing-safe string comparison for OpenSSL::HMAC
* Indent style mismatch
* Should try to convert the argument with `StringValue()`
* Why HMAC only? Other digests d...
nobu (Nobuyoshi Nakada)
03:15 PM Bug #10099 (Rejected): Compiling Ruby 2.1.2 with OpenSSL "recipe for target 'openssl_missing.o' failed"
Hi,
I compile Ruby 2.1.2 from source but "get recipe for target 'openssl_missing.o' failed". I don't understand wh...
yb601 (Iain Barnett)
01:25 PM Revision db91d29f (git): * ext/win32ole/win32ole.c (hash2olerec): ignore WIN32OLE_RECORD
instance variable if the variable is nil.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46998 b2dd03c8-39d4-4d...
suke (Masaki Suketa)
10:48 AM Revision ce4325f3 (git): * ext/win32ole/win32ole.c (folerecord_method_missing): refactoring.
divide functionality of folerecord_method_missing into
olerecord_ivar_set and olerecord_ivar_get.
git-svn-id: sv...
suke (Masaki Suketa)
08:22 AM Revision e3ba618f (git): compile.c: suppress a warning
* compile.c (compile_data_alloc): cast to suppress a warning by
apple gcc-4.2. it doesn't cause an error but a war...
nobu (Nobuyoshi Nakada)
07:55 AM Bug #10019: segmentation fault/buffer overrun in pack.c (encodes)
Nobuyoshi Nakada wrote:
> I couldn't reproduce it with that code, can you?
I can't, and I explained that the outp...
thoger (Tomas Hoger)
07:41 AM Revision 9a8b21b3 (git): ruby-additional.el: change key
* misc/ruby-additional.el (ruby-encode-unicode): change key
binding to get rid of conflict with uncomment-region.
...
nobu (Nobuyoshi Nakada)
07:41 AM Revision c82b44e1 (git): ruby-additional.el: track by marker
* misc/ruby-additional.el (ruby-encode-unicode): use marker
instead of offset to track insertion.
git-svn-id: svn+...
nobu (Nobuyoshi Nakada)
04:18 AM Bug #9712 (Assigned): Dir.entries replace Unicode character with questionmarks
In that case, we need to ask for a backport of r42058; this must be done by usa the maintainer of 2.0 series.
Than...
zzak (zzak _)
03:28 AM Revision 360a8652 (git): marshal.c: fix symlink index
* marshal.c (w_symbol): fix symlink index. register the given
symbols, not its name.
git-svn-id: svn+ssh://ci.rub...
nobu (Nobuyoshi Nakada)
02:07 AM Feature #9064: Add support for packages, like in Java
In Java it doesn't but I only borrowed Java's name, while keeping the concept of Ruby modules. Ruby modules do search... rosenfeld (Rodrigo Rosenfeld Rosas)

07/28/2014

10:27 PM Feature #9064: Add support for packages, like in Java
It doesn't seem that `package A::B::C` searches constants from `A` and `A::B`. nobu (Nobuyoshi Nakada)
12:48 PM Feature #9064: Add support for packages, like in Java
Not all reasons, but important ones in my opinion specially as you get big namespaces and nesting level.
I didn't ...
rosenfeld (Rodrigo Rosenfeld Rosas)
10:11 PM Bug #10019: segmentation fault/buffer overrun in pack.c (encodes)
Tomas Hoger wrote:
> Hence the minimal reproducer should be:
>
> ~~~ruby
> require 'openssl'
> digest = OpenSSL...
nobu (Nobuyoshi Nakada)
03:42 PM Bug #10019: segmentation fault/buffer overrun in pack.c (encodes)
Will Wood wrote:
> Here's the issue. In the loop (len >= 3) you check to see if there's enough room in buff. Unfor...
thoger (Tomas Hoger)
02:50 PM Bug #10019: segmentation fault/buffer overrun in pack.c (encodes)
I took a look at it yesterday. Here's the issue. In the loop (len >= 3) you check to see if there's enough room in ... wkwood (Will Wood)
08:36 PM Revision fbc3f55b (git): * 2014-07-29
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46992 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
08:36 PM Revision 2d1e5bce (git): marshal.c: fix instance variable load odrder
* marshal.c (r_symreal): fix instance variable load odrder, its
name must be read before its value. the order of f...
nobu (Nobuyoshi Nakada)
03:13 PM Feature #10098: [PATCH] Timing-safe string comparison for OpenSSL::HMAC
Modified misleading error message - new patch attached. arrtchiu (Matt U)
02:58 PM Feature #10098 (Closed): [PATCH] Timing-safe string comparison for OpenSSL::HMAC
I could be totally wrong, but it seems the standard library doesn't provide a reliable way of comparing hashes in con... arrtchiu (Matt U)
02:32 PM Bug #10013: [CSV] Yielding all elements from a row
First of all sorry for the late answer Andrew.
Checking arity was one thing I was considering. You're right that t...
Gat (Dawid Janczak)
01:15 PM Feature #7797: Hash should be renamed to StrictHash and a new Hash should be created to behave like AS HashWithIndifferentAccess
What do you mean by introducing a mode to make a hash indifferent? You mean another method changing how the Hash work... rosenfeld (Rodrigo Rosenfeld Rosas)
12:56 PM Feature #9980: Create HashWithIndiferentAccess using new syntax {a: 1}i
Was this rejected because the i suffix was already taken or because the idea of using suffixes would be confusing? Sh... rosenfeld (Rodrigo Rosenfeld Rosas)
12:08 PM Feature #6452: Allow extend to override class methods
Hi Boris,
there's indeed no urgency in asking for such a feature but I don't think it's a required reason for a fe...
rosenfeld (Rodrigo Rosenfeld Rosas)
11:28 AM Revision aa3b5062 (git): add some documents [ci skip]
* bignum.c (Init_Bignum): [DOC] Bignum::GMP_VERSION.
* complex.c (Init_Complex): [DOC] ignore an internal class.
* ...
nobu (Nobuyoshi Nakada)
11:26 AM Revision 4d812cf6 (git): * ext/win32ole/win23ole.c (folerecord_method_missing): support
setter of member of WIN32OLE_RECORD object.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46989 b2dd03c8-39d4-4...
suke (Masaki Suketa)
08:15 AM Revision 95d1b61a (git): symbols instead of IDs
* encoding.c (rb_enc_get_index): deal with symbols instead of IDs
to get rid of inadvertent pin-downs.
* enum.c (c...
nobu (Nobuyoshi Nakada)
08:02 AM Bug #9712: Dir.entries replace Unicode character with questionmarks
As mentioned the documentation for version 2.0 is missing this. SketchUp 2014 embedded Ruby 2.0 and developers usuall... thomthom (Thomas Thomassen)
07:42 AM Bug #10097: Case-insensitive Regexp matching for Windows-1252 not working for ŠšŽžŒœÿŸ
I've forgotten the test file, "test/ruby/enc/test_windows_1252.rb", and added it now.
What tests are needed?
nobu (Nobuyoshi Nakada)
05:38 AM Revision e4c92f24 (git): common.mk: null device name
* common.mk (clean-platform): use $(NULL) as portabile null device
name instead of hard coded /dev/null for the por...
nobu (Nobuyoshi Nakada)
05:32 AM Feature #10084: Add Unicode String Normalization to String class
copying notes from 2014/7/26 developer's meeting (Google docs):
Proposed method names by Matz: unicode_normalize o...
duerst (Martin Dürst)
04:37 AM Feature #6373 (Open): public #self
duerst (Martin Dürst)
04:25 AM Feature #6373: public #self
Yukihiro Matsumoto wrote:
> I can accept `#itself`. I want to see it isn't conflict with existing methods.
It's ...
nobu (Nobuyoshi Nakada)
02:30 AM Feature #10095: Object#as
What about unifying this feature with this feature: https://bugs.ruby-lang.org/issues/6373? Let the block be optional... sawa (Tsuyoshi Sawada)
 

Also available in: Atom