Project

General

Profile

Activity

From 07/22/2015 to 07/28/2015

07/28/2015

09:48 PM Bug #11396: Bad performance in ruby >= 2.2 for Hash with many symbol keys
Eric Wong <[email protected]> wrote:
> I am also working on more improvements, rb_objid_hash seems weak.

May...
normalperson (Eric Wong)
08:28 PM Bug #11396: Bad performance in ruby >= 2.2 for Hash with many symbol keys
Thanks for testing. A backporter will backport it to 2.2 since this
is a regression.

I am also working on more ...
normalperson (Eric Wong)
03:13 PM Bug #11396: Bad performance in ruby >= 2.2 for Hash with many symbol keys
I can report patch is functional and seems to be working also on current ruby_2_2 branch [ruby 2.2.3p147 (2015-07-04 ... dunric (David Unric)
09:13 PM Bug #11058: [PATCH] Net::HTTPResponse#read_body raises TypeError when receiving empty gzipped response body
Almost are ok.
One thing in 0002-lib-net-http-response.rb-Net-HTTPResponse-Inflater.patch, use @inflate.total_in ins...
naruse (Yui NARUSE)
08:18 PM Bug #11400: IO.gets(/\x0d?\x0a\x0d?\x0a/, 4096) raises comparison of Fixnum with nil failed
Since you're using SSLSocket, I recommend dumping a backtrace when you
rescue since gets is implemented in Ruby in ...
normalperson (Eric Wong)
12:11 PM Bug #11400: IO.gets(/\x0d?\x0a\x0d?\x0a/, 4096) raises comparison of Fixnum with nil failed
Further Testing show that this happens (less so) when Regexp is not used, as in IO.gets("\r\n\r\n") bararchy (Bar Hofesh)
09:43 AM Bug #11400 (Closed): IO.gets(/\x0d?\x0a\x0d?\x0a/, 4096) raises comparison of Fixnum with nil failed
This is my code, "socket" is a SSLSocket this is why it allows a Regexp in gets
`begin
http_response[:http_he...
bararchy (Bar Hofesh)
08:03 PM Bug #11397 (Closed): rubygems tests slow after r51384
Applied in changeset r51414.
----------
test/rubygems/test_gem_remote_fetcher.rb: pre-generate test key
OpenSSL::PK...
Anonymous
11:38 AM Bug #11397: rubygems tests slow after r51384
Thank you Eric.
We discussed this issue today.
Your solution is good to me.
Please commit it.
hsbt (Hiroshi SHIBATA)
05:07 AM Bug #11397 (Closed): rubygems tests slow after r51384
Attached is a proposed patch to memoize the tmp_dh_callback result for RubyGems,
similar to what existing OpenSSL, D...
normalperson (Eric Wong)
03:23 PM Bug #11402 (Closed): Seg Fault on intensive numeric calculation
Occur several times:
~~~
[BUG] Segmentation fault at 0x00000000000000
ruby 2.1.4p265 (2014-10-27 revision 48166)...
laise (Alexey Chernenkov)
12:10 PM Bug #10587 (Third Party's Issue): Time#to_json != DateTime#to_json (Time#to_json not outputting iso8601)
Could you report to upstream?
https://github.com/flori/json
naruse (Yui NARUSE)
12:06 PM Bug #11401 (Assigned): Net::HTTP SSL session resumption does not send SNI
naruse (Yui NARUSE)
11:44 AM Bug #11401 (Closed): Net::HTTP SSL session resumption does not send SNI
See https://github.com/ruby/ruby/pull/964
## Problem
When an initial SSL request is done, Net::HTTP stores the ...
mkarnebeek (Michiel Karnebeek)
09:22 AM Bug #11399 (Rejected): Regexp's free-spacing mode adding whitespace to character classes
The *free-spacing* mode (x-option) does not ignore whitespace within character classes:
~~~
r = /[a
# comment
...
sos4nt (Stefan Schüßler)
07:57 AM Feature #11398: deprecate constants
It seems a good idea, for example, we have TimeoutError (instead of Timeout::Error).
Matz.
matz (Yukihiro Matsumoto)
07:34 AM Feature #11398 (Closed): deprecate constants
Sometimes old constants are deprecated but still remained for backward compatibilities.
It is not noticed and will b...
nobu (Nobuyoshi Nakada)
07:42 AM Feature #11297: Allow private method of self to be called
It changes the concept of private methods a little. It's OK to merge the patch if the document is updated at the sam... matz (Yukihiro Matsumoto)
07:35 AM Feature #11258: add 'x' mode character for O_EXCL
It looks good to me.
Matz.
matz (Yukihiro Matsumoto)
07:35 AM Feature #11253: rb_io_modestr_oflags for Ruby API
It looks good to me.
Matz.
matz (Yukihiro Matsumoto)
02:16 AM Bug #9244: unexpected behaviour of 'require' when $LOAD_PATH gets changed
~~~
$ ruby -v
ruby 2.1.6p336 (2015-04-13 revision 50298) [x86_64-darwin14.0]
$ cat test.rb
$LOAD_PATH.unshift F...
byroot (Jean Boussier)

07/27/2015

10:38 PM Bug #11396: Bad performance in ruby >= 2.2 for Hash with many symbol keys
Thanks for testing, committed as r51410 and 2.2 backport requested.

The only downside is slightly increased dynam...
normalperson (Eric Wong)
10:26 PM Bug #11396 (Closed): Bad performance in ruby >= 2.2 for Hash with many symbol keys
Applied in changeset r51410.
----------
symbol.h: memoize hashval for RSymbol
This speeds up the hash function for ...
Anonymous
07:51 PM Bug #11396: Bad performance in ruby >= 2.2 for Hash with many symbol keys
Eric Wong wrote:
> Possible fix is to memoize hashval inside struct RSymbol:
>
> http://80x24.org/spew/m/143799...
brunoe (Bruno Escherl)
10:28 AM Bug #11396: Bad performance in ruby >= 2.2 for Hash with many symbol keys
Possible fix is to memoize hashval inside struct RSymbol:

http://80x24.org/spew/m/1437992270-20549-1-git-send-ema...
normalperson (Eric Wong)
08:52 PM Bug #11048: blocks raise on missing and extra keyword args
another use case for this is hash destructuring
```
array_of_hashes.each do |key1:, key2:|
end
```
it would ...
bughit (bug hit)
06:29 PM Bug #10910 (Closed): NoMethodError when opening SSL connection with OpenSSL::SSL::VERIFY_PEER set and anonymous ciphers allowed
Applied in changeset r51409.
----------
* ext/openssl/lib/openssl/ssl.rb (module OpenSSL): raise a more
helpful ex...
Anonymous

07/26/2015

06:16 PM Bug #11396 (Closed): Bad performance in ruby >= 2.2 for Hash with many symbol keys
This started out as an issue on stackoverflow, where I found strange performance anomalies when comparing Set.include... brunoe (Bruno Escherl)
06:11 PM Feature #11253: rb_io_modestr_oflags for Ruby API
a patch is following:
```diff
diff --git a/ChangeLog b/ChangeLog
index 23f82a7..83ae426 100644
--- a/ChangeLog
...
naruse (Yui NARUSE)
04:07 PM Bug #10910 (Assigned): NoMethodError when opening SSL connection with OpenSSL::SSL::VERIFY_PEER set and anonymous ciphers allowed
tenderlovemaking (Aaron Patterson)
04:07 PM Bug #10910: NoMethodError when opening SSL connection with OpenSSL::SSL::VERIFY_PEER set and anonymous ciphers allowed
I see. I'm not sure what I did wrong because it seems to be behaving correctly now. Maybe I was running an older ver... tenderlovemaking (Aaron Patterson)
01:36 AM Bug #11395: ruby gets stuck when entropy_avail is 0
`ENOSYS` should be for that purpose.
~~~
$ ./x86_64-linux/bin/ruby -v -e 'syscall(9999)'
ruby 2.3.0dev (2015-07-...
nobu (Nobuyoshi Nakada)

07/25/2015

11:24 PM Bug #11118: Unable to build Ruby with Visual Studio 2015 RC
Now that RTM is out, is any progress being made on this? scorpion007 (Alex Budovski)
02:26 PM Bug #10910: NoMethodError when opening SSL connection with OpenSSL::SSL::VERIFY_PEER set and anonymous ciphers allowed
Just rebased against trunk, and the test still fails on my machine if I remove the changes to `ext/openssl/lib/openss... Sinjo (Chris Sinjakli)
12:48 PM Bug #11395: ruby gets stuck when entropy_avail is 0
Will `syscall` return `ENOSYS` if the given syscall number is not available?
If so, I guess the current patch will w...
mame (Yusuke Endoh)
12:45 PM Bug #11395: ruby gets stuck when entropy_avail is 0
Sorry, r51374 may lead to a problem under the following situation.
* the system uses a new libc that knows `SYS_ge...
mame (Yusuke Endoh)
12:04 PM Bug #11395 (Closed): ruby gets stuck when entropy_avail is 0
Applied in changeset r51374.
----------
random.c: get rid of blocking
* random.c (fill_random_bytes_syscall): get r...
nobu (Nobuyoshi Nakada)
08:19 AM Bug #11395: ruby gets stuck when entropy_avail is 0
Nobuyoshi Nakada wrote:
> Does this header exist?
Yes.
~~~~
compiling random.c
random.c: In function 'fill_r...
mame (Yusuke Endoh)
07:39 AM Bug #11395: ruby gets stuck when entropy_avail is 0
Does this header exist? nobu (Nobuyoshi Nakada)
04:11 AM Bug #11395: ruby gets stuck when entropy_avail is 0
Well, my system has `SYS_getrandom` but not `GRND_NONBLOCK` even in `linux/random.h`.
I'm using musl libc. It mig...
mame (Yusuke Endoh)
02:53 AM Bug #11395: ruby gets stuck when entropy_avail is 0
including `<linux/random.h>`?
And checking `errno` with `EAGAIN` doesn't seem necessary since the return value sho...
nobu (Nobuyoshi Nakada)
10:58 AM Bug #10803: Similar issue/stack trace as above in 2.1.5, 2.1.6
Hi,
since the upgrade of our chef client on ubuntu 14.04 LTS x64, we are facing a similar (same?) issue...
akaempfe (Axel Kämpfe)

07/24/2015

04:00 PM Bug #11385: `==` with bidirectional/cyclic dependency
#1448 and the specs in
https://github.com/ruby/rubyspec/blob/master/core/array/shared/eql.rb
convinced me this is d...
Eregon (Benoit Daloze)
02:08 PM Bug #11395 (Closed): ruby gets stuck when entropy_avail is 0
When `/proc/sys/kernel/random/entropy_avail` is 0, Ruby gets stuck during initialization.
$ ruby -v
(stuc...
mame (Yusuke Endoh)
11:30 AM Bug #11394 (Closed): Error in test/rinda/test_rinda.rb when IPv6 address is only ::1 assigned to the loopback device
Applied in changeset r51362.
----------
* test/rinda/test_rinda.rb (RingIPv6#prepare_ipv6): prevent to use
IPv6 lo...
ngoto (Naohisa Goto)
11:07 AM Bug #11394 (Closed): Error in test/rinda/test_rinda.rb when IPv6 address is only ::1 assigned to the loopback device
システム上に存在するIPv6アドレスが、ループバックデバイスに割り当てられた ::1 だけの場合、test/rinda/test_rinda.rb で以下のエラーが発生します。
Linux (Debian wheezy)の場合 ...
ngoto (Naohisa Goto)
07:39 AM Bug #11386 (Closed): taint flag about rb_fstring()
Applied in changeset r51360.
----------
string.c: pool only bare strings in fstring
* string.c (fstr_update_callbac...
nobu (Nobuyoshi Nakada)
05:25 AM Bug #11386: taint flag about rb_fstring()
やっぱそうなりますよねー。
ぼくもそれがいいと思います。
usa (Usaku NAKAMURA)
05:06 AM Bug #11386: taint flag about rb_fstring()
昨日笹田さんとも話した結果、「内容だけをfstringに保存する」という方針がいいのではないか、ということになりました。
https://github.com/nobu/ruby/tree/bug/fstring-extra
nobu (Nobuyoshi Nakada)
02:48 AM Bug #9244 (Feedback): unexpected behaviour of 'require' when $LOAD_PATH gets changed
2.1.2 is too old version. Please try with Ruby 2.1.6 hsbt (Hiroshi SHIBATA)
01:58 AM Bug #11384: multi-threaded autoload sometimes fails
Eric Wong <[email protected]> wrote:
> Currently testing this in a loop:
> http://80x24.org/spew/m/94541be0225...
normalperson (Eric Wong)

07/23/2015

10:28 PM Bug #11384: multi-threaded autoload sometimes fails
Currently testing this in a loop:
http://80x24.org/spew/m/94541be0225540e34f0196e9754ae0eb5c07a4b7.txt

Subject: ...
normalperson (Eric Wong)
10:10 PM Bug #10910 (Feedback): NoMethodError when opening SSL connection with OpenSSL::SSL::VERIFY_PEER set and anonymous ciphers allowed
Hi,
When I apply just the test, it doesn't fail. Are you sure the bug is still present? If it's still present, c...
tenderlovemaking (Aaron Patterson)
09:54 PM Bug #11393: segfault on trivial application, embedding in C app.
Note that the file "abc" intentionally doesn't exist. scorpion007 (Alex Budovski)
09:53 PM Bug #11393 (Third Party's Issue): segfault on trivial application, embedding in C app.
~~~c
#include <ruby.h>
#include <stdio.h>
int main()
{
ruby_setup();
rb_load_file("abc"); // AV here
ruby_...
scorpion007 (Alex Budovski)
08:31 PM Bug #11392 (Third Party's Issue): proj4_c_impl.bundle: [BUG] Segmentation fault at 0x00000000000440
~~~
DOTs-MacBook-Pro:sims moboyle$ rails s
/Users/moboyle/.rvm/gems/ruby-2.2.2/gems/rgeo-0.3.20/lib/rgeo/coord_sys/...
michaeloboyle (Michael O'Boyle)
08:01 PM Bug #10968: [BUG] object allocation during garbage collection phase in /opt/rubies/ruby-2.2.1/lib/ruby/2.2.0/openssl/ssl.rb:177
Problem still happens.
Any news with it?
It happens only on one machine on Debian 7.
Does not reproduce on same ma...
mkechinov (Michael Kechinov)
07:58 PM Feature #11375: Decreased Object Allocation in Pathname.rb
[email protected] wrote:
> You've mentioned the case statement optimization previously in a patch I sent ...
normalperson (Eric Wong)
06:45 PM Feature #11375: Decreased Object Allocation in Pathname.rb
Thanks for reviewing! I added a new patch above: https://bugs.ruby-lang.org/attachments/download/5400/ruby-changes.pa... schneems (Richard Schneeman)
07:40 PM Bug #11389: Regression in method parameter parsing
Thank you, it works fine now! <3 felixbuenemann (Felix Bünemann)
12:05 AM Bug #11389 (Closed): Regression in method parameter parsing
Applied in changeset r51350.
----------
parse.y: pop cmdarg
* parse.y (lambda_body): pop cmdarg stack for lookahead...
nobu (Nobuyoshi Nakada)
05:55 PM Feature #10949: Time is WB unprotected
@Koichi Sanada: could you guide me some hints to make Time WB-protected ? I really can't figure it out from the curre... sylvain.joyeux (Sylvain Joyeux)
05:53 PM Bug #9244: unexpected behaviour of 'require' when $LOAD_PATH gets changed
Ping ? Still happening on ruby 2.1.2p95 sylvain.joyeux (Sylvain Joyeux)
05:14 PM Feature #11390: Allow symbols starting with numbers
But it goes against the principle of least surprise that ruby follows throughout the language. It's counter-intuitive... v0dro (Sameer Deshmukh)
08:31 AM Bug #11383: Infinite loop in str_buf_cat triggered by str_gsub
Nobuyoshi Nakada wrote:
> Very interesting.
> An empty string is usually embedding, and I can't tell why there is a...
lfarcy (Laurent Farcy)
08:18 AM Bug #11391 (Closed): chopped_length should return early for empty strings
The current implementation only tries to check if the beginning of the string isn't coming after its end (I'm not eve... cesario (Franck Verrot)
07:38 AM Feature #10903: [PATCH] Matrix#zip returns a matrix
Marc-Andre Lafortune wrote:
> Hi, sorry I missed your proposal until now, and thanks for the patch.
>
> Could you...
LitoNico (Lito Nicolai)
02:00 AM Bug #11386: taint flag about rb_fstring()
むむ、早い。
で、このパッチだと、Stringのサブクラスのインスタンスだったり特異メソッドがあったりインスタンス変数を持ってたりするとfstringにならなくなってるわけですが、そもそもtaintフラグが立ってるものもfstr...
usa (Usaku NAKAMURA)
01:44 AM Bug #11386: taint flag about rb_fstring()
ほいさ nobu (Nobuyoshi Nakada)
12:06 AM Bug #11380 (Closed): Parser regression in 2.3?
Applied in changeset r51350.
----------
parse.y: pop cmdarg
* parse.y (lambda_body): pop cmdarg stack for lookahead...
nobu (Nobuyoshi Nakada)

07/22/2015

11:50 PM Bug #11386: taint flag about rb_fstring()
なるほど、とは思ったのですが、
「次にぼくは『特異メソッドを定義したStringオブジェクトをrb_fstring()に渡すと問題がある』と言うッ!」
という感じです。(そして次はインスタンス変数)
usa (Usaku NAKAMURA)
11:23 PM Bug #11386: taint flag about rb_fstring()
tainted/untaintedのfstringを分けるようにするパッチです。 nobu (Nobuyoshi Nakada)
05:31 AM Bug #11386 (Closed): taint flag about rb_fstring()
r51261以降、mswinのtest-allでfailureが出るようになった件を調査していて発見したのですが、
rb_fstring()にはtaintフラグを保存しないという問題があります。
原因は2つあって、
1....
usa (Usaku NAKAMURA)
10:49 PM Bug #11389: Regression in method parameter parsing
This bug is a duplicate of #11380. felixbuenemann (Felix Bünemann)
10:31 PM Bug #11389: Regression in method parameter parsing
The issue can be fixed by reverting r50402 which was introduced by #11107. felixbuenemann (Felix Bünemann)
06:00 PM Bug #11389 (Closed): Regression in method parameter parsing
There is a regression in parameter parsing with current ruby-2.2-head and ruby-head:
```ruby
# ruby 2.2.2p95 (201...
felixbuenemann (Felix Bünemann)
09:13 PM Feature #11390: Allow symbols starting with numbers
Permitting such syntax would needlessly complicate the parser for virtually no gain, and potentially break existing c... 0x0dea (D.E. Akers)
07:32 PM Feature #11390 (Assigned): Allow symbols starting with numbers
Currently it is not possible to create a symbol that looks like `:1twothree`.
Converting to a string and then symb...
v0dro (Sameer Deshmukh)
06:35 PM Feature #11356 (Closed): Add ECDH support to OpenSSL wrapper
Applied in changeset r51348.
----------
* ext/openssl/ossl_ssl.c: add ECDH callback support. [Feature #11356]
* tes...
Anonymous
06:32 PM Feature #9390 (Closed): Support for the ALPN TLS extension
Applied in changeset r51347.
----------
* ext/openssl/ossl_ssl.c: add ALPN support. [Feature #9390]
* ext/openssl/e...
Anonymous
04:29 PM Feature #11388 (Open): SMTP Service Extension for Delivery Status Notifications
Considering https://tools.ietf.org/html/rfc1891 and http://www.sendmail.org/~ca/email/dsn.html
TD;DR
SMTP sessio...
evserykh (Evgeniy Serykh)
02:44 PM Bug #11387 (Closed): String#force_encoding と String#reverse の後にSEGV
Applied in changeset r51344.
----------
string.c: fix coderange of reverse
* string.c (rb_str_reverse): reversed st...
nobu (Nobuyoshi Nakada)
12:53 PM Bug #11387 (Closed): String#force_encoding と String#reverse の後にSEGV
以下のコードでSEGVします。
```ruby
broken_str = "abcd\xf0"
broken_str.force_encoding("utf-8").reverse
p broken_str.reverse...
tatzyr (Tatsuya Otsuka)
01:43 PM Bug #11379: Difference in `Array#sort_by` method between Ubuntu Linux and OS X
All clear, thank you. pibako (Piotr Kowalski)
01:39 PM Bug #11379: Difference in `Array#sort_by` method between Ubuntu Linux and OS X
Because `qsort_r()` of glibc is used instead of `ruby_qsort()`. nobu (Nobuyoshi Nakada)
01:36 PM Bug #11379: Difference in `Array#sort_by` method between Ubuntu Linux and OS X
> You may not expect order is same even with two subsequent sort invocation.
Non deterministic algorithm... makes ...
pibako (Piotr Kowalski)
12:50 PM Bug #11379: Difference in `Array#sort_by` method between Ubuntu Linux and OS X
> I understand that the order cannot be guaranteed but I would expect it to work the same on all platforms.
And yo...
funny_falcon (Yura Sokolov)
08:56 AM Bug #11385: `==` with bidirectional/cyclic dependency

my version is "ruby 2.3.0dev (2015-07-21 trunk 51319) [x86_64-linux]"
and it does return true for me too
Hanmac (Hans Mackowiak)
08:34 AM Bug #11385: `==` with bidirectional/cyclic dependency
Should the result not be **false** instead?
These two instances each have a different @friend and it cannot be deter...
Eregon (Benoit Daloze)
07:16 AM Bug #11385: `==` with bidirectional/cyclic dependency
Hi Nakada-san:
~~~
D:\> ruby -v
ruby 2.2.3p147 (2015-07-04 revision 51143) [x64-mswin64_120]
D:\> ruby test.r...
lowjoel (Joel Low)
05:54 AM Bug #11385 (Rejected): `==` with bidirectional/cyclic dependency
`true` is the expected result, and the same with x64-mswin64_120. nobu (Nobuyoshi Nakada)
02:54 AM Bug #11385 (Rejected): `==` with bidirectional/cyclic dependency
```ruby
class Something
attr_accessor :friend
def initialize(friend)
self.friend = friend
end
def...
allenwq (Allen Wang)
07:18 AM Bug #11383 (Feedback): Infinite loop in str_buf_cat triggered by str_gsub
nobu (Nobuyoshi Nakada)
07:18 AM Bug #11383: Infinite loop in str_buf_cat triggered by str_gsub
Very interesting.
An empty string is usually embedding, and I can't tell why there is an empty non-embed string.
Co...
nobu (Nobuyoshi Nakada)
12:58 AM Bug #11384 (Closed): multi-threaded autoload sometimes fails
~~~
I get this failure once in a blue moon:
#8 test_autoload.rb:46:in `<top (required)>':
open("zzz.rb", "w...
normalperson (Eric Wong)
 

Also available in: Atom