Project

General

Profile

Activity

From 05/03/2018 to 05/09/2018

05/09/2018

11:34 PM Feature #14739: Improve fiber yield/resume performance
What compiler is used to compile 64-bit Ruby on Windows? ioquatix (Samuel Williams)
02:23 PM Feature #14739: Improve fiber yield/resume performance
Thanks Koichi, for your valuable response and I appreciate your past work in this area.
I started hacking on my ow...
ioquatix (Samuel Williams)
08:06 PM Bug #14741: [].pack('M') quoted printable RFC2045 contains only LF, does not contain CRLF, Messages
> To those who don't read Japanese let me summarize:
Thanks for the summary in english, shyouhei!
shevegen (Robert A. Heiler)
05:40 PM Revision 6e06d644 (git): fix potential memory leaks
* gc.c (rb_alloc_tmp_buffer_with_count): keep the order; allocate
an empty imemo first then xmalloc, to get rid of ...
nobu (Nobuyoshi Nakada)
05:19 PM Revision 8789eb02 (git): _mjit_compile_pc_and_sp: re-commit r63360
reverting r63379 (revert of r63360).
The cause of error seems to be r63350. See r63382.
git-svn-id: svn+ssh://ci.ru...
k0kubun (Takashi Kokubun)
05:17 PM Revision 5afd479d (git): compile.c: suppress a warning
* compile.c (iseq_peephole_optimize): initialize dniobj first, to
suppress a false warning by gcc 8.1.0.
git-svn-i...
nobu (Nobuyoshi Nakada)
05:11 PM Revision 179bc1b8 (git): _mjit_compile_send.erb: revert r63350
Revert "_mjit_compile_send.erb: inline recursive call"
I reverted r63360 in r63379, but the errors were reproductive...
k0kubun (Takashi Kokubun)
04:12 PM Revision 29ac19a0 (git): * 2018-05-10
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63381 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
04:12 PM Revision c4a83d29 (git): iseq.h: fix argument order
* iseq.h (ISEQ_ORIGINAL_ISEQ_ALLOC): the order of ruby_xmalloc2
arguments is `count` and `element size`.
git-svn-i...
nobu (Nobuyoshi Nakada)
01:42 PM Bug #14746 (Closed): $cppflags が ext/zlib/Makefile に反映されないため(?) Solaris 10 にて ext/zlib のmakeに失敗する
Solaris 10 にて、以下のように configure && make すると、ext/zlibのmakeに失敗します。(r63361 にて確認)
~~~
$ export PATH=/usr/local/64/bin...
ngoto (Naohisa Goto)
01:09 PM Revision 3c4f49c8 (git): _mjit_compile_pc_and_sp.erb: revert r63360
Revert "_mjit_compile_pc_and_sp.erb: make sure no uninitialized"
This triggered some `NoMethodError`s which seem to ...
k0kubun (Takashi Kokubun)
01:01 PM Bug #14678: Segmentation fault in pg
Hi,
I have the same problem, exactly the same Ruby version and revision. I can supply a crash report or 3 if you r...
yb601 (Iain Barnett)
12:51 PM Revision 34002d12 (git): Use `&.` instead of modifier if
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63378 b2dd03c8-39d4-4d8f-98ff-823fe69b080e znz (Kazuhiro NISHIYAMA)
12:50 PM Bug #14745 (Closed): High memory usage when using String#replace with IO.copy_stream
I'm using custom IO-like objects that implement #read as the first argument to IO.copy_stream, and I noticed odd memo... janko (Janko Marohnić)
11:44 AM Revision 10a495a0 (git): Use hard-coded file list instead of Dir.glob.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63377 b2dd03c8-39d4-4d8f-98ff-823fe69b080e hsbt (Hiroshi SHIBATA)
11:44 AM Revision 954d0c58 (git): Revert "Use hard-coded vesion number for CI broken."
This reverts commit f5fef0a80d597f40c2d1a8cc8079bf190039fd6f.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@6337...
hsbt (Hiroshi SHIBATA)
09:53 AM Revision abc30f25 (git): align jmp_buf to VALUE
This ec->machine.regs is marked by GC. However jmp_buf is
not defined by us. There are chances of unaligned access.
...
shyouhei (Shyouhei Urabe)
09:35 AM Revision f5fef0a8 (git): Use hard-coded vesion number for CI broken.
https://rubyci.org/logs/rubyci.s3.amazonaws.com/ubuntu/ruby-trunk/log/20180509T063003Z.fail.html.gz
git-svn-id: svn+...
hsbt (Hiroshi SHIBATA)
09:09 AM Bug #14744: Refinements modules have a superclass
shugo (Shugo Maeda) wrote:
> The superclass of a refinement module is for implementing super in refined methods.
> ...
Eregon (Benoit Daloze)
03:57 AM Bug #14744: Refinements modules have a superclass
> So the refinement module (self in the refine Array do block) is a Module, but looking at its ancestors it has Array... shugo (Shugo Maeda)
07:46 AM Revision a6108df9 (git): RSTRING_PTR is not guaranteed to be VALUE-aligned
Don't abuse struct RString to hold arbitrary memory region.
Thanks to @mame we now have rb_imemo_alloc_auto_free_poin...
shyouhei (Shyouhei Urabe)
07:11 AM Revision e9303e1a (git): Rename imemo_alloc with imemo_tmpbuf
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63372 b2dd03c8-39d4-4d8f-98ff-823fe69b080e mame (Yusuke Endoh)
07:08 AM Revision af069678 (git): gc.c (rb_imemo_alloc_new): split for each purpose
imemo_alloc is used for three purposes: auto-free pointer (alternative
of alloca), alloc_tmp_buffer, and heap allocat...
mame (Yusuke Endoh)
06:55 AM Revision 01d998aa (git): type func(); is different from type func(void);
If a function declarator includes no parameter list, that doesn't
mean the function takes zero parameter. rb_ast_new ...
shyouhei (Shyouhei Urabe)
06:12 AM Revision 58823392 (git): gc.c (rb_imemo_alloc_new): improve the API interface
rb_imemo_alloc_new returns rb_imemo_alloc_t*, but took VALUEs, which is
inconsistent. To make the intention clear, i...
mame (Yusuke Endoh)
05:42 AM Revision 75d5cf55 (git): RSTRING_PTR is not guaranteed to be VALUE-aligned (retry)
Don't abuse struct RString to hold arbitrary memory region.
Raw pointer should just suffice.
git-svn-id: svn+ssh://...
shyouhei (Shyouhei Urabe)
05:41 AM Bug #14743: Some links broken in README
I can't answer your two questions, but for what it's worth,
aycabta commented on the linked/associated github issue:...
shevegen (Robert A. Heiler)
04:45 AM Revision 433a4e66 (git): Fixed file structure for csv.gemspec.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63367 b2dd03c8-39d4-4d8f-98ff-823fe69b080e hsbt (Hiroshi SHIBATA)
04:39 AM Revision 8835dd49 (git): * properties.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63366 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
04:39 AM Revision 74db990e (git): * append newline at EOF.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63365 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
04:39 AM Revision 5c1941a9 (git): Merge csv-1.0.2 from upstream.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63364 b2dd03c8-39d4-4d8f-98ff-823fe69b080e hsbt (Hiroshi SHIBATA)
02:42 AM Revision dfc56b8c (git): revert r63362 due to test failure. Sorry!
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63363 b2dd03c8-39d4-4d8f-98ff-823fe69b080e shyouhei (Shyouhei Urabe)
02:36 AM Revision 7079db9e (git): RSTRING_PTR is not guaranteed to be VALUE-aligned
Don't abuse struct RString to hold arbitrary memory region.
use rb_alloc_tmp_buffer for that purpose.
git-svn-id: s...
shyouhei (Shyouhei Urabe)

05/08/2018

08:42 PM Bug #14744: Refinements modules have a superclass
> I thought modules can never have a superclass in Ruby.
This may be a bug, I think; other modules do not seem to ...
shevegen (Robert A. Heiler)
02:26 PM Bug #14744 (Closed): Refinements modules have a superclass
~~~
$ ruby -e 'module M; refine Array do; p self; p self.class; p ancestors; end; end'
#<refinement:Array@M>
Modul...
Eregon (Benoit Daloze)
03:06 PM Revision 6061071f (git): * 2018-05-09
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63361 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
03:06 PM Revision bdb42689 (git): _mjit_compile_pc_and_sp.erb: make sure no uninitialized
area on VM stack to prevent SEGV on GC. GC may mark every value in VM
stack.
Unfortunately I couldn't write a test f...
k0kubun (Takashi Kokubun)
02:19 PM Bug #14743 (Closed): Some links broken in README
[Some links broken in README](https://github.com/ruby/docs.ruby-lang.org/issues/56) is original issue.
And I tried t...
znz (Kazuhiro NISHIYAMA)
12:48 PM Bug #14741: [].pack('M') quoted printable RFC2045 contains only LF, does not contain CRLF, Messages
shyouhei (Shyouhei Urabe) wrote:
> See also issue #14352. We have decided to reject this change. The behaviour is ...
uhrohraggy (Michael Moore)
09:29 AM Bug #14741 (Closed): [].pack('M') quoted printable RFC2045 contains only LF, does not contain CRLF, Messages
matz (Yukihiro Matsumoto)
02:05 AM Bug #14741: [].pack('M') quoted printable RFC2045 contains only LF, does not contain CRLF, Messages
See also issue #14352. We have decided to reject this change. The behaviour is now documented.
To those who don'...
shyouhei (Shyouhei Urabe)
01:45 AM Bug #14741 (Closed): [].pack('M') quoted printable RFC2045 contains only LF, does not contain CRLF, Messages
Important
You should contain at least the following items.
Reproduce process
your ruby version (ruby -v)
ruby 2...
uhrohraggy (Michael Moore)
10:58 AM Revision b755fe88 (git): vm_eval.c: eval_string_protect wrapper
* vm_eval.c (eval_string_protect): cast data instead of the
function pointer, to suppress "cast between incompatibl...
nobu (Nobuyoshi Nakada)
10:41 AM Feature #14739: Improve fiber yield/resume performance
ioquatix (Samuel Williams) wrote:
> Thanks for your feedback. When I made this issue, I could only select "Bug", "Fe...
duerst (Martin Dürst)
07:43 AM Feature #14739: Improve fiber yield/resume performance
Sorry I can't read all of your comments because it too long :p
As you quoted first,
> Here is a nice summary of...
ko1 (Koichi Sasada)
04:33 AM Feature #14739: Improve fiber yield/resume performance
It's been a while since I played around with libcoro.
I was evaluating it's performance in a C++ program.
I fou...
ioquatix (Samuel Williams)
09:09 AM Revision 841d5ae8 (git): rb_ary_dig, rb_hash_dig: nobody is using them outside.
mark them static.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63358 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
shyouhei (Shyouhei Urabe)
07:01 AM Feature #13618: [PATCH] auto fiber schedule for rb_wait_for_single_fd and rb_waitpid
I hacked in `EPOLLONESHOT` semantics into my runloop. IT was about the same performance. But when I leveraged it corr... ioquatix (Samuel Williams)
06:40 AM Feature #13618: [PATCH] auto fiber schedule for rb_wait_for_single_fd and rb_waitpid
Sorry, one more question.
I'm interested in the peformance of EPOLLONESHOT.
Is it correct that `EPOLL_CTL_(ADD/...
ioquatix (Samuel Williams)
05:25 AM Feature #13618: [PATCH] auto fiber schedule for rb_wait_for_single_fd and rb_waitpid
I studied that Mio paper.
It was very interesting.
I made a similar server in C++ using my async toolkit (the v...
ioquatix (Samuel Williams)
06:53 AM Revision 76daf51c (git): fix type mismatch.
* cont.c (fiber_context_create): `func` should accept variable args.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/tr...
ko1 (Koichi Sasada)
05:24 AM Misc #14632: [ANN] git.ruby-lang.org
>If you haven't already, enable repack.writeBitmaps (and repack)
Thanks Eric. I invoked repack and set `repack.wri...
hsbt (Hiroshi SHIBATA)
03:42 AM Bug #14742: Deadlock when autoloading different constants in the same file from multiple threads
Yes, this is an old bug and not caused by my changes, I guess.
It requires reworking some internal data structures ...
normalperson (Eric Wong)
03:12 AM Bug #14742: Deadlock when autoloading different constants in the same file from multiple threads
Investigating normalperson (Eric Wong)
02:16 AM Bug #14742 (Closed): Deadlock when autoloading different constants in the same file from multiple threads
The following example deadlocks consistently:
~~~ ruby
# a.rb
autoload :Foo, __dir__ + "/b"
autoload :Bar, __di...
eugeneius (Eugene Kenny)
03:34 AM Feature #14718: Use jemalloc by default?
I'm neutral. I have two questions.
* What will be changed by using jemalloc by default? I understood that jemall...
mame (Yusuke Endoh)
02:27 AM Feature #14718: Use jemalloc by default?
Hi, I'm a jemalloc dev (sorry I didn't see this earlier, I try to keep an eye out for mentions on bug trackers). I do... davidtgoldblatt (David Goldblatt)
02:07 AM Revision e75d8e0c (git): Merge rdoc-6.0.4 from upstream.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63356 b2dd03c8-39d4-4d8f-98ff-823fe69b080e hsbt (Hiroshi SHIBATA)
01:27 AM Bug #10892: Deadlock in autoload
The simpler repro script runs successfully from 2.3.0 onwards, and `git bisect` between 2.2.0 and 2.3.0 shows that r5... eugeneius (Eugene Kenny)
12:01 AM Revision f5f218f7 (git): cont.c: host out context setup
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63355 b2dd03c8-39d4-4d8f-98ff-823fe69b080e nobu (Nobuyoshi Nakada)
12:00 AM Revision 3dd6c0d3 (git): Remove unreachable break
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63354 b2dd03c8-39d4-4d8f-98ff-823fe69b080e znz (Kazuhiro NISHIYAMA)
12:00 AM Revision e8ec23b1 (git): Modify spaces [ci skip]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63353 b2dd03c8-39d4-4d8f-98ff-823fe69b080e znz (Kazuhiro NISHIYAMA)

05/07/2018

11:52 PM Revision d7a9f591 (git): cont.c: wrapper function
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63352 b2dd03c8-39d4-4d8f-98ff-823fe69b080e nobu (Nobuyoshi Nakada)
11:14 PM Revision cd36bea5 (git): cont.c: refined error message
* cont.c (fiber_machine_stack_alloc): refined the error message on
failure at setting a guard page.
git-svn-id: sv...
nobu (Nobuyoshi Nakada)
10:05 PM Bug #14733 (Closed): Error on reading log4r
It works fine now and I don't know what happened. Thanks anyway.
Cheers!
cardillos (cherry ard)
04:16 PM Revision 6c62356e (git): _mjit_compile_send.erb: inline recursive call
mjit_compile.c: propagate funcname to compile_insn
test_jit.rb: add test covering this behavior
* Benchmark
```
re...
k0kubun (Takashi Kokubun)
03:15 PM Feature #14723: [WIP] sleepy GC
normalperson (Eric Wong) wrote:
> So multithreaded? Do you have any info on the amount of CPU
> time was being u...
noahgibbs (Noah Gibbs)
09:52 AM Feature #14723: [WIP] sleepy GC
Koichi Sasada <[email protected]> wrote:
> On 2018/05/05 6:32, Eric Wong wrote:
> >Also, I think we need to start GC i...
normalperson (Eric Wong)
08:12 AM Feature #14723: [WIP] sleepy GC
On 2018/05/05 6:32, Eric Wong wrote:
> Also, I think we need to start GC if no sweeping/marking is
> inprogress.
...
ko1 (Koichi Sasada)
03:08 PM Revision a4a66510 (git): Remove needless require [ci skip]
already require on top
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63349 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
znz (Kazuhiro NISHIYAMA)
03:07 PM Revision 1a38d5ee (git): * 2018-05-08
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63348 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
03:07 PM Revision 59c5d0b9 (git): Use `&.` instead of modifier if and remove needless closed?
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63347 b2dd03c8-39d4-4d8f-98ff-823fe69b080e znz (Kazuhiro NISHIYAMA)
02:44 PM Revision 58357237 (git): Fix a typo [ci skip]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63346 b2dd03c8-39d4-4d8f-98ff-823fe69b080e znz (Kazuhiro NISHIYAMA)
11:39 AM Feature #13618: [PATCH] auto fiber schedule for rb_wait_for_single_fd and rb_waitpid
> Can you please summarize and perhaps link to code they talk about?
The simplest summary I can give is that OS sc...
ioquatix (Samuel Williams)
09:58 AM Feature #14187: `make test` and `make check` to run all test suites
Looks good to me, +1.
I don't know who uses just `make test` currently.
But if it's to check changes to CRuby the...
Eregon (Benoit Daloze)
06:46 AM Feature #14187: `make test` and `make check` to run all test suites
Casual users really needs to run test-all and rubyspec?
Those tests often fail on some environment. (see also https:...
naruse (Yui NARUSE)
06:36 AM Feature #14187: `make test` and `make check` to run all test suites
Current test suites:
* `bootstraptest/`: Some trivial tests to verify the VM; each test is executed under a new Ru...
mame (Yusuke Endoh)
08:47 AM Bug #14740 (Closed): You may have encountered a bug in the Ruby interpreter or extension libraries. Bug reports are welcome.
re_ext/kernel_require.rb:20:in `require_with_bootsnap_lfi'
/home/pi/.rvm/gems/ruby-2.4.1/gems/bootsnap-1.3.0/lib/boo...
KIlokura (Dante Abreu)
06:59 AM Revision 04aba59c (git): * 2018-05-07
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63345 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
06:59 AM Revision 8da1219d (git): cont.c: machine stack cache condition
* cont.c (fiber_store, rb_fiber_terminate): separate the condition
to cache machine stacks, which is not directly r...
nobu (Nobuyoshi Nakada)
06:39 AM Bug #14726: wrong message when superclass is not a Class
duerst (Martin Dürst) wrote:
> mame (Yusuke Endoh) wrote:
> > くだらないコメントです。英語がわかりませんが、"given a XXX" の語順は変な気がします。"a X...
mame (Yusuke Endoh)
06:29 AM Bug #14726: wrong message when superclass is not a Class
mame (Yusuke Endoh) wrote:
> くだらないコメントです。英語がわかりませんが、"given a XXX" の語順は変な気がします。"a XXX given" でいいような?
念のためぐたいれいをみたい...
duerst (Martin Dürst)
06:03 AM Bug #14726: wrong message when superclass is not a Class
くだらないコメントです。英語がわかりませんが、"given a XXX" の語順は変な気がします。"a XXX given" でいいような? mame (Yusuke Endoh)

05/06/2018

12:17 PM Feature #14739: Improve fiber yield/resume performance
I tested async-http, a web server, it has a basic performance spec using `wrk` as the client.
I ran it several tim...
ioquatix (Samuel Williams)
11:17 AM Feature #14739: Improve fiber yield/resume performance
Compare async-dns with bind9 for the same workload:
```
# Without libcoro-fiber
...
ioquatix (Samuel Williams)
11:06 AM Feature #14739: Improve fiber yield/resume performance
I test in some real world applications today. The first is async, which has a performance test for read context switc... ioquatix (Samuel Williams)
10:09 AM Feature #14739: Improve fiber yield/resume performance
Thanks for your feedback. When I made this issue, I could only select "Bug", "Feature" or "Misc". Should I have selec... ioquatix (Samuel Williams)
09:48 AM Feature #14739: Improve fiber yield/resume performance
I'm neutral. This is a feature request but the "feature" being discussed is the speed of execution. It is by nature ... shyouhei (Shyouhei Urabe)
09:53 AM Revision fb2acec9 (git): * 2018-05-06
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63343 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
09:53 AM Revision 2ad7fb6d (git): optparse: Suppress warnings
Ruby warns "instance variable `@version` not initialized" for optparse when it receives `--version` option.
`test.rb...
nobu (Nobuyoshi Nakada)
03:33 AM Feature #14723: [WIP] sleepy GC
[email protected] wrote:
> For Rails Ruby Bench (large concurrent Rails benchmark based
> on Discourse),...
normalperson (Eric Wong)
03:04 AM Feature #13618: [PATCH] auto fiber schedule for rb_wait_for_single_fd and rb_waitpid
[email protected] wrote:
> I've been thinking about these issues for the past few days, and one thing I foun...
normalperson (Eric Wong)

05/05/2018

10:21 PM Feature #14739: Improve fiber yield/resume performance
The windows code path for fibers is relatively trivial both in libcoro and cont.c, so I wouldn’t be too concerned abo... ioquatix (Samuel Williams)
08:28 PM Feature #14739: Improve fiber yield/resume performance
> However, it wouldn't be silly to update libcoro to make it
> compile without problems on all supported platforms.
...
shevegen (Robert A. Heiler)
12:55 PM Feature #14739: Improve fiber yield/resume performance
I was reading https://sourceware.org/ml/libc-help/2016-01/msg00008.html and noticed the following regarding `*context... ioquatix (Samuel Williams)
12:30 PM Feature #14739: Improve fiber yield/resume performance
I updated my branch with a few changes.
I'm sorry I didn't rebase on your branch.
I think once we decide if thi...
ioquatix (Samuel Williams)
12:17 PM Feature #14739: Improve fiber yield/resume performance
Okay, I found out what happened.
On macOS, you need to set
```
#include "libcoro/coro.c"
#define FIBER_USE_NA...
ioquatix (Samuel Williams)
12:03 PM Feature #14739: Improve fiber yield/resume performance
Yes, that supports my own test as well.
```
koyoko% ruby --version
ruby 2.5.0p0 (2017-12-25 revision 61468) [x86...
ioquatix (Samuel Williams)
12:00 PM Feature #14739: Improve fiber yield/resume performance
ioquatix (Samuel Williams) wrote:
> > Also, asm needed to be replaced with `__asm__` to compile with Apple clang
> ...
nobu (Nobuyoshi Nakada)
10:48 AM Feature #14739: Improve fiber yield/resume performance
I am trying out your branch, and will report back. 3% is within the margin for error so it sounds like nothing change... ioquatix (Samuel Williams)
10:18 AM Feature #14739: Improve fiber yield/resume performance
I've compiled this on both LLVM and GCC just fine.
I've never tried compiling it on Windows but it should work. It...
ioquatix (Samuel Williams)
10:14 AM Feature #14739: Improve fiber yield/resume performance
You can see the supported methods here.
https://github.com/ioquatix/ruby/blob/4a9c12d94aae1cf3a52ca5f026432cd03e98...
ioquatix (Samuel Williams)
10:13 AM Feature #14739: Improve fiber yield/resume performance
And seems it requires gcc (variants) and non-Windows.
coro.c can't compile with Visual C nor mingw gcc.
Also, `asm`...
nobu (Nobuyoshi Nakada)
08:41 AM Feature #14739: Improve fiber yield/resume performance
I wonder what architectures libcoro supports? It seems it supports x86 a probably some ARM, but what about s390x and ... vo.x (Vit Ondruch)
03:56 AM Feature #14739: Improve fiber yield/resume performance
I don't know how to run a full benchmark of Ruby. Can someone help me with that? It would be interesting to get a mor... ioquatix (Samuel Williams)
03:54 AM Feature #14739: Improve fiber yield/resume performance
```
# Without libcoro (macOS)
^_^ > ./build/bin/ruby ./fiber_benchmark.rb 10000 1000
setup time for 10000 fibers...
ioquatix (Samuel Williams)
03:38 AM Feature #14739: Improve fiber yield/resume performance
```
# Without libcoro
koyoko% ./build/bin/ruby ./fiber_benchmark.rb 10000 1000
setup time for 10000 fibers: ...
ioquatix (Samuel Williams)
02:50 AM Feature #14739: Improve fiber yield/resume performance
> Not sure how fast libcoro is, though.
In my experience, the `libcoro` ASM implementation is the fastest implemen...
ioquatix (Samuel Williams)
02:48 AM Feature #14739: Improve fiber yield/resume performance
Here is the code https://github.com/ioquatix/ruby/tree/fiber-libcoro
UPDATE: I provided some benchmark details, bu...
ioquatix (Samuel Williams)
01:25 AM Feature #14739: Improve fiber yield/resume performance
ioquatix (Samuel Williams) wrote:
> Does Ruby currently reuse stacks?
Yes.
Not sure how fast libcoro is, thoug...
shyouhei (Shyouhei Urabe)
12:59 AM Feature #14739 (Closed): Improve fiber yield/resume performance
I am interested to improve Fiber yield/resume performance.
I've used this library before: http://software.schmorp....
ioquatix (Samuel Williams)
04:25 PM Bug #14539: Duplicate range in character class warning
shevegen (Robert A. Heiler) wrote:
> Agreed. Your code did not use more than one \X so the warning is
> incorrect a...
vipulnsward (Vipul Amler)
02:53 PM Feature #14723: [WIP] sleepy GC
For Rails Ruby Bench (large concurrent Rails benchmark based on Discourse), measuring sleepy-gc-v3 branch versus the ... noahgibbs (Noah Gibbs)
07:02 AM Feature #14723: [WIP] sleepy GC
I updated pg to [use rb_wait_for_single_fd()](https://github.com/ged/ruby-pg/commit/3dfd36bf08ba49cf87410ae73edb2dabb... larskanis (Lars Kanis)
01:06 PM Feature #13618: [PATCH] auto fiber schedule for rb_wait_for_single_fd and rb_waitpid
I've been thinking about these issues for the past few days, and one thing I found was this video https://www.youtube... ioquatix (Samuel Williams)
11:15 AM Feature #14737 (Assigned): Split default gems into separate directory structure
hsbt (Hiroshi SHIBATA)
08:23 AM Feature #14737: Split default gems into separate directory structure
> BTW2 I could fill this against RubyGems, but the default gems
> are Ruby stuff IMO, so I think this is appropriate...
shevegen (Robert A. Heiler)
10:53 AM Feature #14683: IRB with Ripper
I discussed this issue with @hsbt, @matsuda, and @matz .
In the present day, IRB needs compatibility completely.
...
aycabta (aycabta .)
10:45 AM Bug #14733 (Rejected): Error on reading log4r
I tried to reproduce the issue because I have Vagrant 2.0.4 on Windows 10 1709 by chance. I cannot reproduce though. ... gotoken (Kentaro Goto)
03:12 AM Revision d32763ec (git): securerandom.rb: [DOC] require in examples
* lib/securerandom.rb: added `require 'securerandom'` to each
example, to state these methods are defined in this l...
nobu (Nobuyoshi Nakada)
02:51 AM Feature #14736: Thread selector for flexible cooperative fiber based concurrency
As part of this, I've started working on https://bugs.ruby-lang.org/issues/14739 ioquatix (Samuel Williams)
02:46 AM Bug #14738: Failed to load_from_binary on 2.5.1
`"extra_data"` is not necessary. nobu (Nobuyoshi Nakada)
02:44 AM Bug #14738 (Closed): Failed to load_from_binary on 2.5.1
nobu (Nobuyoshi Nakada)

05/04/2018

09:32 PM Feature #14723: [WIP] sleepy GC
Eric Wong <[email protected]> wrote:
> Marking is best done when the stack is shallow (where unicorn
> calls I...
normalperson (Eric Wong)
04:21 PM Bug #14738 (Closed): Failed to load_from_binary on 2.5.1
```
% cat /tmp/1226.rb
iseq = RubyVM::InstructionSequence.compile('num = 1 + 2')
binary = iseq.to_binary("extra_d...
znz (Kazuhiro NISHIYAMA)
03:20 PM Revision a99d017d (git): forgot to add INT2FIX (sorry!)
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63340 b2dd03c8-39d4-4d8f-98ff-823fe69b080e shyouhei (Shyouhei Urabe)
03:18 PM Revision 1096be5a (git): passing rb_thread_sleep to rb_protect is IMHO dangerous
rb_thread_sleep's argument is int, while rb_protect expects the function
to take VALUE. Depending on ABI this could b...
shyouhei (Shyouhei Urabe)
03:03 PM Revision 7ba44caa (git): * 2018-05-05
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63338 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
03:03 PM Revision b121cfde (git): nobody is using the return value of rb_io_fptr_finalize
However this function is listed in ruby/io.h. We cannot but
define a new, void-returning variant to use instead.
g...
shyouhei (Shyouhei Urabe)
01:30 PM Revision b4d93545 (git): Use `&.` instead of modifier if
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63336 b2dd03c8-39d4-4d8f-98ff-823fe69b080e znz (Kazuhiro NISHIYAMA)
01:09 PM Misc #14735: thread-safe operations in a hash could be documented
Thanks, Eric. So, if I got this right, even though MRI tries to make it safe for common key types (it's a string in m... rosenfeld (Rodrigo Rosenfeld Rosas)
12:22 AM Misc #14735: thread-safe operations in a hash could be documented
[email protected] wrote:
> result = {} # assume this is thread-safe in MRI for now
> data_types.map do |data_type...
normalperson (Eric Wong)
10:38 AM Feature #14737 (Assigned): Split default gems into separate directory structure
On Fedora, we are using operating_system.rb [1], [2] to setup various RubyGems paths. Unfortunately, if we change Gem... vo.x (Vit Ondruch)
10:29 AM Bug #14728: OptionParser takes other options as argument values
In common, an argument is determined by the preceding option, consider `grep` command's `-e` option.
If you want to ...
nobu (Nobuyoshi Nakada)
06:12 AM Bug #14729 (Closed): Float("long_invalid_string") fails to throw an exception
Applied in changeset trunk|r63334.
----------
object.c: raise on long invalid float string
* object.c (rb_cstr_to_d...
nobu (Nobuyoshi Nakada)
06:12 AM Revision 306e1e81 (git): * 2018-05-04
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63335 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
06:12 AM Revision 955849c1 (git): object.c: raise on long invalid float string
* object.c (rb_cstr_to_dbl_raise): check long invalid float
string more precisely when truncating insignificant par...
nobu (Nobuyoshi Nakada)
03:12 AM Feature #14736 (Closed): Thread selector for flexible cooperative fiber based concurrency
Ruby concurrency can be greatly enhanced by concurrent, deterministic IO.
Fibers have been shown many times to be ...
ioquatix (Samuel Williams)
12:59 AM Bug #14734 (Third Party's Issue): trunk + gcc-8 + mac SEGV
OK, could reproduce without ruby. Filed an issue in GCC bugzilla.
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85644
shyouhei (Shyouhei Urabe)

05/03/2018

10:09 PM Bug #14733: Error on reading log4r
Thanks for the update. However I checked the gem directory and I can find log4r in it.
It just weird I cant run the ...
cardillos (cherry ard)
03:55 PM Bug #14733: Error on reading log4r
The error says missing log4r.
I think this is not related to ruby core - the tracker here is about
ruby itself, n...
shevegen (Robert A. Heiler)
06:52 AM Bug #14733 (Closed): Error on reading log4r
Hello all,
I used Vagrant on Windows 10 which is using Ruby.
Here is the error on the log
!verror.png!
Any i...
cardillos (cherry ard)
09:00 PM Bug #14464: MJIT & MinGW / gcc 7.3.0 seemed ok as of 62337, fail or skip after
k0kubun,
Thanks for looking into this. The motherboard on my home desktop stopped working, so I've been without a...
MSP-Greg (Greg L)
06:55 PM Misc #14735 (Open): thread-safe operations in a hash could be documented
Hi, sometimes I find myself fetching data from the database through multiple queries concurrently. For example, suppo... rosenfeld (Rodrigo Rosenfeld Rosas)
06:01 PM Bug #14139: [BUG] Segmentation fault
Thanks for sharing! https://giaonhanquocte247.com/order-hang-nhat/ giaonhanquocte247 (giaonhan quocte)
02:09 PM Bug #14734 (Third Party's Issue): trunk + gcc-8 + mac SEGV
- ruby 2.6.0dev (2018-05-03 trunk 63333) [x86_64-darwin15]
- gcc-8 (Homebrew GCC 8.1.0) 8.1.0
- Mac OS X 10.11.6 Bu...
shyouhei (Shyouhei Urabe)
11:27 AM Feature #14724: chains of inequalities
After reading comments above I believe even more strongly that feature like this does not belong in language which al... graywolf (Gray Wolf)
09:19 AM Feature #14724: chains of inequalities
A Eregon (Benoit Daloze) wrote:
> > 1. if a non-boolean is returned, treats the rest of chain in the compatible mann...
gotoken (Kentaro Goto)
08:47 AM Revision 6dd4657f (git): _mjit_compile_send.erb: retry inlining attr_reader
This reverts r63249 (revert r63212) and fixes a bug in it. The test to
prevent the bug is added as well.
vm_insnhelp...
k0kubun (Takashi Kokubun)
07:13 AM Feature #14723: [WIP] sleepy GC
[email protected] wrote:
> perf change seems a tiny bit more noticable.

Thanks for benchmarking! Disappoin...
normalperson (Eric Wong)
06:07 AM Feature #14723: [WIP] sleepy GC
I found one place where we were not using async_exec so I changed it to use async_exec... this is revised numbers:
...
sam.saffron (Sam Saffron)
05:43 AM Feature #14723: [WIP] sleepy GC
From my testing on Discourse bench ... the difference is pretty much not that measurable
Before patch
```
Unic...
sam.saffron (Sam Saffron)
03:17 AM Feature #14723: [WIP] sleepy GC
Ah, never mind. It looks like the Ruby I tested doesn't have the sleepy GC changes! So it's slower, but that's not th... noahgibbs (Noah Gibbs)
03:12 AM Feature #14723: [WIP] sleepy GC
I checked today's head-of-master with Rails Ruby Bench. The first run suggests a noticeable drop in performance betwe... noahgibbs (Noah Gibbs)
07:09 AM Revision d9d84688 (git): mjit_compile.c: skip generating unnecessary goto
after return or longjmp. This is mainly for skipping the check of stack
size in such cases, which shouldn't be checke...
k0kubun (Takashi Kokubun)
05:44 AM Bug #14714: Ruby 2.5.1 Segmentation Fault in GC
I tried putting GC.stress = true in the rails_helper file, and after 4.5 hours, no test has been completed, so this i... obromios (Chris Drane)
03:08 AM Revision cdef13d7 (git): mjit_compile.c: verify stack size agreement
between branches.
mjit_compile.inc.erb: move the compiled_for_pos reference to
mjit_compile.c
git-svn-id: svn+ssh:/...
k0kubun (Takashi Kokubun)
01:33 AM Bug #14732: CGI.unescape returns different instance between Ruby 2.3 and 2.4
[email protected] wrote:
> normalperson (Eric Wong) wrote:
> > > > https://bugs.ruby-lang.org/issues/14732
> >
> > ...
normalperson (Eric Wong)
01:25 AM Bug #14732 (Open): CGI.unescape returns different instance between Ruby 2.3 and 2.4
I'm actually not sure what the correct behavior should be...
normalperson (Eric Wong)
12:22 AM Bug #14732: CGI.unescape returns different instance between Ruby 2.3 and 2.4
normalperson (Eric Wong) wrote:
> > > https://bugs.ruby-lang.org/issues/14732
>
> r63328 This also affects 2.3...
jnchito (Junichi Ito)
01:24 AM Revision 0e32c7c1 (git): Revert "ext/cgi/escape: preserve String subclass in result"
This reverts commit 6afea14043b0c0e603f26c89ae0d043f65852668 r63328
I misread the original bug report and got results...
Eric Wong
12:52 AM Revision 9b6dec6c (git): mjit_compile.inc.erb: verify stack consistency
on JIT compilation. r63092 was risky without this check.
mjit_compile.c: update comment about stack consistency chec...
k0kubun (Takashi Kokubun)
 

Also available in: Atom