Activity
From 07/03/2018 to 07/09/2018
07/09/2018
-
06:55 PM Feature #14904: Make it possible to run instance_eval with zero-arguments lambda
- I have no particular pro or con opinion on the suggestion itself.
I want to comment on one part though:
> I've ... -
11:42 AM Feature #14904: Make it possible to run instance_eval with zero-arguments lambda
- Sorry, define_method in example should be that:
```
define_method(param_name){ instance_eval(&kwargs[:default]) }
``` -
- At a moment #instance_eval always yields an object to a given block. Though if we passed lambda as a block for instan...
-
12:05 PM Bug #14891: Pathname#join has different behaviour to File.join
- I think it is expected behavior.
https://github.com/ruby/ruby/blob/38e05ff3e194268fd2f38ac7c9530298e464f07b/test/p... -
08:07 AM Bug #14847 (Closed): `clone` can generate strange objects
- Applied in changeset trunk|r63912.
----------
Don't copy FL_USER* on Kernel#clone. [Bug #14847]
* object.c (mutable... -
01:23 AM Bug #14899 (Closed): Pathname#glob Matching to the directory results in lack
- Applied in changeset trunk|r63909.
----------
dir.c: fix directory glob
* dir.c (glob_helper): fix directory glob w...
07/08/2018
-
09:14 PM Misc #14902: Replace benchmark/driver.rb with benchmark_driver.gem
- @k0kubun
Thank you for your work on this. Somewhat off topic...
I ran the suite on ruby-loco, and the only cha... -
02:38 PM Misc #14902 (Closed): Replace benchmark/driver.rb with benchmark_driver.gem
- Applied in changeset trunk|r63888.
----------
benchmark: introduce benchmark_driver.gem
Makefile.in: Clone benchmar... -
- ## What's benchmark_driver.gem?
benchmark_driver.gem is a gem created by a project accepted as Ruby Association Gran... -
07:22 PM Feature #14901: [PATCH] do not block SIGCHLD in normal Ruby Threads
- [email protected] wrote:
> So these 2 issues ("OpenSSL::PKey::*.new",
> test/-ext-/gvl/test_last_thread.rb) ar... -
-
- > In this context, "blocking" mean disabling interrupts using pthread_sigmask/sigprocmask. As in: blocking signals fr...
-
- [email protected] wrote:
> I have not completely read your patch for [Bug #14867] yet, so
> let me ask some qu... -
- I have not completely read your patch for [Bug #14867] yet, so let me ask some questions to understand the context.
... -
- @k0kubun: any opinions on this? Thanks.
```
I blocked SIGCHLD in normal Ruby Threads for [Bug #14867]
because I... -
11:35 AM Bug #14900: Extra allocation in String#byteslice
- I played around with my assumptions here. By far the worst from a memory POV was `slice!`, which given a string of 5M...
-
- The way I've implemented it now (as in your first example) is something like this:
```
@buffer = read_data
if @b... -
- Yeah, I agree, this patch probably isn't right, but I just try to figure it out what is going on and suggest a soluti...
-
09:46 AM Bug #14900: Extra allocation in String#byteslice
- @ioquatix, your patch doesn't seems to be correct for me on first glance.
Imagine pipelined RPC server:
- we rea... -
- I think there are several things to consider here:
- Even though the string appears to be two allocations, it's on... -
- Okay I made an attempt to fix this: https://github.com/ruby/ruby/pull/1909
-
- One thing I noticed if I freeze source string, the extra memory allocation goes away.
-
- Okay, I reproduced the error. I made a test case here:
https://github.com/ioquatix/ruby/commit/9fb5cd644209efc7937... -
09:41 AM Feature #13620: Simplifying MRI's build system: always make install
- @normalperson wrote in ruby-core:87864:
> mkmf works fine with everything in ext/ without install, so I
> expect mj... -
- Eric,
r63880 fixed it, Appveyor mswin is green. I will ask them about a 'no javascript' fallback for at least som... -
- [email protected] wrote:
> Both mswin & ruby-loco failed the test `test_sigchld_ignore` in r63879.
>
> Havin... -
- @normalperson
Eric,
Both mswin & ruby-loco failed the test `test_sigchld_ignore` in r63879.
Having recentl... -
- Thanks! I confirmed that the patch works well on my machine as well.
-
- Applied in changeset trunk|r63877.
----------
process.c (rb_f_exec): pause MJIT before replacing process
Non-parall... -
- I have updated the PR to use `transfer` in the scheduler, and I've added an example showing that it is composable wit...
07/07/2018
-
- [email protected] wrote:
> Hi Eric. I fixed [Bug #14892] on r63875, but only the rubyspec check you added is fa... -
- Hi Eric. I fixed [Bug #14892] on r63875, but only the rubyspec check you added is failing with -DMJIT_FORCE_ENABLE li...
-
- Nice catch I will try to verify on my end too
-
09:47 AM Bug #14900 (Closed): Extra allocation in String#byteslice
- When executing `String#byteslice` with a range, I noticed that sometimes the original string is allocated again. When...
-
- normalperson (Eric Wong) wrote:
> Of course, there will be differences not detected before
> install, but the goa... -
- The patch got outdated in the latest trunk, so I updated it again. It's a really small change with big impact on memo...
-
- * [Bug #14878] Add command line argument to deactivate JIT (k0kubun)
* Please discuss the necessity of the flag an... -
- Applied in changeset trunk|r63875.
----------
insns.def: stop pushing unnecessary keys for MJIT
[Bug #14892] -
08:45 AM Bug #14899 (Closed): Pathname#glob Matching to the directory results in lack
- Pathname.glob では問題ないのですが、
ruby 2.5 から追加された Pathname#glob で、スラッシュで終わる引数を渡すとディレクトリ名の最初の１文字がかけた状態で返ってきます
~~~
Pathna... -
- On 2018/07/07 14:36, Eric Wong wrote:
> Maybe r63872 can help by retrying send.
Great! Thank you.
--
// SAS... -
- Koichi Sasada <[email protected]> wrote:
> On 2018/07/06 18:47, Eric Wong wrote:
> > I would not expect it to be (but ... -
- Applied in changeset trunk|r63872.
----------
test/socket/test_socket.rb (test_timestamp): retry send
I theorize th... -
- On 2018/07/06 18:47, Eric Wong wrote:
> I've never seen it stuck myself.
Only a few times per thousands trial. I...
07/06/2018
-
- > https://bugs.ruby-lang.org/issues/14851
Maybe reject this feature. Keeping non-sleepy timer thread
implementa... -
- [email protected] wrote:
> It is impossible to implement Thread migration between native
> threads. All other... -
- > Yes, they are great, but it's probably impossible to implement in Ruby.
It is impossible to implement Thread mig... -
- > But we have example of Go: goroutine is a really green thread, and they do really scale.
Yes, they are great, bu... -
- > In my experience, threads simply don't scale as as well as fibers, there is too much overhead.
Native threads d... -
-
- [email protected] wrote:
> With parallel tests (`make test-all TESTS=-j4` with 4 parallelism) stuck sometimes.
>
> h... -
- With parallel tests (`make test-all TESTS=-j4` with 4 parallelism) stuck sometimes.
http://ci.rvm.jp/results/trunk... -
- [email protected] wrote:
> Well done. The build is 'green' (passing).
Thanks! Committed as r63869. -
- Applied in changeset trunk|r63869.
----------
mjit.c: fix waitpid macro return value for win32
We started checking ... -
- Eric,
Well done. The build is 'green' (passing). Script generated result summary is:
```
————————————————————... -
- Greg: oh, I think I finally spotted it. The waitpid() macro for
_WIN32 doesn't set a return value. The old code a... -
- @normalperson
> Were there any compiler warnings building process.c or mjit.c?
No. Only warning were for `warn... -
- [email protected] wrote:
> Below is the out from `ruby --jit -e exit`
>
> ```
> C:\Greg\GitHub> ruby --jit -e... -
- @normalperson
Attached is the config portion of ruby-loco mingw build log.
Thanks, Greg -
- @normalperson
Below is the out from `ruby --jit -e exit`
```
C:\Greg\GitHub> ruby --jit -e exit
process.c: si... -
- @normalperson
I've got builds running both locally and on Appveyor, when they finish I'll have more info.
> Jus... -
04:53 AM Bug #14897: Unexpected behavior of `if` in specific code
- Good catch. It was a bug of peephole optimization. Fixed. Thank you.
-
- Applied in changeset trunk|r63868.
----------
Fix a bug of peephole optimization
```
if L1
L0:
jump L2
L1:
... -
04:03 AM Bug #14897: Unexpected behavior of `if` in specific code
- Seems `obj = obj` is (mistakenly) optimized out.
```
% ./miniruby --dump=i -v tmp.rb
ruby 2.6.0dev (2018-07-06 t... -
03:22 AM Bug #14897 (Closed): Unexpected behavior of `if` in specific code
- I found a strange behavior of `if` in the following code.
~~~ ruby
def seems_bug(obj)
if obj || obj
obj =... -
12:49 AM Bug #14892: r63763 breaks -DMJIT_FORCE_ENABLE=1
- Many cases (including `a, b = nil`) go well after r63863.
Now I found that there remain 2 issues at least.
1. `pc...
07/05/2018
-
- > They have their own IO scheduler because ruby had just native threads, which are bad as IO scheduler.
Thanks so ... -
- > It's also going to be more useful for existing code bases like ActionCable, Puma, Async, etc which use their own IO...
-
- Thanks for your feedback.
> About "extendable api" vs "implicit behavior" (ie between your proposal
> for "Thread... -
- @ioquatix About "extendable api" vs "implicit behavior" (ie between your proposal
for "Thread.scheduler=' and replac... -
- Looks like I was not exactly right: typical iteration over Enumerator doesn't use Fiber.yield.
But usage of Enumerat... -
- [email protected] wrote:
> @normalperson
>
> Thanks for the patch, I added it, and a build with r63859 locked/... -
- @normalperson
Thanks for the patch, I added it, and a build with r63859 locked/froze on test-all. I’m going to se... -
- [email protected] wrote:
>
> Importantly, mswin (ruby's vc12) passed r63856.
Good to know. I saw your messa... -
- Importantly, mswin (ruby's vc12) passed r63856.
Unfortunately, ruby-loco locked up on test-all. So, before the re... -
- [email protected] wrote:
> As it was reverted on r63852 by @naruse, assigning this back
> to Eric. I'm guessin... -
- [email protected] wrote:
> I'm not sure what you look at on the web (GitHub, Appveyor), so briefly:
> 1. The m... -
- @normalperson
I'm not sure what you look at on the web (GitHub, Appveyor), so briefly:
1. The mswin builds do n... -
09:10 PM Bug #14895: Inconsistent constant names when using const_set on a singleton class
- This looks like a bug to me.
Here's a simplified example:
```
s = Object.new.singleton_class
a = s.const_set... -
05:35 PM Bug #14895: Inconsistent constant names when using const_set on a singleton class
- So, what you're saying is that the singleton class is being assigned to a constant when it creates module `A`, so mod...
-
- silver_phoenix (Pedro Pinto) wrote:
> Yes, I understand that, but why isn't `Z` named like `B` is?
>
> `Z` is `#<... -
- Yes, I understand that, but why isn't `Z` named like `B` is?
`Z` is `#<Module:...>` (unnamed)
`B` is `#<...>::B` ... -
- The names of `A`, `B`, and `Z` are temporary names at the moments of assignment.
Once you assign `x.singleton_class`... -
06:32 PM Feature #14887: Array#delete_if does not use #delete
- marcandre (Marc-Andre Lafortune) wrote:
> You probably meant "... call #delete_at in the background".
Yes, Marc-A... -
07:28 AM Feature #14887: Array#delete_if does not use #delete
- @shevegen : the problem is that:
* `delete_if` can't call `delete` for the given reason of duplicates. the example w... -
- This is actually a (to me) quite interesting discussion. I want to comment on
a very few things but of course I'll k... -
- duerst (Martin Dürst) wrote:
> On the other hand, if we change it to the source encoding, then the implementation ge... -
- Yes, I agree with what you say, and I agree with your conclusion, I was just giving an example where it failed with a...
-
- I've shown `to_enum(:aga).to_a` to present the place where I wasn't right.
But if you look at your own second exam... -
- For the first case, you naturally can't call Fiber.yield in that context... but this works:
```
#!/usr/bin/env ru... -
- Yes. While usually Enumerator doesn't call to Fiber.yield, it is called if Enumerator is used as external iterator:
... -
- Are you saying that calling Fiber.yield is not valid within an enumerator?
-
07:36 AM Feature #14697 (Assigned): Introducing Range#% as an alias to Range#step
-
- Here is what I made using RubyVM::AST. It was useful. https://github.com/ioquatix/covered
In the end I made a regu... -
- And another one.
```
ruby --jit-wait --disable-gems -e '1000.times { break if /a/ =~ "ab" && !$~[0] }'
``` -
- A mini reproductive command is here.
```
ruby --jit-wait --disable=gems -e '1000.times { a, b = nil }'
```
07/04/2018
-
11:20 PM Bug #14884: msys2 mingw32 'rake' has unexpected text at top of file
- > Try changing line 4 from `};{#` to `};{ #` (add a space before #). Worked for me in a Git bash shell running `rake...
-
- GardenTools (Garden Tools) wrote:
> Error message is
>
> /c/Ruby25/bin/rake: line 4: {#: command not found
Try... -
- Error message is
/c/Ruby25/bin/rake: line 4: {#: command not found
-
- As it was reverted on r63852 by @naruse, assigning this back to Eric. I'm guessing it was reverted since it was not p...
-
- I have nothing useful to add to the issue at hand as I only very
rarely use Net:: directly (my use cases usually sta... -
08:43 PM Feature #14896 (Open): Expose Net::HTTPResponse socket for integration with libraries expecting an IO
- As several stdlib libraries support reading from IO-compatible objects (e.g. Zlib::GzipReader, Gem::Package::TarReade...
-
- Constants defined in the namespace of a class or a module are named on the fly:
```ruby
class X; end
X.const_set... -
- @ioquatix nothing prevents from adding new method:
`Thread.create(scheduler: :current, args: [block_arg1, block_arg2... -
- @funny_falcon I don't think it's easy to change `Thread.new(...)` because arguments are passed to the thread block.
... -
- Considering implementation, `Fiber.transfer` should be used, not `Fiber.resume`+`Fiber.yield`,
ie exclusively use `f... -
- Just remark: make test example to use `Fiber.transfer`.
If patch will be accepted, example will be copied, and usage... -
- Some of the benefits of this PR are:
- Makes it possible to implement different models for concurrency.
- Easy to... -
- @normalperson that's awesome, great effort! I really appreciate you taking these PRs seriously and the effort you are...
-
- @naruse
I'm sorry, maybe I should have been clearer. This isn't the same as r63839.
For platforms that don't s... -
03:45 PM Bug #14890 (Closed): test/ruby/test_time_tz.rb - Skip on Windows (mswin|mingw)?
- Fixed by r 63839
-
04:39 AM Bug #14863: Array#join with empty array returns empty string always in US-ASCII encoding
- nobu (Nobuyoshi Nakada) wrote:
> May I close this?
Yes, please do.
I agree that US-ASCII is the greatest commo...
07/03/2018
-
11:53 PM Bug #14894 (Closed): Segfault loading iseqs
- Follow up on https://github.com/Shopify/bootsnap/issues/172
In particular:
https://gist.githubusercontent.com/... -
- I support adding `String#byteslice!`. I've been using `String#byteslice` in custom IO-like objects that implement `IO...
-
- Applied in changeset trunk|r63841.
----------
signal.c: packed signals
* signal.c (signals): pack signal names inst... -
12:28 PM Bug #14893 (Closed): Global buffer overflow in signm2signo of signal.c.
- Found some memory error with address sanitizer:
```
==29152==ERROR: AddressSanitizer: global-buffer-overflow on a... -
- May I close this?
-
- * [Feature #13050] Readline: expose `rl_completion_quote_character` variable
* [Feature #14850] Add official API for... -
- It's polyglot code for sh and cmd.exe.
What error do you have with it actually? -
- I recognize that. I'm currently taking time for RubyBench project but planning to take a look after that. Please igno...
-
- r63763 ("give up insn attr handles_frame") breaks -DMJIT_FORCE_ENABLE=1
(commit 6b534134a78e3e43c344682c3585e1abab... -
11:22 AM Feature #14869: Proposal to add Hash#===
- > 空の場合は Enumerable#all? と類似の話なので、 true のほうがいいんじゃないでしょうか。
なるほど、参考になります。
> また、再帰的なハッシュに対して使用したときに無限再帰にならないようにする必要... -
More examples:
~~~ ruby
Pathname.new('/a').join('c', 'b').to_s #=> "/a/c/b"
Pathname.new('/a').join('/c', 'b')...-
- This behaviour surprised me too. Is it expected that the information from "/a"
is lost? I have no idea but the docum... -
02:37 AM Bug #14891 (Closed): Pathname#join has different behaviour to File.join
- ~~~ ruby
Pathname.new('/a').join('/b').to_s
# => "/b"
File.join(Pathname.new('/a'), '/b').to_s
# => "/a/b"
~~~
...