Project

General

Profile

Activity

From 07/07/2018 to 07/13/2018

07/13/2018

03:43 PM Feature #12306: Implement String #blank? #present? and improve #strip and family to handle unicode
Sam suggested the topic to be discussed at the next upcoming ruby
developer meeting here recently:
https://bugs.r...
shevegen (Robert A. Heiler)
03:18 PM Bug #14909: Method call with object that has to_hash method crashes (method with splat and keyword arguments)
https://bugs.ruby-lang.org/issues/14909#note-2 doesn't resolve the issue for me
> Why your object has to_hash meth...
johannes_luedke (Johannes Lüdke)
04:52 AM Bug #14909: Method call with object that has to_hash method crashes (method with splat and keyword arguments)
Why your object has `to_hash` method?
Ruby uses long named methods for implicit conversion: `to_str` - if your obj...
funny_falcon (Yura Sokolov)
02:43 PM Bug #14911: Segmentation fault
Have you tried with 2.5.1 ? It does not seg fault with 2.5.1 ned (Ned Hadzo)
01:45 PM Bug #14911 (Rejected): Segmentation fault
Hi,
This `SyntaxError`
~~~ ruby
def foobar
‘x’, 'y'
end
~~~
But this `Segmentation fault`
~~~ ruby
def fo...
askn (Aşkın Gedik)
06:38 AM Misc #14861: DevelopersMeeting20180718Japan
Would it be possible to discuss: https://bugs.ruby-lang.org/issues/12306
"Implement String #blank? #present? and i...
sam.saffron (Sam Saffron)
06:05 AM Revision eb53b0ff (git): process.c (assert_close_on_exec): quiet warning about unused result
Not much we can do if writing to STDERR_FILENO fails.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63963 b2dd03...
Eric Wong
04:59 AM Bug #14908: Enumerator::Lazy creates unnecessary Array objects.
Indeed, as long as `Yielder#yield` is kept with arity -1 (as in this patch), indeed I don't think that would be an "i... marcandre (Marc-Andre Lafortune)
04:46 AM Bug #14908: Enumerator::Lazy creates unnecessary Array objects.
Eregon (Benoit Daloze) wrote:
> Changing Enumerator::Yielder#<< to have arity 1 seems fine to me, as I guess nobody ...
chopraanmol1 (Anmol Chopra)
04:58 AM Bug #14891: Pathname#join has different behaviour to File.join
I'd rather say that File.join is currently broken, and it should behave like Pathname.join. But probably I'm missing ... funny_falcon (Yura Sokolov)
03:15 AM Revision 83b737d8 (git): test/ruby/test_signal.rb (test_sigchld_ignore): increase timeout
I suspect CI test machine was overloaded at the time,
or swapping at the time due to parallel build with mjit.
git-s...
Eric Wong
01:15 AM Bug #14910: /usr/local/Cellar/ruby/2.5.1/lib/ruby/2.5.0/x86_64-darwin17/openssl.bundle: [BUG] Segmentation fault at 0x0000000000000001
nobu (Nobuyoshi Nakada) wrote:
> Seems that it happened in BoringSSL.
>
> https://boringssl.googlesource.com/bori...
huangyanpeng (彦鹏 黄)

07/12/2018

11:23 PM Revision 20d3e1c8 (git): * 2018-07-13
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63961 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
11:23 PM Revision c6b85fcd (git): timer_thread: do not close pipes around fork
There's actually no need to close the pipes used by the
sleepy timer thread before forking, only to stop the timer
th...
Eric Wong
09:39 PM Feature #14473: Add Range#subrange?
Not directly related, but if your ranges are such that begin <= end, then I think you can use `range.max > idx.max` f... marcandre (Marc-Andre Lafortune)
06:55 AM Feature #14473: Add Range#subrange?
As real-world use-case,
I want it(include,cover version) for guarding NArray's Index arguments.
NArray#[] can acce...
tarui (Masaya Tarui)
01:05 PM Bug #14910 (Feedback): /usr/local/Cellar/ruby/2.5.1/lib/ruby/2.5.0/x86_64-darwin17/openssl.bundle: [BUG] Segmentation fault at 0x0000000000000001
Seems that it happened in BoringSSL.
https://boringssl.googlesource.com/boringssl/+/master#boringssl
> Although B...
nobu (Nobuyoshi Nakada)
11:16 AM Bug #14910 (Closed): /usr/local/Cellar/ruby/2.5.1/lib/ruby/2.5.0/x86_64-darwin17/openssl.bundle: [BUG] Segmentation fault at 0x0000000000000001
```
-- Control frame information -----------------------------------------------
c:0026 p:-17561534676150 s:0174 e:...
huangyanpeng (彦鹏 黄)
12:29 PM Bug #14909: Method call with object that has to_hash method crashes (method with splat and keyword arguments)
At least, it behaves the same if passing a keyword arguments directly:
~~~ruby
def my_func(*objects, error_code: ...
Eregon (Benoit Daloze)
11:21 AM Bug #14909 (Feedback): Method call with object that has to_hash method crashes (method with splat and keyword arguments)
In the plan of Ruby 3 (#14183), keyword arguments will be separated from other kinds of arguments. If this plan is i... mame (Yusuke Endoh)
07:37 AM Bug #14909 (Closed): Method call with object that has to_hash method crashes (method with splat and keyword arguments)
In a method with a splat method argument followed by a keyword argument, it leads to an `ArgumentError` when calling ... johannes_luedke (Johannes Lüdke)
09:25 AM Bug #14908: Enumerator::Lazy creates unnecessary Array objects.
Changing Enumerator::Yielder#<< to have arity 1 seems fine to me, as I guess nobody calls << on an Enumerator::Yielde... Eregon (Benoit Daloze)
05:03 AM Bug #14908: Enumerator::Lazy creates unnecessary Array objects.
shyouhei (Shyouhei Urabe) wrote:
> Understand the problem. The proposed fix however involves spec change. We need ...
chopraanmol1 (Anmol Chopra)
12:12 AM Bug #14908: Enumerator::Lazy creates unnecessary Array objects.
Understand the problem. The proposed fix however involves spec change. We need to discuss effects of it before appl... shyouhei (Shyouhei Urabe)
07:53 AM Bug #12548: Rounding modes inconsistency between round versus sprintf
Ok
How about listing them in the format
name ......... height (rounded to whole centimetre)
sprintf would se...
unclekiki (Kieran McCusker)
12:53 AM Bug #12548: Rounding modes inconsistency between round versus sprintf
unclekiki (Kieran McCusker) wrote:
> Imagine you take the height of 100 school children to the nearest half centimet...
nobu (Nobuyoshi Nakada)
07:35 AM Misc #14861: DevelopersMeeting20180718Japan
* [Bug #14908] `Enumerator::Lazy` creates unnecessary `Array` objects. nobu (Nobuyoshi Nakada)
06:40 AM Misc #14861: DevelopersMeeting20180718Japan
[Feature #14473] Add Range#subrange? (tarui)
tarui (Masaya Tarui)
05:01 AM Revision cb5598a4 (git): Improve branch misses
Improve branch misses on frozen object predicate checks negatively
affecting performance of most setters as most obje...
nobu (Nobuyoshi Nakada)
03:59 AM Revision bcf8ce84 (git): Fix compile error on debian8 and gentoo
https://rubyci.org/logs/rubyci.s3.amazonaws.com/debian8/ruby-trunk/log/20180711T213004Z.log.html.gz#miniruby
https://...
znz (Kazuhiro NISHIYAMA)
03:52 AM Bug #14906: MinGW failure - TestIO#test_copy_stream_no_busy_wait
normalperson (Eric Wong) wrote:
> Oops, sorry about that :x
No problem. I don't expect you or anyone else to ...
MSP-Greg (Greg L)
03:32 AM Misc #14905 (Rejected): Strange behavior in Dir.glob using ** operator
It is same as zsh. nobu (Nobuyoshi Nakada)
12:06 AM Misc #14905: Strange behavior in Dir.glob using ** operator
Oops, sorry about that! In my efforts to anonymize the example, I broke it.
It's actually more like this:
~~~ t...
trobinson (Trevor Robinson)
02:29 AM Revision 1c904182 (git): removed unusecd constants
* ruby-runner.c (ruby_libm_func): removed as the following test
actually doesn't need the path of libm.
* test/fid...
nobu (Nobuyoshi Nakada)
02:14 AM Revision 7c5a79ef (git): exe/ruby: link libm for fiddle test
* common.mk (exe/ruby): $(LIBS) should come after the source file
due to the ld spec.
* ruby-runner.c (ruby_libm_f...
nobu (Nobuyoshi Nakada)

07/11/2018

10:49 PM Revision 727e9017 (git): * 2018-07-12
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63955 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
10:49 PM Revision 706d2664 (git): benchmark/README.md: skip showing --timeout option [ci skip]
because it's only available for limited platforms for now.
I'll make it portable and show it later.
git-svn-id: svn+...
k0kubun (Takashi Kokubun)
08:03 PM Bug #14906: MinGW failure - TestIO#test_copy_stream_no_busy_wait
[email protected] wrote:
> r63947 was causing a test-all failure, as on Windows, one
> can't do `File.unlink(t.p...
normalperson (Eric Wong)
01:29 PM Bug #14906: MinGW failure - TestIO#test_copy_stream_no_busy_wait
@normalperson
Eric,
r63947 was causing a test-all failure, as on Windows, one can't do `File.unlink(t.path)` if...
MSP-Greg (Greg L)
09:52 AM Bug #14906: MinGW failure - TestIO#test_copy_stream_no_busy_wait
[email protected] wrote:
> https://bugs.ruby-lang.org/issues/14906

I made r63950 to skip tests to diagnose the...
normalperson (Eric Wong)
04:17 AM Bug #14906 (Closed): MinGW failure - TestIO#test_copy_stream_no_busy_wait
ruby-loco just had a failure on `TestIO#test_copy_stream_no_busy_wait` for the first time.
```
8) Failure:
Tes...
MSP-Greg (Greg L)
07:52 PM Misc #14907: [PATCH] io.c: do not close inherited FDs by default
[email protected] wrote:
> ```diff
> + r.close_on_exec = true
> + r.close_on_exec = true
...
normalperson (Eric Wong)
03:29 PM Misc #14907: [PATCH] io.c: do not close inherited FDs by default
```diff
+ r.close_on_exec = true
+ r.close_on_exec = true
```
The second is `w`?
nobu (Nobuyoshi Nakada)
11:12 AM Misc #14907: [PATCH] io.c: do not close inherited FDs by default
> https://bugs.ruby-lang.org/issues/14907
> I only found one minor regression from this change in
> test/lib/test...
normalperson (Eric Wong)
10:33 AM Misc #14907 (Closed): [PATCH] io.c: do not close inherited FDs by default
io.c: do not close inherited FDs by default
While I fully agree Ruby should create FDs with close-on-exec by
defa...
normalperson (Eric Wong)
01:23 PM Bug #14908 (Closed): Enumerator::Lazy creates unnecessary Array objects.
Benchmark result on trunk:
~~~
user system total real
Lazy: 0.120000 0.0...
chopraanmol1 (Anmol Chopra)
01:00 PM Revision f2dec4ab (git): Failed to unlink before close on mswin
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63953 b2dd03c8-39d4-4d8f-98ff-823fe69b080e znz (Kazuhiro NISHIYAMA)
12:33 PM Bug #12548: Rounding modes inconsistency between round versus sprintf
It is a real bug, it's just that, as I have said before, the "fix" took the wrong direction. sprintf should behave li... unclekiki (Kieran McCusker)
01:55 AM Bug #12548: Rounding modes inconsistency between round versus sprintf
The current status is:
- We once have fixed this bug.
- That caused rails breakage.
- Everybody complained.
- S...
shyouhei (Shyouhei Urabe)
10:28 AM Revision 304b5446 (git): test/ruby/test_io.rb (test_copy_stream_to_duplex_io): join thread
Don't leave runaway threads as it could affect other tests.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63952 ...
Eric Wong
09:56 AM Revision dae0f438 (git): Make block spacing consistent
[Fix GH-1910] [ci skip]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63951 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
09:47 AM Revision 44d1929d (git): test/ruby/test_io.rb: skip garbage and CPU tests if multi-threaded
Threads should not be active during these tests, but
maybe they are...
ref: https://bugs.ruby-lang.org/issues/14906
...
Eric Wong
09:26 AM Feature #9123: Make Numeric#nonzero? behavior consistent with Numeric#zero?
ana06 (Ana Maria Martinez Gomez) wrote:
> It is already 4 years since this was pointed out. I am really surprised th...
bozhidar (Bozhidar Batsov)
08:49 AM Revision b2056425 (git): thread_pthread: avoid redundant error message on pipe2() fail
Seeing one error for pipe creation is enough.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63949 b2dd03c8-39d4-...
Eric Wong
08:49 AM Revision 23f4ba46 (git): thread_pthread.c: use mask for timer implementation
timer-thread will continue to be supported, but future
"timer" implementation may not be a thread.
git-svn-id: svn+s...
Eric Wong
08:33 AM Revision e22f3bf9 (git): test/test_{tempfile,tmpdir}: get rid of leftover files
I ran out of inodes in $TMPDIR
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63947 b2dd03c8-39d4-4d8f-98ff-823fe...
Eric Wong
08:33 AM Revision 9366d709 (git): spec/ruby/security/cve_2018_6914_spec.rb: get rid of leftover files
I ran out of inodes in $TMPDIR :<
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63946 b2dd03c8-39d4-4d8f-98ff-82...
Eric Wong
05:03 AM Feature #14904: Make it possible to run instance_eval with zero-arguments lambda
prijutme4ty (Ilya Vorontsov) wrote:
> My use case is just a simple example showing why current behavior isn't as goo...
jeremyevans0 (Jeremy Evans)
02:35 AM Feature #14904: Make it possible to run instance_eval with zero-arguments lambda
My use case is just a simple example showing why current behavior isn't as good as it can be.
That's not about lam...
prijutme4ty (Ilya Vorontsov)
12:34 AM Revision 3e93bf3b (git): common.mk: upgrade benchmark_driver
benchmark/README.md: fix help output, which is changed on v0.14.6.
Especially `e1::path1,arg1,...; e2::path2,arg2` pa...
k0kubun (Takashi Kokubun)
12:08 AM Misc #14905 (Feedback): Strange behavior in Dir.glob using ** operator
I cannot reproduce the issue on Linux. What OS are you using?
```
$ ruby -v
ruby 2.5.1p57 (2018-03-29 revision ...
mame (Yusuke Endoh)

07/10/2018

11:56 PM Revision 1053c3d4 (git): benchmark/README.md: some are defined with YAML [ci skip]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63944 b2dd03c8-39d4-4d8f-98ff-823fe69b080e k0kubun (Takashi Kokubun)
11:12 PM Misc #14905 (Rejected): Strange behavior in Dir.glob using ** operator
Hello,
I didn't want to report this as a bug because I'm not sure if it's intentional or not. The documentation di...
trobinson (Trevor Robinson)
05:41 PM Bug #12548: Rounding modes inconsistency between round versus sprintf
I don't think that Float#round and sprintf should have different default behavior. Whichever rounding mode is consid... vor_lord (Brett Williams)
04:10 PM Revision 4b2f2225 (git): Use "diagnose_if" attribute for clang
Before this patch, clang shows many "division by zero is undefined" errors
if a files has syntax error.
git-svn-id: ...
naruse (Yui NARUSE)
04:03 PM Revision fdd7f57b (git): benchmark/README.md: fix typo [ci skip]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63942 b2dd03c8-39d4-4d8f-98ff-823fe69b080e k0kubun (Takashi Kokubun)
03:58 PM Revision 3efcb740 (git): benchmark: revise ERB benchmarks using YAML syntax
to improve the accuracy of measurement by stop using block.
benchmark/app_erb.rb -> benchmark/app_erb.yml: renamed a...
k0kubun (Takashi Kokubun)
03:51 PM Revision 498487ec (git): benchmark/README.md: erb_render is no longer yml but rb [ci skip]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63940 b2dd03c8-39d4-4d8f-98ff-823fe69b080e k0kubun (Takashi Kokubun)
03:49 PM Revision 301cb9ea (git): benchmark/README.md: wording consistency in one sentence [ci skip]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63939 b2dd03c8-39d4-4d8f-98ff-823fe69b080e k0kubun (Takashi Kokubun)
03:44 PM Revision cf438cae (git): * properties.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63938 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
03:44 PM Revision 5d35664a (git): output/driver.rb: add output plugin to reproduce
the original behavior of benchmark/driver.rb.
Probably I won't use this but this is requested by ko1.
Use this with:...
k0kubun (Takashi Kokubun)
03:06 PM Revision 020bb758 (git): revert r63899
this is no longer needed due to r63926
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63936 b2dd03c8-39d4-4d8f-98...
k0kubun (Takashi Kokubun)
03:01 PM Revision eaf312d0 (git): * properties.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63935 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
03:01 PM Revision 2d47a1eb (git): * 2018-07-11
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63934 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
03:01 PM Revision f328fe40 (git): benchmark_driver/runner: add runners for metrics
supported by legacy benchmark/driver.rb.
benchmark/README.md: document them
common.mk: update benchmark_driver to c...
k0kubun (Takashi Kokubun)
02:16 PM Revision 79a8c10b (git): runner/size.rb: fix metric passed to output
runner/peak.rb: ditto
This is needed to make commands like `make -C .ruby-svn benchmark
ITEM=erb OPTS="-r size -o si...
k0kubun (Takashi Kokubun)
01:41 PM Revision 34eed0cd (git): benchmark/README.md: add help output [ci skip]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63931 b2dd03c8-39d4-4d8f-98ff-823fe69b080e k0kubun (Takashi Kokubun)
01:36 PM Revision 59ec265e (git): benchmark/README.md: don't recommend alias installation [ci skip]
benchmark_driver is the official way to install benchmark_driver.
benchmark-driver is just an alias for it.
git-svn-...
k0kubun (Takashi Kokubun)
01:16 PM Revision 83c53894 (git): common.mk: execute benchmark alphabetically
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63929 b2dd03c8-39d4-4d8f-98ff-823fe69b080e k0kubun (Takashi Kokubun)
01:08 PM Revision 433af161 (git): benchmark: drop all bm_ prefix for legacy driver.rb
benchmark/*.rb is only benchmarks now. We don't need prefixes.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@639...
k0kubun (Takashi Kokubun)
01:05 PM Revision f992f425 (git): * properties.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63927 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
01:05 PM Revision 8068d34c (git): Revert "benchmark/*.yml: convert from benchmark/bm_*.rb"
This reverts r63900.
Having single-execution benchmark as a normal Ruby script is preferred
by ko1. I'm not a big fa...
k0kubun (Takashi Kokubun)
12:14 PM Revision bd12037e (git): * properties.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63925 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
12:14 PM Revision 12a38cba (git): benchmark: resurrect peak / size metrics
by adding runner plugins for them.
benchmark/lib/benchmark_driver/runner/peak.rb: added peak runner plugin
benchmark...
k0kubun (Takashi Kokubun)
04:18 AM Feature #5481: Gemifying Ruby standard library
Thank you for putting matrix and ostruct as gems :-)
I’m not sure where to commit changes to the libraries now: do...
marcandre (Marc-Andre Lafortune)
01:12 AM Feature #14904: Make it possible to run instance_eval with zero-arguments lambda
-1. Seems you are already aware of the fact that lambdas are different from procs in handling of the arguments. Lam... shyouhei (Shyouhei Urabe)

07/09/2018

08:01 PM Revision d8583b13 (git): Remove redundant code in the compiler.
During instruction translation (linked list -> iseq generation), we can
treat `TS_VALUE` and `TS_ISEQ` the same as th...
tenderlovemaking (Aaron Patterson)
07:20 PM Revision 162cbfe6 (git): Remove test code. ISE generation should not impact write barrier
orz!
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63922 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
tenderlovemaking (Aaron Patterson)
06:55 PM Feature #14904: Make it possible to run instance_eval with zero-arguments lambda
I have no particular pro or con opinion on the suggestion itself.
I want to comment on one part though:
> I've ...
shevegen (Robert A. Heiler)
11:42 AM Feature #14904: Make it possible to run instance_eval with zero-arguments lambda
Sorry, define_method in example should be that:
```
define_method(param_name){ instance_eval(&kwargs[:default]) }
```
prijutme4ty (Ilya Vorontsov)
11:32 AM Feature #14904 (Open): Make it possible to run instance_eval with zero-arguments lambda
At a moment #instance_eval always yields an object to a given block. Though if we passed lambda as a block for instan... prijutme4ty (Ilya Vorontsov)
05:49 PM Revision b46ef9d6 (git): Add lldb as a debugger option
This adds support for lldb as a debugger so that tests can be run under
lldb like this:
$ make test-all TESTS=test...
tenderlovemaking (Aaron Patterson)
05:47 PM Revision 7aab72f7 (git): Fix crash when loading iseq from an array
Objects loaded during iseq deserialization using arrays need to be added
to the compile time mark array so that they ...
tenderlovemaking (Aaron Patterson)
04:43 PM Revision 44377383 (git): benchmark/README.md: fix -e interface for v0.14 [ci skip]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63919 b2dd03c8-39d4-4d8f-98ff-823fe69b080e k0kubun (Takashi Kokubun)
04:31 PM Revision 7bed459a (git): benchmark/driver.rb: fully obsolete this
in favor of just using benchmark_driver.gem.
common.mk: The new `make benchmark` covers the both usages for old `mak...
k0kubun (Takashi Kokubun)
03:45 PM Revision 0b519e11 (git): * 2018-07-10
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63917 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
03:45 PM Revision 5b9ff710 (git): common.mk: upgrade benchmark_driver to v0.14
benchmark/driver.rb: deal with breaking changes which are actually
introduced for this driver.
git-svn-id: svn+ssh:/...
k0kubun (Takashi Kokubun)
02:01 PM Revision 70785c1c (git): Promote irb library to default gems.
* lib/irb/irb.gemspec: init.
* lib/irb/version.rb: Set @RELEASE_VERSION value to IRB::VERSION for gemspec.
* doc/...
hsbt (Hiroshi SHIBATA)
01:20 PM Revision 6c4e05d2 (git): file_rename.yml: allow running this on mswin/mingw
Suggested by MSP-Grep:
http://blade.nagaokaut.ac.jp/cgi-bin/scat.rb/ruby/ruby-core/87883
git-svn-id: svn+ssh://ci.ru...
k0kubun (Takashi Kokubun)
12:50 PM Revision 14153a9b (git): app_pentominio.yml: drop unnecessary prelude
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63913 b2dd03c8-39d4-4d8f-98ff-823fe69b080e k0kubun (Takashi Kokubun)
12:05 PM Bug #14891: Pathname#join has different behaviour to File.join
I think it is expected behavior.
https://github.com/ruby/ruby/blob/38e05ff3e194268fd2f38ac7c9530298e464f07b/test/p...
znz (Kazuhiro NISHIYAMA)
08:07 AM Bug #14847 (Closed): `clone` can generate strange objects
Applied in changeset trunk|r63912.
----------
Don't copy FL_USER* on Kernel#clone. [Bug #14847]
* object.c (mutable...
ko1 (Koichi Sasada)
08:07 AM Revision 38e05ff3 (git): Don't copy FL_USER* on Kernel#clone. [Bug #14847]
* object.c (mutable_obj_clone): `Kernel#clone` should not copy
FL_USER* flags because they are copied unexpectedly....
ko1 (Koichi Sasada)
03:07 AM Revision 63efc86b (git): addr2line.c (kprintf): static
This function is not used outside of addr2line.c
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63911 b2dd03c8-39...
Eric Wong
01:50 AM Revision bf9169d5 (git): common.mk: codesign ruby-runner too
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63910 b2dd03c8-39d4-4d8f-98ff-823fe69b080e nobu (Nobuyoshi Nakada)
01:23 AM Bug #14899 (Closed): Pathname#glob Matching to the directory results in lack
Applied in changeset trunk|r63909.
----------
dir.c: fix directory glob
* dir.c (glob_helper): fix directory glob w...
nobu (Nobuyoshi Nakada)
01:20 AM Revision 58f2e6bc (git): dir.c: fix directory glob
* dir.c (glob_helper): fix directory glob which resulted in lacking
the first byte. adjust the length of basename ...
nobu (Nobuyoshi Nakada)

07/08/2018

11:43 PM Revision 0528838b (git): addr2line.c: no need to keep fd around after mmap
POSIX mmap(3) manpage stipulates mmap bumps the reference
count of the file description. Thus keeping a file descrip...
Eric Wong
09:14 PM Misc #14902: Replace benchmark/driver.rb with benchmark_driver.gem
@k0kubun
Thank you for your work on this. Somewhat off topic...
I ran the suite on ruby-loco, and the only cha...
MSP-Greg (Greg L)
02:38 PM Misc #14902 (Closed): Replace benchmark/driver.rb with benchmark_driver.gem
Applied in changeset trunk|r63888.
----------
benchmark: introduce benchmark_driver.gem
Makefile.in: Clone benchmar...
k0kubun (Takashi Kokubun)
03:05 AM Misc #14902 (Closed): Replace benchmark/driver.rb with benchmark_driver.gem
## What's benchmark_driver.gem?
benchmark_driver.gem is a gem created by a project accepted as Ruby Association Gran...
k0kubun (Takashi Kokubun)
07:30 PM Revision e1a8d281 (git): range.c: [DOC] small improvement
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63907 b2dd03c8-39d4-4d8f-98ff-823fe69b080e stomar (Marcus Stollsteimer)
07:22 PM Feature #14901: [PATCH] do not block SIGCHLD in normal Ruby Threads
[email protected] wrote:
> So these 2 issues ("OpenSSL::PKey::*.new",
> test/-ext-/gvl/test_last_thread.rb) ar...
normalperson (Eric Wong)
01:02 PM Feature #14901 (Assigned): [PATCH] do not block SIGCHLD in normal Ruby Threads
k0kubun (Takashi Kokubun)
08:24 AM Feature #14901: [PATCH] do not block SIGCHLD in normal Ruby Threads
> In this context, "blocking" mean disabling interrupts using pthread_sigmask/sigprocmask. As in: blocking signals fr... k0kubun (Takashi Kokubun)
07:04 AM Feature #14901: [PATCH] do not block SIGCHLD in normal Ruby Threads
[email protected] wrote:
> I have not completely read your patch for [Bug #14867] yet, so
> let me ask some qu...
normalperson (Eric Wong)
03:34 AM Feature #14901: [PATCH] do not block SIGCHLD in normal Ruby Threads
I have not completely read your patch for [Bug #14867] yet, so let me ask some questions to understand the context.
...
k0kubun (Takashi Kokubun)
02:53 AM Feature #14901 (Assigned): [PATCH] do not block SIGCHLD in normal Ruby Threads
@k0kubun: any opinions on this? Thanks.
```
I blocked SIGCHLD in normal Ruby Threads for [Bug #14867]
because I...
normalperson (Eric Wong)
06:33 PM Revision 2a12b82d (git): benchmark/driver.rb: make this more similar
to original benchmark-driver command.
I'm going to add some runner plugins to resurrect metrics which were
originall...
k0kubun (Takashi Kokubun)
06:10 PM Revision 2cab2fc8 (git): benchmark/README.md: [ci skip] change syntax highlight
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63905 b2dd03c8-39d4-4d8f-98ff-823fe69b080e k0kubun (Takashi Kokubun)
06:08 PM Revision 26a95dda (git): * properties.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63904 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
06:08 PM Revision 8b015867 (git): benchmark/README.md: [ci skip] write documentation
about this directory
benchmark/driver.rb: ditto
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63903 b2dd03c8-39...
k0kubun (Takashi Kokubun)
05:48 PM Revision dc8327d7 (git): benchmark/driver.rb: drop legacy Ruby script support
Now all benchmarks are converted to YAMLs.
common.mk: Drop obsoleted bm_* pattern
git-svn-id: svn+ssh://ci.ruby-lan...
k0kubun (Takashi Kokubun)
05:47 PM Revision a7681376 (git): benchmark/app_pentomino.yml: remove original scripts after __END__
mistakenly left by conversion script...
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63901 b2dd03c8-39d4-4d8f-9...
k0kubun (Takashi Kokubun)
05:36 PM Revision 929982ec (git): benchmark/*.yml: convert from benchmark/bm_*.rb
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63900 b2dd03c8-39d4-4d8f-98ff-823fe69b080e k0kubun (Takashi Kokubun)
05:31 PM Revision d933fe9b (git): benchmark/gc: prevent GC bench from depending on normal benchmark
scripts.
This is needed to finish converting Ruby scripts to YAMLs.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/tru...
k0kubun (Takashi Kokubun)
05:22 PM Revision 2079fe86 (git): benchmark/vm2_struct_small_aset.yml: unwrap loop_count
since `i` is involved in this script as well...
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63898 b2dd03c8-39d...
k0kubun (Takashi Kokubun)
05:19 PM Revision 71f8406f (git): benchmark/vm2_*.yml: fix ugly conversion errors
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63897 b2dd03c8-39d4-4d8f-98ff-823fe69b080e k0kubun (Takashi Kokubun)
05:03 PM Revision 12068aa4 (git): benchmark/vm2_*.yml: abstract away the while loop
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63896 b2dd03c8-39d4-4d8f-98ff-823fe69b080e k0kubun (Takashi Kokubun)
04:46 PM Revision 1aedeaa4 (git): benchmark/vm1_ensure.yml: rollback loop_count abstraction
for now.
When measured script is really too fast, while loop substituion may
return a negative benchmark result.
Pr...
k0kubun (Takashi Kokubun)
04:35 PM Revision 94e55bbd (git): benchmark/vm1_*.yml: manual fixes for ugly conversions
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63894 b2dd03c8-39d4-4d8f-98ff-823fe69b080e k0kubun (Takashi Kokubun)
04:28 PM Revision 820ad9cb (git): benchmark/vm1_*.yml: abstract away the while loop
benchmark/driver.rb had removed the cost for while loop in benchmark/bm_vm1_*.rb,
and benchmark_driver.gem can achiev...
k0kubun (Takashi Kokubun)
03:35 PM Revision 9e62c93d (git): benchmark: convert bm_vm2_*.rb to vm2_*.yml
This YAML transformation is needed to support whileloop2 time substituion
by benchmark_driver.gem later.
This commmi...
k0kubun (Takashi Kokubun)
03:12 PM Revision 95a187e0 (git): benchmark: convert bm_vm1_*.rb to vm1_*.yml
This YAML transformation is needed to support whileloop time substituion
by benchmark_driver.gem later.
This commmit...
k0kubun (Takashi Kokubun)
03:05 PM Revision 62e95638 (git): * 2018-07-09
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63890 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
03:05 PM Revision 893b2d97 (git): benchmark/driver.rb: fix wrong multiline regexp
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63889 b2dd03c8-39d4-4d8f-98ff-823fe69b080e k0kubun (Takashi Kokubun)
02:38 PM Revision 3293322a (git): benchmark: introduce benchmark_driver.gem
Makefile.in: Clone benchmark-driver repository in benchmark/benchmark-driver
`make update-benchmark-driver`, like s...
k0kubun (Takashi Kokubun)
02:08 PM Revision 1f4541cb (git): common.mk: load prelude on `make benchmark`
because benchmark/bm_io_nonblock_noex.rb and benchmark/bm_io_nonblock_noex2.rb
are using IO#write_nonblock and it's d...
k0kubun (Takashi Kokubun)
01:03 PM Revision 9fd839c0 (git): benchmark: drop legacy benchmark drivers
It seems like they are all benchmark drivers but "benchmark/driver.rb"
is the latest and others are no longer used.
...
k0kubun (Takashi Kokubun)
11:35 AM Bug #14900: Extra allocation in String#byteslice
I played around with my assumptions here. By far the worst from a memory POV was `slice!`, which given a string of 5M... ioquatix (Samuel Williams)
10:45 AM Bug #14900: Extra allocation in String#byteslice
The way I've implemented it now (as in your first example) is something like this:
```
@buffer = read_data
if @b...
ioquatix (Samuel Williams)
09:47 AM Bug #14900: Extra allocation in String#byteslice
Yeah, I agree, this patch probably isn't right, but I just try to figure it out what is going on and suggest a soluti... ioquatix (Samuel Williams)
09:46 AM Bug #14900: Extra allocation in String#byteslice
@ioquatix, your patch doesn't seems to be correct for me on first glance.
Imagine pipelined RPC server:
- we rea...
funny_falcon (Yura Sokolov)
03:31 AM Bug #14900: Extra allocation in String#byteslice
I think there are several things to consider here:
- Even though the string appears to be two allocations, it's on...
ioquatix (Samuel Williams)
03:22 AM Bug #14900: Extra allocation in String#byteslice
Okay I made an attempt to fix this: https://github.com/ruby/ruby/pull/1909 ioquatix (Samuel Williams)
02:52 AM Bug #14900: Extra allocation in String#byteslice
One thing I noticed if I freeze source string, the extra memory allocation goes away. ioquatix (Samuel Williams)
02:52 AM Bug #14900: Extra allocation in String#byteslice
Okay, I reproduced the error. I made a test case here:
https://github.com/ioquatix/ruby/commit/9fb5cd644209efc7937...
ioquatix (Samuel Williams)
09:41 AM Feature #13620: Simplifying MRI's build system: always make install
@normalperson wrote in ruby-core:87864:
> mkmf works fine with everything in ext/ without install, so I
> expect mj...
Eregon (Benoit Daloze)
07:27 AM Revision d41baaee (git): test/ruby (*no_hidden_garbage): disable GC and skip if multi-threaded
Any single object allocation can reduce object count, and
object counts are global, so multi-threading leads to unpre...
Eric Wong
07:27 AM Revision c93adfc1 (git): mjit: get rid of memory leak in pause+resume loop
pthread_atfork is not idempotent and repeatedly calling it
causes it to register the same hook repeatedly; leading to...
Eric Wong
05:52 AM Revision a1e58949 (git): tool/git-refresh: skip git fetch and checkout
if the tag is already checked out, to optimize the execution time.
I'm going to prepare a task depending on this too...
k0kubun (Takashi Kokubun)
04:12 AM Revision c2ae11e3 (git): benchmark/driver.rb: simplify LoadError handling
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63882 b2dd03c8-39d4-4d8f-98ff-823fe69b080e k0kubun (Takashi Kokubun)
02:45 AM Bug #14867: Process.wait can wait for MJIT compiler process
Eric,
r63880 fixed it, Appveyor mswin is green. I will ask them about a 'no javascript' fallback for at least som...
MSP-Greg (Greg L)
01:52 AM Bug #14867: Process.wait can wait for MJIT compiler process
[email protected] wrote:
> Both mswin & ruby-loco failed the test `test_sigchld_ignore` in r63879.
>
> Havin...
normalperson (Eric Wong)
01:07 AM Bug #14867: Process.wait can wait for MJIT compiler process
@normalperson
Eric,
Both mswin & ruby-loco failed the test `test_sigchld_ignore` in r63879.
Having recentl...
MSP-Greg (Greg L)
12:06 AM Bug #14867: Process.wait can wait for MJIT compiler process
Thanks! I confirmed that the patch works well on my machine as well. k0kubun (Takashi Kokubun)
12:01 AM Bug #14867 (Closed): Process.wait can wait for MJIT compiler process
Applied in changeset trunk|r63877.
----------
process.c (rb_f_exec): pause MJIT before replacing process
Non-parall...
normalperson (Eric Wong)
02:25 AM Revision d081b3c6 (git): common.mk: drop obsoleted `make tbench`
benchmark/bmx_* files haven't existed since r37263 and thus it runs
nothing.
git-svn-id: svn+ssh://ci.ruby-lang.org/...
k0kubun (Takashi Kokubun)
02:02 AM Feature #14736: Thread selector for flexible cooperative fiber based concurrency
I have updated the PR to use `transfer` in the scheduler, and I've added an example showing that it is composable wit... ioquatix (Samuel Williams)
01:46 AM Revision bc4ecaa6 (git): test/ruby/test_signal.rb: skip ensure if test is skipped
Thanks to Greg for the fix. [ruby-core:87860] [Bug #14867]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63880 b...
Eric Wong
12:02 AM Revision b93dc848 (git): signal.c: preserve trap(:CHLD, "IGNORE") behavior with SIGCHLD
We need to preserve "IGNORE" behavior from Ruby 2.5 and earlier.
We can't rely on SA_NOCLDWAIT any more, since we alw...
Eric Wong

07/07/2018

11:59 PM Revision 4719a454 (git): * 2018-07-08
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63878 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
11:59 PM Revision ac41c2c1 (git): process.c (rb_f_exec): pause MJIT before replacing process
Non-parallel "make test-spec" caused
spec/ruby/core/process/wait2_spec.rb failures because mspec
uses "exec" in singl...
Eric Wong
10:52 PM Bug #14867: Process.wait can wait for MJIT compiler process
[email protected] wrote:
> Hi Eric. I fixed [Bug #14892] on r63875, but only the rubyspec check you added is fa...
normalperson (Eric Wong)
02:58 PM Bug #14867 (Assigned): Process.wait can wait for MJIT compiler process
Hi Eric. I fixed [Bug #14892] on r63875, but only the rubyspec check you added is failing with -DMJIT_FORCE_ENABLE li... k0kubun (Takashi Kokubun)
08:48 PM Bug #14900: Extra allocation in String#byteslice
Nice catch I will try to verify on my end too ioquatix (Samuel Williams)
09:47 AM Bug #14900 (Closed): Extra allocation in String#byteslice
When executing `String#byteslice` with a range, I noticed that sometimes the original string is allocated again. When... janko (Janko Marohnić)
05:43 PM Feature #13620: Simplifying MRI's build system: always make install
normalperson (Eric Wong) wrote:
> Of course, there will be differences not detected before
> install, but the goa...
Eregon (Benoit Daloze)
05:07 PM Feature #14426: [PATCH] openssl: reduce memory allocation in OpenSSL::Buffering#do_write
The patch got outdated in the latest trunk, so I updated it again. It's a really small change with big impact on memo... janko (Janko Marohnić)
04:16 PM Misc #14861: DevelopersMeeting20180718Japan
* [Bug #14878] Add command line argument to deactivate JIT (k0kubun)
* Please discuss the necessity of the flag an...
k0kubun (Takashi Kokubun)
02:55 PM Revision a854e4dd (git): wait2_spec.rb: skip leak checker for now
This is not working with cppflags="-DMJIT_FORCE_ENABLE" on my machine.
```
$ make test-spec
$ /home/k0kubun/src/gith...
k0kubun (Takashi Kokubun)
02:41 PM Bug #14892 (Closed): r63763 breaks -DMJIT_FORCE_ENABLE=1
Applied in changeset trunk|r63875.
----------
insns.def: stop pushing unnecessary keys for MJIT
[Bug #14892]
k0kubun (Takashi Kokubun)
02:41 PM Revision 8bec3e1f (git): insns.def: stop pushing unnecessary keys for MJIT
[Bug #14892]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63875 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
k0kubun (Takashi Kokubun)
02:28 PM Revision c2df63d0 (git): _mjit_compile_insn_body: rollback pc correctly
for catch_except_p case
Partially solving Bug#14892
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63874 b2dd03c...
k0kubun (Takashi Kokubun)
08:45 AM Bug #14899 (Closed): Pathname#glob Matching to the directory results in lack
Pathname.glob では問題ないのですが、
ruby 2.5 から追加された Pathname#glob で、スラッシュで終わる引数を渡すとディレクトリ名の最初の1文字がかけた状態で返ってきます
~~~
Pathna...
hazi (yuhei mukoyama)
05:52 AM Bug #14898: test/lib/test/unit/parallel.rb: TestSocket#test_timestamp stuck sometimes
On 2018/07/07 14:36, Eric Wong wrote:
> Maybe r63872 can help by retrying send.

Great! Thank you.

--
// SAS...
ko1 (Koichi Sasada)
05:42 AM Bug #14898: test/lib/test/unit/parallel.rb: TestSocket#test_timestamp stuck sometimes
Koichi Sasada <[email protected]> wrote:
> On 2018/07/06 18:47, Eric Wong wrote:
> > I would not expect it to be (but ...
normalperson (Eric Wong)
05:36 AM Bug #14898 (Closed): test/lib/test/unit/parallel.rb: TestSocket#test_timestamp stuck sometimes
Applied in changeset trunk|r63872.
----------
test/socket/test_socket.rb (test_timestamp): retry send
I theorize th...
normalperson (Eric Wong)
03:42 AM Bug #14898: test/lib/test/unit/parallel.rb: TestSocket#test_timestamp stuck sometimes
On 2018/07/06 18:47, Eric Wong wrote:
> I've never seen it stuck myself.

Only a few times per thousands trial. I...
ko1 (Koichi Sasada)
05:34 AM Revision 886cfe49 (git): * 2018-07-07
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63873 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
05:34 AM Revision eb78beda (git): test/socket/test_socket.rb (test_timestamp): retry send
I theorize there can be UDP packet loss even over loopback if
the kernel is under memory pressure. Retry sending per...
Eric Wong
 

Also available in: Atom