Activity
From 09/08/2019 to 09/14/2019
09/14/2019
-
09:49 PM Feature #10344: [PATCH] Implement Fiber#raise
- NEWS is updated.
-
08:57 PM Revision 1edcfd61 (git): Issue a warning if invalid kw_splat is passed to *_kw function
- This should only happen if the API is misused. It's much better
to warn here and fix the problem, versus to try to d... -
07:46 PM Bug #16167 (Assigned): make-snapshot does not work from fresh checkout
- nobu (Nobuyoshi Nakada) wrote:
> I'm going to deprecate `-exported` option because it can't make stable-checksum tar... -
02:53 PM Bug #16167: make-snapshot does not work from fresh checkout
- I'm going to deprecate `-exported` option because it can't make stable-checksum tarballs.
-
- Applied in changeset commit:git|e9c7fc7ca9bc15a9f84bdc356f7b6fac12988ccb.
----------
Continue to export even if no n... - 05:15 PM Revision 395e5f51 (git): * 2019-09-15 [ci skip]
-
-
- Just exporting may not imply exporting ChangeLog which needs
notes/commits. [Bug #16167] -
- Enters raw-mode but enable interrupts.
https://github.com/ruby/io-console/commit/7cba76561a -
12:38 PM Revision 82634596 (git): Keep the reference of imemo while argv may be used
- To prevent the `v` reference from being eliminated before argv is used,
calling `rb_free_tmp_buffer` against `v` expl... -
- Needs another room to append an empty hash.
- 10:43 AM Revision 9699a5c5 (git): Update news regarding `Fiber#raise`.
-
- nagachika pointed out that ALLOC_N is actually just malloc, so
this memory wasn't being freed. This shouldn't be a p... -
- It is not safe to set this in C functions that can be called from
other C functions, as in the non argument-delegatio... -
- It happens inside “grpc” extension library.
Have you asked them? -
02:25 AM Bug #16136: String corruption in 2.6.4
- ruby_2_6 r67803 merged revision(s) ade1283ca276f7d589ffd3539fbc7b9817f682d5.
-
- Fix a use-after-free bug by avoiding rb_str_new_frozen
`str2 = rb_str_new_frozen(str1)` seems to make str1 a...
09/13/2019
- 11:54 PM Revision b2c29bba (git): * remove trailing spaces. [ci skip]
-
- Remove rb_add_empty_keyword, and instead of calling that every
place you need to add empty keyword hashes, run that c... -
05:54 PM Misc #16157: What is the correct and *portable* way to do generic delegation?
- Dan0042 (Daniel DeLorme) wrote:
> In that case I'd like to make one last suggestion.
>
> For a method with `*args... -
05:00 PM Misc #16157: What is the correct and *portable* way to do generic delegation?
- In that case I'd like to make one last suggestion.
For a method with `*args`, if the method is called with keyword... -
- Dan0042 (Daniel DeLorme) wrote:
> With 2.7, people will be asked to migrate their generic delegations to use `pass_k... -
- There's something I'd like to clarify.
With 2.7, people will be asked to migrate their generic delegations to use ... -
- So far, I was using this sequence to get Ruby snapshot:
~~~
git clone https://github.com/ruby/ruby ~/ruby
cd ~/r... -
- This sets the correct VM frame flags when using Method#call to
call funcs, and handles empty keyword hashes for cfunc... -
03:45 PM Feature #16166: Remove exceptional treatment of *foo when it is the sole block parameter
- Actually that reminds me - mame mentioned that the ruby core team needs a
motivation/impetus if a change is necessar... -
- > We need an evidence that the behavior actually confuses
> many people, at least.
It does not confuse me because... -
10:16 AM Feature #16166: Remove exceptional treatment of *foo when it is the sole block parameter
- I agree that Ruby's arguments are insanely complex. In the basic case, `"a"` and `["a"]` are distinguished.
```
... -
08:17 AM Feature #16166 (Closed): Remove exceptional treatment of *foo when it is the sole block parameter
- In the parameter signature of a code block for a method that is not involved in method definition or creation of lamb...
-
03:16 PM Revision 98f919ed (git): The stdlib readline should raise Interrupt when pressing C-c
- 03:12 PM Revision 70fe473c (git): * 2019-09-14 [ci skip]
-
- This reverts commit 805b0a481132938638dbd32830cf5dca3910efb1.
-
- This reverts commit 685f12bbca50ff9b7a16b3016b3b8b3f2ac8b796.
-
- This reverts commit 6d9e54816f828983bcf383ce6fce287bd3ca05b9.
-
- test/ruby/test_fiber.rb: reduce the count of object creation to cause
GC
The test consistently fail... -
- webrick/test_utils.rb: loosen timeout severity
to stabilize CI failure like:
https://rubyci.org/logs... -
-
-
07:24 AM Revision 2da6b328 (git): introduce IBF_(MAJOR|MINOR)_VERSION.
- RubyVM::InstructionSequence.to_binary generates a bytecode binary
representation. To check compatibility with binary ... -
04:44 AM Revision 3c162df9 (git): Dump some information
09/12/2019
-
- Ok, I misunderstood what `pass_keywords` was doing; I thought it would only apply to `baz(*args)` in this case.
-
- Dan0042 (Daniel DeLorme) wrote:
> After some more thinking I believe the `pass_keywords` behavior would be appropria... -
- After some more thinking I believe the `pass_keywords` behavior would be appropriate for 100% of methods with an argu...
-
- > Then if you call `foo` with keywords, keywords will be passed to `bar`. This should allow for more backwards compa...
- 03:35 PM Revision 69acf40b (git): * 2019-09-13 [ci skip]
-
- Fixed new Struct-related keyword argument warnings
-
11:19 AM
Feature #14781 (Closed): Enumerator.generate
- Applied in changeset commit:git|775037613bffe6f90e7af510b7f46a2ac10610be.
----------
Implement Enumerator.produce [F... - 11:18 AM Revision ac3e8834 (git): Document and test Enumerator.produce
- Co-authored-by: Victor Shepelev <[email protected]>
- 11:18 AM Revision 77503761 (git): Implement Enumerator.produce [Feature #14781]
-
09:43 AM Bug #16161: tailcall_optimization may be disabled after r67315
- How about adding `vm_call_iseq_setup_tailcall_opt_start` as same as `vm_call_iseq_setup_normal_opt_start`?
(Copy-and... -
-
09:25 AM Feature #16102: `Symbol#call`
- I propose this general solution.
diff --git a/array.c b/array.c
index 3717c3ff34..3809af01cf 100644
... -
- I remember the old pickaxe having mentioned ENV as a hash-like
object. I guess the documentation could be updated to... -
- That is a documentation bug.
-
01:04 AM Bug #16165: Endless ranges have inconsistency between #cover? and #include?
- For the sake of archives & potential future search engine hits - this got fixed a few days ago and will be in whateve...
09/11/2019
-
- Closing as per your request. Thank you for your investigation anyway.
-
- Doh, this needs closing; my apologies. I had not realised that I was testing in an execution environment that had pul...
-
- In an endless Range, I'd expect to be able to use `#include?` just as I do with a Range that has an end value. It wou...
-
- Dan0042 (Daniel DeLorme) wrote:
> Of course this is all *extremely* unconventional usage and doesn't really deserve ... -
- After discussion with some other committers, I have an alternative approach in https://github.com/ruby/ruby/pull/2449...
-
- > Prior to the keyword argument separation branch merge, it was not even possible for a C method to tell if it was ca...
-
09:58 PM Revision 515b1989 (git): Make NODE_ARYPTN layout consistent between Ripper and AST
- We are seeing SEGVs in CI:
http://ci.rvm.jp/results/trunk-gc-asserts@ruby-sky1/2253563
This is happening because ... -
- I added an alternative approach for handling delegate keyword warnings in https://github.com/ruby/ruby/pull/2449. Th...
-
09:24 PM Bug #16164 (Closed): ENV.each with block returns ENV object itself, not Hash
- My code:
x = ENV.each { |name, value| }
puts "Return value class: #{x.class}"
puts "Return value is a Hash? #{x.... -
09:23 PM Revision 21994b7f (git): Avoid rehashing keys in transform_values
- Previously, calling transform_values would call rb_hash_aset for each
key, needing to rehash it and look up its locat... -
- 06:21 PM Revision 1febb6f4 (git): * 2019-09-12 [ci skip]
-
- Previously, the warning functions skipped warning in these cases.
This removes the skipping, and uses a less descript... -
05:35 PM Bug #16159: rubyspec about time fails in Asia/Kuala_Lumpur timezone
- Also, I ran it multiple times between 11pm - 1.30am
-
- GMT+8
```
$ date +%z
+0800
``` -
03:59 PM Bug #16158: "st" Character Sequence In Regex Look-Behind Causes Illegal Pattern Error When Combined With POSIX Bracket Expressions And Case Insensitivity Flag
- Thank you both.
I can confirm the encoding being a factor. It's an issue even if it is not the default.
```
... -
- This appears to be an issue if the default encoding is UTF-8:
```
$ ruby -ve 'pat = /(?<!a st)\p{Space}/i'
ruby ... -
- I can reproduce the bug in all versions of ruby.
```
$ 2.5 ruby -ve 'pat = /(?<!a st)\p{Space}/i'
ruby 2.5.6p167... -
03:03 PM Misc #16152: DevelopersMeeting20190919Japan
- - [Feature #16131] Remove $SAFE, taint and trust
- What do you think about the proposed schedule?
- I am askin... -
- I opened PR [1] implementing this.
[1]: https://github.com/rubygems/rubygems/pull/2909 -
-
- What you're asking for is a O(n²) operation. I'm not sure it's a good idea to make that so easy and transparent as a ...
-
-
09:03 AM Feature #16163 (Closed): Reduce the output of `RubyVM::InstructionSequence#to_binary`
- ## Abstract
The output of `RubyVM::InstructionSequence#to_binary` is extremely large.
We have reduced the output ... -
-
07:01 AM Revision 655c65d6 (git): &$$->nd_lit is uninitialized at this point
- See also https://travis-ci.org/ruby/ruby/jobs/583031687#L1874
-
- Bump. I would like to revisit this. Do we need this many call to malloc_usable_size()?
-
- https://docs.aws.amazon.com/cli/latest/reference/s3/sync.html
> --no-progress (boolean) File transfer progress is not... -
- This is still an issue in the master branch. I've added a pull request for rdoc that will treat `rb_define_method` t...
09/10/2019
-
- Macros can't be expressions, that is a GNU extension (I didn't know
that). This commit converts the macro to a funct... -
- Dan0042 (Daniel DeLorme) wrote:
> > The only time you really need the `RUBY_VERSION` check is for complete argument ... -
- > Note that the `RUBY_VERSION` check is only needed in a subset of the cases. In cases where the target method does ...
-
- Note that the `RUBY_VERSION` check is only needed in a subset of the cases. In cases where the target method does no...
-
- Hmm, ok, that's what I was afraid of. I mean, it's not exactly a pretty solution. And it's not limited to method_miss...
-
-
07:06 PM Feature #16150: Add a way to request a frozen string from to_s
- @eregon, for context Matz recently refused a very similar change https://bugs.ruby-lang.org/issues/15836
-
08:12 AM Feature #16150: Add a way to request a frozen string from to_s
- I tried running ActiveSupport tests from Rails master on Ruby 2.6.2 + my PR, and found that one change is needed:
... -
- Dan0042 (Daniel DeLorme) wrote:
> But I can't agree to a backward-incompatible change without a proper deprecation p... -
-
05:42 PM Feature #16144: Honor Logger#level overrides in Logger#add
- My GitHub PR was merged, so I think this can be closed.
- 05:45 PM Revision 721cab47 (git): * 2019-09-11 [ci skip]
-
- Fixes a test in RubySpec
-
- As some background for the dev meeting, I tried a couple of different approaches before this that didn't work.
One... -
- Ruby 2.3.8 is no longer supported, can you please try with Ruby 2.5.6, 2.6.4, or the master branch?
-
12:33 PM Bug #16162 (Closed): Resque::DirtyExit - Child process received unhandled signal (You may have encountered a bug in the Ruby interpreter or extension libraries)
- My background jobs are all failing with the following error Resque::DirtyExit Child process received unhandled signal...
-
- What timezone are you using?
-
- https://github.com/ruby/io-console/commit/4e17c90788
-
- About unused variables and a function.
https://github.com/ruby/io-console/commit/32baf54e7a -
- LONG_MAX_as_double is not needed when long is small enough to be
exactly representable as a double, e.g., IL32LLP64 p... -
- Silly typo.
-
- "GCC diagnostic push/pop" seems appeared at gcc 4.6.
-
- While not intuitive, I think this behavior is expected and not a bug. It is not relating to class cloning, it is due ...
-
03:39 AM Revision f5024de0 (git): Remove check of ai.protocol
- Solaris 10 returns addrinfo.ai_protocol as 0, not 6.
-
- See also https://rubyci.org/logs/rubyci.s3.amazonaws.com/centos6/ruby-master/log/20190910T003005Z.fail.html.gz
-
- From my testing with `class Object; define_method(:bar) {send(:bar)}; bar end`:
1.9-2.1: SystemStackError
2.2-2.4... -
-
- Addrinfo.getaddrinfo and .foreach now accepts :timeout in seconds as
a keyword argument. If getaddrinfo_a(3) is avail... -
- Before r67315:
```
$ ./miniruby -v -e 'iseq = RubyVM::InstructionSequence.compile("def foo(n, s = 0);return s if ...
09/09/2019
-
- The documentation for `owner` states: `Returns the class or module that defines the method.`. The example given in t...
-
- I tried on Ruby 2.5.6 and was not able to reproduce:
```
$ irb25
irb(main):001:0> pat = /(?<!a st)\p{Space}/i
=... -
- Sorry, bad paste on the OP with the success examples.
```
2.5.0 :007 > pat = /((?<!Costa)Mesa|Arlington(?=(\p{Spa... -
- *This is my first Ruby bug submission. Please let me know if there is anything else that I can provide that would be ...
-
- https://github.com/ruby/io-console/commit/ee648fa8bb
-
- https://github.com/ruby/io-console/commit/83e70de8ab
-
- https://github.com/ruby/io-console/commit/e6344108a1
-
- https://github.com/ruby/io-console/commit/143a9d5764
-
- https://github.com/ruby/io-console/commit/21d340e4a2
-
- https://github.com/ruby/io-console/commit/7f2b1b473d
-
- https://github.com/ruby/io-console/commit/41a6a6cace
-
- A function to query console info.
https://github.com/ruby/io-console/commit/db75a07fa3 -
- https://github.com/ruby/io-console/commit/972ceb081d
-
- Applied in changeset commit:git|00744a03d576f308d7fa586c2d04b5c1cb8fe3f4.
----------
Update documentation for Except... -
- Thanks, I'll merge this shortly with some minor changes.
-
- Enhancements (in my view) to doc for class Exception.
The git diff for error.c is attached.
Affects doc only fo... -
- Mostly from [email protected] (Burdette Lamar).
Implements [Misc #16156] -
09:40 PM Misc #16152: DevelopersMeeting20190919Japan
- * [Misc #16160] Lazy init thread local storage (methodmissing)
* Storage for Fiber local storage of execution cont... -
- * [Misc #16124] Let the transient heap belong to objspace (methodmissing)
* As per PR and outline of pros and cons... -
- * [Bug #16154] lib/delegate.rb issues keyword argument warnings
* `Module#pass_positional_hash` for disabling fals... -
- References PR https://github.com/ruby/ruby/pull/2295
### Why?
The `local_storage` member of execution context i... -
- This patch changes parse.y to only use `add_mark_object` in Ripper.
Previously we were seeing a bug in write barrier ... -
- This reverts commit 092f31e7e23c0ee04df987f0c0f979d036971804.
-
09:16 PM Feature #16155: Add an Array#intersection method
- connorshea (Connor Shea) wrote:
>
> Should we keep `intersection` as a simple alias for `&` or have it allow multi... -
07:10 PM Feature #16155: Add an Array#intersection method
- shevegen (Robert A. Heiler) wrote:
> You could consider adding this to the upcoming developer meeting:
>
> https:... -
- I sort of agree with your reasoning. A slight add-on, though,
on that part:
> This would essentially just be a mo... -
- `Array#union` and `Array#difference` were added in Ruby 2.6 ([see this bug](https://bugs.ruby-lang.org/issues/14097))...
-
- Dan0042 (Daniel DeLorme) wrote:
> I've compiled your delegate-keyword-argument-separation branch to test this. BTW i... -
- I've compiled your delegate-keyword-argument-separation branch to test this. BTW in your example it should be `respon...
-
- I haven't tested this, but I think it should work the same between 2.0 - 3.0 (assuming #16154 is accepted):
```rub... -
- With the keyword argument changes in 2.7 we must now specify keyword arguments explicitly when doing generic delegati...
-
- Ran it 3 times and oddly enough they all fail at `Expected 1932 to equal 1933`
-
- Steps to reproduce:
1. Check out current master from Github (89c5d5a64e12cea23b230913b79c3d499bf30b12)
2. Run `au... -
05:16 PM Bug #12984: `rescue *[]` should be equivalent to `rescue` as `method_call(*[])` is equivalent to `method_call`
- > I think it's is less surprising than rescue *no_classes to "magically" rescue StandardError
It is the current b... -
05:12 PM Feature #16146: Array .difference allow custom comparison
- As recommended I'll place in example directly here:
The feature I am requesting is to allow custom comparison of t... - 03:57 PM Revision 9b53a69d (git): * 2019-09-10 [ci skip]
-
-
-
-
- This is an issue for *all* delegation code. This `pass_positional_hash` workaround is ok for the stdlib, but what abo...
-
- In the current master branch, `lib/delegate.rb` (e.g. `Delegator`/`SimpleDelegator`/`DelegateClass`) does not delegat...
-
- This is a test extension so we basically want test failures rather
than a configure breakage but if there is no C++ c... -
- Not the case of recent compilers, but compilers before C++11
rejected ruby.h, like https://ci.appveyor.com/project/ru... -
- These variables then get their room for storage.
See also https://github.com/ruby/ruby/runs/214042030 -
-
- This reverts commit 53d21087da078cf999cc4757b03b2ff0fab4c2cf.
-
- This reverts commit 6382f5cc91ac9e36776bc854632d9a1237250da7.
test failed on Solaris. -
- Calling some syscall functions such as Dir.chroot causes SIGSYS instead
of EPERM on Android.
This change skips all te... -
-
- Thx.
However, I wonder if there is some explanation for disabling the test. I see a lot of comments such as `# The... -
10:16 AM Revision 551edf64 (git): Reline: Fix wrong variable name
- This raised a NameError before.
-
-
- change service name to fix failed test on Solaris
-
- committed in 6382f5cc91ac9e36776bc854632d9a1237250da7
-
-
- This removes an invalid keyword argument separation warning for
code such as:
```ruby
def foo(arg)
arg
end
kw = {}... -
- Addrinfo.getaddrinfo and .foreach now accepts :timeout in seconds as
a keyword argument. If getaddrinfo_a(3) is avail... -
- > So, let's make Symbol#to_s frozen?
> I think in general it makes a lot of sense that immutable classes return a fr... -
- Freezing strings can give us a nice performance boost, but freezing previously non-frozen strings is a backward-incom...
-
01:12 AM Bug #16136: String corruption in 2.6.4
- Our blog system was fixed at commit:ade1283ca276f7d589ffd3539fbc7b9817f682d5
-
- Can you file this to https://github.com/ruby/bugs.ruby-lang.org/issues?
Our tracker only handles the language issues.
09/08/2019
-
- That general approach sounds good to me, but please let me mention some caveats.
```diff
@@ -1308,8 +1310,6 @@ st... -
- Probably, `STR_IS_SHARED_M` string must not get its buffer replaced.
And I don't think that memory leaks, resulted b... -
- My reading is that `STR_NOFREE` exists solely for strings that point to C string literals. It exists to prevent `free...
-
- In addition to `STR_NOFREE` , there are more two things that I cannot understand about string representation.
* Wh... -
- Hi @alanwu , thank you for taking time to this issue.
I may be wrong, but I think that the code path you pointed i... -
- ashmaroli (Ashwin Maroli) wrote:
> Similar to `Symbol#to_s`, even `nil.to_s` allocates a new string.
Right, as me... -
- For methods that convert object to a string, we already have three:
* `to_s`
* `to_str`
* `inspect`
Adding ye... -
10:10 AM Feature #16150: Add a way to request a frozen string from to_s
- Similar to `Symbol#to_s`, even `nil.to_s` allocates a new string.
``` shell
irb(main):001:0> 5.times { p nil.to_s._... -
- PR at https://github.com/ruby/ruby/pull/2437
-
- I also tried this version which always returns the same String for a given Symbol:
```diff
diff --git a/string.c ... -
- How about specifically making Symbol#to_s return a frozen String?
I tried this trivial patch:
```diff
diff --git... -
- > For example, String#to_s returns itself and mutating sth.to_s is therefore not safe if sth can be a String.
`Str... -
02:19 AM Feature #16150: Add a way to request a frozen string from to_s
- > For example, String#to_s returns itself and mutating sth.to_s is therefore not safe if sth can be a String.
This... -
- * [Feature #16150] Add a way to request a frozen string from to_s
* Can I commit https://github.com/ruby/ruby/pull... -
- * [Bug #12984] `rescue *[]` should be equivalent to `rescue` as `method_call(*[])` is equivalent to `method_call`
... -
- Please comment on your favorite ticket numbers you want to ask to discuss with your *SHORT* comment or summary.
(you... -
- No code changes are necessary, but we didn't have as extensive
tests for these calls previously. - 03:27 PM Revision d636feb6 (git): * 2019-09-09 [ci skip]
-
- And test-rubyspec is deprecated.
-
-
-
-
Also available in: Atom