Activity
From 09/16/2019 to 09/22/2019
09/22/2019
-
10:21 PM Feature #16168: Add keyword argument separation to C functions using rb_scan_args
- At the last developer meeting, matz requested that instead of "k", "e", and "n" modifiers to `rb_scan_args`, a new `r...
-
06:40 PM Bug #16173: ENV.delete returns nil when name does not exist and block given
- IMHO it's better to fix behavior to be consistent with Hash#delete.
And the compatibility risk seems non existent he... -
06:29 PM Feature #16119: Optimize Array#flatten and flatten! for already flattened arrays
- nobu (Nobuyoshi Nakada) wrote:
> This patch unrolls the `while`-loop for the already flatten head and seems reasonab... -
05:21 PM Revision 142efba9 (git): Adjusted directives order of a function [ci skip]
-
-
- vo.x (Vit Ondruch) wrote:
> However, I wonder if there is some explanation for disabling the test. I see a lot of co... -
- Just my opinion: I don't think we should have list comprehensions in Ruby.
They are just a small subset of the far... -
- sammomichael (Samuel Michael) wrote:
> ```ruby
> [for x in 1..10 do x**2 if x.even? end] #=> 1..10 (normal Ruby)
... -
04:38 PM Bug #14716: SecureRandom throwing an error in Ruby 2.5.1
- I am encountering this in a project as well. In my case, I see this while running rspec regression tests:
```
#<A... -
- 04:04 PM Revision 2afe86e4 (git): * 2019-09-23 [ci skip]
-
03:55 PM Revision d8221a54 (git): Add `-mtc=off` to `7z` not to store NTFS timestamps
- https://sevenzip.osdn.jp/chm/cmdline/switches/method.htm
-
- nobu (Nobuyoshi Nakada) wrote:
> I'm positive about this, except for the performance.
> Do you have any numbers?
... -
- It disables 7z, which seems not to have an option to stop saving
extra file attributes (uid/gid and atime), in order ... -
- Extra file attributes (uid/gid and atime) make the packaged zip
file unstable. -
01:12 PM Revision 5f35b8ca (git): st.c: Use rb_st_* prefix instead of st_* (#2479)
- The original st.c was public domain hash table implementation, but
Ruby's st.c is highly modified, and its data struc... -
- I agree with Jeremy. It is not a bug.
I think that the wording of `freeze: false` is a bit confusing, but the doc... -
09:59 AM Feature #16175: Object#clone(freeze: true) is inconsistent with Object#clone(freeze: false)
- @jeremyevans0 thanks for your answer.
Let me explain my point a bit.
I come upon this inconsistency (or what **... -
09:30 AM Feature #16175: Object#clone(freeze: true) is inconsistent with Object#clone(freeze: false)
- I sort of agree with zverok at the least for the expectation of freeze: true
working. IMO for boolean toggle-values ... -
-
- It was originally static inline, but seemed to be accidentally published
at 8f675cdd00e2c5b5a0f143f5e508dbbafdb20ccd. -
- This function was created as a variant of st_copy with firing write
barrier.
It should have more explicit name, such ... -
- instead of deprecated BigDecimal.new.
-
- nobu (Nobuyoshi Nakada) wrote:
> I'm positive about this, except for the performance.
> Do you have any numbers?
... -
- `check-snapshot-ruby_2_4` uses `make test` instead of `make check`.
https://github.com/ruby/actions/blob/95692e54f426...
09/21/2019
-
11:24 PM Bug #16174: Feature #15958 triggers Rails unit test failure
- Thanks for the fix. https://github.com/rails/rails/pull/37262 has been merged to master, I think this issue can be cl...
-
- https://github.com/rails/rails/pull/37262
-
- This Rails unit test compares the output of Time using pp.
pp Time class object also changed to show subseconds.
... -
- Let me inform one of Rails Active Record unit test get failed since https://bugs.ruby-lang.org/issues/15958
I prefer... - 11:10 PM Revision c020fd6a (git): * 2019-09-22 [ci skip]
-
11:10 PM Bug #7522 (Closed): Non-core "Type()" Kernel methods return new objects
- Applied in changeset commit:git|2e551356a7a6e74ba07283e000ff16f5d1ea6506.
----------
Make Kernel#{Pathname,BigDecima... -
- Applied in changeset commit:git|7470f965650bf17875632f0c5f9e5a4d9de9fc3f.
----------
Fix Module#class_variables for ... -
- This is how Kernel#{Array,String,Float,Integer,Hash,Rational} work.
BigDecimal and Complex instances are always froze... -
- Module#class_variables should reflect class variable lookup. For
singleton classes of classes/modules, this means the... -
09:46 PM Feature #16147: List Comprehensions in Ruby
- In reiteration of my main points, Ruby is a dynamic multi-paradigm language which should when possible embrace a vari...
-
- An interesting bit here is that there is no way to get back the module from which the method was retrieved, even thou...
-
- `nil` does not respond to `to_hash` though, how do you propose to deal with that?
Should `**` call `to_h` rather t... -
- I worked on an alternative approach of using `ruby2_keywords` with a hash flag approach instead of a VM frame flag ap...
-
- The `freeze: false` option was intended to be: "do not freeze clone if receiver is already frozen". The `Object#clone...
-
- In #12300, the new keyword `freeze:` was introduced, allowing this:
```ruby
h = {}.freeze
h.clone.frozen?
# => ... -
- I'm still against frozen-string-literal by default. It is arguable if the string creation limits performance so much...
-
05:11 PM Bug #16173: ENV.delete returns nil when name does not exist and block given
- Thanks, @alanwu. I'm refreshing diff.txt with more fulsome documentation, along with enhanced testing.
-
- Thanks, @nobu, but I'm not going to propose a change to the functionality.
-
- Comparing with `Hash#delete`, it looks that the document is correct and the code is wrong.
```diff
diff --git i/h... -
- Matz didn't determine this proposal at the meeting. There were four points discussed:
* Before matz accepts this ... -
- Hmm. I can somewhat understand the proposal, but I believe you would also
add a bit more complexity here; you need t... -
- to suppress variable unused warning
-
- I published the Log. Closing.
-
- I've added a pull request that adds warnings to setting/access of $SAFE, as well as public C function that deal with ...
-
07:09 AM Revision b4149993 (git): Add a benchmark for JIT-ed code dispatch
-
04:24 AM Revision e006b992 (git): typedef rb_jmpbuf_t to void *[5] if __builtin_setjmp is used
- The built-in version operates on a buffer of 5 words, much smaller than
the size of jmp_buf defined in libc.
Note, po...
09/20/2019
-
11:10 PM Bug #16173: ENV.delete returns nil when name does not exist and block given
- This gives the impression that the return value is always nil, which isn't true when the environment variable exists....
-
- Attached diff.txt:
* ENV.delete for nonexistent name and block given:
* Test enhanced to verify return value is... -
- Applied in changeset commit:git|27144de2bd95c5886c3d4400c3b8aea932b856f1.
----------
Fix documentation for ENV.each ... -
- I'm attaching a diff that:
* Enhances the test to verify the returned object, which is ENV.
* Corrects the docume... -
- Also have spec check that it returns ENV.
Mostly from [email protected] (Burdette Lamar).
Fixes [Bug #16164] -
- Inadvertently merged change to suppress warnings by gcc 9.2.
Pointed out by Alan Wu. -
- Can you please post or upload the error output from the failure with Ruby 2.6.3 and no AMD Kysy installed? Also, if ...
-
04:25 PM Bug #16135: Segmentation fault in Ruby 2.6.1
- I have tested in a clean machine with no Kysy ,but it failed there too.
-
- I already tried with Ruby 2.6.3 too and faced same issue .
- 03:48 PM Revision 990e714f (git): * 2019-09-21 [ci skip]
-
-
- Use PRIdPTRDIFF for the platforms where a pointer is larger than a long.
-
- rb_vm_call_kw handles the tmp buffer for you.
Also, change method_missing so it also calls rb_vm_call_kw to
handle t... -
- When Object#to_enum is passed a block, the block is called to get
a size with the arguments given to to_enum. This c... -
- If defined in Ruby, dig would be defined as def dig(arg, *rest) end,
it would not use keywords. If the last dig argu... -
-
- `iseq->body->jit_unit->compile_info` should not be referenced before
the null check of `iseq->body->jit_unit`. -
- in vm_push_frame and limit scope of i.
Just a minor maintainability improvement. -
11:32 AM Feature #16153: eventually_frozen flag to gradually phase-in frozen strings
- Dan0042 (Daniel DeLorme) wrote:
> The naming is a bit wonky, I'll freely admit. I'll change the description to your ... -
-
-
- for debug counters
```
../include/ruby/intern.h:1175:137: warning: passing argument 3 of 'rb_define_singleton_method... -
08:35 AM Bug #16121: Stop making a redundant hash copy in Hash#dup
- I found that
> ` rb_define_method(rb_cArray, "initialize_copy", rb_ary_replace, 1);`
`Array#initialize_copy`... -
- Thank you. Completely fine.
Do you want to merge via github PR or attached patch by my commit? -
08:12 AM Feature #16170: Remove the unmaintained libraries from Ruby 2.7
- Just FTR, I am using tracer from time to time, typically just from command line as `-rtracer`. I'll be sad to see it ...
-
- NMAKE sets MAKE to the full path name, which includes spaces by
the default installation. -
- * Removed excess backslashes
* Fixed the target name to try failure.cpp -
- [Feature #11297] [Feature #16123]
-
- I wanted to briefly add that I think C++ support or have it as a "first class citizen"
could be great - even though ... -
02:25 AM Misc #16172 (Closed): C++ situation?
- We discussed this topic at the developer meeting held yesterday.
The attendees' mood was that we would like to say... -
- The idea is very interesting to me, purely from a conceptual point of view
alone. So from this point of view, I like... -
05:22 AM Revision 1de242de (git): Fixed up 37c083942509dd7e0d8b7ccd3575936a2017c400
-
-
-
-
-
-
- Can someone update the "Log" link above?
-
02:10 AM Feature #15381: Let double splat call `to_h` implicitly
- I came here to file this feature request, only to find this had already been proposed. This would be beautiful, indee...
-
- * array.c (flatten): fix a memory leak in the case of an exception
at conversion of an element to Array. -
-
-
- This patch unrolls the `while`-loop for the already flatten head and seems reasonable.
But I could get only insignif...
09/19/2019
-
- @mame
I think that class is used frequently, though I'm not sure if Rails tries to deduplicate instances with fstr... -
06:46 PM Feature #16153: eventually_frozen flag to gradually phase-in frozen strings
- The naming is a bit wonky, I'll freely admit. I'll change the description to your suggestion.
Does this mean you a... -
- `freeze(eventual: false)` gives the impression that it will never be frozen, but the proposal is to have this mean th...
-
06:25 PM Feature #11297 (Closed): Allow private method of self to be called
- Applied in changeset commit:git|7fbd2f7cc247ee66e877ab3c88f0274834c6b6c7.
----------
Allow calling a private method ... -
- Applied in changeset commit:git|7fbd2f7cc247ee66e877ab3c88f0274834c6b6c7.
----------
Allow calling a private method ... -
08:17 AM Feature #16123: Allow calling a private method with `self.`
- Accepted. But as I said in #11297, the document should be updated. After the patch, you can say `self.puts("hello")`,...
-
- [Feature #11297] [Feature #16123]
-
- [Feature #11297] [Feature #16123]
-
- [Feature #11297] [Feature #16123]
- 05:20 PM Revision 7fbd2f7c (git): Allow calling a private method with `self.`
- This makes it consistent with calling private attribute assignment
methods, which currently is allowed (e.g. `self.va... -
- Define overloading functions of rb_define_virtual_variable and
rb_define_hooked_variable, for combinations with and w... -
- By using template and overloading, instead of transparent union.
-
- At the dev meeting yesterday, matz recommended changing the method name from `pass_keywords` to `ruby2_keywords`. I ...
- 03:20 PM Revision 5e3771aa (git): * 2019-09-20 [ci skip]
-
- > `Time.now.floor(step: 3600)` doesn't work well with leap seconds.
```ruby
n = (Time.now.to_i / 86400).floor * 8... -
- As @akr stated, `round` etc.for `Time` class do not work well (rejected).
For float values, we could suffer from err... -
09:22 AM Feature #16021: floor/ceil/round/truncate should accept a :step argument
- `Time.now.floor(step: 3600)` doesn't work well with leap seconds.
Also, we want floor/round/ceil for month and yea... -
-
-
-
01:26 PM Feature #16131: Remove $SAFE, taint and trust
- I look forward to removing all tainting logic!
-
- Basically agreed.
My proposal for the schedule:
2.7:
* Remove taint tracking/mechanism.
* Non-verbose war... -
- To substitute suffixes and VPATH for nmake.
-
-
- This reverts commit 69e209a3450bd6b281dcad1d96a34e9cab184845.
The debug has finishted. -
11:45 AM Revision cbf405fe (git): Specify encoding explicitly for sprintf
-
- Applied in changeset commit:git|5208c431bef3240eb251f5da23723b324431a98e.
----------
Separate Time#inspect from to_s... -
-
-
-
- to fix another keyword argument warning which was added recently.
-
08:35 AM Feature #16163 (Closed): Reduce the output of `RubyVM::InstructionSequence#to_binary`
- Applied in changeset commit:git|20baa08d652b844806fab424a2a590408ab613ef.
----------
Improve the output of `RubyVM::... -
- The output of RubyVM::InstructionSequence#to_binary is extremely large.
We have reduced the output of #to_binary by m... -
- Accepted. PR welcome.
Matz. -
- @nobu Could you please review this?
-
-
- I'll review it.
-
-
08:07 AM Feature #15667: Introduce malloc_trim(0) in full gc cycles
- I'd just like to point out that calling malloc_trim(0) according to article explaining the feature - https://www.joyf...
-
- Accepted.
Matz.
-
- I'm positive about this, except for the performance.
Do you have any numbers? -
- I'm positive about this, except for the performance.
Do you have any numbers? -
- FYI: How many times the gems is required from all latest public gems by using [gem-codesearch](https://github.com/akr...
-
- >Can we remain it as bundled gem?
sounds good.
We are going to remove them at Ruby 2.7.0-preview2
* cmath
... -
- I'll maintain `debug`. Can we remain it as bundled gem?
-
- Can we also remove them?
* debug
* getoptlong
-
- For frozen `Symbol#to_s`, I see a clear benefit. But I worry a little bit for incompatibility.
So how about making a... -
- This bug should be fixed. @nobu could you review the patch?
Matz. -
- See also https://travis-ci.org/ruby/ruby/jobs/586452224
-
- I noticed that in case of cache misshit, re-calculated cc->me can
be the same method entry than the pevious one. Tha... -
05:56 AM Misc #16114: Naming of "beginless range"
- I hope this discussion leads to Ruby having Ranges congruent to all the mathematical intervals.
Today we have righ... -
- This `*[]` is not just exception list omitted, but explicitly specifies zero exceptions to catch.
Thus the current b... -
- We discussed about this in developer meeting.
This feature has some difficulty in spec for example padding, unknown ... -
- What's the use case of this comparison?
-
- > Is there a reason why the existing frozen-string-literal: false is not good enough?
My understanding of `frozen-... -
- Make draft release packages. (Release packages are official after tests and release announce.)
- Copy from ruby/acti... -
-
-
- rb_vm_call0 allocates its own struct call_info etc. But they are
already there in case of rb_funcallv_with_cc. Let'... -
-
-
- [Misc #16172] C++ situation?
- What do we do with C++ extensions? -
- (This issue is MRI specific)
Few weeks ago I pushed a minimalist C++ compatibility layer to the master branch. Th... -
-
-
- https://ruby-doc.org/ is not our resource. Please contact admin of ruby-doc.org
09/18/2019
-
-
- @alanwu
Indeed, it makes sense. Thank you.
I am not familiar with Rails at all so I could be wrong, but I hear... -
- @mame
Thanks for pointing that out. I should clarify what I meant there. In a world where strings don't track tain... -
- @alanwu
Just FYI: You said in https://bugs.ruby-lang.org/issues/16152#note-8
> * What do you think about the pr... -
- Replace [arg=1, args] with [arg, args] so we can actually test
the value correctly.
Add some missing tests for **h3 ... -
- Documentation for PP is in https://ruby-doc.org/stdlib-2.4.6/ but it's no longer in https://ruby-doc.org/stdlib-2.5.6...
- 03:11 PM Revision 2b708ab7 (git): * 2019-09-19 [ci skip]
-
- Look up language module with `MakeMakefile.[]`, insted of a
accessing constant under that module directly, to get rid... -
-
- * [Feature #16120] Omitted block argument if block starts with dot-method call
* `posts.map{ .author.name }` has ... -
- [Feature #16170] Remove the unmaintained libraries from Ruby 2.7
* Is it ok to remove them? -
- It is exposed to the topleven namespace via included MakeMakefile.
-
-
-
- Agreed. Might also be simpler to get full support in gem-spec format
for those libraries that are maintained. :)
... -
- I'm working to extract standard libraries to rubygems in recent years. So, the standard libraries will be promoted th...
-
- > And I have a path forward that would easily address any breakage: we add a `mutable-string-literal` pragma.
I do... -
- > This depends on the ruby code. Some projects will be semi-dormant due to various reasons.
That's for us to addre... -
- @mame
> Ruby allows to omit parentheses of method calls
Oh, thanks! In fact, that was the piece of understandin... -
- Isn't it there? http://rubies.travis-ci.org/
-
-
-
-
-
09:26 AM Revision effacde2 (git): [bundler/bundler] Merge all `bundle check --path` specs
- And skip them all for bundler 3.
https://github.com/bundler/bundler/commit/b88936cdc2 - 09:26 AM Revision 434af730 (git): [bundler/bundler] Merge #7340
- 7340: Fix bundle clean issue r=deivid-rodriguez a=deivid-rodriguez
### What was the end-user problem that led to thi... -
- It was suggested a deprecated command as a fix.
https://github.com/bundler/bundler/commit/e330a9a34f -
- https://github.com/bundler/bundler/commit/6e9774b377
-
09:26 AM Revision 4f2f6aeb (git): [bundler/bundler] Add a spec for installing git deps after packaging w/o git
- https://github.com/bundler/bundler/commit/65351c58b8
-
- This reverts commit 3dc509e645abb497e4dc92a7c42be471ff87db0b.
https://github.com/bundler/bundler/commit/b5766564fb -
- This reverts commit 00b095b98fe4bd44950beaf3bc9f1d91eac7b69e.
https://github.com/bundler/bundler/commit/e93bce3b20 -
- This reverts commit 52c5a0eedec34b5d86464b3cf135dc2002486f1d.
https://github.com/bundler/bundler/commit/b4cc36deb9 -
- This reverts commit 3a2d2f025081755bdb38af660897e7b2f749a33a.
https://github.com/bundler/bundler/commit/13cef81582 - 09:26 AM Revision c27aaf1a (git): [bundler/bundler] Fix comments and messages to refer to https url
- https://github.com/bundler/bundler/commit/a86b49f1b9
-
- https://github.com/bundler/bundler/commit/b7fc6f4187
-
- To not mention that the flag is remembered when it's not.
https://github.com/bundler/bundler/commit/82f0b95854 -
- https://github.com/bundler/bundler/commit/0a0e7cf5ec
-
08:29 AM Revision 9118cb24 (git): Fix typos
-
- Why do you use private attr_accessor? You can access its instance variable directly.
Allowing `self.private_metho... -
09/17/2019
-
- I agree that Ruby syntax is very subtle. Ruby's parser is a unspeakable monolith of compromise between human intuiti...
-
- mame explained that the behaviour is correct (in the context).
Perhaps the documentation could explain that, becau... -
- This is the same thing as #16092, where I submitted a documentation patch a little while ago.
-
- At 2.4, #12686 was introduced, allowing code like this:
```ruby
foo (Integer(ENV['FOO']) rescue nil)
```
Thou... - 11:23 PM Revision c170e23d (git): * 2019-09-18 [ci skip]
-
- Make sure that vm_yield_with_cfunc can correctly set the empty keyword
flag by passing 2 as the kw_splat value when c... -
- This makes method_missing take a flag for whether keyword arguments
were passed.
Adds tests both for rb_call_super_k... -
- > I suspect that the vast majority of Ruby code out there would work out of the box or
> require only minor changes ... -
- I regret missing this "final" decision, but I believe we should reconsider.
> I am sure introducing this could cau... -
- Some more information: The onigmo documentation says (https://github.com/k-takata/Onigmo/blob/master/doc/RE#L270):
`... -
- I've had a hunch, and have now been able to confirm this hunch:
The problem must be related to the fact that there... -
- https://github.com/ruby/ruby/runs/224877570#step:3:1008
```
Error: No such file or directory @ dir_s_rmdir - /Users/r... -
- Enable `Ctrl+Y`, which is bound with it by default on BSD-like
systems, for editing. - 06:15 AM Revision b49c1380 (git): * 2019-09-17 [ci skip]
- 06:14 AM Revision f9332ad8 (git): Fix previous history in vi_insert mode
- 06:14 AM Revision a3533bc9 (git): Fix history navigation in vi_insert mode
09/16/2019
-
- 12:37 PM Revision 2a39de19 (git): * 2019-09-16 [ci skip]
-
-
12:20 PM Feature #7639: More freedom for location of comments
- It looks like this feature has been realized by https://bugs.ruby-lang.org/projects/ruby-trunk/repository/git/revisio...
Also available in: Atom