Activity
From 06/22/2020 to 06/28/2020
06/28/2020
-
07:07 PM Bug #16510: irb crashes when hitting 'Home' or 'End' keys
- I noticed this issue when I connect to my Ubuntu 20.04 server and I press Home or End in the Rails console. This is a...
-
05:14 AM Revision 09b936d8 (git): Calculate header line count instead of hardcoding
-
-
- To suppress warnings by Visual C.
```
./integer.rb(5) : warning C4129: 'i' : unrecognized character escape sequence
.... -
- Define `Fiddle::TYPE_VARIADIC` only when `ffi_prep_cif_var` is
available, otherwise skip the test for it.
06/27/2020
-
09:26 PM Bug #16997 (Open): IO#gets converts some \r\n to \n with universal_newline: false
- Reproduction code:
```
IO.binwrite "t.csv", ("a" * 100 + "\r\n") * 100
File.open("t.csv", encoding: "BOM|UTF-8",... -
07:12 PM Feature #16984: Remove write barrier exemption for T_ICLASS
- Thank you for great work. This kind of hack can cause BUGs easily.
> Private app A's heap size is about 22 MiB com... -
06:31 PM Feature #16986: Anonymous Struct literal
- First of all, this is super cool idea!
I do have habit to use hash since it is seems to be elegant (as described i... -
- Other syntax ideas, by others:
* Other prefixes
* `::{a: 1}`
* `\{a: 1}`
* `<>` to indicate
* `{<> a:1}` for a... -
- # Q&A
## Splat like Hash literal and method arguments
https://bugs.ruby-lang.org/issues/16986#note-3
> I was wonder... -
02:28 PM Feature #16986: Anonymous Struct literal
- I like the idea of being able to quickly create an anonymous Struct but am concerned about the use of `$` for the syn...
-
12:37 PM Feature #16986: Anonymous Struct literal
- `struct = (a: 1, b: 2)` would be a great syntax, because I think anonymous struct is something like Tuple of Python.
... -
05:07 PM Revision 0703e014 (git): Mark some Integer methods as inline (#3264)
- 05:03 PM Revision 247dd874 (git): * 2020-06-28 [ci skip]
-
04:37 PM Bug #16996: Hash should avoid doing unnecessary rehash
- Dan0042 (Daniel DeLorme) wrote in #note-2:
> Shouldn't the rehash be tied to a change in the number of buckets rathe... -
04:00 PM Bug #16996: Hash should avoid doing unnecessary rehash
- Very surprising results for `Hash#dup`. I even tried `h.rehash` before the benchmark, with no effect.
Shouldn't th... -
11:48 AM Bug #16996: Hash should avoid doing unnecessary rehash
- Completely agreed, `Hash#dup` should not rehash (and it already doesn't on TruffleRuby).
-
- Pop quiz: Which is the fastest way to get a copy of a Hash `h`?
If, like me, you thought `h.dup` (of course, right... -
- If no installed libffi found, use bundled libffi unless explicitly
`--disable-bundled-libffi` option is given. - 02:54 PM Revision f2bcdc72 (git): [ruby/fiddle] Support MSWIN (#43)
- https://github.com/ruby/fiddle/commit/f16e7ff6e0
- 02:54 PM Revision a40b390b (git): [ruby/fiddle] test windows: use _snprintf
- https://github.com/ruby/fiddle/commit/aa261bdb9f
- 02:54 PM Revision 6429b6d9 (git): [ruby/fiddle] Add missing include
- https://github.com/ruby/fiddle/commit/4ca61efcd7
- 02:54 PM Revision ae18220f (git): [ruby/fiddle] Add support for variadic arguments
- GitHub: fix GH-39
Reported by kojix2. Thanks!!!
https://github.com/ruby/fiddle/commit/6c4cb904dc - 02:54 PM Revision 9f740aca (git): [ruby/fiddle] Use meaningful variable name
- https://github.com/ruby/fiddle/commit/2cac24b7c8
- 02:54 PM Revision 50fbd00e (git): [ruby/fiddle] Use "do { } while (0)" to ensure requiring ";"
- https://github.com/ruby/fiddle/commit/2155ae5979
-
-
-
-
-
09:14 AM Feature #16812: Allow slicing arrays with ArithmeticSequence
- > But a negative start with a non-negative end is quite weird. What is that operation even supposed to mean? What is ...
-
- sawa (Tsuyoshi Sawada) wrote in #note-2:
> Would
>
> ```ruby
> Set.new(h.each_key)
> ```
>
> not work?
It... -
01:55 AM Feature #16993: Sets: from hash keys using Hash#key_set
- Would
```ruby
Set.new(h.each_key)
```
not work? -
- This reverts commit 5c03e4680e724faeedb2c5fc1581d5fcb66aaff2.
I gave up stabilizing Rinda::TupleSpaceProxyTest#test_... -
04:53 AM Revision 600f3990 (git): Cosmetic change
-
-
04:51 AM Revision c9ee34a1 (git): Add #deconstruct cache to find pattern
-
-
-
03:29 AM Bug #16979: FileUtils#cp_r with preserve, lchmod fails with ENOTSUPP
- ruby_2_7 799c5766a4dc215d139d2c26ac68636f43a64fbf merged revision(s) a19228f878d955eaf2cce086bcf53f46fdf894b9.
-
- Closed to backport.
-
- brace the fact that lchmod(2) can EOPNOTSUPP
Musl libc has this function as a tiny wrapper of fchmodat(3posi... -
- ruby_2_7 d8a32b146561a0ddd3e60da9863a082b7e7725db merged revision(s) 263b941321c3de6afc8f9dafbc2625f866b7437e.
-
- [ripper] fix mismatched indentations warning [Bug #16981]
The scanner location has to be set from `lex.ptok`... -
-
- I don’t this is an implementation bug, but a documentation issue.
- 01:55 AM Revision d6c9c014 (git): * 2020-06-27 [ci skip]
-
-
- Moved this hack mark to an argument to `compile_hash`.
> Bad Hack: temporarily mark hash node with flag so
> compile_...
06/26/2020
-
- This is quite minor, but `Set#<=>` should be refined.
Reminder: `Set` defines `<`, `>`, etc. as inclusion, but doe... -
- I would like a shorthand syntax for *frozen Sets of symbols or of strings*.
I am thinking of:
```ruby
%ws{hell... -
- To create a set from hash keys currently implies a temporary array for all keys, rehashing all those keys and rebuild...
-
- Officially, set elements have uncertain order. This predades when Hash started being ordered (Ruby 1.9.0, Xmas 2007)....
-
- I'd like to add `#join` to `Set`:
```ruby
# Now:
Set[1, 2, 3].join('x') # => NoMethodError
# After
Set[1, 2, 3... -
- We currently have `set <operator> array` work fine:
```ruby
Set[1] + [2] # => Set[1, 2]
```
Nothing works in ... -
- I am opening a series of feature requests on `Set`, all of them based on this usecase.
The main usecase I have in ... -
- mrkn (Kenta Murata) wrote in #note-7:
> It may be better to change the behavior of `[*0..10][-100..100]`
I somewh... -
06:08 PM Bug #16988 (Closed): Kernel.load loads file from current directory without '.' in path
- Ruby allows to load files using ```Kernel.load``` without explicitly specifying the relative path with ```.``` I'm no...
-
- Thinking a bit more about it, I see more of a conceptual problem.
Introducing new literal in a language, we kinda... -
11:15 AM Feature #16986: Anonymous Struct literal
- > Or yeah just a simple Struct() or Struct[] with no additional syntax as suggested just above.
Actually I just re... -
- > Matz said he thought about {|a: 1, b: 2 |} syntax.
Might be just me but `{|` on first sight makes me think: this... -
- Another (unrelated, but conflicting) matter: I am not sure we have/had a discussion for this, but I remember Bozhidar...
-
- WDYT about half-solution (without syntax change)?
E.g. for me, the problem with `Struct.new(:a, :b).new(1, 2)` is n... -
10:09 AM Feature #16986: Anonymous Struct literal
- hi, I like this idea :)
I was wondering if `${}` can do the following things compared to Hash literals:
```ruby
... -
09:36 AM Feature #16986: Anonymous Struct literal
- First, I like the idea, so +1 for the idea. It also reminds me of
a more "prototypic-based approach" in general with ... -
- # Abstract
How about introducing anonymous Struct literal such as `${a: 1, b: 2}`?
It is almost the same as `Stru... -
- Since it's an error in 3.0, shouldn't it be made a non-verbose warning in 2.7?
-
- sam.saffron (Sam Saffron) wrote in #note-28:
> If we keep `foo(a: 1)` working a developer may get confused (despite ... -
- Enumerations are designed to be greedy (immediately executed on each method call within a chain) by default. Sometime...
-
- That's interesting...
My understanding was that the "find" and "load" operations were supposed to be orthogonal, so... -
- To add an "opinion perspective"... I, for one, even if not fascinated but at least intrigued by new syntax.
My rea... -
- I don't have any big preference, but I tend to agree with sawa too.
When I first read the proposal, I was confused i... -
07:58 AM Feature #16985: Improve `pp` for `Hash` and `String`
- I wish the hashrocket stays and the syntax is consistent without exceptions for symbol.
-
- shyouhei (Shyouhei Urabe) wrote in #note-4:
> There are lots of debatable points on String#inspect (for instance its ... -
02:01 AM Feature #16985: Improve `pp` for `Hash` and `String`
- There are lots of debatable points on String#inspect (for instance its return value depends on runtime locale, why?)....
-
- For `String`, I meant to say that current format would be kept the same except if the single quote version exist and ...
-
-
- asked by ko1 to put this.
-
- and a related VM improvement.
JIT related commits:
* Code size reduction
* Deduplicate functions on JIT compactio... -
- https://github.com/ruby/fiddle/commit/a09e66adf4
https://github.com/ruby/fiddle/commit/6cab9b45d6
https://github.com/... -
- and add a debug log
-
- for opt_* insns.
opt_eq handles rb_obj_equal inside opt_eq, and all other cfunc is
handled by opt_send_without_block... -
- to make sure :opt_invokebuiltin_delegate_leave doesn't become
:(trace_)opt_invokebuiltin_delegate.
This is to preven... -
05:15 AM Revision a640bcee (git): test/ruby/test_settracefunc.rb: Suppress a warning
- http://rubyci.s3.amazonaws.com/ubuntu2004/ruby-master/log/20200626T033003Z.log.html.gz
```
/home/chkbuild/chkbuild/tm... -
- To prevent random failure with --jit-wait like
http://ci.rvm.jp/results/trunk-mjit-wait@silicon-docker/3026615 -
- If :return event is specified for a opt_invokebuiltin_delegate_leave
and leave combination, the instructions should b...
06/25/2020
-
- Eregon (Benoit Daloze) wrote in #note-23:
> Noteworthy is the current syntax in trunk is `def name(*args) = expr` (a... -
- Noteworthy is the current syntax in trunk is `def name(*args) = expr` (and not `def: name`), so there is *no* visual ...
-
- tldnr; I am against this proposal, it decreases readability, increases complexity and doesn't bring anything to the t...
-
- I think `symbol_key: value` would be nice in Hash#inspect, even if there are also non-Symbol keys.
I think changin... -
- Could we improve `pp` for `Hash` and `String`:
```ruby
pp({hello: 'My name is "Marc-André"'})
# =>
{hello: 'My ... -
06:23 PM Feature #16147: List Comprehensions in Ruby
- In my opinion, the more useful types of list comprehensions are when multiple inputs are needed.
The Ruby syntax in ... - 03:21 PM Revision 289a28e6 (git): * 2020-06-26 [ci skip]
- 03:21 PM Revision 2d89af45 (git): Add require to Delegator examples
- In Ruby 2.7.1 SimpeDelegator cannot be used without requiring `delegate` this PR adds the require to the first exampl...
-
- Digging a bit into this issue, I was wrong that this is just s390x.
~~~
for i in {1..10000}
do
echo "******... -
- While `spec/bundler` and `spec/bundler/` are treated different
targets by GNU make 4, the same target by GNU make 3. ... -
08:09 AM Feature #16897: General purpose memoizer in Ruby 3 with Ruby 2 performance
- Understood Jeremy, there are always compromises.
```
def bar(a:); end
def foo(*args); bar(*args); end;
```
... -
- As it is ignored and set at building packages automatically, it is
just nonsense to set in gemspec file for input. -
06:32 AM Revision 4eff8a66 (git): [flori/json] add metadata
- https://github.com/flori/json/commit/9f430a7bba
-
06:32 AM Revision 1b076ca3 (git): [flori/json] Gem::Specification#date is set automatically by RubyGems.org.
- https://github.com/flori/json/commit/1920653013
-
- https://github.com/flori/json/commit/78ec5e2bd3
-
- It's probably not worth it because there's nothing we can optimize in
such builtin methods. It's worth JIT only when ... -
- to prevent a random failure like
http://ci.rvm.jp/results/trunk-random2@phosphorus-docker/3024287 -
01:03 AM Feature #16984 (Closed): Remove write barrier exemption for T_ICLASS
- Currently, iclasses are "shady", or not protected by write
barriers. Because of that, the GC needs to spend more tim... -
12:01 AM Bug #16977: Ambiguous lookup super for refinements
- ssnickolay (Nikolay Sverchkov) wrote:
> [In specification](https://docs.ruby-lang.org/en/2.7.0/syntax/refinements_rd...
06/24/2020
-
06:31 PM Revision 5e860ed4 (git): [ci skip] Enhanced RDoc for Array (#3252)
- Methods:
map/collect
map!/collect!
values_at
select/filter
select!/filter! -
- Because it does not have closing `end`.
-
- 03:20 PM Revision 5dfe95d1 (git): * 2020-06-25 [ci skip]
-
-
-
- This was fixed in master:
https://github.com/ruby/ruby/commit/a18e81d797135de6e143a600e4f4d2b00ab23bf9
https://gi... -
12:34 PM Bug #16904: rubygems: psych: superclass mismatch for class Mark (TypeError)
- Is it possible to do backport the fixes to Ruby 2.7?
For Fedora Ruby, we applied the following 4 patches (merged p... -
12:57 PM Bug #16983 (Closed): RubyVM::AbstractSyntaxTree.of(method) returns meaningless node if the method is defined in eval
# Problem
`RubyVM::AST.of(method)` returns a meaningless node if the method is defined in eval.
For example:
...-
- I found two problems with `DelegateClass`.
The patch is available on GitHub. https://github.com/ruby/ruby/pull/3221
... -
- Applied in changeset commit:git|263b941321c3de6afc8f9dafbc2625f866b7437e.
----------
[ripper] fix mismatched indenta... -
- ```
$ ruby2.5 -v -rripper -e 'r = Ripper.new("begin\n end"); def r.warn(*e) p e; end; r.parse'
ruby 2.5.8p224 (202... -
- The scanner location has to be set from `lex.ptok` before it is
flushed by dispatching the scanner event. -
-
- A test worker process may already be enabling TracePoint, which results
in changing the insn name in this test.
http... -
-
-
-
- ```
$ benchmark-driver -v --rbenv 'before;after;before --jit;after --jit' benchmark/mjit_class.yml --repeat-count=4
b... -
- using opt_invokebuiltin_delegate_leave insn.
Since Ruby 2.7, :return of methods using builtin have not been traced p... - 06:18 AM Revision fbb32b1f (git): * 2020-06-24 [ci skip]
-
- RubyVM::AbstractSyntaxTree is a module actually, but the document says "class".
-
- I guess this is already fixed in changeset commit:a19228f878d955eaf2cce086bcf53f46fdf894b9
06/23/2020
-
- Ping.
This still happens and is annoying as it fails consistently in ruby/spec's CI (e.g., https://github.com/ruby/s... -
06:04 PM Misc #16980 (Closed): Improve documentation on JSON#parse and JSON#parse!
- Adds information about raised error when fails to parse on JSON#parse and JSON#parse!
-
03:49 PM Feature #16897: General purpose memoizer in Ruby 3 with Ruby 2 performance
- sam.saffron (Sam Saffron) wrote in #note-26:
> > In terms of usability, matz seems to like handling *args, **kwargs ... -
- > In terms of usability, matz seems to like handling *args, **kwargs because it is explicit and not so complex.
T... -
03:34 PM Bug #16979 (Closed): FileUtils#cp_r with preserve, lchmod fails with ENOTSUPP
Hello,
I encountered an issue copying a directory tree with symlinks with FileUtils#cp_r with preserve flag.
...-
- Methods:
#rotate!
#rotate
#sort!
#sort
#bsearch
#bsearch_index -
- I think even just doing the first one, "Positional Hash Argument to Keyword Argument Conversion", is only going to ma...
-
- This is the simplest test case:
~~~
$ mkdir a
$ echo "puts __FILE__" > a/test.rb
$ ln -s a b
$ ruby -Ib ... -
- only for opt_nil_p and opt_not.
While vm_method_cfunc_is is used for opt_eq too, many fast paths of it
don't call it... -
-
- https://github.com/ruby/psych/commit/4e7794fc2c
-
- https://github.com/ruby/psych/commit/68da645c7e
-
- https://github.com/ruby/psych/commit/39996192cc
-
- https://github.com/ruby/psych/commit/ef74fc01e2
-
-
- Interesting, I can reproduce the performance difference:
```
$ time ./miniruby -e '100000.times { Time.utc(2007, ... -
- and default jit-verbose to 1 if no argument.
-
-
06/22/2020
-
11:27 PM Revision e2d94f61 (git): Convert RMoved to a doubly linked list
- This commit converts RMoved slots to a doubly linked list. I want to
convert this to a doubly linked list because the... -
06:33 PM Bug #16977 (Closed): Ambiguous lookup super for refinements
- [In specification](https://docs.ruby-lang.org/en/2.7.0/syntax/refinements_rdoc.html) we have the note
> Note that ... -
- Eregon (Benoit Daloze) wrote in #note-9:
> One consideration here is performance.
> For instance `Time.at(Float)` i... -
- One consideration here is performance.
For instance `Time.at(Float)` is quite slow, due to going through Rational, e... -
- I've added an alternative approach, which uses Float#rationalize for all Float conversions in Time, except for Time.a...
-
-
- This was fixed earlier in commit:39a1959d289ecba5e61431deaef239123c3f0fcc. I don't consider it worth backporting.
-
- Thanks for the report! I'll fix the documentation shortly.
-
04:27 PM Bug #16976 (Closed): Documentation bug in Proc
- https://ruby-doc.org/core-2.7.0/Proc.html
About 1/3 of the way through the docs, it states:
Lambda semantics is... - 03:31 PM Revision 079ed74d (git): * 2020-06-23 [ci skip]
-
- Exclude linker flags for external libraries used by no longer
built extension libraries when static-linked-ext. -
- Thanks for the tip; all these years and I never realized `FileUtils.mkdir_p` had this `mode:` argument (and/or never ...
-
02:08 PM Bug #16973: Rails Active Support unit test fails since 41582d5866
- Opened a pull request at Rails https://github.com/rails/rails/pull/39697 Thank you for the useful information.
-
09:34 AM Revision 6adbdb56 (git): Fix Encoding::CompatibilityError in `FileUtils::Entry_#join`
-
-
-
09:13 AM Feature #16975: Warn when value from environment is being ignored by `Dir.tmpdir`
- @nobu You are totally right, I misread the code. What we would need is indeed to split the following conditions.
-
- I think it would be acceptable.
That "silent rescue" is actually for `File.stat` only, that is an obvious case.
I g... -
- because opt_nil/opt_not/opt_eq populates cc even when it doesn't
fallback to opt_send_without_block because of vm_met... -
- `path_info` contains filesystem encoding and binary.
Example is `"/webrick.cgi/%A5%DB%A4%B2/%A4%DB%A4%B2"` in `TestWE... -
-
-
-
-
-
- These days I don't use `make benchmark`. The YAML files should be
executable with bare `benchmark-driver` CLI without... -
- It failed again
http://ci.rvm.jp/results/trunk-mjit-wait@silicon-docker/3018488
Also available in: Atom