Project

General

Profile

Activity

From 07/21/2020 to 07/27/2020

07/27/2020

11:36 PM Feature #16345: Don't emit deprecation warnings by default.
I'm not sure if this is the right way.
I agree that a deprecation warning is annoying for end users. I also under...
mame (Yusuke Endoh)
09:02 PM Bug #17007: SystemStackError when using super inside Module included and lexically inside refinement
Eregon (Benoit Daloze) wrote in #note-4:
> Thanks for the fix!
> BTW this changes the behavior on a new spec, is th...
jeremyevans0 (Jeremy Evans)
07:30 PM Bug #17007: SystemStackError when using super inside Module included and lexically inside refinement
Thanks for the fix!
BTW this changes the behavior on a new spec, is that intended? (result is [:A, :C] instead of [:...
Eregon (Benoit Daloze)
03:18 PM Bug #17007 (Closed): SystemStackError when using super inside Module included and lexically inside refinement
Applied in changeset commit:git|eeef16e190cdabc2ba474622720f8e3df7bac43b.
----------
Prevent SystemStackError when c...
jeremyevans (Jeremy Evans)
08:14 PM Bug #12671 (Open): Hash#to_proc result is not a lambda, but enforces arity
Is there a reason why the arity was not fixed to `1` (instead of `-1`)? marcandre (Marc-Andre Lafortune)
07:41 PM Revision 126fd5f1 (git): Update to ruby/spec@07164da
Eregon (Benoit Daloze)
07:41 PM Revision 7429841a (git): Update to ruby/mspec@9cffee9
Eregon (Benoit Daloze)
07:40 PM Revision 35ba2783 (git): Use a linked list to eliminate imemo tmp bufs for managing local tables
This patch changes local table memory to be managed by a linked list
rather than via the garbage collector. It reduc...
tenderlovemaking (Aaron Patterson)
07:36 PM Misc #17053: RDoc for Hash Keys
Thanks, @marcandre. Your first update above makes things much clearer to me. I'll continue studying this. [email protected] (Burdette Lamar)
07:22 PM Misc #17053: RDoc for Hash Keys
[email protected] (Burdette Lamar) wrote:
> My view has been this: This is API reference documentation. Ruby...
marcandre (Marc-Andre Lafortune)
06:37 PM Misc #17053: RDoc for Hash Keys
Let me first repeat that I am very grateful of all efforts to improve our documentation.
Documentation can be diffic...
marcandre (Marc-Andre Lafortune)
05:55 PM Misc #17053: RDoc for Hash Keys
Should have linked to the source of the remarks: https://github.com/ruby/ruby/pull/3139#issuecomment-663281047 [email protected] (Burdette Lamar)
04:36 PM Misc #17053: RDoc for Hash Keys
Where is the source of the quote? Neither of the links seems to lead to it. sawa (Tsuyoshi Sawada)
03:42 PM Misc #17053 (Open): RDoc for Hash Keys
marcandre [comments](https://github.com/ruby/ruby/pull/3139#issuecomment-663281047) on my pull request regarding [doc... [email protected] (Burdette Lamar)
06:12 PM Feature #17054 (Open): Some NilClass methods are faster if implemented in Ruby
Sorry, looks like I misread. marcandre (Marc-Andre Lafortune)
05:59 PM Feature #17054 (Rejected): Some NilClass methods are faster if implemented in Ruby
marcandre (Marc-Andre Lafortune)
05:00 PM Feature #17054: Some NilClass methods are faster if implemented in Ruby
Patch was created.
https://github.com/ruby/ruby/pull/3366
S_H_ (Shun Hiraoka)
04:54 PM Feature #17054 (Closed): Some NilClass methods are faster if implemented in Ruby
Looking at these pull requests, I wondered "Is it faster to implement some NilClass methods in Ruby?"
* https://gi...
S_H_ (Shun Hiraoka)
03:18 PM Revision c5ae79d7 (git): * 2020-07-28 [ci skip]
git[bot]
03:18 PM Revision eeef16e1 (git): Prevent SystemStackError when calling super in module with activated refinement
Without this, if a refinement defines a method that calls super and
includes a module with a module that calls super ...
jeremyevans (Jeremy Evans)
03:16 PM Bug #17028 (Closed): On the latest OpenSSL adaptation
jeremyevans0 (Jeremy Evans)
03:02 PM Bug #17052: Ruby with LTO enabled has issues with SIGSEGV handler
Actually, the platform might not matter. It might fail just randomly, because now I have caught the same issue also o... vo.x (Vit Ondruch)
12:27 PM Bug #17052 (Closed): Ruby with LTO enabled has issues with SIGSEGV handler
Fedora aims to enable link time optimization (LTO) of packages in next release. The specific changes in configuration... vo.x (Vit Ondruch)
01:13 PM Bug #16492: TestBugReporter#test_bug_reporter_add test failures
After a lot of testing, I think that the test should not fail with the timeout, because the input for the asserts is ... vo.x (Vit Ondruch)
06:25 AM Revision cb512792 (git): * 2020-07-27 [ci skip]
git[bot]
06:24 AM Revision c4f8095e (git): Use typewriter notation for var[:sym] correctly
aycabta (aycabta .)

07/26/2020

10:34 PM Bug #17051 (Third Party's Issue): Crash when attempting to load schema in Rails application
duerst (Martin Dürst)
06:33 PM Bug #17051: Crash when attempting to load schema in Rails application
I have confirmed you are correct. After switching back to my original installation of mysql, all is good. [email protected] (Tom Hoen)
04:23 PM Bug #17048: Calling initialize_copy on live modules leads to crashes
nobu (Nobuyoshi Nakada) wrote in #note-10:
> Tried it.
> https://github.com/nobu/ruby/tree/uninitialized-module
...
Eregon (Benoit Daloze)
06:21 AM Bug #17048: Calling initialize_copy on live modules leads to crashes
Tried it.
https://github.com/nobu/ruby/tree/uninitialized-module
nobu (Nobuyoshi Nakada)
12:24 PM Revision a8e5f785 (git): * 2020-07-26 [ci skip]
git[bot]
12:24 PM Revision d210a397 (git): Fixed a typo
nobu (Nobuyoshi Nakada)
09:33 AM Bug #16498: Hash#transform_values in 2.7.0 sets new hash's default to old hash's default_proc
ruby_2_7 05c4c88767b54808cd1459a1d6da11179c422cfa merged revision(s) 1b4d406e3a04032b6d01e92b6d184a16945c6ac3. nagachika (Tomoyuki Chikanaga)
09:32 AM Bug #16914: Hash.new with `default_proc` returns this `default_proc` instead of calling it sometimes
ruby_2_7 05c4c88767b54808cd1459a1d6da11179c422cfa merged revision(s) 1b4d406e3a04032b6d01e92b6d184a16945c6ac3. nagachika (Tomoyuki Chikanaga)
09:32 AM Revision 05c4c887 (git): merge revision(s) 1b4d406e3a04032b6d01e92b6d184a16945c6ac3: [Backport #16498] [Backport #16914]
Hash#transform_values should return a plain new Hash
[Bug #16498]
nagachika (Tomoyuki Chikanaga)
09:11 AM Bug #16522: Ruby 2.7 logs deprecation warning when Warning[:deprecated] is set to false.
We are discussing on the deprecated warning category feature in 2.7.2 on #17000 too.
As these are keyword arguments ...
nagachika (Tomoyuki Chikanaga)
08:59 AM Bug #16801: The default Struct constructor improperly handle keyword arguments
ruby_2_7 61c6d433060881e952140d2154c06f8c9803dc8a. nagachika (Tomoyuki Chikanaga)
08:45 AM Revision 61c6d433 (git): partially merge revision adf709a78534c1483ba851ccb0490464ca31503c: [Backport #16801]
Classes made from Struct should have default new singleton method.
Co-authored-by: Yusuke Endoh mame@ruby-la...
nagachika (Tomoyuki Chikanaga)
07:19 AM Bug #16846: Commit - win32ole: separate global variable declarations and definitions - backport?
ruby_2_7 43cc6997c59d2fbe3b91e91ee52faaa8749e9349 merged revision(s) a0bc3f2a1c2c98f225612101cb4e1ea1a6813546,75a0447... nagachika (Tomoyuki Chikanaga)
07:19 AM Revision 43cc6997 (git): merge revision(s) a0bc3f2a1c2c98f225612101cb4e1ea1a6813546,75a0447c15a7ab017bd4240c2a9cc69b134b80b9,f1699314147bad2cf5550cc582693424fdbc2510: [Backport #16846]
Suppress C4267 "possible loss of data" warnings
Suppress C4267 "possible loss of data" warnings
Jus...
nagachika (Tomoyuki Chikanaga)

07/25/2020

11:27 PM Misc #17050: profiler gem
I was able to profile 200+ million* allocations with my fork which was impossible with the current implementations. R... ioquatix (Samuel Williams)
01:15 PM Misc #17050: profiler gem
@ioquatrix I’m curious. What’s the difference between your memory-profiler and the existing memory_profiler?
For c...
byroot (Jean Boussier)
01:12 PM Misc #17050: profiler gem
In the `profile` stdlib, both files are used: `-rprofile` starts the profiler immediately, while `profiler.rb` is lik... Eregon (Benoit Daloze)
11:10 AM Misc #17050: profiler gem
I agree all your points. I already have working `profiler-memory` to a certain extent. ioquatix (Samuel Williams)
09:38 AM Misc #17050: profiler gem
I'd recommend starting with something specific like `profiler-memory`.
`profiler` is very generic but therefore al...
Eregon (Benoit Daloze)
04:10 AM Misc #17050: profiler gem
My initial goal is to expose some general data structures for efficiently capturing large memory profiles on top of `... ioquatix (Samuel Williams)
03:39 AM Misc #17050: profiler gem
Can you tell us shortly what you plan to use that gem/namespace for? If it's something that can (in some reasonable w... duerst (Martin Dürst)
12:25 AM Misc #17050: profiler gem
Also I'd be happy to receive/resuse the `profile` namespace too but either one is fine and the `profile` gem actually... ioquatix (Samuel Williams)
12:03 AM Misc #17050 (Closed): profiler gem
I would like to reuse profiler gem namespace:
https://rubygems.org/gems/profiler/versions
It currently conflict...
ioquatix (Samuel Williams)
09:01 PM Bug #17051: Crash when attempting to load schema in Rails application
I think you are correct Alan. During my rebuild of the laptop, I inadvertently installed v 8 instead of 5.6. What thr... [email protected] (Tom Hoen)
08:09 PM Bug #17051: Crash when attempting to load schema in Rails application
> Thank you for responding Alan. Is 2.5.8 sufficient?
Actually, you seem to be running into a known problem in the...
alanwu (Alan Wu)
07:47 PM Bug #17051: Crash when attempting to load schema in Rails application
Thank you for responding Alan. Is 2.5.8 sufficient? [email protected] (Tom Hoen)
07:31 PM Bug #17051: Crash when attempting to load schema in Rails application
Support for the 2.4 series has [ended](https://www.ruby-lang.org/en/news/2020/04/05/support-of-ruby-2-4-has-ended/). ... alanwu (Alan Wu)
06:42 PM Bug #17051 (Third Party's Issue): Crash when attempting to load schema in Rails application
I am experiencing a crash when running `rake db:schema:load` or `rake db:migrate` in a Rails 4.2.9/Mysql2 0.4.0 appli... [email protected] (Tom Hoen)
06:33 PM Bug #17048: Calling initialize_copy on live modules leads to crashes
> How about having an initialized flag that's set by #initialize and #initialize_copy and checked in both of these me... alanwu (Alan Wu)
10:32 AM Bug #17048: Calling initialize_copy on live modules leads to crashes
Should we rather design a good way to allow copying but yet not have to deal with uninitialized state?
Right now t...
Eregon (Benoit Daloze)
02:35 AM Bug #17048: Calling initialize_copy on live modules leads to crashes
I agree with @alanwu, that it won't be worth.
```diff
diff --git c/class.c i/class.c
index 6835d2d7289..f7a56601...
nobu (Nobuyoshi Nakada)
12:42 PM Bug #16780: Net::FTP PUT command issuing Net::ReadTimeout too quickly
ruby_2_7 578bacc471fa3fa14f8607fe67adccce21e81657 merged revision(s) 5e81e8675a020ecd493620a4ff38db8fcf4b972a. nagachika (Tomoyuki Chikanaga)
12:42 PM Revision 578bacc4 (git): merge revision(s) 5e81e8675a020ecd493620a4ff38db8fcf4b972a: [Backport #16780]
Ignore exceptions when closing data connections [Bug #16780]
Patch by koshigoe (Masataka SUZUKI). Thanks!
nagachika (Tomoyuki Chikanaga)
10:12 AM Feature #17016: Enumerable#accumulate
y.annikov (Yakov Annikov) wrote in #note-22:
> I've created a PR with the implementation of `scan` and `lazy.scan` me...
y.annikov (Yakov Annikov)
07:49 AM Feature #17016: Enumerable#accumulate
nobu (Nobuyoshi Nakada) wrote in #note-23:
> RubyBugs (A Nonymous) wrote in #note-19:
> > In keeping with the Ruby-...
duerst (Martin Dürst)
06:20 AM Feature #17016: Enumerable#accumulate
parker (Parker Finch) wrote in #note-21:
> nobu (Nobuyoshi Nakada) wrote in #note-20:
> > ```ruby
> > (1..).lazy.i...
duerst (Martin Dürst)
05:17 AM Bug #16834: rb_profile_frame_classpath only recognize class singleton methods, not module singleton methods
ruby_2_7 12391cdbe11f3fbeb3b04c30b944139e5bbd9ea6 merged revision(s) cbe4f75ef802f13d05f94e42274b65a062bd3666. nagachika (Tomoyuki Chikanaga)
05:17 AM Revision 12391cdb (git): merge revision(s) cbe4f75ef802f13d05f94e42274b65a062bd3666: [Backport #16834]
Fix rb_profile_frame_classpath to handle module singletons
Right now `SomeClass.method` is properly named, b...
nagachika (Tomoyuki Chikanaga)
04:41 AM Bug #16854: Using (...) when the method name is a keyword generates error
ruby_2_7 be359442cb07c25fdc769431ffed3249b9016829 merged revision(s) 71c166e11e761dcaaa943f9b94da38f86ada1bdb. nagachika (Tomoyuki Chikanaga)
04:40 AM Revision be359442 (git): merge revision(s) 71c166e11e761dcaaa943f9b94da38f86ada1bdb: [Backport #16854]
Fixed argument forwarding in reserved word method [Bug #16854] nagachika (Tomoyuki Chikanaga)
03:00 AM Bug #16798: ENV.replace on Windows with a variable name not respecting case will clear it
ruby_2_7 89f06ce8b8a887f12b53ea190d79a58e98b59008 merged revision(s) 08529a61153e5c40f57a65272211357511d6e6db. nagachika (Tomoyuki Chikanaga)
03:00 AM Revision 89f06ce8 (git): merge revision(s) 08529a61153e5c40f57a65272211357511d6e6db: [Backport #16798]
Compare environment variable names in those manor [Bug #16798] nagachika (Tomoyuki Chikanaga)
02:56 AM Bug #16767: Time#strftime not working correctly with a big precision on recurred formats like "%c"
ruby_2_7 2e9626fddd168bd12352b4f5dc3412c6a33ce44e merged revision(s) 2f1895fa15386fb3cdc91c5604171290828b9da8. nagachika (Tomoyuki Chikanaga)
02:56 AM Revision 2e9626fd (git): merge revision(s) 2f1895fa15386fb3cdc91c5604171290828b9da8: [Backport #16767]
Fixed formatted substring expansion [Bug #16767] nagachika (Tomoyuki Chikanaga)

07/24/2020

10:59 PM Bug #17025: `Time#ceil` does not work like `Rational#ceil` or `Float#ceil`
I've added a pull request to fix this: https://github.com/ruby/ruby/pull/3362 jeremyevans0 (Jeremy Evans)
10:29 PM Bug #17048: Calling initialize_copy on live modules leads to crashes
In principle I agree that allowing initialization only once is a good way to go, but the way `Module.allocate` is cur... alanwu (Alan Wu)
05:52 PM Bug #17048: Calling initialize_copy on live modules leads to crashes
I would recommend to have `initialize_copy` always raise instead of only raising if the module has children. It's mo... jeremyevans0 (Jeremy Evans)
05:23 PM Bug #17048: Calling initialize_copy on live modules leads to crashes
I'm not proposing that we remove `initialize_copy`, but to make it raise when the receiver has children. So this is w... alanwu (Alan Wu)
04:40 PM Bug #17048: Calling initialize_copy on live modules leads to crashes
Removing `Module#initialize_copy` would probably require changes to `Module#{dup,clone}`. Maybe we can set a flag in... jeremyevans0 (Jeremy Evans)
04:09 PM Bug #17048 (Closed): Calling initialize_copy on live modules leads to crashes

Here's a repro script
```ruby
loop do
m = Module.new do
prepend Module.new
def hello
end
e...
alanwu (Alan Wu)
09:12 PM Bug #17049: Net::IMAP - Handling of NOOP untagged responses sent by Zimbra
Per RFC 3501 Section 7: `The client MUST be prepared to accept any response at all times.` Arguably, raising an exce... jeremyevans0 (Jeremy Evans)
07:53 PM Bug #17049 (Closed): Net::IMAP - Handling of NOOP untagged responses sent by Zimbra
Zimbra server sends invalid untagged responses to prevent some clients from disconnecting during long-running request... Nestorfish (Christophe Le Roy)
08:17 PM Bug #17044 (Closed): ObjectSpace.dump allocates one string per anonymous class and module
jeremyevans0 (Jeremy Evans)
12:08 PM Revision 3ead2770 (git): Respect visibility in non-array Enumerable#inject [Bug #13592]
nobu (Nobuyoshi Nakada)
11:17 AM Bug #17046 (Closed): Time#to_a yday is 0(given timezone info)
Applied in changeset commit:git|2735da2039b9e441e41b11b606ba362db350a658.
----------
Fix Time#to_a behavior with tim...
S_H_ (Shun Hiraoka)
11:17 AM Revision 2735da20 (git): Fix Time#to_a behavior with timezone [Bug #17046]
S_H_ (Shun Hiraoka)
02:30 AM Feature #17016: Enumerable#accumulate
RubyBugs (A Nonymous) wrote in #note-19:
> In keeping with the Ruby-ish collection methods that end with "-ect", how...
nobu (Nobuyoshi Nakada)
02:11 AM Revision 922fe4da (git): * 2020-07-24 [ci skip]
git[bot]
02:00 AM Revision ba99eae2 (git): [ruby/optparse] Fix ls-files matching regexp
As splitting by NUL means to allow the file names to contain
newlines, path names should match at beginning-of-string...
nobu (Nobuyoshi Nakada)

07/23/2020

10:25 PM Bug #17031: `Kernel#caller_locations(m, n)` should be optimized
I've added a pull request that addresses this issue: https://github.com/ruby/ruby/pull/3357 jeremyevans0 (Jeremy Evans)
10:21 PM Feature #17047 (Open): Support parameters for MAIL FROM and RCPT TO
## Proposal
In `Net::SMTP`, add support for parameters for `MAIL FROM` and `RCPT TO`, such as [SMTPUTF8](https://too...
c960657 (Christian Schmidt)
09:44 PM Feature #17016: Enumerable#accumulate
I've created a PR with the implementation of `scan` and `lazy.scan` methods https://github.com/ruby/ruby/pull/3358
...
y.annikov (Yakov Annikov)
03:39 PM Feature #17016: Enumerable#accumulate
nobu (Nobuyoshi Nakada) wrote in #note-20:
> With https://github.com/ruby/ruby/pull/3337, you can
> ```ruby
> (1.....
parker (Parker Finch)
03:12 AM Feature #17016: Enumerable#accumulate
With https://github.com/ruby/ruby/pull/3337, you can
```ruby
(1..).lazy.inject(0, :+).first(10) #=> [0, 1, 3, 6, 10...
nobu (Nobuyoshi Nakada)
08:57 PM Feature #17043: Invokable module for custom Proc-like objects
Got it, that make sense. But, just to be clear my proposal is not to include my module in the standard library, but t... delonnewman (Delon Newman)
06:43 PM Feature #17043 (Rejected): Invokable module for custom Proc-like objects
> But, it'd be great to be able to treat sets as predicate functions
Note that since Ruby 2.5, `Set#===` is an al...
marcandre (Marc-Andre Lafortune)
06:19 PM Feature #17043: Invokable module for custom Proc-like objects
Yeah, I guess I wasn't that clear. I'm curious if an officially blessed "Invokable" module might be a useful thing fo... delonnewman (Delon Newman)
05:16 AM Feature #17043 (Feedback): Invokable module for custom Proc-like objects
While your library seems great, what is proposed in this ticket is not that obvious. How can we help? What can we do? shyouhei (Shyouhei Urabe)
12:42 AM Feature #17043 (Rejected): Invokable module for custom Proc-like objects
Ruby beautifully integrates Functional and Object-Oriented Programming, and there's more moving in the direction of s... delonnewman (Delon Newman)
07:28 PM Bug #16921: s390x: random test failures for timeout or segmentation fault
I sent this PR related to this ticket.
https://github.com/ruby/ruby/pull/3354
It's to apply test-scale to test_no...
jaruga (Jun Aruga)
03:06 PM Bug #16921: s390x: random test failures for timeout or segmentation fault
> Try an environment variable RUBY_TEST_TIMEOUT_SCALE. If you set RUBY_TEST_TIMEOUT_SCALE=10, all timeout tests wait ... jaruga (Jun Aruga)
07:22 PM Bug #16492: TestBugReporter#test_bug_reporter_add test failures
> Therefore I wonder if there is any other possible solution?
Another option might be using `--retry` with jobs.
...
jaruga (Jun Aruga)
03:15 PM Bug #16492: TestBugReporter#test_bug_reporter_add test failures
> > I extended the timeout and so far the test was executed in the more then 56 seconds for the worst case. I am afra... jaruga (Jun Aruga)
03:02 PM Bug #16492: TestBugReporter#test_bug_reporter_add test failures
I took a look at the code.
```
RUBY_TEST_TIMEOUT_SCALE=5 \
make runruby TESTRUN_SCRIPT="-Itool/lib test/-ext-/...
jaruga (Jun Aruga)
06:54 PM Bug #17046: Time#to_a yday is 0(given timezone info)
Patch was created: https://github.com/ruby/ruby/pull/3355 S_H_ (Shun Hiraoka)
06:37 PM Bug #17046 (Closed): Time#to_a yday is 0(given timezone info)
I interest in Time#to_a behavior(background is Bug #17042)
Tried whether yday is displayed correctly in `Time #to_...
S_H_ (Shun Hiraoka)
02:44 PM Revision 098e8c28 (git): Suppress "assigned but unused variable" warnings
mame (Yusuke Endoh)
01:49 PM Revision e43d6295 (git): [ruby/observer] add symbol usage example to Observer#add_observer [doc]
https://github.com/ruby/observer/commit/62a94e3799 Tom Rothe
08:52 AM Feature #17045 (Closed): ObjectSpace.dump_all should allocate as little as possible in the GC heap
For context I'm working on a [heap profiler](https://github.com/Shopify/heap-profiler). In short the use case is like... byroot (Jean Boussier)
08:47 AM Bug #16764: Module.const_source_location does not work on autoloaded constants
ruby_2_7 c65aae118ccff86096b9983641b371491bc23434 merged revision(s) 927308108cced69cae478798004524b9a5d2f252. nagachika (Tomoyuki Chikanaga)
08:47 AM Revision c65aae11 (git): merge revision(s) 927308108cced69cae478798004524b9a5d2f252: [Backport #16764]
Fix source location of autoloaded constant [Bug #16764] nagachika (Tomoyuki Chikanaga)
08:30 AM Bug #16749: File.lchmod specs fails on linux since glibc 2.31.9000
ruby_2_7 4437f9eb0bf8369bcf12bd7cd324e11b5d885e07 merged revision(s) da05c1552ee519d8f180b48d97148d28501acb35. nagachika (Tomoyuki Chikanaga)
08:30 AM Revision 4437f9eb (git): merge revision(s) da05c1552ee519d8f180b48d97148d28501acb35: [Backport #16749]
Update to ruby/spec@cc7b9e5 nagachika (Tomoyuki Chikanaga)
08:23 AM Bug #16662: lchmod available in linux since glibc 2.31.9000
ruby_2_7 c53cee7a0e7b3e87ba3fbafa86bd74460af18d93 merged revision(s) 72c02aa4b79731c7f25c9267f74b347f1946c704. nagachika (Tomoyuki Chikanaga)
08:22 AM Revision c53cee7a (git): merge revision(s) 72c02aa4b79731c7f25c9267f74b347f1946c704: [Backport #16662]
Moved not-implemented method tests [Bug #16662]
Test not-implemented method with the dedicated methods, inst...
nagachika (Tomoyuki Chikanaga)
08:02 AM Bug #16519: pp [Hash.ruby2_keywords_hash({})] shows `[nil]`
Seems already backported at bb93659fefd7f4557129043742771a33bd30c255. nagachika (Tomoyuki Chikanaga)
07:59 AM Bug #16501: Support marshaling of ruby2_keywords flag
ruby_2_7 ae804b143455075687c8b4a401fba48fda72a217 merged revision(s) b23fd59cbb3f097bcd559d0c85a86ff7a1eeeb7e. nagachika (Tomoyuki Chikanaga)
07:59 AM Revision ae804b14 (git): merge revision(s) b23fd59cbb3f097bcd559d0c85a86ff7a1eeeb7e: [Backport #16501]
marshal.c: Support dump and load of a Hash with the ruby2_keywords
flag
It is useful for a program ...
nagachika (Tomoyuki Chikanaga)
07:57 AM Revision 54acb3dd (git): Improved Enumerable::Lazy#zip
| |compare-ruby|built-ruby|
|:-------------------|-----------:|---------:|
|first_ary | ...
nobu (Nobuyoshi Nakada)
07:57 AM Revision 6b3cff12 (git): Improved Enumerable::Lazy#flat_map
| |compare-ruby|built-ruby|
|:-------|-----------:|---------:|
|num3 | 96.333k| 160.732k|
| | ...
nobu (Nobuyoshi Nakada)
07:57 AM Revision 89a86788 (git): New functions to pass more elements than passed
nobu (Nobuyoshi Nakada)
07:56 AM Revision f1563edc (git): Get rid of use of magic number 'E'
nobu (Nobuyoshi Nakada)
07:17 AM Bug #17044 (Closed): ObjectSpace.dump allocates one string per anonymous class and module
This is because it dump the module/class names using `rb_class2name` which will create an ad hoc name for anonymous c... byroot (Jean Boussier)
05:57 AM Revision 347639ad (git): Removed fragile tests in https://github.com/ruby/ruby/pull/3349
nobu (Nobuyoshi Nakada)
05:30 AM Revision ff397d00 (git): dln.h: delete unused codes
defines.h already has them. Also __cplusplus can never be defined here. shyouhei (Shyouhei Urabe)
05:30 AM Revision c4fc737f (git): include/ruby/util.h: delete unused codes
- util.h includes defines.h,
- ... which includes ruby/backward/2/stdarg.h,
- ... which always defines _.
This `#ifn...
shyouhei (Shyouhei Urabe)
05:17 AM Revision 1d8b689b (git): Remove unused field in rb_iseq_constant_body
This was introduced in 191ce5344ec42c91571f8f47c85be9138262b1c7
and has been unused since beae6cbf0fd8b6619e5212552de...
alanwu (Alan Wu)
05:02 AM Bug #16830: URI.parse raises NoMethodError instead of URI::InvalidURIError
ruby_2_7 4f714939efde6d6b3b74c09e1e151e6ce6818b90 merged revision(s) e04418bb16cd99b4a4402e7457d3bdc967284f98. nagachika (Tomoyuki Chikanaga)
05:02 AM Revision 4f714939 (git): merge revision(s) e04418bb16cd99b4a4402e7457d3bdc967284f98: [Backport #16830]
[ruby/uri] Check if DN exists
https://bugs.ruby-lang.org/issues/16830
https://github.com/ruby/uri/c...
nagachika (Tomoyuki Chikanaga)
04:51 AM Bug #16826: ObjectSpace::WeakMap#key? returns false if value is nil
ruby_2_7 9da6470d7b3aa136b4b92469c8bbc522beb1ac31 merged revision(s) a2be428c5fec31b8adbd5ac087e7637ddf7e54d0. nagachika (Tomoyuki Chikanaga)
04:50 AM Revision 9da6470d (git): merge revision(s) a2be428c5fec31b8adbd5ac087e7637ddf7e54d0: [Backport #16826]
Fix ObjectSpace::WeakMap#key? to work if the value is nil
* Fixes [Bug #16826]
nagachika (Tomoyuki Chikanaga)
03:13 AM Bug #17033: Infinite Traceback when encountering an Exception while catching an Exception
ruby_2_7 27fa1c61b78c1685ccf9ac203a95cfa9041d618f merged revision(s) 579645d9f870fa4116dcd3200bbbb6e2c0b7f400. nagachika (Tomoyuki Chikanaga)
03:13 AM Revision 27fa1c61 (git): merge revision(s) 579645d9f870fa4116dcd3200bbbb6e2c0b7f400: [Backport #17033]
Fixed infinite loop at error in printing cause [Bug #17033] nagachika (Tomoyuki Chikanaga)
02:52 AM Revision caf565f7 (git): Ensure time object meets a given condition [Bug #17042]
nobu (Nobuyoshi Nakada)
02:46 AM Bug #16760: backport #67305 / e39f7e64 to 2.6?
I just find that e39f7e64b73f0506def7adc88226d6821608da54 (r67305) is included in ruby_2_7. nagachika (Tomoyuki Chikanaga)
02:35 AM Revision afacf85e (git): Merge pull request #3352 from S-H-GAMELINKS/bug/17042-strftime
Fix Time#strftime with timezone [Bug #17042] S_H_ (Shun Hiraoka)
02:35 AM Bug #17042 (Closed): Times with timezones return incorrect week numbers
Applied in changeset commit:git|8ed687a4d7b7a77f30f8e937f58aae74bfb699b6.
----------
Test for weeknumber with timezo...
nobu (Nobuyoshi Nakada)
02:33 AM Revision 8ed687a4 (git): Test for weeknumber with timezone [Bug #17042]
nobu (Nobuyoshi Nakada)
02:33 AM Bug #17024: Times with timezones return incorrect wday and yday
ruby_2_7 4be9bf1f67b997fc519625d56a93b8a68a70d124 merged revision(s) 99a9c3fe2eaab8157765d792dc871da6daea0327. nagachika (Tomoyuki Chikanaga)
02:33 AM Revision 4be9bf1f (git): merge revision(s) 99a9c3fe2eaab8157765d792dc871da6daea0327: [Backport #17024]
Fixed yday and wday with timezone [Bug #17024] nagachika (Tomoyuki Chikanaga)
02:16 AM Bug #16918: Dir.mktmpdir should yield a copy of the dir to protect cleanup
ruby_2_7 13d2ab0d88bbf72ed310efaec6edc46dd96fdb4d merged revision(s) 2ecfb88ee50510955acd3ae9fc94a5f109e7f109. nagachika (Tomoyuki Chikanaga)
02:16 AM Revision 13d2ab0d (git): merge revision(s) 2ecfb88ee50510955acd3ae9fc94a5f109e7f109: [Backport #16918]
Correctly remove temporary directory if path yielded is mutated
Another approach would be to freeze the stri...
nagachika (Tomoyuki Chikanaga)
02:11 AM Bug #16925: Backport request: net/http raises in ensure and replaces the original error
ruby_2_7 cc39480cf9f2767967b6bcc69ccb3c201e5b2231 merged revision(s) 5a79d8e0507cd143100bf928a88a59a8b5a5bca6,160511d... nagachika (Tomoyuki Chikanaga)
02:11 AM Revision cc39480c (git): merge revision(s) 5a79d8e0507cd143100bf928a88a59a8b5a5bca6,160511d851375f7cb922faae3a9310633187f51f: [Backport #16925]
Fix error raised by Net::HTTPResponse#inflater if the block raises
* See https://bugs.ruby-lang.org/issues/1...
nagachika (Tomoyuki Chikanaga)
01:57 AM Revision f120e652 (git): [ruby/optparse] Define OptionParser::Version
https://github.com/ruby/optparse/commit/4c0021b5b2 nobu (Nobuyoshi Nakada)
01:57 AM Revision cd429e68 (git): [ruby/optparse] Update required ruby version
Now needs `DidYouMean#formatter` which is provided since
did_you_mean 1.2, which requires ruby 2.5.
https://github.c...
nobu (Nobuyoshi Nakada)
01:52 AM Revision 6a0cb1d6 (git): Avoid allocating a string when dumping an anonymous module or class
byroot (Jean Boussier)
12:06 AM Revision 5d04ac6e (git): Enhanced RDoc for Array (#3350)
* Enhanced RDoc for Array
Methods:
==
eql?
hash
include?
<=>
burdettelamar (Burdette Lamar)

07/22/2020

11:01 PM Revision 37e6c836 (git): Lazily insert origins on prepend to save memory
98286e9850936e27e8ae5e4f20858cc9c13d2dde made it so that
`Module#include` allocates an origin iclass on each use. Sin...
alanwu (Alan Wu)
07:47 PM Bug #17023: How to prevent String memory to be relocated in ruby-ffi
tenderlovemaking (Aaron Patterson) wrote in #note-16:
> I think Lars was having trouble expanding strings that are f...
Eregon (Benoit Daloze)
06:23 PM Bug #17023: How to prevent String memory to be relocated in ruby-ffi
Eregon (Benoit Daloze) wrote in #note-15:
> Maybe we need a pin function that doesn't mind if the String is frozen?
...
tenderlovemaking (Aaron Patterson)
06:19 PM Bug #17023: How to prevent String memory to be relocated in ruby-ffi
Maybe FFI should discourage cases where the native function saves the RSTRING_PTR() and still use it after the native... Eregon (Benoit Daloze)
05:57 PM Bug #17023: How to prevent String memory to be relocated in ruby-ffi
One idea I had is that we could make `RSTRING_PTR`, `StringValueCStr`, `StringValuePtr`, etc ensure that the characte... tenderlovemaking (Aaron Patterson)
09:45 AM Bug #17023: How to prevent String memory to be relocated in ruby-ffi
@Hanmac The string must be kept as a ruby object in an instance variable or constant, etc. and must not be modified a... larskanis (Lars Kanis)
07:41 AM Bug #17023: How to prevent String memory to be relocated in ruby-ffi
the problem there is that ruby can't know how long the C lib is going to use the String. Depending on the C Function,... Hanmac (Hans Mackowiak)
07:32 PM Bug #17042: Times with timezones return incorrect week numbers
Created patch.
https://github.com/ruby/ruby/pull/3352
S_H_ (Shun Hiraoka)
07:15 PM Bug #17042: Times with timezones return incorrect week numbers
This code resolve this behaviour.
```c
static VALUE
time_strftime(VALUE time, VALUE format)
{
struct time_...
S_H_ (Shun Hiraoka)
06:43 PM Bug #17042: Times with timezones return incorrect week numbers
Apparently the calculation result `ret = ((timeptr->tm_yday + 7 - wday) / 7);` is negative(`timeptr->tm_yday` is nega... S_H_ (Shun Hiraoka)
05:56 PM Bug #17042: Times with timezones return incorrect week numbers
Same behaviour in `2.7` & `2.6`(checked `2.7.1`, `2.7.0`, `2.6.6`, `2.6.5`). S_H_ (Shun Hiraoka)
02:08 PM Bug #17042 (Closed): Times with timezones return incorrect week numbers
Times with timezones return incorrect week numbers from strftime. For example:
$ irb -r tzinfo
irb(main):...
timcraft (Tim Craft)
06:12 PM Feature #17016: Enumerable#accumulate
parker (Parker Finch) wrote in #note-18:
> Are there other names you think should be considered?
In keeping with th...
RubyBugs (A Nonymous)
05:23 PM Feature #17016: Enumerable#accumulate
matz (Yukihiro Matsumoto) wrote in #note-17:
> I don't see any real-world use-case for `scan_left`. Is there any?
...
parker (Parker Finch)
05:46 PM Bug #17029 (Closed): URI.parse considers https://example.com/### invalid when browsers consider it valid
jeremyevans0 (Jeremy Evans)
05:28 PM Misc #17041: DevelopersMeeting20200831Japan
* [Feature #16989] Sets need ♥️, aka the "Set Program" (marcandre)
* Bring `Set` into core
* Insure interoperab...
marcandre (Marc-Andre Lafortune)
08:04 AM Misc #17041: DevelopersMeeting20200831Japan
Please note that it may not be possible to go though all topics that are raised in this agenda because we will discus... mame (Yusuke Endoh)
06:06 AM Misc #17041: DevelopersMeeting20200831Japan
* [Feature #17040] cleanup include/ruby/backward* (shyouhei)
* Is anybody against it?
shyouhei (Shyouhei Urabe)
05:58 AM Misc #17041: DevelopersMeeting20200831Japan
* [Feature #17039] Remove `Time#succ` (znz)
* `Time#succ` is obsolete since 1.9.2.
znz (Kazuhiro NISHIYAMA)
05:55 AM Misc #17041 (Closed): DevelopersMeeting20200831Japan
# The next dev meeting
**Date: 2020/08/26 13:00-17:00**
Place/Sign-up/Agenda/Log: https://github.com/ruby/dev-mee...
mame (Yusuke Endoh)
04:35 PM Bug #16492: TestBugReporter#test_bug_reporter_add test failures
On top of that, I also received following error:
~~~
+ make runruby 'TESTRUN_SCRIPT=-Itool/lib test/-ext-/bug_rep...
vo.x (Vit Ondruch)
01:33 PM Bug #16492: TestBugReporter#test_bug_reporter_add test failures
> waiting somewhere else:
Presumably waiting for `status ||= Process.wait2(pid)[1]`
vo.x (Vit Ondruch)
01:29 PM Bug #16492: TestBugReporter#test_bug_reporter_add test failures
Just two examples from my testing:
~~~
+ make runruby 'TESTRUN_SCRIPT=-Itool/lib test/-ext-/bug_reporter/test_bug...
vo.x (Vit Ondruch)
03:40 PM Bug #14804 (Closed): GzipReader cannot read Freebase dump (but gzcat/zless can)
This can now be handled using `Zlib::GzipReader.zcat`, which was recently added to zlib. jeremyevans0 (Jeremy Evans)
03:39 PM Bug #9790 (Closed): Zlib::GzipReader only decompressed the first of concatenated files
matz approved Zlib::GzipReader.zcat, so I merged the pull request into zlib. jeremyevans0 (Jeremy Evans)
03:39 PM Bug #11180 (Closed): Missing lines with Zlib::GzipReader
matz approved Zlib::GzipReader.zcat, so I merged the pull request into zlib. jeremyevans0 (Jeremy Evans)
03:36 PM Feature #16923 (Closed): Switch reserved for numbered parameter warning to SyntaxError
Implemented in commit:d47e124857ecdccfeb0766c04cf1ef2cdfdd08bc jeremyevans0 (Jeremy Evans)
03:35 PM Revision fdcbb288 (git): * 2020-07-23 [ci skip]
git[bot]
03:34 PM Revision d47e1248 (git): Switch reserved for numbered parameter warning to SyntaxError
jeremyevans (Jeremy Evans)
02:58 PM Misc #17019 (Closed): DevelopersMeeting20200720Japan
mame (Yusuke Endoh)
12:28 PM Revision 50aac2ff (git): Share the size for sigaltstack between configure.ac and signal.c
nobu (Nobuyoshi Nakada)
11:46 AM Revision 8b0dc77a (git): configure.ac: Bump the size of sigaltstack
The RubyVM uses C macro defines to feature detect whether
`backtrace(2)` support is available, and if so it includes ...
jez (Jake Zimmerman)
09:38 AM Revision 7befc0cd (git): Promote optparse to default gems
hsbt (Hiroshi SHIBATA)
05:16 AM Feature #17040: cleanup include/ruby/backward*
I'm pretty confident that nobody is against such change. But opening an issue anyways, because this is a breaking ch... shyouhei (Shyouhei Urabe)
05:14 AM Feature #17040 (Open): cleanup include/ruby/backward*
I recently noticed [[ruby-dev:35813]](http://blade.nagaokaut.ac.jp/cgi-bin/scat.rb/ruby/ruby-dev/35813):
> こんなところで...
shyouhei (Shyouhei Urabe)

07/21/2020

10:07 PM Revision a50750c8 (git): Enhanced RDoc for Array
burdettelamar (Burdette Lamar)
10:07 PM Revision d29de7b3 (git): Enhanced RDoc for Array
burdettelamar (Burdette Lamar)
10:07 PM Revision 8a974e0f (git): Enhanced RDoc for Array
burdettelamar (Burdette Lamar)
08:18 PM Bug #17023: How to prevent String memory to be relocated in ruby-ffi
Sorry for not responding earlier! Unfortunately this issue still remains. So it is not closed and the backported comm... larskanis (Lars Kanis)
07:11 PM Revision 20172672 (git): Add require 'irb/ruby-lex' to use RubyLex
aycabta (aycabta .)
07:04 PM Feature #10911 (Closed): IPAddr.new should ignore zone identifiers
jeremyevans0 (Jeremy Evans)
06:49 PM Revision ee2529df (git): Sometimes result indicator (=>) isn't shown
aycabta (aycabta .)
06:13 PM Revision 0faf0271 (git): Use simple assersion
aycabta (aycabta .)
05:53 PM Feature #16786: Light-weight scheduler for improved concurrency.
Replying to only one of your points for now:
> like a tailor-made solution for integrating nio4r into Ruby.
I see i...
Eregon (Benoit Daloze)
06:49 AM Feature #16786: Light-weight scheduler for improved concurrency.
I've been working a lot with fibers recently, and I would like to share my thoughts on this issue. Disclaimer: I'm cu... ciconia (Sharon Rosner)
05:42 PM Revision 1d0e8fd4 (git): * 2020-07-22 [ci skip]
git[bot]
05:35 PM Revision 02951a45 (git): [ruby/rdoc] Create link to unary operator methods correctly
https://github.com/ruby/rdoc/commit/54500cf12a hyrious
05:34 PM Revision 7693aa70 (git): [ruby/rdoc] Remove empty lines from html file by using ERB trim_mode flag
https://github.com/ruby/rdoc/commit/9e27299a46 Benoit Tigeot
05:34 PM Revision 38480ad5 (git): [ruby/rdoc] Fix parsing of rb_define_module_under
Fixes Ruby Bug #15819
https://github.com/ruby/rdoc/commit/94a052d833
jeremyevans (Jeremy Evans)
05:34 PM Revision f76d67f4 (git): [ruby/rdoc] Fix RDoc::Context#instance_method_list
The warn method returns nil, it's a bug of #instance_method_list.
https://github.com/ruby/rdoc/commit/a20df89263
aycabta (aycabta .)
05:31 PM Revision f6e789e3 (git): [ruby/irb] handle rescue modifier properly
https://github.com/ruby/irb/commit/6de1341f5e no6v (Nobuhiro IMAI)
05:31 PM Revision 22d38d54 (git): [ruby/irb] Add test_eval_object_without_inspect_method
https://github.com/ruby/irb/commit/c0d9a26bce aycabta (aycabta .)
05:31 PM Revision b40e925c (git): [ruby/irb] Fix error when `inspect` is called but not found in inspector
https://github.com/ruby/irb/commit/ce6d53e6d9 pocke (Masataka Kuwabara)
05:31 PM Revision 4268084d (git): [ruby/irb] Add encoding magic comments of editors
https://github.com/ruby/irb/commit/f8c10ea24b aycabta (aycabta .)
05:31 PM Revision c72a2fad (git): [ruby/irb] Simplify RubyLex.compile_with_errors_suppressed
nobu-san reviewed,
https://github.com/ruby/irb/pull/106#pullrequestreview-423400033
> How about lexer = Ripper::Lexe...
aycabta (aycabta .)
05:31 PM Revision 1dfd24a7 (git): [ruby/irb] Suppress incomplete encoding magic comment error
https://github.com/ruby/irb/commit/443e90af80 aycabta (aycabta .)
05:31 PM Revision 78ccab25 (git): [ruby/irb] Suppress incomplete coding magic comment error
https://github.com/ruby/irb/commit/6a457edbd1 aycabta (aycabta .)
02:56 PM Bug #17038 (Rejected): On master, ancestry edits can lead to duplicates in Module#ancestors
Note that this change is listed in the `NEWS`
I'm thus closing this.
marcandre (Marc-Andre Lafortune)
03:23 AM Bug #17038: On master, ancestry edits can lead to duplicates in Module#ancestors
> I believe it's always been possible to have duplicates in ancestors, even before this change
Thank you for the exa...
alanwu (Alan Wu)
02:25 AM Bug #17038: On master, ancestry edits can lead to duplicates in Module#ancestors
I imagine that @alanwu feels the example code should behave the same way if the `include` were done sooner or later.
...
marcandre (Marc-Andre Lafortune)
12:50 AM Bug #17038: On master, ancestry edits can lead to duplicates in Module#ancestors
I believe it's always been possible to have duplicates in ancestors, even before this change:
```ruby
class A
en...
jeremyevans0 (Jeremy Evans)
01:58 PM Feature #16345: Don't emit deprecation warnings by default.
matz (Yukihiro Matsumoto) wrote in #note-46:
> So I changed my mind. Deprecation warnings should be turned on manu...
akr (Akira Tanaka)
12:32 PM Bug #16492: TestBugReporter#test_bug_reporter_add test failures
So I did quite a lot of testing focusing especially on internals of `EnvUtils.invoke_ruby` and I am not sure if there... vo.x (Vit Ondruch)
11:43 AM Feature #17039 (Closed): Remove Time#succ
`Time#succ` is obsolete since 1.9.2.
```
% docker run -it --rm rubylang/all-ruby env ALL_RUBY_SINCE=ruby-1.8 ./al...
znz (Kazuhiro NISHIYAMA)
11:28 AM Revision 48eb1ad2 (git): [DOC] time.c document updated.
* fraction -> subsecond
for consistency with method name
* The sentence,
"A non-portable feature allows the offs...
akr (Akira Tanaka)
11:27 AM Bug #17030: Enumerable#grep{_v} should be optimized for Regexp
I have an idea to solve it without any compatibility problem.
[1] Introduce such a Regexp object that `===` method...
scivola20 (sciv ola)
12:20 AM Revision 73ee1295 (git): Add memsize support for the call cache table
Each class/module/iclass can potentially have their own cc table.
Count their malloc usage.
alanwu (Alan Wu)
12:18 AM Revision ac3dbbd4 (git): * 2020-07-21 [ci skip]
git[bot]
12:17 AM Revision a8eeccea (git): [ruby/csv] Bump minimum ruby version to 2.5.0 (#159)
A dependency to stringio was added to csv, which requires Ruby version
>= 2.5. Bump the gemspec version accordingly.
...
gabuscus (Gabriel Nagy)
12:17 AM Revision c6f389d8 (git): [ruby/csv] Move doc/* to doc/csv/* to work in ruby/ruby too
https://github.com/ruby/csv/commit/910f8e0c5d Sutou Kouhei
 

Also available in: Atom