Project

General

Profile

Activity

From 08/03/2020 to 08/09/2020

08/09/2020

10:51 PM Feature #17109: Eliminate the performance impact of operands' order in array's | and &
`a & b` returns different result from `b & a`. `a | b` returns different result from `b | a`. You cannot substitute o... sawa (Tsuyoshi Sawada)
09:52 PM Feature #17109 (Rejected): Eliminate the performance impact of operands' order in array's | and &
When I do intersection (`a & b`) or union (`a | b`), usually the array in one position is more likely longer than the... [email protected] (Andrey Samsonov)
06:53 PM Misc #17041: DevelopersMeeting20200831Japan
* [Bug #17105] A single `return` can return to two different places in a proc inside a lambda inside a method (eregon... Eregon (Benoit Daloze)
08:19 AM Misc #17041: DevelopersMeeting20200831Japan
* [Feature #13381] Expose rb_fstring and its family to C extensions
* It's only missing a decision on the names. C...
byroot (Jean Boussier)
10:41 AM Bug #17105: A single `return` can return to two different places in a proc inside a lambda inside a method
+1 to @eregon ’s interpretation. Current behaviour is at least very cryptic. shyouhei (Shyouhei Urabe)
10:02 AM Bug #17108: error: initialization of ‘long unsigned int’ from ‘void *’ makes integer from pointer without a cast
tested with latest RUBY -> same warning=error aotto1968 (Andreas Otto)
09:43 AM Bug #17108 (Rejected): error: initialization of ‘long unsigned int’ from ‘void *’ makes integer from pointer without a cast
It seems that the "OPTIMIZATION" macro for "rb_funcall" causes something bad.
```
|| CC rubymsgque_la-mis...
aotto1968 (Andreas Otto)

08/08/2020

11:11 PM Feature #8215 (Closed): Support accessing Fiber-locals and backtraces for a Fiber
It looks like we can implement `Fiber#backtrace`:
https://bugs.ruby-lang.org/issues/16815
and in addition we sh...
ioquatix (Samuel Williams)
11:10 PM Feature #13893: Add Fiber#[] and Fiber#[]= and restore Thread#[] and Thread#[]= to their original behavior
Also discussed here:
https://bugs.ruby-lang.org/issues/8215
ioquatix (Samuel Williams)
08:35 PM Bug #11628: Net::SMTPServerBusy is not behaving according to documentation
Checkout this - https://www.smtpservers.co/blog/free-smtp-servers/ jackryan0307 (Jack Ryan)
02:25 PM Feature #14844: Future of RubyVM::AST?
@ioquatix Two reasons I've heard from projects using `RubyVM::AbstractSyntaxTree` are: built-in (not an extra depende... Eregon (Benoit Daloze)
08:35 AM Feature #14844: Future of RubyVM::AST?
I was using `RubyVM::AbstractSyntaxTree` but moved to `parser` gem. I cannot see any reason to use `RubyVM::AbstractS... ioquatix (Samuel Williams)
04:47 AM Bug #17107: Backtick in backtrace is a little bit annoying
The choice of characters used for quoting is irrelevant to such problem, which will not be solved unless the method n... sawa (Tsuyoshi Sawada)
04:39 AM Bug #17107 (Rejected): Backtick in backtrace is a little bit annoying
See #13589 hsbt (Hiroshi SHIBATA)
02:30 AM Bug #17107 (Rejected): Backtick in backtrace is a little bit annoying
In Ruby exception backtrace (and other places), the method name uses a quoting style of a backtick followed by a text... ioquatix (Samuel Williams)
01:29 AM Feature #16461 (Assigned): Proc#using
shugo (Shugo Maeda) wrote in #note-5:
> > I think that could be a good rule, all `Proc#using` must happen `before Pr...
shugo (Shugo Maeda)

08/07/2020

05:08 PM Revision b4b702dd (git): * 2020-08-08 [ci skip]
git[bot]
05:08 PM Revision 4126a979 (git): Enhanced RDoc for Array#take and Array#take_while (#3398)
burdettelamar (Burdette Lamar)
11:52 AM Revision 615b7fa5 (git): Enhanced RDoc for Array#product (#3395)
burdettelamar (Burdette Lamar)
11:21 AM Feature #15504: Freeze all Range objects
Right, every object cached at parse time must be deeply immutable, I would think that was an oversight. Eregon (Benoit Daloze)
06:12 AM Feature #15504: Freeze all Range objects
I got an issue on Ractor.
```ruby
def test
(1..2)
end
r1 = test
Ractor.new do
r2 = test
end.take
```
* compil...
ko1 (Koichi Sasada)
11:17 AM Bug #17013: `RubyVM::AbstractSyntaxTree.parse("struct.field += foo")` has no operator
ruby_2_7 e9e4f8430a62f56a4e62dd728f4498ee4c300c12 merged revision(s) 8e189df32cacef4b21e357a590d349330532baf5. nagachika (Tomoyuki Chikanaga)
11:16 AM Revision e9e4f843 (git): merge revision(s) 8e189df32cacef4b21e357a590d349330532baf5: [Backport #17013]
Add operator info to `OP_ASGN2` of `RubyVM::AbstractSyntaxTree`. nagachika (Tomoyuki Chikanaga)
07:38 AM Bug #17106: Build ruby 2.6.6 from git source
Hi,
I think you are using bison that is newer than the latest version at Ruby 2.6 release.
I guess @nobu has alre...
mame (Yusuke Endoh)
06:50 AM Bug #17106 (Closed): Build ruby 2.6.6 from git source
Hello!
I tried to build ruby 2.6.6 from git source, but get an error.
My Dockerfile:
```
FROM archlinux:2020070...
yegorov (Artem Yegorov)
05:01 AM Revision 504e632a (git): sync NDEBUG, RUBY_DEBUG, and RUBY_NDEBUG (#3327)
- When NDEBUG is defined that shall be honoured.
- When RUBY_DEBUG is defined that shall be honoured.
- When both are...
shyouhei (Shyouhei Urabe)
03:28 AM Revision 8a99f820 (git): Use zlib provided by vcpkg in mswin CI (#3397)
* Revert "mswin build - install src zlib files after checkout"
This reverts commit b6175c9e4fe25b978252d8998fe791d65...
hsbt (Hiroshi SHIBATA)
12:27 AM Feature #16495: Inconsistent quotes in error messages
Some terminals don't highlight text inside different quotes (for example, Iterm2, Terminal on Mac).
So you're going ...
vlad0337187 (Vladislav Ivanov)

08/06/2020

11:47 PM Bug #17105: A single `return` can return to two different places in a proc inside a lambda inside a method
IMHO it should be a LocalJumpError. The Proc should return to the lambda, that's syntactically the closest scope it s... Eregon (Benoit Daloze)
07:09 PM Bug #17105: A single `return` can return to two different places in a proc inside a lambda inside a method
I think the behavior makes sense to some extent, because the proc is within 2 nested contexts. Since the proc is with... Dan0042 (Daniel DeLorme)
02:43 PM Bug #17105: A single `return` can return to two different places in a proc inside a lambda inside a method
Hans I don't think anyone is debating the basic idea of what return in a proc or lambda does - I think we're talking ... chrisseaton (Chris Seaton)
02:34 PM Bug #17105: A single `return` can return to two different places in a proc inside a lambda inside a method
i think this is by design:
https://www.rubyguides.com/2016/02/ruby-procs-and-lambdas/
> A lambda will return no...
Hanmac (Hans Mackowiak)
11:00 AM Bug #17105: A single `return` can return to two different places in a proc inside a lambda inside a method
I should also note some of these semantics might significantly harm the performance of Ruby.
CRuby seems to walk the...
Eregon (Benoit Daloze)
10:54 AM Bug #17105 (Closed): A single `return` can return to two different places in a proc inside a lambda inside a method
A single `return` in the source code might return to 2 different lexical places.
That seems wrong to me, as AFAIK al...
Eregon (Benoit Daloze)
03:17 PM Revision 429efce4 (git): * 2020-08-07 [ci skip]
git[bot]
03:16 PM Revision fcdda2f8 (git): Add more debug info to test_verify
http://ci.rvm.jp/results/trunk-random1@phosphorus-docker/3111684 znz (Kazuhiro NISHIYAMA)
01:04 PM Revision 99e48527 (git): Add verbose message to random failed assertion
for example:
http://ci.rvm.jp/results/trunk-random1@phosphorus-docker/3111251
http://ci.rvm.jp/results/trunk-random1@...
znz (Kazuhiro NISHIYAMA)
11:10 AM Feature #17104: Do not freeze interpolated strings when using frozen-string-literal
> I'd argue "a#{2}c" is not a string literal ("a2c" is a string literal).
I understand your point of view. However...
byroot (Jean Boussier)
10:12 AM Feature #17104: Do not freeze interpolated strings when using frozen-string-literal
byroot (Jean Boussier) wrote in #note-8:
> Because I understand the consistency argument. "All string literals are fr...
Eregon (Benoit Daloze)
09:23 AM Feature #17104: Do not freeze interpolated strings when using frozen-string-literal
> If you want to get a mutable string from an interpolated literal +"_#{method1}_", 2 allocation will be done instead... byroot (Jean Boussier)
01:37 AM Feature #17104: Do not freeze interpolated strings when using frozen-string-literal
+1
A while ago I opened ticket #16047 about the same thing.
Seems a lot of people don't like the current behavior s...
Dan0042 (Daniel DeLorme)
10:14 AM Misc #17041: DevelopersMeeting20200831Japan
* [Feature #17104] Do not freeze interpolated strings when using frozen-string-literal (eregon)
* It seems many peo...
Eregon (Benoit Daloze)
06:51 AM Feature #17100: Ractor: a proposal for a new concurrent abstraction without thread-safety issues
I've directly heard "not-yet-implemented" from @ko1. Sorry for noise. mame (Yusuke Endoh)
06:45 AM Feature #17100: Ractor: a proposal for a new concurrent abstraction without thread-safety issues
Question: What is "immutable"?
I've tried the following code, but the implementation raises a NameError "can not a...
mame (Yusuke Endoh)
02:56 AM Feature #16513 (Closed): TracePoint#inspect to return "... file:line" instead of "...@file:line"
Applied in changeset commit:git|1819652578e8f9fe3606f7a716ec4e427fc55f0a.
----------
[Feature #16513] TracePoint#ins...
nguyenquangminh0711 (Quang-Minh Nguyen)
02:56 AM Revision 18196525 (git): [Feature #16513] TracePoint#inspect returns "... file:line" (#3391)
* Fix debug documents to match Thread#to_s change (Feature #16412 ticket)
* TracePoint#inspect returns "... file:lin...
Nguyễn Quang Minh

08/05/2020

11:36 PM Revision bbbec4b8 (git): Apply timeout-scale to test_thr_kill.
Jun Aruga
09:26 PM Feature #17104 (Open): Do not freeze interpolated strings when using frozen-string-literal
We can treat this as a feature request. I changed it from Misc to Feature and modified the Subject to be the feature... jeremyevans0 (Jeremy Evans)
09:18 PM Feature #17104: Do not freeze interpolated strings when using frozen-string-literal
Can't we just treat this as I feature request? The reasons are, it will reduce allocations, be more logical, less sur... bughit (bug hit)
09:10 PM Feature #17104: Do not freeze interpolated strings when using frozen-string-literal
FWIW I'd be +1 to make interpolated Strings non-frozen.
It's BTW still the behavior in TruffleRuby to this day, since...
Eregon (Benoit Daloze)
09:05 PM Feature #17104: Do not freeze interpolated strings when using frozen-string-literal
If you would like the behavior changed, you should file a feature request for it, and add it to the agenda of a futur... jeremyevans0 (Jeremy Evans)
08:58 PM Feature #17104: Do not freeze interpolated strings when using frozen-string-literal
If you want to get a mutable string from an interpolated literal `+"_#{method1}_"`, 2 allocation will be done instead... bughit (bug hit)
08:25 PM Feature #17104 (Closed): Do not freeze interpolated strings when using frozen-string-literal
Other people have felt the same way, including me (see https://bugs.ruby-lang.org/issues/11473#note-7 and https://bug... jeremyevans0 (Jeremy Evans)
08:06 PM Feature #17104 (Closed): Do not freeze interpolated strings when using frozen-string-literal
I think the point of frozen string literals is to avoid needless allocations. Interpolated strings are allocated each... bughit (bug hit)
07:58 PM Revision 77cfd2e0 (git): * 2020-08-06 [ci skip]
git[bot]
07:58 PM Revision e0bc436d (git): Enhanced documentation for Array#repeated_combination (#3392)
* Enhanced documentation for Array#repeated_combination
* Enhanced documentation for Array#repeated_combination
burdettelamar (Burdette Lamar)
02:42 PM Revision 24983346 (git): Enhanced documentation for Array#repeated_permutation (#3390)
* Enhanced documentation for Array#repeated_permutation
* Enhanced documentation for Array#repeated_permutation
burdettelamar (Burdette Lamar)
11:01 AM Revision 8f71bb0e (git): Fixed the inconsistency gemspec location with net-* gems.
hsbt (Hiroshi SHIBATA)
09:14 AM Feature #16513: TracePoint#inspect to return "... file:line" instead of "...@file:line"
I created a patch for this ticket here: https://github.com/ruby/ruby/pull/3391.
nguyenquangminh0711 (Quang-Minh Nguyen)
08:01 AM Bug #17025: `Time#ceil` does not work like `Rational#ceil` or `Float#ceil`
Thank you for fixing this Jeremy. tgxworld (Guo Xiang Tan)

08/04/2020

11:15 PM Feature #17100: Ractor: a proposal for a new concurrent abstraction without thread-safety issues
ko1 (Koichi Sasada) wrote in #note-5:
> BTW, there is some inconsistent by variable types:
I think that does not mat...
Eregon (Benoit Daloze)
01:18 AM Feature #17100: Ractor: a proposal for a new concurrent abstraction without thread-safety issues
Eregon (Benoit Daloze) wrote in #note-2:
> * I think we need to introduce `#deep_freeze` to make it easy to create d...
shyouhei (Shyouhei Urabe)
12:38 AM Feature #17100: Ractor: a proposal for a new concurrent abstraction without thread-safety issues
Thank you for trying Ractor.
ibylich (Ilya Bylich) wrote in #note-4:
> 1. Multiple ractors use a single shared ob...
ko1 (Koichi Sasada)
12:30 AM Feature #17100: Ractor: a proposal for a new concurrent abstraction without thread-safety issues
Thank you for your question.
Eregon (Benoit Daloze) wrote in #note-2:
> * Reactor#recv/Channel#recv => Reactor#re...
ko1 (Koichi Sasada)
11:05 PM Revision c8704328 (git): * 2020-08-05 [ci skip]
git[bot]
11:04 PM Revision 9db5d63e (git): [DOC] Use oracle url instead of sun url
[ci skip] S_H_ (Shun Hiraoka)
07:57 PM Bug #14607: Fix use of the rb_profile_frames start parameter
The original patch has a merge conflict. However, I have opened a pull request with the fix for this issue (https://... dylants (Dylan Thacker-Smith)
03:36 PM Bug #17101: YAML.load_file: Massive slowdown under Ruby 2.7 vs. Ruby 2.4
I run this program on Windows 10 64-bit. Very very slow: I wait more than 10 minutes, then I press Ctrl-Break. Now I ... fitmap (Justin Peal)
10:13 AM Bug #17101: YAML.load_file: Massive slowdown under Ruby 2.7 vs. Ruby 2.4
I tried this benchmark in several ruby's(Ubuntu18.04 in WSL2. using `rbenv`).
```yaml
prelude: |
require 'yaml'
be...
S_H_ (Shun Hiraoka)
08:32 AM Misc #17041: DevelopersMeeting20200831Japan
* [Feature #17103] Add a :since option to `ObjectSpace.dump_all` (byroot)
* On large heap, `dump_all` can take over...
byroot (Jean Boussier)
08:26 AM Feature #17103 (Closed): Add a :since option to ObjectSpace.dump_all
Patch: https://github.com/ruby/ruby/pull/3368
This is useful for seeing what a block of code allocated, e.g.
``...
byroot (Jean Boussier)
08:24 AM Bug #17020: ObjectSpace.trace_object_allocations_stop raises if called before trace_object_allocations_start
I added a regression test using `assert_separately`. byroot (Jean Boussier)
02:59 AM Feature #17055: Allow suppressing uninitialized instance variable and method redefined verbose mode warnings
tenderlovemaking (Aaron Patterson) wrote in #note-16:
> I guess I need to read the Sequel implementation. It seems ...
jeremyevans0 (Jeremy Evans)
12:40 AM Feature #16986: Anonymous Struct literal
Matz said: "good to have, but current proposed syntax are not acceptable. If there is good syntax, I can consider to ... ko1 (Koichi Sasada)
12:19 AM Feature #15752: A dedicated module for experimental features
FYI: [Type-profiler](https://github.com/mame/ruby-type-profiler), which I'm developing for an experimental type infer... mame (Yusuke Endoh)
12:01 AM Revision e8edc34f (git): Remove unused struct member
I accidentally added this in 35ba2783fe6b3316a6bbc6f00bf975ad7185d6e0,
and it's making the size of RVALUE be too big....
tenderlovemaking (Aaron Patterson)

08/03/2020

10:31 PM Bug #17102 (Closed): openssl/buffering.rb:182: [BUG] Segmentation fault at 0x00001fa0fd774000
Ruby crashed in our CI today, here's the console output:
```
Fetching google-api-client 0.23.9
/Users/anka/.rben...
Hixie (Ian Hickson)
07:56 PM Bug #17021: "arm64" and "arm" are mixed in RbConfig on Apple silicon
IMHO, "host_cpu" should have "arm64". "arm" looks like a bug to me. Would be nice to get this resolved, since it bloc... larskanis (Lars Kanis)
07:40 PM Feature #15752: A dedicated module for experimental features
I think an important lesson the Ruby implementors have learned over time is that there are no CRuby-specific APIs, it... Eregon (Benoit Daloze)
07:34 PM Feature #15752: A dedicated module for experimental features
Dan0042 (Daniel DeLorme) wrote in #note-18:
> Can I ask what would be so bad about having the `RubyVM` constant in o...
Eregon (Benoit Daloze)
07:04 PM Feature #15752: A dedicated module for experimental features
Can I ask what would be so bad about having the `RubyVM` constant in other implementations? I mean, in itself the nam... Dan0042 (Daniel DeLorme)
07:28 PM Revision d8e78850 (git): * 2020-08-04 [ci skip]
git[bot]
07:28 PM Revision 3dc313a2 (git): Don't pin objects if we're just walking the heap
Walking the heap can inadvertently pin objects. Only mark the object's
pin bit if the mark_func_data pointer is NULL...
tenderlovemaking (Aaron Patterson)
06:51 PM Bug #17101: YAML.load_file: Massive slowdown under Ruby 2.7 vs. Ruby 2.4
You used the phrase 'runs very very slow'. I found 2.7 slower, as below. What were the times you had?
Using Psych....
MSP-Greg (Greg L)
03:19 PM Bug #17101 (Closed): YAML.load_file: Massive slowdown under Ruby 2.7 vs. Ruby 2.4
When use Ruby 2.4, the following program runs fast, After ungrade to Ruby 2.7, the same program runs very very slow. ... fitmap (Justin Peal)
06:31 PM Feature #17055: Allow suppressing uninitialized instance variable and method redefined verbose mode warnings
jeremyevans0 (Jeremy Evans) wrote in #note-15:
> tenderlovemaking (Aaron Patterson) wrote in #note-14:
> > jeremyev...
tenderlovemaking (Aaron Patterson)
05:01 PM Feature #17055: Allow suppressing uninitialized instance variable and method redefined verbose mode warnings
tenderlovemaking (Aaron Patterson) wrote in #note-14:
> jeremyevans0 (Jeremy Evans) wrote in #note-13:
> > As you'l...
jeremyevans0 (Jeremy Evans)
04:48 PM Feature #17055: Allow suppressing uninitialized instance variable and method redefined verbose mode warnings
jeremyevans0 (Jeremy Evans) wrote in #note-13:
> As you'll see by the benchmark, the reason the performance differen...
tenderlovemaking (Aaron Patterson)
04:30 PM Feature #17055: Allow suppressing uninitialized instance variable and method redefined verbose mode warnings
Eregon (Benoit Daloze) wrote in #note-12:
> jeremyevans0 (Jeremy Evans) wrote in #note-11:
> > The last time I did ...
jeremyevans0 (Jeremy Evans)
11:22 AM Feature #17055: Allow suppressing uninitialized instance variable and method redefined verbose mode warnings
jeremyevans0 (Jeremy Evans) wrote in #note-11:
> The last time I did testing on this in Sequel, the performance decr...
Eregon (Benoit Daloze)
04:23 PM Bug #15773: Net::HTTP doesn't try next IP address in case of timeout
phluid61 (Matthew Kerwin) wrote in #note-5:
> benlangfeld (Ben Langfeld) wrote in #note-4:
> >
> > RFC3484 (https://...
benlangfeld (Ben Langfeld)
03:55 PM Misc #17041: DevelopersMeeting20200831Japan
* [Bug #17017] Range#max & Range#minmax incorrectly use Float end as max (dan0042)
* `(1..3.1).max` has resulted i...
Dan0042 (Daniel DeLorme)
10:46 AM Revision 1d637b1f (git): [ruby/weakref] Use Gemfile instead of Gem::Specification#add_development_dependency.
https://github.com/ruby/weakref/commit/10d547ba12 hsbt (Hiroshi SHIBATA)
10:42 AM Revision 9e93596d (git): [ruby/ostruct] Drop to Ruby 2.4
https://github.com/ruby/ostruct/commit/00e8fe3df2 hsbt (Hiroshi SHIBATA)
10:29 AM Feature #17100: Ractor: a proposal for a new concurrent abstraction without thread-safety issues
First of all, thanks a lot for your work. This is a huge (and incredibly valuable) addition to Ruby.
I have your b...
ibylich (Ilya Bylich)
10:18 AM Feature #17100: Ractor: a proposal for a new concurrent abstraction without thread-safety issues
Note: I updated my questions on Redmine based on rereading https://github.com/ko1/ruby/blob/ractor_parallel/doc/racto... Eregon (Benoit Daloze)
09:49 AM Feature #17100: Ractor: a proposal for a new concurrent abstraction without thread-safety issues
Looking forward to this.
I have a few questions.
* Reactor#recv/Channel#recv => Reactor#receive/Channel#receive. I d...
Eregon (Benoit Daloze)
05:54 AM Feature #17100 (Closed): Ractor: a proposal for a new concurrent abstraction without thread-safety issues
# Ractor: a proposal for a new concurrent abstraction without thread-safety issues
## Abstract
This ticket prop...
ko1 (Koichi Sasada)
09:56 AM Revision 85dc5708 (git): [ruby/net-http] Fix SSL session reuse test with LibreSSL 3.2+
https://github.com/ruby/net-http/commit/5ae9620fbc jeremyevans (Jeremy Evans)
09:55 AM Revision 20eb9e98 (git): [ruby/net-http] Switch invalid server name format
invalid_servername is not a valid name in an SSL request due to
the use of the underscore, and LibreSSL 3.2.0 will ra...
jeremyevans (Jeremy Evans)
09:30 AM Revision e732d376 (git): [ruby/cgi] Drop to Ruby 2.4
https://github.com/ruby/cgi/commit/8a86536e94 hsbt (Hiroshi SHIBATA)
08:52 AM Revision 3ec860ae (git): net-ftp is under `lib/net` instead of `lib/net/ftp`
hsbt (Hiroshi SHIBATA)
08:40 AM Revision 2346e2f0 (git): Followed up b2d96abb42abbe2e01f010ffc9ac51f0f9a50002 for net-ftp.
hsbt (Hiroshi SHIBATA)
01:25 AM Bug #16695: Stack consistency error when using the return value
Oops, my patch is duplicated at 43c1eb440a7 == r61618 partially so I must revert it at first.
```diff
diff --git ...
wanabe (_ wanabe)
 

Also available in: Atom