Activity
From 08/20/2020 to 08/26/2020
08/26/2020
-
08:43 PM Bug #17030: Enumerable#grep{_v} should be optimized for Regexp
- What about this?
```ruby
2.times do
p $~ # depends on match *below*
rx =~ str
end
```
Now imagine if ... -
07:31 PM Bug #17030: Enumerable#grep{_v} should be optimized for Regexp
- Dan0042 (Daniel DeLorme) wrote in #note-15:
> But static analysis has other limits
Good example but it is easily ... -
- > Couldn't static analysis of the code determine in most cases if match data need be generated or not?
scivola20 h... -
- fatkodima (Dima Fatko) wrote in #note-13:
> In many cases, probably yes, but again, `case-when`, when arguments/cons... -
05:01 PM Bug #17030: Enumerable#grep{_v} should be optimized for Regexp
- marcandre (Marc-Andre Lafortune) wrote in #note-12:
> Maybe it would be best to start a different thread as none of t... -
- Couldn't static analysis of the code determine in most cases if match data need be generated or not?
This is Ruby,... -
- sawa (Tsuyoshi Sawada) wrote in #note-10:
> I feel scivola20 (sciv ola)'s idea promising, but have a concern that it ... -
08:27 PM Bug #17048: Calling initialize_copy on live modules leads to crashes
- Yes, nobu's patch fixes the crash. It is technically a breaking change though, so maybe it needs approval from Matz?
... -
06:11 PM Bug #17131: Time.at(time) != time in certain cases
- The check for `to_int` in addition to `to_r` is deliberate. The related code comment states: `test to_int method ava...
-
05:49 PM Bug #17131 (Closed): Time.at(time) != time in certain cases
- ## Problem
According to the [spec](https://github.com/ruby/ruby/blob/445e5548c9da906a2d7a490e660328b2893d07d1/spec... -
- Pull request submitted: https://github.com/ruby/ruby/pull/3458
-
- Method#super_method currently does not work correctly for aliased methods. Here's a simple example:
```ruby
clas... -
- I'm able to reproduce this issue on Windows (`ruby 2.7.0p0 (2019-12-25 revision 647ee6f091) [x64-mingw32]`), but not ...
-
12:36 PM Revision 445e5548 (git): Fixed error messages at non-ascii %string terminator
-
-
09:05 AM Feature #17127: Some TrueClass methods are faster if implemented in Ruby
- these method able to speeding up implemented by Ruby code.
- `TrueClass#^`
- `TrueClass#&`
benchmark:
```yaml
benc... -
08:40 AM Misc #17041: DevelopersMeeting20200831Japan
- The meeting was postponed to the next Monday (31th Aug.) for some reason.
-
01:16 AM Misc #17041: DevelopersMeeting20200831Japan
- * [Feature #16812] Allow slicing arrays with ArithmeticSequence (mrkn)
* I found the wrong test case, so the imple... -
08:39 AM Bug #17129: bundle install `eventmachine` and `sassc` fails since 914b2208ab3eddec478cdc3e079e6c30d0f0892c
- It only reproduces with Ruby using`rubylang/ruby:master-nightly-bionic`.
It does not reproduce ruby installed by `rb... -
08:10 AM Bug #17129: bundle install `eventmachine` and `sassc` fails since 914b2208ab3eddec478cdc3e079e6c30d0f0892c
- Is there a way for me to get the `config.log` which has to be created during compiling ruby itself? It must contain ...
-
- bundle install `eventmachine` and `sassc` fails since 914b2208ab3eddec478cdc3e079e6c30d0f0892c
Ruby on Rails CI ag... -
07:43 AM Feature #17104: Do not freeze interpolated strings when using frozen-string-literal
- Non-freezing interpolated strings is good thing to reduce allocations.
I think it is possible if most developers und... -
07:30 AM Feature #17125: Remove Thread.exclusive
- We checked gems which use this API and they look obsoleted.e
We should check the impact with preview.
Go ahead -
- It looks implementation detail and concurrent gems already supports new headers.
Go ahead -
06:35 AM Feature #17122: Add category to Warning#warn
- If we can accept the compatibility issue, I support it.
However, I'm not sure the "category" is a last attribute, so... -
- We discussed about it and I recognized the motivation is how to shorten the migration period (to reuse conflicts feat...
- 05:28 AM Revision 72cb9bc5 (git): [webrick][DOC] Describe the stance of WEBrick about its security and utilization (#3457)
- WEBrick is not recommended for the production use. We need to explicitly
describe this fact in the document to avoid... -
- Gauche scheme interpreter has same issue and Kawai-san (the author of Gauche) investigate it.
http://blog.practica...
08/25/2020
-
11:37 PM Bug #17030: Enumerable#grep{_v} should be optimized for Regexp
- I feel scivola20 (sciv ola)'s idea promising, but have a concern that it is going to introduce the same kind of mess ...
-
- I have implemented a simple PoC - https://github.com/ruby/ruby/pull/3455.
I got the following results.
## Enume... -
- I like @scivola20 's idea and would like to try to implement it.
Before starting, @nobu, wdyt, is this something tha... -
- - [Feature #14723] python's buffer protocol clone (mrkn)
- I renamed `buffer` to `memory_view`.
- This na... -
-
- I think this was fixed by commit:92b2d5816ae04375cef7e3909bf69954e1833160.
-
- The pull request was merged (https://github.com/ruby/io-console/pull/16), so this can be closed.
-
09:09 PM Revision a84a2e87 (git): Comply with guide for method doc: hash.c (#3454)
- Methods reviewed (a few not modified):
key
delete
shift
delete_if
reject!
reject
slice
... -
05:50 PM Revision 92b2d581 (git): Add documentation to "dcompact" callback and "parent" member
-
05:14 PM Revision 326d89b7 (git): Correctly account for heap_pages_final_slots so it does not underflow
- `rb_objspace_call_finalizer` creates zombies, but does not do the correct accounting (it should increment `heap_pages...
- 03:47 PM Revision 8c030b5c (git): * 2020-08-26 [ci skip]
-
- Methods:
::new
::[]
::try_convert
#rehash
#[]
#fetch
#default
#default=
#default... -
12:17 PM Revision 2e3a7f70 (git): Promote nkf to default gems
- 09:11 AM Revision 8d68f54c (git): Fix erb executable
- Run ERb processing unconditionally since __FILE__ and $0 doesn't match
in a gem context.
08/24/2020
-
-
11:11 PM Bug #17094 (Closed): PTY methods with blocks
- Applied in changeset commit:git|9e25eb308d4fae9a10e120c2b4601916cc38336c.
----------
Update PTY.open documentation t... - 11:11 PM Revision 1b34d843 (git): * 2020-08-25 [ci skip]
-
- For a regular block, accepting two arguments is fine as the array
will be autosplatted. However, a lambda that acce... -
- I've added a pull request with a fix for this: https://github.com/ruby/ruby/pull/3452
-
- The enabled-by-default deprecation warnings have following effects.
- Good Effect: It makes developers more aware of... -
- +1
I think this is more important than having a general Set syntax as discussed in #5478. Being able to use `%ws[fo... -
- > matz: Positive to introduce Set into core. But we need to first introduce a set literal. { x, y, z } is good, but J...
-
- That's great news.
Was there discussion for a *frozen* set literal of symbols / strings as I proposed in #16994? F... -
- We discussed this issue at the last-month meeting.
https://github.com/ruby/dev-meeting-log/blob/master/DevelopersM... -
- k0kubun (Takashi Kokubun) wrote in #note-3:
> off topic: If you write an entire ticket in English, I think you shoul... -
- Dan0042 (Daniel DeLorme) wrote in #note-37:
> > I thought that this would be a useful substitute of symbol-key Hash ... -
- > I thought that this would be a useful substitute of symbol-key Hash (like JSON data) which we can read the values b...
-
- 👍
I'd like to have optional `start` and `stop` arguments for `find_index`, `find`, `bsearch` and `bsearch_index`.
... -
-
07:35 AM Feature #17103: Add a :since option to ObjectSpace.dump_all
- > this feature strongly connected with trace_object_allocations, right?
Indeed.
> so please write it on documen... -
- this feature strongly connected with `trace_object_allocations`, right? so please write it on document.
what happens... -
06:58 AM Revision cb7634c1 (git): Fix links [ci skip]
-
-
- Without the patch:
```ruby
require "digest"
p Digest::SHA256 #=> Digest::SHA256
p Digest::SHA2 #=> Digest::SH...
08/23/2020
-
09:07 PM Feature #6309: Add a reference queue for weak references
- This still seems like a good idea. Any update?
- 05:10 PM Revision f292bb24 (git): * 2020-08-24 [ci skip]
-
- Further compliance with https://github.com/ruby/ruby/blob/master/doc/method_documentation.rdoc#details-and-examples-
-
- 12:46 PM Revision 4f7ff9c9 (git): * 2020-08-23 [ci skip]
-
- Added some cross compilers that we can run on GitHub Workflow runner
environments. Because they are cross compilers ... -
- > > When it comes to optimization, though, I would assume that the keywords are all symbols would open a lot more doo...
08/22/2020
-
09:59 AM Bug #16853: calling bla(hash, **kw) with a string-based hash passes the strings into **kw (worked < 2.7)
- FWIW I also find the `where("table.id" => 42)` example unconvincing.
That could work just fine with `def where(condi... -
- sylvain.joyeux (Sylvain Joyeux) wrote in #note-9:
> Keyword splat would not allow anything but symbols as keys pre-2... -
- They are rather annoying than being useful to us.
-
02:54 AM Feature #15974: Warn in verbose mode on defining a finalizer that captures the object
- A partial solution to this but with a better implementation is at https://github.com/ruby/ruby/pull/3444.
-
- It seems `clang --save-temps` does not interface well with
tool/update-deps. Prefer gcc for that purpose. -
- STRIP now depends on compilers, not on OS. Previous check against
$target_os does no longer work. -
- https://rubyci.org/logs/rubyci.s3.amazonaws.com/freebsd12/ruby-master/log/20200821T223002Z.fail.html.gz
```
process.c...
08/21/2020
-
- Applied in changeset commit:git|a0273d67d044dc9fe25313e0854a33374b990e8a.
----------
Avoid a use after free in VM as... -
- I think I've found a solution. If the thread for the EC has been killed, then don't check that the VM pointer matche...
-
- If the thread for the current EC has been killed, don't check
the VM ptr for the EC (which gets it via the thread), a... -
- "Trivial" typically means "returns a new empty Array."
-
08:37 PM Bug #16853: calling bla(hash, **kw) with a string-based hash passes the strings into **kw (worked < 2.7)
- > If there is a call like foo(**h), and h has both Symbol and non-Symbol keys, in <2.7 the Hash is "split" which I fi...
-
06:37 PM Feature #17127: Some TrueClass methods are faster if implemented in Ruby
- off topic: If you write an entire ticket in English, I think you should post your ticket to ruby-core to attract more...
-
- Most of the CI issues were when running with asserts, so I compiled with asserts enabled and ran tests. It took quit...
-
- * Remove nil-return examples from hash.c
-
03:54 PM Bug #17128: test_io_console.rb fails on actual console
- Jeremy, thank you for the suggestion! I will do that now.
-
- leam (Leam Hall) wrote in #note-1:
> I have opened Bug 17128, to handle an edge case in a test. I have
> working ... -
- I have opened Bug 17128, to handle an edge case in a test. I have
working code to fix the issue, but am still lear... -
- When running "make test-all TESTS=io/console/test_io_console" on the current Ruby source, the following error is gene...
-
- CI failures observed for old Sun C++. We don't want to hustle, as newer
versions are okay. Just check the sanity an... -
- AC_PROG_CC_C99 calls AC_PROC_CC, which calls _AC_PROG_CC_G, which sets
default CFLAGS, whose contents are not customi... - 03:33 PM Revision 7263fd6f (git): * 2020-08-22 [ci skip]
-
- `llvm-strip-7` is a sane valid strip command that LLVM 7 ships, albeit
it does not understand `--version`. It is a b... -
02:22 PM Feature #17016: Enumerable#accumulate
- I'd like to propose that we name this method `#accumulate`. @matz do you think that is an acceptable name?
-
-
-
-
-
- At first, I misunderstood this feature. I thought that this would be a useful substitute of symbol-key Hash (like JS...
-
- In case of cross-compilation, GCC might provide its own linker. Its
behaviour seems slightly different from that of ... -
- Caused CI failures on environments without sane C++ compilers.
-
- Historically `$program_transform_name` has been put in front of
`AC_CANONICAL_TARGET`. Previous commit changes it, w... -
- These days as link-time optimisations spread accross compilers, they
tend to ship their own version of ld, ar, etc. ... -
- Because we check HAVE_STMT_AND_DECL_IN_EXPR in configure, it is peoven
to work in C. But C++ situation can be differ... -
- I found a way to suppress particular kind of warnings via pragmas.
-
- Oracle Developer Studio's C++ preprocessor started to understand
__has_cpp_attribute since version 12.5, and is broke... -
08/20/2020
- 05:10 PM Revision 6ba038af (git): * 2020-08-21 [ci skip]
-
- Removes references to *-convertible thingies.
-
02:48 PM Feature #16986: Anonymous Struct literal
- ko1 (Koichi Sasada) wrote in #note-34:
> how about `%struct{a: 1, b: 2}` (and `%value{...}` if needed)?
> (znz-san'... -
- Some TrueClass methods are faster if implemented in Ruby code.
like this.
```ruby
class TrueClass
def to_... -
- > About raw fds, I don't think we necessarily need to deprecate C APIs, the conversion fd->IO could be done in C (whe...
-
- Here is new PR:
https://github.com/ruby/ruby/pull/3434
> [NEED TO CHANGE] doc/fiber.rdoc
We will update it.
> [NE... -
- I hadn't thought of `method /a /x` or `method /a /<newline>other_method`, indeed.
This warning is only there when ... -
- In your example, `/[a-z]` looks very likely a regexp because of `[`, but how about `/a`?
Or `match? /(a` ...lines...... -
- Removes references to *-convertible thingies.
-
-
08:14 AM Bug #17126: String#gsub fails to escape single quote for shell
- Got it. I missed that completely in the documentation, thinking it wasn't related to our use of `\'`.
Thanks a lo... -
07:44 AM Bug #17052: Ruby with LTO enabled has issues with SIGSEGV handler
- vo.x (Vit Ondruch) wrote in #note-4:
> Thank you for the investigation. There is a whole thread on Fedora devel mail... -
- Thank you for the investigation. There is a whole thread on Fedora devel mailing list:
https://lists.fedoraproject... -
- Meanwhile it can not be a bad idea for us to avoid SEGV even when DWARF is broken.
-
- Yes I can reproduce this on my machine.
```
% LC_ALL=C gdb --args ./miniruby -e'Process.kill("SIGSEGV",$$)'
GNU ... -
04:24 AM Revision 6509652c (git): Skip irb/test_history on Windows too
-
-
03:21 AM Bug #16680: Symlink folder in $LOAD_PATH does not work with autoload
- nobu (Nobuyoshi Nakada) wrote in #note-6:
> I can't reproduce it with the master.
> I could reproduce it with 2.7...
Also available in: Atom