Activity
From 07/09/2021 to 07/15/2021
07/15/2021
-
08:40 PM Feature #17795: Around `Process.fork` callbacks API
- > Please propose other good name candidates.
Maybe `Process.forkpid`? -
- @mame did you mean to close the ticket?
-
07:47 AM Feature #17795 (Closed): Around `Process.fork` callbacks API
- Applied in changeset commit:git|645616c273aa9a328ca4ed3fceac8705e2e036cd.
----------
process.c: Call rb_thread_atfor... -
- Discussed at today's dev-meeting.
* @akr agreed with the API design of `Process._fork_`
* As above, @matz dislike... -
07:18 AM Feature #17795: Around `Process.fork` callbacks API
- I considered the idea of overriding `_fork_` method. The idea itself sounds reasonable but `_fork_` is not a good nam...
-
06:07 PM Feature #3187: Allow dynamic Fiber stack size
- nerdrew (Andrew Lazarus) wrote in #note-22:
> Is this request still being considered?
I consider this issue (and ... -
06:04 PM Feature #3187: Allow dynamic Fiber stack size
- Is this request still being considered?
-
05:05 PM Bug #17757 (Closed): Hash#slice does not keep compare_by_identity on the results
- Applied in changeset commit:git|95f8ffa5f6c70aa9383e1f6db02b22707c183402.
----------
Copy hash compare_by_identity s... -
- Yes, we must keep `compare_by_identity` status for those methods. Accepted.
Matz.
-
- This makes the compare_by_identity setting always copied
for the following methods:
* except
* merge
* reject
* sele... -
- Applied in changeset commit:git|fa87f72e1e84e2b55516be188f00434a683b924c.
----------
Add pattern matching pin suppor... -
- Sounds reasonable. Accepted.
Matz.
-
- Pin matching for local variables and constants is already supported,
and it is fairly simple to add support for these... -
04:55 PM Revision f1035248 (git): [ruby/irb] Show code page by irb_info on Windows
- https://github.com/ruby/irb/commit/6160d74199
-
- https://github.com/ruby/irb/commit/085ac42947
-
03:49 PM Bug #18011: `Method#parameters` is incorrect for forwarded arguments
- nobu (Nobuyoshi Nakada) wrote in #note-10:
> `Method#ruby2_keywords?` may be needed, I guess.
It's possible to de... -
02:35 PM Bug #18011: `Method#parameters` is incorrect for forwarded arguments
- Changing `parameters` broke rbs test.
https://github.com/nobu/ruby/runs/3076547487?check_suite_focus=true#step:15:... -
- Sounds reasonable. Accepted.
Matz.
-
03:49 PM Bug #18014 (Closed): Memory leak in GC when using Ractors
- Applied in changeset commit:git|119697f61e2b2b157816a8aa33aada5863959900.
----------
[Bug #18014] Fix rb_gc_force_re... - 03:49 PM Revision feec80a3 (git): * 2021-07-16 [ci skip]
-
- This commit adds an assertion has been added after `gc_page_sweep` to
verify that the freelist length is equal to the... -
- When a Ractor is removed, the freelist in the Ractor cache is not
returned to the GC, leaving the freelist permanentl... -
- If we force recycle an object before the page is swept, we should clear
it in the mark bitmap. If we don't clear it i... -
-
-
11:50 AM Bug #18007: Help developers of C extensions meet requirements in "doc/extension.rdoc"
- Naruse, thank you for your time.
Would you consider for 3.1 if this change was behind a configuration option that ... -
09:07 AM Bug #18007: Help developers of C extensions meet requirements in "doc/extension.rdoc"
- I want Ruby 3.1 to be compatible with 3.0. Therefore even if it is accepted, you can merge this in 3.2.
-
-
09:15 AM Feature #18008 (Closed): `keyword_init?` method for Struct
- Applied in changeset commit:git|1a637544166eca6b917fb6f32baeb771f4914b7a.
----------
struct.c: Add keyword_init? sin... -
- hkdnet's patch is https://github.com/ruby/ruby/pull/4609
-
- Accepted.
Matz.
-
- Fixes [Feature #18008]
-
- Sounds OK. Let's try it.
Matz.
-
07:54 AM Revision 3ce2bf4d (git): rb_interned_id_p: does not exist
- This declaration was added at commit 0ee5a49dd4ffbbb285c25fa6cba88370ce9
without its implementation. Must be a mista... -
- This declaration was added at commit 0ee5a49dd4ffbbb285c25fa6cba88370ce9
without its implementation. Must be a mistake. -
- All occurrences of rb_fork_ruby are followed by a call rb_thread_fork in
the created child process.
This is refactor... -
07:16 AM Revision 8f62f12c (git): Fix typo in flag in NEWS.md
-
06:46 AM Feature #17938: Keyword alternative for boolean positional arguments
- matz (Yukihiro Matsumoto) wrote in #note-12:
> Although I agreed with the idea of adding keyword arguments correspond... -
- Although I agreed with the idea of adding keyword arguments corresponding to boolean flags, I don't like the above na...
-
- I think it can be fixed by removing the optimization in the parser and leaving it to the compiler.
-
- I agree with @marcandre. We need no fix here.
Matz.
-
05:18 AM Feature #17994: Clarify `IO.read` behavior and add `File.read` method
- I feel adding File.read method is uselessly complex behavior:
Socket.read (no pipe) inherits IO.read (support pipe) ... -
04:10 AM Bug #17666: Thread#join hangs when Fiber.set_scheduler is set
- I don't have enough time to see details of the request just now. I filled the Backport field to recall myself to this...
-
01:57 AM Bug #17666: Thread#join hangs when Fiber.set_scheduler is set
- I think we should consider isolating this for backport to 3.0.3 if possible.
This three lines:
https://github.com/r... -
- 12:26 AM Revision 0d74ddc5 (git): * 2021-07-15 [ci skip]
-
- Even when the path which was used to dlopen may be a symlink.
07/14/2021
-
11:54 PM Bug #18031: Nested TracePoint#enable with define_method target crashes
- I don't think the overriding behavior is intentional, since it doesn't happen for other kinds of targets.
There is a... -
11:47 PM Bug #13671: Regexp with lookbehind and case-insensitivity raises RegexpError only on strings with certain characters
- Eregon (Benoit Daloze) wrote in #note-12:
> It seems ruby master as of today still uses Onigmo 6.1.3, but https://gi... -
- It seems ruby master as of today still uses Onigmo 6.1.3, but https://github.com/k-takata/Onigmo/releases/tag/Onigmo-...
-
- * [Bug #13671] Regexp with lookbehind and case-insensitivity raises RegexpError only on strings with certain characte...
-
- - [Feature #17837] Add support for Regexp timeouts (Sam Saffron)
- I support looking more closely at Nobu's patch.... -
-
- nobu (Nobuyoshi Nakada) wrote in #note-22:
> I made a patch for `Regexp#backtrack_limit=`.
> This seems no signific... -
11:52 AM Bug #18038 (Closed): Invalid interpolation in heredocs
- Given code as followed:
``` ruby
var = 1
v1 = <<~CMD
something
#{"/#{var}"}
CMD
v2 = <<~CMD
somet... - 09:56 AM Revision 67897762 (git): [ruby/fiddle] Add Fiddle::Handle#file_name (https://github.com/ruby/fiddle/pull/88)
- https://github.com/ruby/fiddle/commit/4ee1c6fc4b
-
- https://github.com/ruby/fiddle/commit/c5abcc3a7e
- 09:43 AM Revision 818c74b7 (git): [ruby/fiddle] Return the module handle value in Fiddle::Handle#to_i and add FIddle::Handle#to_ptr (https://github.com/ruby/fiddle/pull/87)
- https://github.com/ruby/fiddle/commit/170111a0cb
-
04:18 AM Bug #16654 (Closed): Segfault in rb_str_hash
-
03:14 AM Bug #16654: Segfault in rb_str_hash
- I was able to reproduce this on an old app I inherited. It's not an issue in ruby itself, rather the issue seems to b...
- 01:48 AM Revision 57a743ef (git): * 2021-07-14 [ci skip]
-
01:48 AM Revision 896bbb9f (git): Merge RubyGems/Bundler master from 8459ebd6ad65ce3397233416dc64083ae7572bb9
-
- @eregon thanks for the feedback.
The flags are more efficient and for the current design they are mostly implementat...
07/13/2021
-
01:55 PM Bug #17788 (Closed): ruby 3.0.0 - compiling c++ extension on alpine fails
- Applied in changeset commit:git|29f6f79e7396018962eb25c5f5e409f5fe28a73b.
----------
Get `ruby_nonempty_memcpy` to h... -
- Fixes [Bug #17788]
-
01:20 PM Misc #17997: DevelopersMeeting20210715Japan
- * [Feature #17795] Around `Process.fork` callbacks API (dan0042)
* After a few meetings without a decision, can we... -
-
- https://github.com/ruby/irb/commit/759be5a344
-
- https://github.com/ruby/fiddle/commit/93f9564446
-
- https://github.com/ruby/error_highlight/commit/8273d3b6f2
-
- Drop supports for old versions, keeping 2.5 as CI supports it for
now.
https://github.com/ruby/fiddle/commit/90634e7c55 - 10:37 AM Revision bb868f48 (git): [ruby/fiddle] Use have_header and have_type to detect memory view availability
- Fix https://github.com/ruby/fiddle/pull/84
It may detect ruby/memory_view.h for system Ruby that is installed in
/us... -
10:37 AM Revision 5c0d8c63 (git): [ruby/fiddle] Add "offsetof" to Struct classes (https://github.com/ruby/fiddle/pull/83)
- * Add "offsetof" to Struct classes
I need to get the offset of a member inside a struct without allocating
the struc... - 10:37 AM Revision a2c9e1b5 (git): [ruby/fiddle] Bump version
- https://github.com/ruby/fiddle/commit/049138b4b8
- 10:37 AM Revision 70b03186 (git): [ruby/fiddle] MemoryView: ensure reset rb_memory_view_t::obj on error
- https://github.com/ruby/fiddle/commit/0ed39345fe
- 10:37 AM Revision 9f86e50e (git): [ruby/fiddle] StringValuePtr may change the val
- https://github.com/ruby/fiddle/commit/bddca7c895
- 10:37 AM Revision 10e26cfa (git): [ruby/fiddle] Add MemoryView.export and MemoryView#release (https://github.com/ruby/fiddle/pull/80)
- fix https://github.com/ruby/fiddle/pull/79
Users can release memory views explicitly before process exit.
Reported ... - 10:37 AM Revision 9988f6ac (git): [ruby/fiddle] Add Fiddle::MemoryView#to_s (https://github.com/ruby/fiddle/pull/78)
- Fix https://github.com/ruby/fiddle/pull/74
Reported by dsisnero. Thanks!!! - 10:37 AM Revision 8c905349 (git): [ruby/fiddle] test: fix SetLastError's input type
- https://github.com/ruby/fiddle/commit/ca5e6a0404
- 10:37 AM Revision 37d16bb9 (git): [ruby/fiddle] test: use double quote for string literal
- https://github.com/ruby/fiddle/commit/fab7eab95b
- 10:37 AM Revision 5516d74a (git): [ruby/fiddle] test: add a test for win32_last_socket_error
- https://github.com/ruby/fiddle/commit/c86cec03cd
- 10:37 AM Revision 303ab5da (git): [ruby/fiddle] test: add missing receiver
- https://github.com/ruby/fiddle/commit/1da3b4af16
- 10:37 AM Revision d1eeb9fe (git): [ruby/fiddle] windows: use GetLastError() for win32_last_error
- Ruby: [Bug #11579]
Patch by cremno phobia. Thanks!!!
https://github.com/ruby/fiddle/commit/760a8f9b14 - 10:37 AM Revision c0f9191a (git): [ruby/fiddle] Bump version
- https://github.com/ruby/fiddle/commit/3784cfeec4
-
-
- API-wise: integer flags feel not so Ruby-like. How about symbols instead?
Or are those flags only meant to be used f... -
-
- https://github.com/ruby/error_highlight/commit/9d671284cb
-
- Now, the highlight line is created by replacing non-tab characters with
spaces, and keeping all hard tabs as-is. This... - 07:28 AM Revision b18f6fff (git): * 2021-07-13 [ci skip]
- 07:28 AM Revision 9df712a0 (git): Expose `rb_obj_is_fiber`.
07/12/2021
-
04:30 PM Bug #18002: s390x: Tests failing without LC_ALL env
- Here is the status under the `/tmp/rubytest1` (`tmpdir`).
```
ruby01|s390x$ unset LC_ALL
ruby01|s390x$ ls -l /tm... -
- > ```
> $ make test-all TESTS="-v test/ruby/test_file.rb -n TestFile#test_realpath_encoding"
> ```
For the 1st f... -
- The feature index arrays seems to ignore the priority of file types.
-
10:28 AM Bug #17664: Behavior of sockets changed in Ruby 3.0 to non-blocking
- > I missed some functions in io.c which could invoke read. That's why read was showing up.
Sorry, this tripped me ... -
- I was playing around with a larger number of connections and the deferred submit:
```
io_write:Event_Backend_fibe... -
- Here is `DirectScheduler`:
```
Running 30s test @ http://localhost:9090
4 threads and 128 connections
Thread Sta... -
- I rewrote the `uring` implementation to track the number of pending operations. I'm kind of surprised that the SQ doe...
-
- I missed some functions in `io.c` which could invoke `read`. That's why `read` was showing up. Now that's been patche...
-
- https://github.com/ruby/error_highlight/commit/2fc70d7f8e
-
- See https://github.com/ruby/error_highlight/issues/4
https://github.com/ruby/error_highlight/commit/c20efd3961 -
- I have successfully tested upgrading to Unicode 14.0.0 with the beta release data, and reported this back to the Unic...
-
- Unicode Version 14.0.0 is currently in beta. See the announcement at https://home.unicode.org/unicode-14-0-beta-revie...
- 07:16 AM Revision 028441d2 (git): Avoid calling `fstat` on things we already know are valid sockets.
-
05:50 AM Feature #17039 (Closed): Remove Time#succ
- Removed at commit:7817a438eb1803e7b3358f43bd1f38479badfbdc
-
05:19 AM Misc #18025: rb_iterate is obsolete since 1.9 but is not marked as deprecated for C compilers
- +1
- 04:45 AM Revision 0895d57d (git): * 2021-07-12 [ci skip]
-
07/11/2021
-
- nagachika (Tomoyuki Chikanaga) wrote in #note-11:
> The multiple GitHub Actions environments show the failure of mak... -
- > My understanding is sockets are buffered, so normally you'll see EAGAIN only if you saturate them.
For `write` t... -
- > In my testing, comparing `io_uring` `io_read` and `io_write` operations, perform about 20% worse in practice in my ...
-
- Here are some summaries from `strace -c`:
Using non-blocking sockets (note the errors column which indicates EAGAIN)... -
- I have researched this topic today and I'm going to share some of my notes and thoughts.
Firstly, with regards to pe... -
- https://github.com/ruby/date/commit/404f9d2096
-
- Fixes [Bug #17945]
https://github.com/ruby/date/commit/953d907238 -
-
- This file contains extended assertions for ruby core which do not
belong to test/unit. -
09:26 AM Revision b32ae989 (git): Move rb_str_escape function declaration
-
- It is a different thing from single '/' on Windows, like drive letters.
07/10/2021
- 09:12 PM Revision e330bbee (git): * 2021-07-11 [ci skip]
-
- Co-authored-by: Nobuyoshi Nakada <[email protected]>
https://github.com/ruby/irb/commit/b431742430 -
- When fiddle is not avaiable, reline/terminfo depending on it also
fails. -
-
- ```
user system total real
Time.iso8601 0.006919 0.000185 0.007104 ( 0.00... -
- Undefine LIST_HEAD from BSD-origin sys/queue.h.
-
- 04:44 AM Revision 9c285150 (git): * 2021-07-10 [ci skip]
-
- This fixes at least an issue where irb will incorrectly assume
code opens a heredoc when it does not, such as this co... -
- Add notes about buffer allocation.
-
01:20 AM Bug #15856: Performance of redundant `Kernel.require` is slow when many gems are activated
- We've still been using the David Rodriguez patch with no reported issues around it for the past ~2 years or so.
It... -
- I've submitted a pull request to fix this crash: https://github.com/ruby/ruby/pull/4640
I noticed two other issues...
07/09/2021
-
- One of the testing scripts (`test/ruby/enc/test_emoji_break.rb`) that the version declared internally in a data files...
-
- This was merged and basic testing seems to work well. More evaluation is required.
-
- inversion (Yura Babak) wrote in #note-8:
> jeremyevans0 (Jeremy Evans) wrote in #note-7:
> > This appears to be fix... -
11:12 AM Bug #15993: 'require' doesn't work if there are Cyrillic chars in the path to Ruby dir
- jeremyevans0 (Jeremy Evans) wrote in #note-7:
> This appears to be fixed starting in Ruby 2.7 (also works in 3.0):
... -
- I'm fine having `fork` raise an exception when called from non-main fiber if the pthread coroutine implementation is ...
-
- Fork is notoriously hard to use correctly and I most cases we should be encouraging `Process#spawn`. However, it does...
-
- Regarding method chains, one thing that's always bothered me a bit is this:
```ruby
def foo(*arguments)
pp object_i... -
- This is mostly just a generic comment that may not be very helpful, but I can only say that I fully agree. Even befor...
-
- Fix title.
-
- It would be good to establish some rules around mutability, immutability, frozen, and deep frozen in Ruby.
I see t... -
- ioquatix (Samuel Williams) wrote in #note-4:
> > Time.parse often results in unintentional/surprising results.
>
... -
- > Time.parse often results in unintentional/surprising results.
Can we change it so that it doesn't return unintenti... -
- ioquatix (Samuel Williams) wrote in #note-2:
> But does any other `#new` implementation work this way? Can we fix `T... -
- It looks like good improvement.
But does any other `#new` implementation work this way? Can we fix `Time#parse`? I... -
- Make `Time.new` parse `Time#inspect` and ISO-8601 like strings.
* `Time.iso8601` and `Time.parse` need an extensio... -
-
07:14 AM Bug #18032: Openstruct is ~20..25x slower with Ruby 3.0.0 and 3.0.1 compared to earlier versions
- @mame @marcandre that is unfortunate, because initializing from a hash is probably the most frequently used form.
... -
06:34 AM Bug #18032 (Rejected): Openstruct is ~20..25x slower with Ruby 3.0.0 and 3.0.1 compared to earlier versions
- @mame is correct that #15409 was a concern, but this is mainly due to #12136 and listed in the release notes for 3.0....
-
- Maybe due to this change: https://bugs.ruby-lang.org/issues/15409#note-9
> reverts lazy initialization and restore... -
- Doing some timings with different Ruby versions, I noticed that when using Ruby 3.0.0 and 3.0.1
the time to create ... -
- Okay, the PR is ready for review: https://github.com/ruby/ruby/pull/4621
Here is how it's used:
- `uring.c`: https:... -
- Does `FFI::Pointer` have locking mechanism suitable for IO? Does it have a mutability model suitable for reading and ...
-
-
- I always got a segmentation fault with `make test-all TESTS="fiddle"` and `--enable-bundled-libffi` on macOS.
http...
Also available in: Atom