Activity
From 08/11/2021 to 08/17/2021
08/17/2021
-
10:55 PM Bug #16906: Calling Thread#thread_variable? in IRB sometimes produce wrong result
- This needs to be backported to 2.7.x. It wasn't fixed in 2.7.4.
-
05:39 PM Bug #18076: ext/digest/md5/md5.c: `-Wnull-pointer-subtraction` warning by Clang 13
- Proposed patch:
```diff
--- a/ext/digest/md5/md5.c
+++ b/ext/digest/md5/md5.c
@@ -225,7 +225,7 @@
uint32_... -
05:25 PM Revision 58bd9434 (git): Replace f_boolcast with RBOOL macro
- * Move f_boolcast definination
* Remove f_boolcast macro defination
* to -
04:26 PM Misc #18082 (Open): FileUtils.remove_entry_secure has inconsistent document
- `FileUtils.remove_entry_secure` and `FileUtils.rm_r` have inconsistency about the vulnerability condition the in the ...
- 03:00 PM Revision 6a9bfa4d (git): * 2021-08-18 [ci skip]
-
- FWIW, another bug is found in `addr2line.c` (#18081), which I believe is irrevant to the issue here, though.
-
- A revised patch (from #note-17) is attached so that `abbrev_number >= 256` is handled properly, although it might be ...
-
- It turns out that `di_read_debug_abbrev_cu` in `addr2line.c` does not work correctly when `abbrev_number` is not alig...
-
- When both `.debug_rnglists` and `.debug_ranges` sections exist, `DW_AT_ranges` can refer to a wrong section, potentia...
-
01:57 PM Revision 36ae44ce (git): [ruby/date] Update zonetab.h at 2021-08-11
- https://github.com/ruby/date/commit/de7dca353f
- 12:44 PM Revision 48145282 (git): [DOC] Fix the rdoc for File::Stat#size? [ci skip]
-
- And the NULL string must be of size 0.
-
- Eregon (Benoit Daloze) wrote in #note-7:
> I'm confused, why does `Class#allocate` not simply use the alloc function... -
08:25 AM Bug #18007: Help developers of C extensions meet requirements in "doc/extension.rdoc"
- I'm confused, why does `Class#allocate` not simply use the alloc function set with `rb_define_alloc_func`?
Then ther... -
- mame (Yusuke Endoh) wrote in #note-5:
> How about raising an exception when attempting to allocate a `T_DATA` object... -
06:01 AM Bug #18007: Help developers of C extensions meet requirements in "doc/extension.rdoc"
- How about raising an exception when attempting to allocate a `T_DATA` object with the default allocator?
-
- Actually thread-local might not be enough, we'd probably want Fiber local, i.e., events which are on the same executi...
-
- mame (Yusuke Endoh) wrote in #note-7:
> Note that the second `trace.enable` does not print `#<TracePoint:line t.rb:4... -
05:24 AM Bug #16889: TracePoint.enable { ... } also activates the TracePoint for other threads, even outside the block
- mame (Yusuke Endoh) wrote in #note-7:
> `TracePoint#enable(target: :block)` does not follow events in a called metho... -
05:19 AM Bug #16889: TracePoint.enable { ... } also activates the TracePoint for other threads, even outside the block
- +1 for Jeremy #6.
I also agree `TP#enable{ ... }` should be thread-local without any options, but I don't think it... -
- `TracePoint#enable(target: :block)` does not follow events in a called method. Is this really intentional?
```
tr... -
08:15 AM Feature #17750 (Closed): Update Unicode data to Unicode Version 13.0.0
- Closed (finally) with revision 21fd83a823.
-
- Mention the update to Unicode Version 13.0.0 and Unicode Emoji
Version 13.1 in NEWS.md. This completes issue #17750. ... -
- Resolved with commit fd7f61c.
It turned out the problem was that in emoji-variation-sequences.txt, lines look like... -
- duerst (Martin Dürst) wrote:
> In particular, I'm a `puts` debugger, but `puts` debugging doesn't seem to work wel... - 07:30 AM Revision de764ae8 (git): * 2021-08-17 [ci skip]
-
07:16 AM Bug #13864: Rinda multicast test failures due to missing default route
- Thx for looking into this. I just wanted to point out that this has low importance for me, since the default route wa...
-
- The emoji data in emoji-variation-sequences.txt was not used for
in test/ruby/enc/test_emoji_breaks.rb, for unknown r... -
- One line pattern matching with a method return value with parameters which are not surrounded by parenthesis raises ...
-
05:43 AM Feature #12075: some container#nonempty?
- What about `ary.filled?` ?
It nicely pairs with empty and is not too long.
It’s also a property of the container. An... -
02:31 AM Feature #12075: some container#nonempty?
- I tend to like `ary.size > 0` more than `!ary.empty?` because the former literally has a "positive" nuance and theref...
-
- ```
building spec/ruby/optional/capi/ext/array_spec.so
lld-link: error: x64-ucrt-ruby310.dll: bad file type. Did yo...
08/16/2021
-
- Ah, I can see there is missing the `read_abstract_origin` on the backtrace.
-
- This is the GDB output:
~~~
(gdb) r
Starting program: /builddir/build/BUILD/ruby-3.0.2/miniruby -e Process.kill\... -
- Aren't there any subtle differences in GDB outputs? If fixed as intended, the value of `abstract_origin` can't get su...
-
- Thank you for looking into this.
Unfortunately, I have tried commit:git|72317b333b85eed483ad00bcd4f40944019a7c13 a... -
08:30 PM Bug #18078 (Closed): rb_fix2uint should avoid method lookup and use FIXNUM_NEGATIVE_P
- `rb_fix2uint` checks if the FIXNUM being converted overflows the `unsigned int` type. Previously this check was being...
-
07:35 PM Misc #18039: DevelopersMeeting20210819Japan
- * [Feature #18007] C extension "allocation function" check
* Should we add a config option and put in 3.1, or just ... -
- One concern for that [PR], probably may not be a matter, is closed `IO`s will no longer raise `IOError` on other `Enc...
-
11:33 AM Bug #18077 (Closed): Marshal.dump(closed_io) raises IOError instead of TypeError
- Marshal.dump is expected to raise a `TypeError` for unmarshallable objects. But closed streams raise an `IOError`:
... -
- Just FTR, Clang/LLVM `__builtin_longjmp` is broken for Sparc targets: https://bugs.llvm.org/show_bug.cgi?id=51489
-
- ```
compiling ../../../../ext/digest/md5/md5.c
../../../../ext/digest/md5/md5.c:228:17: warning: performing pointer... -
-
-
-
- On emscripten `intptr_t`, `uintptr_t`, `ptrdiff_t` and so on are
defined as `long`, but `PRIdPTR` and so on defined a... -
- Select the C source if exists, otherwise the assembler source,
instead of selecting by the coroutine type. - 12:07 AM Revision 4cc44bd8 (git): * 2021-08-16 [ci skip]
- 12:06 AM Revision f8f6d989 (git): coroutine use asm version for handful of architectures for freebsd.
08/15/2021
-
-
11:55 AM Misc #18039: DevelopersMeeting20210819Japan
- * [Feature #16182] Should `expr in a, b, c` be allowed or not? (ktsj)
* How about allowing brackets/braces to be om... -
- How about allowing brackets/braces to be omitted in one-line pattern matching?
Now that we use `=>` in one-line patte... -
- Applied in changeset commit:git|2aa6826e81ec880f5e98fa995e44fae0819be95d.
----------
Extract the wrapped value when ... -
-
- [0] => [0, *, a]
#=> [0] length mismatch (given 1, expected 2+) (NoMatchingPatternError)
Ignore test failures of...
08/14/2021
-
07:36 PM Bug #18000: have_library doesn't work when ruby is compiled with --disable-shared --disable-install-static-library
- No objection from me to drop support for the `--disable-shared
--disable-install-static-library` config. I agree with... -
- byroot (Jean Boussier) wrote in #note-6:
> But yeah I wish I could `--disable-shared` without having to ship a huge ... -
12:27 AM Bug #18000: have_library doesn't work when ruby is compiled with --disable-shared --disable-install-static-library
- > Not sure how byroot (Jean Boussier) or alanwu (Alan Wu) will feel about this approach, though.
At the very least... -
- Applied in changeset commit:git|147bdcc436c888a56f81e190d192cd9312015836.
----------
[Win32] put a space before conf... -
- Not to be concatenated with the preceding `--with-`* option.
- 03:27 PM Revision 717f0c56 (git): * 2021-08-15 [ci skip]
-
-
- Applied in changeset commit:git|72317b333b85eed483ad00bcd4f40944019a7c13.
----------
Ignore `DW_FORM_ref_addr` [Bug ... -
- Ignore `DW_FORM_ref_addr` form and other forms that are not supposed
to be used currently. -
-
- Get rid of tons of linker warnings that it could not find object
file symbol for every symbols, when targeting darwin. -
-
-
-
-
-
01:13 PM Revision 9f88135f (git): [ruby/readline-ext] Give up Editline
- https://github.com/ruby/readline-ext/commit/d924cfc1e6
-
- https://github.com/ruby/reline/commit/8b55fc8fee
-
- https://github.com/ruby/reline/commit/fa54e521da
-
- There used to be a process that did not want to be interrupted by
SIGINT, so it was trapped, but that process is no l... -
-
09:35 AM Bug #16490: mkmf.rbの非互換な変更
- 本件は少なくともRuby 2.7.3辺りでは起きなくなっていますので、チケット自体はcloseしていただいても問題ないと考えています。
> dependファイルを直してコンパイルしてみてもエラーになりますので、
これは、コンパ... -
- `depend`ファイルを直してコンパイルしてみてもエラーになりますので、tmail gem自体をもっと修正する必要があると思います。
```
tmailscanner.c:105:11: error: implicit de... -
09:10 AM Bug #16836: configure-time LDFLAGS leak into ruby pkg-config file
- Thanks for taking a look!
jeremyevans0 (Jeremy Evans) wrote in #note-1:
> According to the history, adding `DLDFL... -
08:10 AM Bug #18048: Thread#join can break with fiber scheduler unblock fails or blocks.
- I will check it.
-
08:06 AM Bug #18048: Thread#join can break with fiber scheduler unblock fails or blocks.
- I create the backport patch including 050a89543952a2c9e7c9bc938f4fdb538f6c9278 and 13f8521c630a15c87398dee0763e95f59c...
-
06:12 AM Feature #16428: Add Array#uniq?, Enumerable#uniq?
- Recently I read similar topic again elsewhere. They pointed
* in most cases we have something to do on each duplicat... -
04:20 AM Bug #18075 (Closed): Crasher using ripper + yydebug
- `method `inspect' called on unexpected T_NODE object` via the following with `-d` (see output at end):
```
#!/usr... -
08/13/2021
-
-
- Reverting the line removed from mkmf.rb in r67033 (commit:3d1c86a26f0c96a9c1d0247b968aa96e6f3c30bb) allows for the tm...
-
- According to the history, adding `DLDFLAGS` to `Libs` was a deliberate decision made back in 2010 in commit:51d25ca8c...
-
- I reviewed the mruby `presym.rake` file and was able to come up with a self contained reproducible example, which I h...
-
- nobu (Nobuyoshi Nakada) wrote in #note-4:
> We should disallow that combination, I think.
> Otherwise, should drop ... -
- We should disallow that combination, I think.
Otherwise, should drop also the headers. -
05:26 PM Revision 963f2e01 (git): Reduce the amount of false positive notifications
-
-
- This reverts commit b64f81c81729bbc248d19af01cafde88eb60fdc7.
It seems to cause a problem in --jit / --jit-wait CIs.... - 04:10 PM Revision 15c9c784 (git): * 2021-08-14 [ci skip]
-
-
02:24 PM Bug #17588: Cannot build with library path with spaces on MSVC
- I think there's an issue somewhere in the configuration for msvc, missing a space between two conf args it seems.
# ... -
- I'll try again, I'll report back. I see how your change could have fixed the enc/lib specifically indeed.
-
- I tried today with master (ac4d53bd461ff386cd45fdd484ffb6b628a251ad). So it isn't fixed by https://bugs.ruby-lang.org...
-
- jmarrec (Julien Marrec) wrote in #note-4:
> My first thing is I've noticed that if I strap --with-static-linked-ext ... -
- I am revisiting this with the latest master today.
My command has quotes, and I am not changing the `--with-openss... -
- It turns out that `DW_FORM_ref_addr` is not interpreted correctly. A patch is attached to just ignore that form (and ...
-
- Now I can reproduce this on my qemu-user-emulated powerpc64le-linux-musl environment:
```
$ powerpc64le-musl-qemu... -
- FYI, I changed the MJIT implementation in commit:ac4d53bd461ff386cd45fdd484ffb6b628a251ad to not disable JIT-ed code ...
-
- events get enabled
-
-
-
-
- Applied in changeset commit:git|573eef7c897ff938539270e605445da13093d664.
----------
Indicate the slow path of `Chec... - 05:51 AM Revision 1a169402 (git): * 2021-08-13 [ci skip]
-
- So that it will not interfere the fast path in `Check_Type`.
-
- Though this call to `rb_check_type` is just to raise an exception
and never return actually, it can return at least f...
08/12/2021
-
- I noticed that `addr2line.c` misinterpreted the size of `DW_FORM_ref_addr` as the size of an address. In fact it shou...
-
- Changing state back to open, because this is unresolved and I am repeatedly hitting this issue in various reincarnati...
-
- While it is possible to compile with only the headers, that only works if you know what the headers should contain. ...
-
06:16 PM Bug #18073: test/ruby/test_jit.rb: "error: invalid use of '__builtin_va_arg_pack ()'" on Ruby 2.7.4 on gcc 4.8.5
- jaruga (Jun Aruga) wrote in #note-4:
> I executed `git bisect` between `v2_7_3` and `v2_7_4`. And I found the follow... -
- @xtkoba thanks for the info. I confirmed the value of `CPP` on RHEL 7 autoconf version 2.69.
The following `config... -
- The problem described in #note-24 does not look like very much related to the other part. Maybe worth reopening #17052?
-
- Just testing the issue from [comment 24](https://bugs.ruby-lang.org/issues/18062#note-24) and there is not difference...
-
- I was able to reduce the `Hash.ruby2_keywords_hash?(1)` repro and report it to GCC.
It looks like we are hitting an ... -
- vo.x (Vit Ondruch) wrote in #note-26:
> BTW, In your experience, do you think trying something like [1] could help c... -
- xtkoba (Tee KOBAYASHI) wrote in #note-25:
> I would humbly advise that the `-fno-strict-aliasing` flag be appended t... -
01:31 PM Bug #17806: Bad interaction between method cache, prepend, and refinements
- Thanks @alanwu!
I forgot to watch this issue so I was never notified of your response. Sorry for the delay.
> I... -
- https://github.com/ruby/reline/commit/040d29b4c0
-
- https://github.com/ruby/irb/commit/98610236ec
-
- https://github.com/ruby/irb/commit/5a0c8dc9e6
-
- This reverts commit c66b27efbb27c6b6b410457282ac841ead1dd132.
-
-
-
02:29 AM Revision 1cdc7510 (git): RBIMPL_ATTR_DEPRECATED: enable for GCC 10.3+
- They fixed the bug.
08/11/2021
- 11:47 PM Revision e1fe209d (git): * 2021-08-12 [ci skip]
-
-
- This issue is due to a race condition because the MatchData object is passed indirectly through the backref. I've su...
-
- jaruga (Jun Aruga) wrote in #note-7:
> Seeing Debian and Ubuntu ruby packages, the "ruby" deb package depends on "ru... -
- Just for the context, this issue was triggered when looking at [1]. And as long as there is `ruby --disable-gems` as ...
-
- @vo.x I would just share how the motivation of some maintainers look like to fix this kind of issue, as I chat with s...
-
- duerst (Martin Dürst) wrote in #note-4:
> I'm not sure how strongly this is related (and I'll create a new issue if ... -
- > I'm not sure how strongly this is related (and I'll create a new issue if necessary), but when I use a very simple ...
-
- I would humbly advise that the `-fno-strict-aliasing` flag be appended to `CFLAGS` by default. See also #17540.
-
- So I have tried to get more details about the #17052:
~~~
$ gdb --args ./miniruby -e'Process.kill("SIGSEGV",$$)'
... -
- nobu (Nobuyoshi Nakada) wrote in #note-21:
> Probably a memory barrier would work.
I confirmed that the `make` an... -
- > But it's dead in the process of make test with wrong result "green".
Sorry, my mistake. The `make test` just fin... -
- Probably a memory barrier would work.
```diff
diff --git a/include/ruby/internal/value_type.h b/include/ruby/inte... -
- > Just curious, would it make sense to update the Ruby CI to test LTO? Maybe even by default? Would there be any down...
-
- Just curious, would it make sense to update the Ruby CI to test LTO? Maybe even by default? Would there be any downside?
-
- I could reproduce the segfault with the master commit:c59da370a5d, just by `Hash.ruby2_keywords_hash?(1)`.
```
* thr... -
- As https://github.com/ruby/ruby/pull/4716 itself seems to make things better at least, I merged it for now.
-
- Applied in changeset commit:git|a0a8f2abf533702b2cd96e79f700ce5b9cd94f50.
----------
Get rid of type-punning pointer... -
- Thanks Jeremy! Just confirmed that the fix in ruby_3_0 solves all the crashes and hangs we were seeing.
-
- It seems that in `configure.ac`, `AC_PROG_CC_C99` must come before `AC_PREPROC_IFELSE` to set `CPP` correctly. That i...
-
- > It should be the default, unless you set CFLAGS at the command line or as the environment variable.
As we chat, ... -
- jaruga (Jun Aruga) wrote in #note-10:
> @nobu OK. Could you provide a patch to change only from `S["CFLAGS"]="-g -O2... -
- > `${cflags}` should contain ${optflags} ${debugflags} ${warnflags} by the default.
> That means the latter CFLAGS l... -
- jaruga (Jun Aruga) wrote in #note-8:
> However the essential difference is the following part.
>
> ```
> -S["CFL... -
- This appears to have been resolved in the master branch. I ran a similar out-of-place build and ran the grep, and it...
- 01:26 PM Revision 79cc566a (git): Make during_compacting flag in GC one bit
- Commit c32218de1ba094223420a4ea017707f48d0009c5 turned during_compacting
flag to 2 bits to support the case when ther... -
-
07:59 AM Bug #16116: ruby2.6.3(x86/x64) use win32ole could not new Object, return 0x80070057
- I have the same issue with Ruby 3.0.2 and .NET COM assemblies. The problem seems to be related to how the assembly i...
-
-
- To make the meaning of assertion easier to understand,
-
-
-
-
- Because it's sometimes nil due to race condition.
-
-
-
04:41 AM Bug #12540 (Closed): test failures when SHARABLE_MIDDLE_SUBSTRING=1
- Applied in changeset commit:git|84bf4d2ce55e16a4fb51b407a8c9c79e583596b3.
----------
Term fill in String#{,l,r}strip... -
- Each of these methods calls str_modify_keep_cr before
term filling, which should ensure the backing string
uses priva... -
- 01:54 AM Revision 7560bf6f (git): * 2021-08-11 [ci skip]
Also available in: Atom