Project

General

Profile

Activity

From 05/31/2022 to 06/06/2022

06/06/2022

10:25 PM Revision cfcf33f1 (git): .github/workflows/compilers.yml: annocheck: Fix a linker flag to pass MJIT tests.
Set the linker flag `-Wl,-z,now` properly.
Co-authored-by: Takashi Kokubun <[email protected]>
Fixes [Bug #18781]
Jun Aruga
08:50 PM Revision ec354222 (git): Ignore invalid escapes in regexp comments
Invalid escapes are handled at multiple levels. The first level
is in parse.y, so skip invalid unicode escape checks...
jeremyevans (Jeremy Evans)
06:31 PM Bug #18818: Thread waitq does not retain referenced objects, can lead to use after free.
There might be a good reason we don't want to do this (or want to do it differently). But I can confirm that marking... nevans (Nicholas Evans)
04:40 PM Bug #18818: Thread waitq does not retain referenced objects, can lead to use after free.
Aha! Thanks, that makes perfect sense. And it does indeed fix it. I knew this toy scheduler wasn't *good*, and my o... nevans (Nicholas Evans)
05:18 AM Bug #18818: Thread waitq does not retain referenced objects, can lead to use after free.
@ko1 I saw this problem because fiber is not retained while waiting, because we have waiting threads but not waiting ... ioquatix (Samuel Williams)
05:17 AM Bug #18818: Thread waitq does not retain referenced objects, can lead to use after free.
Unfortunately Mutex, Queue and probably other objects don't take a reference to the waiting fiber, so your fiber is b... ioquatix (Samuel Williams)
06:17 PM Misc #18803: DevMeeting-2022-06-16
* [Feature #18788] Support passing Regexp options as String to Regexp.new (jeremyevans0)
* Do we want to add suppo...
jeremyevans0 (Jeremy Evans)
06:12 PM Revision c85d1cda (git): Fix Module#const_source_location for autoload constants with direct requires
If an autoload exists for a constant, but the path for the autoload
was required, const_source_location would return ...
jeremyevans (Jeremy Evans)
05:47 PM Revision 653e517e (git): Use bindgen to import Ruby constants wherever possible. (#5943)
Constants that can't be imported via bindgen should have
a comment saying why not.
Noah Gibbs
05:38 PM Feature #18183: make SecureRandom.choose public
One option would be to extend `Random::Formatter#alphanumeric` to have an optional "alphabet":
```ruby
def alphan...
austin (Austin Ziegler)
04:45 PM Feature #18183: make SecureRandom.choose public
My bad for not searching the old topics.
In this module, (most of) the method name describes the output, not the p...
midnight (Sarun R)
05:38 AM Feature #18183: make SecureRandom.choose public
I don't think `SecureRandom.random_string(args, len)` describes the behavior, neither.
Matz.
matz (Yukihiro Matsumoto)
04:01 AM Feature #18183: make SecureRandom.choose public
@matz The OP proposed `random_string`. What do you think about it? mame (Yusuke Endoh)
03:40 AM Feature #18183: make SecureRandom.choose public
My bad. args.sample(random: SecureRandom) is not a replacement for SecureRandom.choose(*args,len).
But still, choose...
matz (Yukihiro Matsumoto)
03:28 AM Feature #18183 (Rejected): make SecureRandom.choose public
`SecureRandom.choose(*args)` is not intuitive from my POV. Use `args.sample(random: SecureRandom)`.
Matz.
matz (Yukihiro Matsumoto)
05:38 PM Bug #18770 (Open): Inconsistent behavior of IO/StringIO's each methods when called with nil as a separator, limit and chomp: true
jeremyevans0 (Jeremy Evans)
05:38 PM Bug #18768 (Open): Inconsistent behavior of IO, StringIO and String each_line methods when return paragraph and chomp: true passed
jeremyevans0 (Jeremy Evans)
04:59 PM Revision c5475f42 (git): Fix Range#cover? returning true for beginless ranges of different types
Previously `(2..).cover?("2"..)` was false, but
`(..2).cover?(.."2")` was true. This changes it so both are false,
t...
jeremyevans (Jeremy Evans)
04:57 PM Revision 7cda7fbb (git): Add Module#undefined_instance_methods
Implements [Feature #12655]
Co-authored-by: Nobuyoshi Nakada <[email protected]>
jeremyevans (Jeremy Evans)
03:37 PM Revision b737998d (git): [ruby/fileutils] [DOC] Enhanced RDoc for FileUtils (https://github.com/ruby/fileutils/pull/78)
Treats:
::rm
::rm_f
::rm_r
::rm_rf
::remove_entry_secure
https://github.com/ruby/fileutils/commi...
burdettelamar (Burdette Lamar)
03:07 PM Revision f2f8c0b3 (git): * 2022-06-07 [ci skip]
git[bot]
03:06 PM Revision 6fc16e74 (git): [ruby/open-uri] [DOC] Fix markup for `URI.open`
* Add missing slash.
https://github.com/ruby/open-uri/commit/40023e63da
Alexander Ilyin
12:19 PM Revision 66a9e452 (git): [ruby/rdoc] Use runnable command as DUMMY_PAGER
https://github.com/ruby/rdoc/commit/fec1ab2e41 nobu (Nobuyoshi Nakada)
09:36 AM Revision ba383188 (git): [rubygems/rubygems] Unify loading `Gem::Requirement`
It was being explicitly required from `Gem::Specification` but also a
strange autoload was set for it at `Gem::Versio...
deivid (David Rodríguez)
09:19 AM Revision f4173ff2 (git): debug is the bundled gems, not default gems
hsbt (Hiroshi SHIBATA)
09:13 AM Revision 4bc7cef8 (git): [ruby/cgi] jruby support
https://github.com/ruby/cgi/commit/93326fb622 Pavel Rosický
03:52 AM Revision 5d014bcb (git): Use `sleep 0.5` for tests of GVL instrumentation API
The tests fail randomly on some platforms.
http://rubyci.s3.amazonaws.com/ubuntu/ruby-master/log/20220605T213004Z.fa...
mame (Yusuke Endoh)
03:22 AM Feature #18817 (Rejected): SecureRandom::choose is not being exposed
"choose" is named just for an internal API. We need another good name if we make it public. Continue to discuss in #1... mame (Yusuke Endoh)
03:00 AM Revision 52678296 (git): Fix a typo [ci skip]
znz (Kazuhiro NISHIYAMA)
02:40 AM Revision 93555e01 (git): * 2022-06-06 [ci skip]
git[bot]
02:30 AM Revision a56a7119 (git): Remove useless assignment always overridden
nobu (Nobuyoshi Nakada)
02:30 AM Revision d8790ecd (git): Export RbConfig::CONFIG["COROUTINE_TYPE"]
THREAD_MODEL is exported already, so this matches that. Exporting this
is simpler than inspecting configure_args and...
nevans (Nicholas Evans)
12:41 AM Bug #18790: cannot load such file -- digest (LoadError)
There is a similar issue with Red Hat Enterprise Linux 8. To install `libyaml-devel` package, it needs 'codeready-bui... yahonda (Yasuo Honda)

06/05/2022

09:39 PM Bug #18818 (Assigned): Thread waitq does not retain referenced objects, can lead to use after free.
The attached script (and/or others like it) can cause SEGV in 3.0, 3.1, and master. It has always behaved as expecte... nevans (Nicholas Evans)
10:17 AM Feature #18817 (Rejected): SecureRandom::choose is not being exposed
I read through [the doc of `SecureRandom`](https://ruby-doc.org/stdlib-3.1.2/libdoc/securerandom/rdoc/SecureRandom.ht... midnight (Sarun R)
06:18 AM Revision 5ce0be02 (git): * 2022-06-05 [ci skip]
git[bot]
05:21 AM Revision ed2dd172 (git): Use RBOOL
nobu (Nobuyoshi Nakada)
04:58 AM Feature #18159: Integrate functionality of syntax_suggest gem into Ruby
schneems (Richard Schneeman) wrote in #note-16:
> I am worried about the memory implications for enabling this by de...
nobu (Nobuyoshi Nakada)
01:17 AM Bug #18816 (Closed): Ractor segfaulting MacOS 12.4 (aarch64 / M1 processor)
Reproduction server:
```
require 'socket'
# Set based on CPU count
CONCURRENCY = 8
server = TCPServer.new(...
brodock (Gabriel Mazetto)

06/04/2022

11:32 AM Revision 5460675b (git): [ruby/rdoc] Use command array form of `IO.popen` always
So that an exception raises by non-existent command, not via shell.
https://github.com/ruby/rdoc/commit/fd94dce69d
nobu (Nobuyoshi Nakada)
07:53 AM Revision 2e6aee6e (git): [ruby/rdoc] Make all documents at the top level `extra_rdoc_files` [ci skip]
https://github.com/ruby/rdoc/commit/6b1a011243 nobu (Nobuyoshi Nakada)
07:42 AM Revision 9a7be959 (git): [ruby/rdoc] Remove `RDoc::RI::Driver#in_path?`
https://github.com/ruby/rdoc/commit/83051403d6 nobu (Nobuyoshi Nakada)
07:42 AM Revision d4c7e4d5 (git): [ruby/rdoc] Enable pager tests
https://github.com/ruby/rdoc/commit/ce63794fde nobu (Nobuyoshi Nakada)
07:42 AM Revision 323acd26 (git): [ruby/rdoc] Stop checking if pager command found
`IO.popen` does that job.
https://github.com/ruby/rdoc/commit/3bbbc5ac84
nobu (Nobuyoshi Nakada)
07:40 AM Revision 76479de1 (git): [ruby/rdoc] Remove never used win32console
https://github.com/ruby/rdoc/commit/47a1aef447 nobu (Nobuyoshi Nakada)
01:58 AM Feature #11689: Add methods allow us to get visibility from Method and UnboundMethod object.
matz (Yukihiro Matsumoto) wrote in #note-24:
> When investigating #18435, I realized the visibility of a method is n...
jeremyevans0 (Jeremy Evans)

06/03/2022

08:07 PM Feature #18159: Integrate functionality of syntax_suggest gem into Ruby
Having `SyntaxError#file_path` would be hugely helpful, there are some non-trivial edge cases I have to handle when r... schneems (Richard Schneeman)
03:05 AM Feature #18159: Integrate functionality of syntax_suggest gem into Ruby
The attribute `file_path` has been written at #note-7 and answered at #note-8 already.
The input from STDIN can be...
nobu (Nobuyoshi Nakada)
02:43 AM Feature #18159: Integrate functionality of syntax_suggest gem into Ruby
Is it useful if `SyntaxError` (or `ScriptError`) has an attribute for the failed locations?
`SyntaxError` often co...
nobu (Nobuyoshi Nakada)
05:50 PM Revision c19a842e (git): * 2022-06-04 [ci skip]
git[bot]
05:50 PM Revision e4fe3473 (git): Prevent printing crash report in a loop
In the event that we are crashing due to a corrupt Ruby stack, we might
re-enter rb_vm_bugreport() due to failed asse...
alanwu (Alan Wu)
04:42 PM Feature #16150: Add a way to request a frozen string from to_s
@matz I don't think so, the request here was for all `to_s` methods, so `Object#to_s`, `Module#to_s`, `Symbol#to_s`, ... byroot (Jean Boussier)
06:33 AM Feature #16150: Add a way to request a frozen string from to_s
Probably #18595 addresses this request. Any opinion?
Matz.
matz (Yukihiro Matsumoto)
01:14 PM Feature #18339 (Closed): GVL instrumentation API
Merged as https://github.com/ruby/ruby/commit/9125374726fbf68c05ee7585d4a374ffc5efc5db after several rounds of review... byroot (Jean Boussier)
01:13 PM Revision 91253747 (git): [Feature #18339] GVL Instrumentation API
Ref: https://bugs.ruby-lang.org/issues/18339
Design:
- This tries to minimize the overhead when no hook is register...
byroot (Jean Boussier)
11:25 AM Revision d142eff6 (git): [ruby/nkf] Constified invariant tables
https://github.com/ruby/nkf/commit/b386ddc11c nobu (Nobuyoshi Nakada)
07:04 AM Feature #11689: Add methods allow us to get visibility from Method and UnboundMethod object.
When investigating #18435, I realized the visibility of a method is not an attribute of the method. Instead, each cla... matz (Yukihiro Matsumoto)
06:54 AM Bug #18435 (Open): Calling `protected` on ancestor method changes result of `instance_methods(false)`
I thought it was OK to accept this behavior, but it caused issues like #18729 and #18751. At the time of the decision... matz (Yukihiro Matsumoto)
05:35 AM Revision a4721ec6 (git): [DOC] Fix documentation of Numeric#div: Complex does not have #div
kyanagi (Kouhei Yanagita)
05:13 AM Revision 512d8a25 (git): * 2022-06-03 [ci skip]
git[bot]
05:10 AM Revision 1b44fcf2 (git): [DOC] Mention the case to autoload already defined constant
nobu (Nobuyoshi Nakada)
05:09 AM Revision 5342fcb6 (git): [DOC] Subjects of `autoload` are not restricted to modules
nobu (Nobuyoshi Nakada)

06/02/2022

05:17 PM Feature #18815: instance_{eval,exec} vs Proc#>>
zverok (Victor Shepelev) wrote in #note-3:
> @jeremyevans0 I don't think it is a "bug", but maybe a nice feature to ...
jeremyevans0 (Jeremy Evans)
04:56 PM Feature #18815: instance_{eval,exec} vs Proc#>>
@jeremyevans0 I don't think it is a "bug", but maybe a nice feature to have (composite procs being a bit smarter than... zverok (Victor Shepelev)
04:00 PM Feature #18815: instance_{eval,exec} vs Proc#>>
This is basically the same as #18067. I don't think it's a bug, because you get the exact same behavior with manual ... jeremyevans0 (Jeremy Evans)
12:58 PM Feature #18815 (Open): instance_{eval,exec} vs Proc#>>
```ruby
measure = proc { p "self=#{self}"; size }
multiply = proc { '*' * _1 }
'test'.instance_eval(&measure)
#...
zverok (Victor Shepelev)
01:35 PM Misc #18803: DevMeeting-2022-06-16
* [Feature #18773] Pass an optional range object to deconstruct
* It can be very expensive to compute the array fo...
kddnewton (Kevin Newton)
09:35 AM Misc #18803: DevMeeting-2022-06-16
* [Bug #18813] Module#autoload isn't strict about the autoloaded constant (fxn)
* `module M; autoload :OpenSSL, "o...
byroot (Jean Boussier)
01:23 PM Revision 4eb140b0 (git): [rubygems/rubygems] Remove redundant bitwise AND
https://github.com/rubygems/rubygems/commit/a20bac7924 deivid (David Rodríguez)
01:23 PM Revision eb5a0197 (git): [rubygems/rubygems] Add test cases from SHA1 RFC and improve test failure message
I found that the current test cases did not cover the bitwise AND
performed on modified words after each iteration
(h...
deivid (David Rodríguez)
11:59 AM Feature #18814: Ractor: add method to query incoming message queue size
For instance in GO it is possible to query the current size of a channel:
``` go
c := make(chan int, 100)
for i := ...
phigrofi (Philipp Großelfinger)
10:57 AM Feature #18814 (Assigned): Ractor: add method to query incoming message queue size
## Abstract
A simple method to query the current size of a Ractor's incoming queue from outside. Can be used to de...
phigrofi (Philipp Großelfinger)
11:24 AM Bug #18811: PTY I/O not working on AIX 7.x
Another discovery... sleep *after* the commands makes it work as well:
``` shell
# ./ptytest.rb 'echo foo; sleep 1'...
hspem (Per-Erik Martin)
10:30 AM Revision 1d924ae4 (git): [rubygems/rubygems] Remove leftover debugging puts
https://github.com/rubygems/rubygems/commit/7c6f15040d deivid (David Rodríguez)
09:31 AM Bug #18813: Let Module#autoload be strict about the autoloaded constant
Changing this from Misc to bug, and I'll add it to the upcoming dev-meeting. byroot (Jean Boussier)
07:05 AM Revision af904338 (git): Typedef built-in function types
nobu (Nobuyoshi Nakada)
06:32 AM Revision b96a3a6f (git): Move `GC.verify_compaction_references` [Bug #18779]
Define `GC.verify_compaction_references` as a built-in ruby method,
according to GC compaction support via `GC::OPTS`.
nobu (Nobuyoshi Nakada)
05:34 AM Revision dfc80607 (git): Adjust indent and nesting [ci skip]
nobu (Nobuyoshi Nakada)
01:29 AM Revision 9108db96 (git): Fix the condition when a new buffer is needed without GMP
nobu (Nobuyoshi Nakada)
01:13 AM Revision f35c5a28 (git): * 2022-06-02 [ci skip]
git[bot]
01:12 AM Revision 689b5ae7 (git): Split YJIT rules for CODEOWNERS
nobu (Nobuyoshi Nakada)

06/01/2022

11:37 PM Bug #18813: Let Module#autoload be strict about the autoloaded constant
I support raising an error when this fails to load the right constant. I think we can add a warning in 3.2 and make i... ioquatix (Samuel Williams)
11:00 PM Bug #18813: Let Module#autoload be strict about the autoloaded constant
Thanks for opening the ticket @fxn.
I'm in favor of this change, however I believe that a deprecation cycle is pre...
byroot (Jean Boussier)
10:55 PM Bug #18813 (Closed): Let Module#autoload be strict about the autoloaded constant
## Introduction
Let's consider
```ruby
module M
autoload :X, 'x'
end
```
The constants API does not di...
fxn (Xavier Noria)
04:36 PM Bug #18730: Double `return` event handling with different tracepoints
Here's some more information to round out this thread. I was a bit sloppy
in [ruby-core:108449] and the output I pos...
alanwu (Alan Wu)
02:42 PM Feature #18812 (Closed): Add ability to trace exit locations for YJIT
Currently, when running yjit with `--yjit-stats` you are able to see method call exit reasons and the top 20 most fre... eileencodes (Eileen Uchitelle)
02:22 PM Revision 9d18661e (git): Revert incorrect string-guard optimisation. (#5969)
Also add jhawthorn's test to for this bug.
Fix String#to_s invalidation test
Noah Gibbs
10:01 AM Revision 1177665e (git): [rubygems/rubygems] Fix `bundle remove` by invalidating cached `Bundle.defintion`.
Prior to this commit, `bundle add GEM_NAME` updated the lockfile,
but `bundle remove GEM_NAME` left GEM_NAME in the l...
Ellen Marie Dash
08:07 AM Revision 0a6b9924 (git): [rubygems/rubygems] Fix generated standalone script for default gems
The installer is actually rewriting the spec's full gem path to be the
one of the newly installed gem, however the ac...
deivid (David Rodríguez)
08:07 AM Revision f5b88d93 (git): [rubygems/rubygems] Remove code that seems unnecessary
This change was never covered with a spec, and we have recently covered
the case of partially deleted gems with specs...
deivid (David Rodríguez)
08:06 AM Revision 8381c568 (git): [rubygems/rubygems] Restore ability to load old marshalled gemspec that use `YAML::PrivateType`
This issue was not detected because when all traces of old YAML parser
and emitter `Syck` were removed, this null-typ...
deivid (David Rodríguez)
08:06 AM Revision 89ec3def (git): [rubygems/rubygems] Improve null private type test
This test is making sure that RubyGems is able to load old marshalled
gemspecs that include a field loading `YAML::Pr...
deivid (David Rodríguez)
08:06 AM Revision ebb53480 (git): [rubygems/rubygems] Remove no longer needed `Psych::PrivateType` cleanup
This old bug used to affect the `rubyforge_project` field in serialized
gemspecs. However, this field has been remove...
deivid (David Rodríguez)
02:01 AM Misc #18803: DevMeeting-2022-06-16
* [Bug #18806] protected methods defined by refinements can't be called (shugo)
* I prefer "1. Treat defined met...
shugo (Shugo Maeda)

05/31/2022

03:14 PM Revision 936e5406 (git): * 2022-06-01 [ci skip]
git[bot]
03:14 PM Revision fd83b888 (git): [rubygems/rubygems] Skip duplicated dependency warning for gemspec dev deps
Generally this warning is skipped for gemspec development dependencies.
I think because it's common to override them ...
deivid (David Rodríguez)
10:30 AM Bug #18779: `GC.compact` and other compaction related methods should be defined as rb_f_notimplement on non supported platforms.
Indeed, thank you. byroot (Jean Boussier)
10:26 AM Bug #18779: `GC.compact` and other compaction related methods should be defined as rb_f_notimplement on non supported platforms.
> no, I requested it, but it's the release manager of each branch that is supposed to do the backport.
Sorry for m...
jaruga (Jun Aruga)
10:01 AM Bug #18779: `GC.compact` and other compaction related methods should be defined as rb_f_notimplement on non supported platforms.
@jaruga no, I requested it, but it's the release manager of each branch that is supposed to do the backport.
These...
byroot (Jean Boussier)
09:59 AM Bug #18779: `GC.compact` and other compaction related methods should be defined as rb_f_notimplement on non supported platforms.
> I'm marking 3.0 and 3.1 for backport. The two commits are:
>
> 6ddec1082d06431111123c03b18ca41e7a2cec12
> ...
jaruga (Jun Aruga)
07:13 AM Revision e2b421d6 (git): [rubygems/rubygems] Give better conflict resolution advice
This alternative really uses only the Gemfile, and can never end up
being absurd, because it will never be suggested ...
deivid (David Rodríguez)
03:50 AM Revision 9241d75a (git): Add information from doc/hacking.md and doc/make_cheatsheet.md back i… (#5963)
Add information from doc/hacking.md and doc/make_cheatsheet.md back into contributing docs jemmai (Jemma Issroff)
02:40 AM Revision 0cae30e1 (git): Skip failing test with freebsd
hsbt (Hiroshi SHIBATA)
 

Also available in: Atom