Project

General

Profile

« Previous | Next » 

Revision 94cb5765

Added by tompng (tomoya ishida) almost 2 years ago

[ruby/irb] Rename current completor to RegexpCompletor and
refactored for future extension
(https://github.com/ruby/irb/pull/707)

  • Move completion implementation to completion/regexp_completor for future extension

  • Remove constant CompletionProc and PerfectMatchedProc and add a class method

  • Move document display logic to InputCompletor. Each completor only need to implement completion_caididates and doc_namespace

  • Move display_document logic to RelineInputMethod

  • Use RegexpCompletor directly. Not through class method of InputCompletor.

  • RegexpCompletor extends BaseCompletor, move back definition to completion.rb

  • Move display_document test to input_method test

  • Stop re-initialize completor on each completion phase

  • Store completor to ReadlineInputMethod's iver

https://github.com/ruby/irb/commit/1e98521483