Reland: bindings: Prepare V8ContextSnapshot on Android
REASON OF RELAND: The issue was out of Chromium repository,
and run on only Chrome official build.
Hence I revert the chagne in merger.py, not to check
v8_context_snapshot.bin.
Original CL is https://chromium-review.googlesource.com/c/chromium/src/+/923683
This CL makes it possible to create and use V8 context snapshot
files on Android, if a developer puts "use_v8_context_snapshot=true"
The V8 context snapshot feature is currently supported and enabled on
Windows, MacOSX, and Linux (not ChromeOS), and its Finch experiment
showed 20% reduction of time to create V8 contexts.
On local Android machine, this feature shows 50% time recution.
Beside it, in order to enable the feature on cross-build platforms
like Android, we have to build Blink twice.
So this CL does not flip the flag |use_v8_context_snapshot|.
FYI, some numbers with the feature are written in the next CL;
https://chromium-review.googlesource.com/c/chromium/src/+/923623
TBR=caitkp,kuniko,nyquist,rockot,haraken,mkwst
Bug: 764576, 817288
Change-Id: Id819aa2d4762e04bd7a9b4f700603d89ee0fe5dd
Reviewed-on: https://chromium-review.googlesource.com/945248
Reviewed-by: Hitoshi Yoshida <[email protected]>
Reviewed-by: Xiaohan Wang <[email protected]>
Reviewed-by: Tao Bai <[email protected]>
Commit-Queue: Hitoshi Yoshida <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540780}diff --git a/gin/v8_initializer.h b/gin/v8_initializer.h
index e427c21..6f3265b 100644
--- a/gin/v8_initializer.h
+++ b/gin/v8_initializer.h
@@ -67,7 +67,9 @@
#if defined(OS_ANDROID)
static base::FilePath GetNativesFilePath();
- static base::FilePath GetSnapshotFilePath(bool abi_32_bit);
+ static base::FilePath GetSnapshotFilePath(
+ bool abi_32_bit,
+ V8SnapshotFileType snapshot_file_type);
#endif
#endif // V8_USE_EXTERNAL_STARTUP_DATA
