Allow ScopedAllowIO in unit tests.
e1396f8adefd2f71ed33732f5ffe013bcf87990a changed the presubmit to allow
ScopedAllowIO in browser tests. From the discussion it seemed like the
intention was to allow it in all tests though. This changes the
presubmit to at least allow usage in unit tests.
Also update the error message to no longer refer to the deprecated
blocking pool and FILE thread.
Change-Id: Ibcc18f502b8c47a50a424a2ffe6eab04291e685b
Reviewed-on: https://chromium-review.googlesource.com/569014
Reviewed-by: Dirk Pranke <[email protected]>
Commit-Queue: Marijn Kruisselbrink <[email protected]>
Cr-Commit-Position: refs/heads/master@{#486164}diff --git a/PRESUBMIT.py b/PRESUBMIT.py
index 3ab7802..8cb86fe 100644
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -204,12 +204,11 @@
'ScopedAllowIO',
(
'New production code should not use ScopedAllowIO (using it in',
- 'browser tests is fine). Post a task to the blocking pool or the',
- 'FILE thread instead.',
+ 'tests is fine). Post a task to a MayBlock task runner instead.',
),
True,
(
- r"^.*browser(|_)test[a-z_]*\.cc$",
+ r"^.*(browser|unit)(|_)test[a-z_]*\.cc$",
r"^base[\\\/]memory[\\\/]shared_memory_posix\.cc$",
r"^base[\\\/]process[\\\/]internal_aix\.cc$",
r"^base[\\\/]process[\\\/]process_linux\.cc$",
