| commit | 0e45c020c43b1a9f6d2870ff7f92b30a2f03a458 | [log] [tgz] |
|---|---|---|
| author | Keishi Hattori <[email protected]> | Sat Nov 27 09:25:52 2021 |
| committer | Chromium LUCI CQ <[email protected]> | Sat Nov 27 09:25:52 2021 |
| tree | 624db1a172f4dcc59216f9ed5dc9057623535f9a | |
| parent | 75157d1dd006cc8a40bbab60acf1a16e46d8bec9 [diff] [blame] |
Rewrite most `Foo* field_` pointer fields to `raw_ptr<Foo> field_`. DO NOT REVERT (unless absolutely necessary)! Report build breaks to keishi@(APAC)/glazunov@(EMEA)/sebmarchand@(NA) as soon as you see them. Fixes are expected to be trivial. This commit was generated automatically, by running the following script: tools/clang/rewrite_raw_ptr_fields/rewrite-multiple-platforms.sh on commit fe74bc434e5b7e92d13a328362fcb6df15d8847e For more information, see MiraclePtr One Pager [1], the PSA at chromium-dev@ [2], and the raw_ptr documentation in //base/memory/raw_ptr.md. FYI This CL does not enable MiraclePtr protection and we expect no behavior change from this. [1] https://docs.google.com/document/d/1pnnOAIz_DMWDI4oIOFoMAqLnf_MZ2GsrJNb_dbQ3ZBg/edit?usp=sharing [2] https://groups.google.com/a/chromium.org/g/chromium-dev/c/vAEeVifyf78/m/SkBUc6PhBAAJ Binary-Size: Increase of around 500kb was approved for MiraclePtr Include-Ci-Only-Tests: true No-Tree-Checks: true No-Presubmit: true Bug: 1272324, 1073933 Change-Id: I05c86a83bbb4b3f4b017f361dd7f4e7437697f69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3305132 Commit-Queue: Keishi Hattori <[email protected]> Reviewed-by: Bartek Nowierski <[email protected]> Owners-Override: Bartek Nowierski <[email protected]> Cr-Commit-Position: refs/heads/main@{#945735}
diff --git a/components/variations/variations_seed_store.h b/components/variations/variations_seed_store.h index d7c762f..bc0f40c 100644 --- a/components/variations/variations_seed_store.h +++ b/components/variations/variations_seed_store.h
@@ -12,6 +12,7 @@ #include "base/compiler_specific.h" #include "base/component_export.h" #include "base/gtest_prod_util.h" +#include "base/memory/raw_ptr.h" #include "base/time/time.h" #include "build/build_config.h" #include "components/variations/metrics.h" @@ -244,7 +245,7 @@ std::string* output) WARN_UNUSED_RESULT; // The pref service used to persist the variations seed. - PrefService* local_state_; + raw_ptr<PrefService> local_state_; // Cached serial number from the most recently fetched variations seed. std::string latest_serial_number_;