Remove invisible views from tab order.
AutofillDialogViews::Layout() and AutofillDialogViews::GetPreferredSize()
short-circuit logic when either the loading shield or sign-in webview are
showing. Unfortunately this has the side-effect of keeping any focusable input
in the dialog in the tab order. Recently I made suggested buttons (down arrows)
focusable so this became more noticeable, but the problem has always been there
(if you currently change all sections to add mode and attempt to sign in you'll
have tons of invisible elements to focus).
This CL makes visually invisible nodes also !visible() to remove them from the
tab order (see: views::View::IsFocusable()).
[email protected]
BUG=306484
Review URL: https://codereview.chromium.org/27085002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229111 0039d316-1c4b-4281-b951-d872f2087c98
diff --git a/components/web_modal.gypi b/components/web_modal.gypi
index ad7d4fd9..ee7a23f 100644
--- a/components/web_modal.gypi
+++ b/components/web_modal.gypi
@@ -31,5 +31,18 @@
'web_modal/web_contents_modal_dialog_manager_delegate.h',
],
},
+ {
+ 'target_name': 'web_modal_test',
+ 'type': 'static_library',
+ 'dependencies': [
+ 'web_modal',
+ ],
+ 'sources': [
+ 'web_modal/test_web_contents_modal_dialog_host.cc',
+ 'web_modal/test_web_contents_modal_dialog_host.h',
+ 'web_modal/test_web_contents_modal_dialog_manager_delegate.cc',
+ 'web_modal/test_web_contents_modal_dialog_manager_delegate.h',
+ ],
+ },
],
}
