| commit | 1640e249cd62df6be245c5117418373d407d50e7 | [log] [tgz] |
|---|---|---|
| author | Christian Dullweber <[email protected]> | Tue Mar 13 10:14:36 2018 |
| committer | Commit Bot <[email protected]> | Tue Mar 13 10:14:36 2018 |
| tree | 51e3d806a4c78b6b722b9f5a55728b86071c7e28 | |
| parent | 72fadacf69811c90163161ed52c93d40ecee5565 [diff] [blame] |
Revert "[Closure GN] Convert MD Bookmarks Closure Compilation to GN" This reverts commit a77029c40317fa3bd45dfbf387c383b966773db9. Reason for revert: Build failed because it is missing java during closure compilation step on windows bot: https://ci.chromium.org/buildbot/chromium/Win/64904 Original change's description: > [Closure GN] Convert MD Bookmarks Closure Compilation to GN > > Bug: 632206 > Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation > Change-Id: I05b1348c408965811a2b557bc2a1cb2ee7850096 > Reviewed-on: https://chromium-review.googlesource.com/954822 > Commit-Queue: calamity <[email protected]> > Reviewed-by: Demetrios Papadopoulos <[email protected]> > Reviewed-by: Dirk Pranke <[email protected]> > Cr-Commit-Position: refs/heads/master@{#542749} [email protected],[email protected],[email protected] Change-Id: I9f52c5010125781f35a08d3fa0743362c788706a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 632206 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Reviewed-on: https://chromium-review.googlesource.com/960141 Reviewed-by: Christian Dullweber <[email protected]> Commit-Queue: Christian Dullweber <[email protected]> Cr-Commit-Position: refs/heads/master@{#542755}
diff --git a/BUILD.gn b/BUILD.gn index cc52e22..b4699c1d 100644 --- a/BUILD.gn +++ b/BUILD.gn
@@ -1154,10 +1154,10 @@ "Do not use a platform name in your output directory (found \"$root_build_dir\"). http://crbug.com/548283") } -if (!is_win && !is_ios) { +if (!is_win) { group("webui_closure_compile") { data_deps = [ - "chrome/browser/resources:closure_compile", + "chrome/browser/resources/engagement:closure_compile", "ui/webui/resources:closure_compile", ] }