Pass clang flags to the host compiler, too.
As of http://codereview.chromium.org/7471028, clang is used as
host compiler as well, so this check is no longer necessary. In
fact, it's harmful: In http://codereview.chromium.org/7550002 ,
a dependency on base is added on the host side, which doesn't
build with clang because e.g. -Wno-char-subscript isn't used,
which means base/third_party/dmg_fp/dtoa.cc doesn't build cleanly
in host compiler mode.
BUG=none
TEST=happy pkasting
Review URL: http://codereview.chromium.org/7606012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96121 0039d316-1c4b-4281-b951-d872f2087c98
diff --git a/build/common.gypi b/build/common.gypi
index cce352b1..99ba71d 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -1509,24 +1509,21 @@
}]]
}],
['clang==1', {
- 'target_conditions': [
- ['_toolset=="target"', {
- 'cflags': [
- '-Wheader-hygiene',
- # Clang spots more unused functions.
- '-Wno-unused-function',
- # Don't die on dtoa code that uses a char as an array index.
- '-Wno-char-subscripts',
- # Survive EXPECT_EQ(unnamed_enum, unsigned int) -- see
- # http://code.google.com/p/googletest/source/detail?r=446 .
- # TODO(thakis): Use -isystem instead (http://crbug.com/58751 )
- '-Wno-unnamed-type-template-args',
- ],
- 'cflags!': [
- # Clang doesn't seem to know know this flag.
- '-mfpmath=sse',
- ],
- }]],
+ 'cflags': [
+ '-Wheader-hygiene',
+ # Clang spots more unused functions.
+ '-Wno-unused-function',
+ # Don't die on dtoa code that uses a char as an array index.
+ '-Wno-char-subscripts',
+ # Survive EXPECT_EQ(unnamed_enum, unsigned int) -- see
+ # http://code.google.com/p/googletest/source/detail?r=446 .
+ # TODO(thakis): Use -isystem instead (http://crbug.com/58751 )
+ '-Wno-unnamed-type-template-args',
+ ],
+ 'cflags!': [
+ # Clang doesn't seem to know know this flag.
+ '-mfpmath=sse',
+ ],
}],
['clang==1 and clang_use_chrome_plugins==1', {
'target_conditions': [
