Update unittests to use '%23' instead of '#' in data URIs
This is a (very) partial reland of
https://chromium-review.googlesource.com/c/chromium/src/+/738395,
restoring only the changes to applicable unittests. This should be safe
since '%23' always has been a correct encoding of '#' and so should work
with the data URI code as it is today. It will also make any future
re-land of the core original CL easier.
Some unittests from the original CL were excluded, as the changes made
to them relied on the underlying behavior change.
TBR: [email protected], [email protected], [email protected]
Bug: 123004
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I816fd90d744a1e12e2d9a8d6d0298834b55f2e57
Reviewed-on: https://chromium-review.googlesource.com/1062190
Reviewed-by: Stephen McGruer <[email protected]>
Reviewed-by: David Benjamin <[email protected]>
Commit-Queue: Stephen McGruer <[email protected]>
Cr-Commit-Position: refs/heads/master@{#559928}
diff --git a/ios/net/protocol_handler_util_unittest.mm b/ios/net/protocol_handler_util_unittest.mm
index 10992f0a..8851be6 100644
--- a/ios/net/protocol_handler_util_unittest.mm
+++ b/ios/net/protocol_handler_util_unittest.mm
@@ -164,8 +164,8 @@
TEST_F(ProtocolHandlerUtilTest, GetResponseDataSchemeTest) {
NSURLResponse* response;
// MIME type and charset are correctly carried over.
- response = BuildDataURLResponse("#mime=type'", "$(charset-*", "content");
- CheckDataResponse(response, "#mime=type'", "$(charset-*");
+ response = BuildDataURLResponse("?mime=type'", "$(charset-*", "content");
+ CheckDataResponse(response, "?mime=type'", "$(charset-*");
// Missing values are treated as default values.
response = BuildDataURLResponse("", "", "content");
CheckDataResponse(response, kTextPlain, kAscii);