Get change property value when tabs.onUpdated is fired.
When chrome.tabs.onupdated is fired, we get tab values for second parameter
(which privacy sensitive values are already scrubed).
That means we can just get changed value from it.
So just pass changed property name(std::set<>) only instead of property
key-value(base::DictionaryValue).
BUG=582484
TEST=browser_tests --gtest_filter=ExtensionApiTest.*
Review URL: https://codereview.chromium.org/1639253009
Cr-Commit-Position: refs/heads/master@{#374345}
diff --git a/chrome/browser/extensions/extension_tab_util.cc b/chrome/browser/extensions/extension_tab_util.cc
index 109aa93..91066d4 100644
--- a/chrome/browser/extensions/extension_tab_util.cc
+++ b/chrome/browser/extensions/extension_tab_util.cc
@@ -409,11 +409,9 @@
// ScrubTabValueForExtension if the extension should not see them.
result->SetString(keys::kUrlKey, contents->GetURL().spec());
result->SetString(keys::kTitleKey, contents->GetTitle());
- if (!is_loading) {
- NavigationEntry* entry = contents->GetController().GetVisibleEntry();
- if (entry && entry->GetFavicon().valid)
- result->SetString(keys::kFaviconUrlKey, entry->GetFavicon().url.spec());
- }
+ NavigationEntry* entry = contents->GetController().GetVisibleEntry();
+ if (entry && entry->GetFavicon().valid)
+ result->SetString(keys::kFaviconUrlKey, entry->GetFavicon().url.spec());
if (tab_strip) {
WebContents* opener = tab_strip->GetOpenerOfWebContentsAt(tab_index);
