| commit | 1f8097665f97436091f03e64d665171a33f71f55 | [log] [tgz] |
|---|---|---|
| author | Wez <[email protected]> | Thu Jun 11 19:08:44 2020 |
| committer | Commit Bot <[email protected]> | Thu Jun 11 19:08:44 2020 |
| tree | 880fbdc97dceb0a10f4f1273d9f40b98886c1ce0 | |
| parent | f38090f17f379dfc848137118f4aebb298421d7c [diff] [blame] |
[fuchsia] Report all unexpected MetricsRecorder disconnections. The fuchsia.legacymetrics.MetricsRecorder channel is expected to remain connected until the service explicitly signals OnCloseSoon, or the fuchsia.web.Context is destroyed, so log unexpected disconnections regardless of the reported disconnect status. Bug: b/158283552 Change-Id: I3bdf2f935c3ce2db04d0d8812b50703822703fbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232367 Auto-Submit: Wez <[email protected]> Commit-Queue: Kevin Marshall <[email protected]> Reviewed-by: Kevin Marshall <[email protected]> Cr-Commit-Position: refs/heads/master@{#777427}
diff --git a/fuchsia/base/legacymetrics_client.cc b/fuchsia/base/legacymetrics_client.cc index c8ad92e..3bb49e30 100644 --- a/fuchsia/base/legacymetrics_client.cc +++ b/fuchsia/base/legacymetrics_client.cc
@@ -147,8 +147,7 @@ } void LegacyMetricsClient::OnMetricsRecorderDisconnected(zx_status_t status) { - ZX_LOG_IF(ERROR, status != ZX_ERR_PEER_CLOSED, status) - << "MetricsRecorder connection lost."; + ZX_LOG(ERROR, status) << "MetricsRecorder connection lost."; // Stop recording & reporting user events. user_events_recorder_.reset();