[Extensions] Remove callback from ExtensionService::UninstallExtension
ExtensionService::UninstallExtension takes a callback to call when the
data is removed for the extension's origin. Of the 60+ callers to this
method, the vast majority passed in base::Bind(&base::DoNothing), with
a handful more passing in an empty base::Closure. Only a single caller
(WebstoreReinstaller) passed in a "real" callback, and it appears to
be unnecessary. Additionally, the callback is already misleading - it
corresponds to removing storage partition data, but not chrome.storage
data.
This callback is also making a refactor on the cookies interface more
complicated, and may not be possible to maintain.
Remove the callback from the method interface.
Bug: 721395, 787563
[email protected] (c/b/apps)
[email protected] (c/b/background, c/b/policy)
[email protected] (c/b/chromeos)
[email protected] (c/b/search)
[email protected] (c/b/themes)
[email protected] (c/b/ui)
Change-Id: I1cbffd781fb90a40ff597e20ae80812b8646c5ef
Reviewed-on: https://chromium-review.googlesource.com/778040
Commit-Queue: Devlin <[email protected]>
Reviewed-by: Randy Smith <[email protected]>
Reviewed-by: Karan Bhatia <[email protected]>
Cr-Commit-Position: refs/heads/master@{#518402}diff --git a/chrome/browser/extensions/service_worker_apitest.cc b/chrome/browser/extensions/service_worker_apitest.cc
index 314c2ea..b0b7d32 100644
--- a/chrome/browser/extensions/service_worker_apitest.cc
+++ b/chrome/browser/extensions/service_worker_apitest.cc
@@ -627,8 +627,7 @@
// Uninstall the extension. Opening pages should fail again.
base::string16 error;
extension_service()->UninstallExtension(
- extension_id, UninstallReason::UNINSTALL_REASON_FOR_TESTING,
- base::Bind(&base::DoNothing), &error);
+ extension_id, UninstallReason::UNINSTALL_REASON_FOR_TESTING, &error);
base::RunLoop().RunUntilIdle();
EXPECT_EQ(content::PAGE_TYPE_ERROR,
