[Extensions] Remove callback from ExtensionService::UninstallExtension
ExtensionService::UninstallExtension takes a callback to call when the
data is removed for the extension's origin. Of the 60+ callers to this
method, the vast majority passed in base::Bind(&base::DoNothing), with
a handful more passing in an empty base::Closure. Only a single caller
(WebstoreReinstaller) passed in a "real" callback, and it appears to
be unnecessary. Additionally, the callback is already misleading - it
corresponds to removing storage partition data, but not chrome.storage
data.
This callback is also making a refactor on the cookies interface more
complicated, and may not be possible to maintain.
Remove the callback from the method interface.
Bug: 721395, 787563
[email protected] (c/b/apps)
[email protected] (c/b/background, c/b/policy)
[email protected] (c/b/chromeos)
[email protected] (c/b/search)
[email protected] (c/b/themes)
[email protected] (c/b/ui)
Change-Id: I1cbffd781fb90a40ff597e20ae80812b8646c5ef
Reviewed-on: https://chromium-review.googlesource.com/778040
Commit-Queue: Devlin <[email protected]>
Reviewed-by: Randy Smith <[email protected]>
Reviewed-by: Karan Bhatia <[email protected]>
Cr-Commit-Position: refs/heads/master@{#518402}diff --git a/chrome/browser/extensions/shared_module_service_unittest.cc b/chrome/browser/extensions/shared_module_service_unittest.cc
index a74f318..a9c09c1 100644
--- a/chrome/browser/extensions/shared_module_service_unittest.cc
+++ b/chrome/browser/extensions/shared_module_service_unittest.cc
@@ -160,7 +160,6 @@
base::string16 error;
service()->UninstallExtension(importing_extension->id(),
extensions::UNINSTALL_REASON_FOR_TESTING,
- base::Bind(&base::DoNothing),
&error);
EXPECT_TRUE(error.empty());
@@ -298,7 +297,7 @@
base::string16 error;
service()->UninstallExtension(importing_extension->id(),
extensions::UNINSTALL_REASON_FOR_TESTING,
- base::Bind(&base::DoNothing), &error);
+ &error);
EXPECT_TRUE(error.empty());
// Since the modules were only referenced by that single extension, they
