tree 1a170f31ad7a341efc6d902fbc146a7789852b89
parent f86114c70e99ec78dedb1e71cd97898020d34314
author Takuto Ikuta <tikuta@chromium.org> 1754292277 -0700
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> 1754292277 -0700

Reland "build: Add generated libc++ headers to Siso tool inputs"

This reverts commit c2b174f91ece7fc15218c8d0a71c068f9d478c08.

Reason for revert: Fixed to check more robust path of libc++ directory
to avoid adding not existing paths under libc++abi dir.

Bug: 411014827 Original change's description:
> Revert "build: Add generated libc++ headers to Siso tool inputs"
>
> This reverts commit d3355efd3f688cabd1bbb948a5e9f9f155bb6360.
>
> Reason for revert: Seems to generate massive log lines, which
> end up with build failures for no disk space.
> https://crbug.com/435051701#comment9
>
> Bug: 411014827
> Original change's description:
> > build: Add generated libc++ headers to Siso tool inputs
> >
> > Siso remote builds can fail when generated libc++ headers are not
> > included in the inputs sent to remote workers. These headers may not be
> > discovered by the precomputed tree or by dependency scanning.
> >
> > This change explicitly adds these headers as tool inputs for clang
> > compile actions. A new Siso handler, `add_generated_libcxx_headers`,
> > reads the list of headers from `libcxx_headers.gni`. It then finds the
> > relevant `-isystem` path from the command line and adds the full paths
> > to the headers to the `tool_inputs`.
> >
> > This new handler is now used for both C++ and Objective-C++ compilation,
> > replacing a previous module map-parsing implementation.
> >
> > Bug: 411014827
> > Cq-Include-Trybots: luci.chromium.try:linux-modules-compile-fyi-rel
> > Change-Id: I065587c4f9b63be4a30754b8e907b1d16aad9188
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6778940
> > Reviewed-by: Junji Watanabe <jwata@google.com>
> > Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
> > Reviewed-by: Matt Stark <msta@google.com>
> > Cr-Commit-Position: refs/heads/main@{#1493961}
>
> Bug: 411014827
> Cq-Include-Trybots: luci.chromium.try:linux-modules-compile-fyi-rel
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Change-Id: I13bb7280668a5d9db0de601ef0dfe8109177bf95
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6800465
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Auto-Submit: Junji Watanabe <jwata@google.com>
> Commit-Queue: Nico Weber <thakis@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1494177}

Bug: 411014827
Cq-Include-Trybots: luci.chromium.try:linux-modules-compile-fyi-rel
Change-Id: I7c2e5e7721bf02d021461dedf78bd34579b06569
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6810605
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Matt Stark <msta@google.com>
Cr-Commit-Position: refs/heads/main@{#1496158}