Reland "[Extensions Bindings] Remove the kNativeCrxBindings feature"
This is a reland of 73c5a82773c0cff9d282e3e2273132b856a4de7e
[email protected]
[email protected]
[email protected]
[email protected]
Original change's description:
> [Extensions Bindings] Remove the kNativeCrxBindings feature
>
> NativeCrxBindings have been enabled on stable channel since M72. Remove
> the feature flag, and update the sites that were using it.
>
> This CL:
> * Removes all references to the feature
> * Updates parameterized tests (typically making them un-parameterized,
> unless they were parameterized on multiple axes)
> * Removes else-blocks that are unreachable
>
> Follow-up CLs will remove JS-binding specific code, such as the
> unnecessary custom bindings files and the JSBindingsSystem concepts.
>
> Bug: 938998
> Change-Id: Ic68cf9da3f52f22321f1b02b00a1ea98951aa540
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507041
> Reviewed-by: Ilya Sherman <[email protected]>
> Reviewed-by: Luke Halliwell <[email protected]>
> Reviewed-by: Jeremy Roman <[email protected]>
> Reviewed-by: Istiaque Ahmed <[email protected]>
> Commit-Queue: Devlin <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#639786}
Bug: 938998
Change-Id: I164d51b3f1885bbd1b05249c298666db8dbdbd74
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518339
Commit-Queue: Devlin <[email protected]>
Reviewed-by: Devlin <[email protected]>
Cr-Commit-Position: refs/heads/master@{#640015}diff --git a/extensions/renderer/module_system_test.cc b/extensions/renderer/module_system_test.cc
index 95551cf..13d50d9 100644
--- a/extensions/renderer/module_system_test.cc
+++ b/extensions/renderer/module_system_test.cc
@@ -14,7 +14,6 @@
#include "base/bind.h"
#include "base/callback.h"
#include "base/command_line.h"
-#include "base/feature_list.h"
#include "base/files/file_path.h"
#include "base/files/file_util.h"
#include "base/lazy_instance.h"
@@ -22,7 +21,6 @@
#include "base/run_loop.h"
#include "base/strings/string_piece.h"
#include "extensions/common/extension_builder.h"
-#include "extensions/common/extension_features.h"
#include "extensions/common/extension_paths.h"
#include "extensions/common/value_builder.h"
#include "extensions/renderer/ipc_message_sender.h"
@@ -53,9 +51,7 @@
GetAPINatives(ScriptContext* context,
NativeExtensionBindingsSystem* bindings_system)
: ObjectBackedNativeHandler(context), bindings_system_(bindings_system) {
- DCHECK_EQ(
- base::FeatureList::IsEnabled(extensions_features::kNativeCrxBindings),
- !!bindings_system);
+ DCHECK(bindings_system_);
}
~GetAPINatives() override {}
@@ -164,8 +160,7 @@
context_->v8_context()->Enter();
assert_natives_ = new AssertNatives(context_);
- if (base::FeatureList::IsEnabled(extensions_features::kNativeCrxBindings))
- bindings_system_ = std::make_unique<NativeExtensionBindingsSystem>(nullptr);
+ bindings_system_ = std::make_unique<NativeExtensionBindingsSystem>(nullptr);
{
std::unique_ptr<ModuleSystem> module_system(
@@ -187,10 +182,8 @@
module_system->SetExceptionHandlerForTest(
std::unique_ptr<ModuleSystem::ExceptionHandler>(new FailsOnException));
- if (bindings_system_) {
- bindings_system_->DidCreateScriptContext(context_);
- bindings_system_->UpdateBindingsForContext(context_);
- }
+ bindings_system_->DidCreateScriptContext(context_);
+ bindings_system_->UpdateBindingsForContext(context_);
}
ModuleSystemTestEnvironment::~ModuleSystemTestEnvironment() {
