Fix missing QUIC_SESSION_PACKET_SENT
When cl/331651056 landed in the QUICHE shared code and changed
QuicConnectionDebugVisitor::OnPacketSent, it failed to update the
overrides in Chrome. This caused us to stop sending
QUIC_SESSION_PACKET_SENT events to netlog. This CL fixes that
and adds a test to ensure we don't regress.
[email protected]
Bug: 1141254
Change-Id: I2f6679ffa42779901cc9c088fbbff716f4e56a30
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2492167
Auto-Submit: David Schinazi <[email protected]>
Reviewed-by: Renjie Tang <[email protected]>
Commit-Queue: David Schinazi <[email protected]>
Cr-Commit-Position: refs/heads/master@{#819949}
diff --git a/net/quic/quic_network_transaction_unittest.cc b/net/quic/quic_network_transaction_unittest.cc
index 4d27e24..db93c09 100644
--- a/net/quic/quic_network_transaction_unittest.cc
+++ b/net/quic/quic_network_transaction_unittest.cc
@@ -1205,6 +1205,12 @@
NetLogEventPhase::NONE);
EXPECT_LT(0, pos);
+ // ... and also a TYPE_QUIC_SESSION_PACKET_SENT.
+ pos = ExpectLogContainsSomewhere(entries, 0,
+ NetLogEventType::QUIC_SESSION_PACKET_SENT,
+ NetLogEventPhase::NONE);
+ EXPECT_LT(0, pos);
+
// ... and also a TYPE_QUIC_SESSION_UNAUTHENTICATED_PACKET_HEADER_RECEIVED.
pos = ExpectLogContainsSomewhere(
entries, 0,
