Land Recent QUIC Changes.

Refactor hybrid slow start in QUIC to create a simpler interface between
it an TCPCubicSender.

In preparation for BBR.
Merge internal change: 64031462
https://codereview.chromium.org/218993002/


Don't log decryption errors in AeadBaseDecrypter::Decrypt.

Instead, have QuicFramer::DecryptPayload log a warning message if both
trial decryptions fail.

Merge internal change: 63977728
https://codereview.chromium.org/218983002/


QUIC refactor to remove a return value which was always true.

Merge internal change: 63977684
https://codereview.chromium.org/218913003/


Simplify the bytes_consumed computation
in QuicPacketCreator::CreateStreamFrame. Does not change behavior.

Merge internal change: 63900899
https://codereview.chromium.org/218873003/


Fixing a broken test for quic.  cr/63542972 added the proxy flag on
outbound packets.  Unfortunately, this broke our tests using the magic
header. This CL provides hooks for clearing that bit of data.

Adding a virtual function to quic client so we can fix a test.

Merge internal change: 63898585
https://codereview.chromium.org/218963003/


+ Use QuicServerKey tuple (host, port, is_https) instead of
  server_hostname, while creating QuicClientSession,
  QuicCryptoClientStream, QuicCryptoClientConfig, QuicClient,
  QuicTestClient, etc objects.

+ QuicServerKey is used as the key to access QUIC server
  config information from all caches.

+ Added couple of new unit tests for HostPortPair class.

+ Added unit tests for QuicServerId for privacy mode
  combination with host, port, is_https.

Merge internal change: 63891842
https://codereview.chromium.org/218923002/

[email protected]

Review URL: https://codereview.chromium.org/216713003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260810 0039d316-1c4b-4281-b951-d872f2087c98
diff --git a/net/quic/quic_sent_packet_manager.h b/net/quic/quic_sent_packet_manager.h
index 0f7266c..d2fe0b8 100644
--- a/net/quic/quic_sent_packet_manager.h
+++ b/net/quic/quic_sent_packet_manager.h
@@ -78,9 +78,8 @@
   void OnRetransmittedPacket(QuicPacketSequenceNumber old_sequence_number,
                              QuicPacketSequenceNumber new_sequence_number);
 
-  // Processes the incoming ack and returns true if the retransmission or ack
-  // alarm should be reset.
-  bool OnIncomingAck(const ReceivedPacketInfo& received_info,
+  // Processes the incoming ack.
+  void OnIncomingAck(const ReceivedPacketInfo& received_info,
                      QuicTime ack_receive_time);
 
   // Discards any information for the packet corresponding to |sequence_number|.