| commit | 28c2fdd4731b4015445b196dda26a6ad23f18f2d | [log] [tgz] |
|---|---|---|
| author | Chris Watkins <[email protected]> | Thu Nov 30 06:06:52 2017 |
| committer | Commit Bot <[email protected]> | Thu Nov 30 06:06:52 2017 |
| tree | 74def6cc1aceadce409f9e714b8eea13942a3e99 | |
| parent | b5dec6f0f0a08f99d75431551b3ded92ae6b4eca [diff] [blame] |
Run clang-tidy modernize-use-equals-{delete,default} on //net/websockets
See the bugs and cxx post for justification and details:
https://groups.google.com/a/chromium.org/forum/#!topic/cxx/RkOHzIK6Tq8
This change was done using clang-tidy as described here:
https://chromium.googlesource.com/chromium/src/+/lkcr/docs/clang_tidy.md
In some cases the the tool leaves behind a string of commas where it
replaced a member initializer list
(https://bugs.llvm.org/show_bug.cgi?id=35051). They were cleaned up with:
git diff --name-only | \
xargs sed -E -i 's/(^\s*|\)\s*):[ ,]*= default/\1 = default/'
BUG=778959,778957
This CL was uploaded by git cl split.
[email protected]
Change-Id: I702f4d49f1d35ec98595a2eeaa5865b3cb4584df
Reviewed-on: https://chromium-review.googlesource.com/799597
Reviewed-by: Yutaka Hirano <[email protected]>
Commit-Queue: Chris Watkins <[email protected]>
Cr-Commit-Position: refs/heads/master@{#520457}diff --git a/net/websockets/websocket_frame_parser.cc b/net/websockets/websocket_frame_parser.cc index 19999ba..1b06cca 100644 --- a/net/websockets/websocket_frame_parser.cc +++ b/net/websockets/websocket_frame_parser.cc
@@ -42,7 +42,7 @@ '\0'); } -WebSocketFrameParser::~WebSocketFrameParser() {} +WebSocketFrameParser::~WebSocketFrameParser() = default; bool WebSocketFrameParser::Decode( const char* data,