Google Git
Sign in
chromium / chromium / src / 295d736c331732b65e5559891d18df04ac904618
commit295d736c331732b65e5559891d18df04ac904618[log] [tgz]
authorVaclav Brozek <[email protected]>Tue Dec 15 10:09:56 2020
committerChromium LUCI CQ <[email protected]>Tue Dec 15 10:09:56 2020
tree53ca094ddb90a7f9d00306fa3800580a1be10da3
parentfc6ed3616e0dd34d832e63b713cde74803182d4a [diff]
Reset last_invalid_percent_index if output is invalidated

When a GURL's path is canonicalized, the code is trying to handle
nested escape sequences. It keeps the index of the last seemingly
invalid "%" in a variable called last_invalid_percent_index, so that
ssequences like "%%41B" can be transformed to "%AB".

However, it can happen, that an already output part of the path is
invalidated and cut off, such as in "abc/../", which is equivalent to
"".

The bug in the current code is that last_invalid_percent_index is not
reset if the part of the output which it points to gets invalidated.
This resulted in the mysterious inserting of the hex code of "%" in
the middle of the escape sequence of ">" when canonicalizing the path
"5%/../>%41".

This CL simply makes sure that last_invalid_percent_index is reset
whenever it points beyond the end of the current output.

Bug: 1080890
Change-Id: I04a5246ecbb66b645d796ec88babd74383d18661
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587060
Auto-Submit: Vaclav Brozek <[email protected]>
Reviewed-by: Daniel Cheng <[email protected]>
Commit-Queue: Daniel Cheng <[email protected]>
Cr-Commit-Position: refs/heads/master@{#837031}
2 files changed
tree: 53ca094ddb90a7f9d00306fa3800580a1be10da3
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. weblayer/
  53. .clang-format
  54. .clang-tidy
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .vpython
  61. .vpython3
  62. .yapfignore
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. ENG_REVIEW_OWNERS
  70. LICENSE
  71. LICENSE.chromium_os
  72. OWNERS
  73. PRESUBMIT.py
  74. PRESUBMIT_test.py
  75. PRESUBMIT_test_mocks.py
  76. README.md
  77. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.