Componentize SigninStatusMetricsProvider
This CL componentizes SigninStatusMetricsProvider and its associated classes
into the signin component to enable clean integration on iOS. No changes are
needed for the componentization.
The reason that the componentization goes into the signin rather than the
metrics component is that these classes depend heavily on //components/signin,
and it is undesirable to introduce that dependency in the metrics component.
For consistency, this CL also moves the remaining related //chrome-side classes
into //chrome/browser/signin.
This CL also adds missing Mac framework dependencies that
the signin->metrics dependency exposed.
Based on a patch by [email protected].
BUG=514309
TBR=jochen
Review URL: https://codereview.chromium.org/1390073003
Cr-Commit-Position: refs/heads/master@{#353725}
diff --git a/chrome/browser/BUILD.gn b/chrome/browser/BUILD.gn
index de72288..c22e542a 100644
--- a/chrome/browser/BUILD.gn
+++ b/chrome/browser/BUILD.gn
@@ -534,21 +534,10 @@
deps += [ "//chrome/browser/chromeos" ]
}
- if (is_ios) {
- sources -= [
- "metrics/signin_status_metrics_provider_base.cc",
- "metrics/signin_status_metrics_provider_base.h",
- ]
- }
-
if (is_chromeos || is_ios) {
sources -= [
- "metrics/chrome_signin_status_metrics_provider_delegate.cc",
- "metrics/chrome_signin_status_metrics_provider_delegate.h",
- "metrics/signin_status_metrics_provider.cc",
- "metrics/signin_status_metrics_provider.h",
- "metrics/signin_status_metrics_provider_delegate.cc",
- "metrics/signin_status_metrics_provider_delegate.h",
+ "signin/chrome_signin_status_metrics_provider_delegate.cc",
+ "signin/chrome_signin_status_metrics_provider_delegate.h",
]
}