Google Git
Sign in
chromium / chromium / src / a0f8775417a4b36578e04318b2f4d9a42beed9ed
commita0f8775417a4b36578e04318b2f4d9a42beed9ed[log] [tgz]
authorDavid Bokan <[email protected]>Tue Jan 23 15:32:42 2018
committerCommit Bot <[email protected]>Tue Jan 23 15:32:42 2018
tree1415a8bce4b4e5e0c81d3129a5e598d202c29a07
parentba29acd9460d792f17a947bcadcec21ee531abf0 [diff]
Fix root layer scrolls crash in viewport registration

The crash would occur when a non-main frame finished its lifecycle
update before the main frame. This can happen in an OOPIF as lifecycle
on local roots is independent. This would kick the viewport layer
registration method while the main frame hadn't yet completed
compositing, leading to a CanQueryCompositingState DCHECK. This occured
only when root-layer-scrolls is turned on because, without it, the
container and scrolling layers would be the layers created by the
PaintLayerCompositor (unless the test/page sets a rootScroller) which
live outside the document lifecycle.

This patch fixes the issue by only reregistering viewport layers after
a compositing update on the frame that contains the global root
scroller. This guarantees that we're in the correct lifecycle state.

Bug: 800566, 642378
Change-Id: Ibbaa77b7f40794f16cecdaec46353dd00bc277e9
Reviewed-on: https://chromium-review.googlesource.com/877338
Reviewed-by: Steve Kobes <[email protected]>
Commit-Queue: David Bokan <[email protected]>
Cr-Commit-Position: refs/heads/master@{#531243}
4 files changed
tree: 1415a8bce4b4e5e0c81d3129a5e598d202c29a07
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. blink/
  6. build/
  7. build_overrides/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. mash/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .