Use base::BindOnce for PostTask callbacks.
TaskRunner::PostTask() takes a OnceCallback. Replace usage of
base::Bind(), which produces a RepeatingCallback, with base::BindOnce()
when the callback is created as a temporary inside of PostTask(). The
following regex was used to find instances that could be replaced:
(Post(?:Delayed)?Task)\((?:\n\s*)?FROM_HERE,(?:\n)?\s*base::Bind\(
Also replace any usage of base::Passed(&var) with std::move(var) for
variables passed to base::BindOnce(). base::Passed() isn't needed for
move-only types with OnceCallbacks.
This CL was uploaded by git cl split.
[email protected]
Bug: 714018
Change-Id: I5d3dabe31b239acb3e4ba6db7527fda5a3cd5f4a
Reviewed-on: https://chromium-review.googlesource.com/c/1475635
Auto-Submit: kylechar <[email protected]>
Reviewed-by: Yuwei Huang <[email protected]>
Commit-Queue: Yuwei Huang <[email protected]>
Cr-Commit-Position: refs/heads/master@{#632735}diff --git a/remoting/host/desktop_session_agent_unittest.cc b/remoting/host/desktop_session_agent_unittest.cc
index 1d2f09b1..d42cf8c 100644
--- a/remoting/host/desktop_session_agent_unittest.cc
+++ b/remoting/host/desktop_session_agent_unittest.cc
@@ -151,17 +151,18 @@
base::TimeDelta::FromMilliseconds(-1))));
ASSERT_TRUE(proxy->Send(
new ChromotingNetworkToAnyMsg_StopProcessStatsReport()));
- task_runner_->PostDelayedTask(FROM_HERE, base::Bind([](
- DesktopSessionAgentTest* test,
- std::unique_ptr<FakeDelegate>* delegate,
- std::unique_ptr<IPC::ChannelProxy>* proxy) {
- test->Shutdown();
- delegate->reset();
- proxy->reset();
- },
- base::Unretained(this),
- base::Unretained(&delegate),
- base::Unretained(&proxy)),
+ task_runner_->PostDelayedTask(
+ FROM_HERE,
+ base::BindOnce(
+ [](DesktopSessionAgentTest* test,
+ std::unique_ptr<FakeDelegate>* delegate,
+ std::unique_ptr<IPC::ChannelProxy>* proxy) {
+ test->Shutdown();
+ delegate->reset();
+ proxy->reset();
+ },
+ base::Unretained(this), base::Unretained(&delegate),
+ base::Unretained(&proxy)),
base::TimeDelta::FromMilliseconds(1));
run_loop_.Run();
}
@@ -180,17 +181,18 @@
base::TimeDelta::FromMilliseconds(1))));
ASSERT_TRUE(proxy->Send(
new ChromotingNetworkToAnyMsg_StopProcessStatsReport()));
- task_runner_->PostDelayedTask(FROM_HERE, base::Bind([](
- DesktopSessionAgentTest* test,
- std::unique_ptr<FakeDelegate>* delegate,
- std::unique_ptr<IPC::ChannelProxy>* proxy) {
- test->Shutdown();
- delegate->reset();
- proxy->reset();
- },
- base::Unretained(this),
- base::Unretained(&delegate),
- base::Unretained(&proxy)),
+ task_runner_->PostDelayedTask(
+ FROM_HERE,
+ base::BindOnce(
+ [](DesktopSessionAgentTest* test,
+ std::unique_ptr<FakeDelegate>* delegate,
+ std::unique_ptr<IPC::ChannelProxy>* proxy) {
+ test->Shutdown();
+ delegate->reset();
+ proxy->reset();
+ },
+ base::Unretained(this), base::Unretained(&delegate),
+ base::Unretained(&proxy)),
base::TimeDelta::FromMilliseconds(1));
run_loop_.Run();
}
