Google Git
Sign in
chromium / chromium / src / 2e4cf27642a996355d3d47c89cb6909dbe031859
commit2e4cf27642a996355d3d47c89cb6909dbe031859[log] [tgz]
authorScott Violet <[email protected]>Tue Jun 01 15:47:12 2021
committerChromium LUCI CQ <[email protected]>Tue Jun 01 15:47:12 2021
tree7628cbf39fe5dade1a4f3ec7a05bcaca3bf8a4be
parente2bb3ce71b41604cfb13c61d40566b47972c0c6a [diff]
Revert "variations: converts the variations target to a component"

This reverts commit 6fda62915219c65c8821f9706f951873b9f2f441.

Reason for revert: This seems to have caused failures on the win-7 debug bot: https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%28dbg%29%281%29/89935

Original change's description:
> variations: converts the variations target to a component
>
> The variations target is currently a static_library. This means
> any executable/shared-library target that depends upon it ends up
> copying the symbols, and we end up with multiple instances of
> singletons. This is painful as I'm trying to ensure a single
> instance of VariationsIdsProvider is created, but because there
> are multiple that is difficult.
>
> By converting the target to a component the duplication doesn't
> happen and a single instance is created.
>
> BUG=1148350
> TEST=covered by tests
>
> Change-Id: Ib5051074673ba7a8c095be0d7a0b9386b8dfef46
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2923224
> Commit-Queue: Scott Violet <[email protected]>
> Reviewed-by: Reilly Grant <[email protected]>
> Reviewed-by: Alexei Svitkine <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#887833}

Bug: 1148350
Change-Id: I51eb38c14768a0fe43380e3fdedacc19765eb86a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2927726
Bot-Commit: Rubber Stamper <[email protected]>
Reviewed-by: Scott Violet <[email protected]>
Reviewed-by: Alexei Svitkine <[email protected]>
Commit-Queue: Alexei Svitkine <[email protected]>
Cr-Commit-Position: refs/heads/master@{#887985}
31 files changed
tree: 7628cbf39fe5dade1a4f3ec7a05bcaca3bf8a4be
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. weblayer/
  53. .clang-format
  54. .clang-tidy
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .mailmap
  61. .vpython
  62. .vpython3
  63. .yapfignore
  64. AUTHORS
  65. BUILD.gn
  66. CODE_OF_CONDUCT.md
  67. codereview.settings
  68. DEPS
  69. DIR_METADATA
  70. ENG_REVIEW_OWNERS
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.