Google Git
Sign in
chromium / chromium / src / 3067dae948c73e6cf5cba5b29735e3fd0debf7c5
commit3067dae948c73e6cf5cba5b29735e3fd0debf7c5[log] [tgz]
authorChris Mumford <[email protected]>Thu Aug 05 23:33:37 2021
committerChromium LUCI CQ <[email protected]>Thu Aug 05 23:33:37 2021
treec9a4d1caf25cbc67437b52cbf9a433c21c196fc6
parent978d20c470520e9fa3976b12598fd83c058d5367 [diff]
[bluetooth] Decouple TestPairingDelegate from RunLoop.

Convert TestPairingDelegate into a pure gMock implementation
(MockPairingDelegate) which makes no calls to base::RunLoop.
This is necessary because the current implementation assumes that the
BluetoothDevice calls made (e.g. SetPinCode(), CancelPairing(), etc.)
are synchronous, but there is no guarantee that they are. Removing the
message loop from this implementation allows tests to do their
own waiting (e.g. with a local RunLoop) for test completion.

Bug: none
Change-Id: I0487890c2c972706865fb584a855976e39043faa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3068380
Commit-Queue: Chris Mumford <[email protected]>
Reviewed-by: Reilly Grant <[email protected]>
Cr-Commit-Position: refs/heads/master@{#909111}
10 files changed
tree: c9a4d1caf25cbc67437b52cbf9a433c21c196fc6
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. weblayer/
  53. .clang-format
  54. .clang-tidy
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .mailmap
  61. .vpython
  62. .vpython3
  63. .yapfignore
  64. AUTHORS
  65. BUILD.gn
  66. CODE_OF_CONDUCT.md
  67. codereview.settings
  68. DEPS
  69. DIR_METADATA
  70. ENG_REVIEW_OWNERS
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.