| commit | 357abfc8db2042eb1e9b7ab8785cd2514c4f78ff | [log] [tgz] |
|---|---|---|
| author | Robbie McElrath <[email protected]> | Fri Sep 14 20:43:54 2018 |
| committer | Commit Bot <[email protected]> | Fri Sep 14 20:43:54 2018 |
| tree | 58611e6667aec83de9bbe786db751dc6cfe1f07e | |
| parent | 37a0eedb060fc2f152b1516aa77aa4c58a838fef [diff] |
Make TestNetworkConnectionTracker a singleton. As more classes get migrated from NetworkChangeManager to NetworkConnectionTracker, more and more tests need a TestNetworkConnectionTracker instance set up, including many tests that are pulling in the NetworkConnectionTracker indirectly, so shouldn't need to set up the test instance themselves. To make sure all tests have access to the test instance, this CL makes TestNetworkConnectionTracker a singleton that is setup at the beginning of each test suite, which ensures only one instance is ever created, and it's torn down at the right time. Bug: 868015 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I90ca6ddfa1669f476b03fa7e27230288dfc4101e Reviewed-on: https://chromium-review.googlesource.com/1214081 Reviewed-by: Ilya Sherman <[email protected]> Reviewed-by: Kristi Park <[email protected]> Reviewed-by: Robert Sesek <[email protected]> Reviewed-by: Doug Arnett <[email protected]> Reviewed-by: Min Qin <[email protected]> Reviewed-by: Sergey Ulanov <[email protected]> Reviewed-by: Jochen Eisinger <[email protected]> Reviewed-by: Reilly Grant <[email protected]> Commit-Queue: Robbie McElrath <[email protected]> Cr-Commit-Position: refs/heads/master@{#591463}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .