| commit | 35f8e3712967bb475b8afbac870168c302713ab0 | [log] [tgz] |
|---|---|---|
| author | Devlin Cronin <[email protected]> | Fri Aug 16 19:15:38 2019 |
| committer | Commit Bot <[email protected]> | Fri Aug 16 19:15:38 2019 |
| tree | b707f759233901deeb789148120a51e185ea1f23 | |
| parent | bae1a684b73c5c40c0e386e8fcc3aab2360802e9 [diff] [blame] |
[Extensions] Remove wildcard TLD support from URLPatterns This was originally added for policy support, but has since been removed. The only usage now is in tests. Remove the support from URLPattern to reduce complexity and clean up dead code. Bug: None Change-Id: I7f8ff84ea0e15e223a3f708e005d4bf8e344dfc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746829 Reviewed-by: Karan Bhatia <[email protected]> Reviewed-by: Tom Sepez <[email protected]> Commit-Queue: Devlin <[email protected]> Cr-Commit-Position: refs/heads/master@{#687767}
diff --git a/chrome/browser/extensions/extension_management_internal.cc b/chrome/browser/extensions/extension_management_internal.cc index c6ee887..6b1e7cc2e 100644 --- a/chrome/browser/extensions/extension_management_internal.cc +++ b/chrome/browser/extensions/extension_management_internal.cc
@@ -137,10 +137,7 @@ URLPattern pattern(extension_scheme_mask); if (unparsed_str != URLPattern::kAllUrlsPattern) unparsed_str.append("/*"); - // TODO(nrpeter): Remove effective TLD wildcard capability from - // URLPattern. - URLPattern::ParseResult parse_result = pattern.Parse( - unparsed_str, URLPattern::DENY_WILDCARD_FOR_EFFECTIVE_TLD); + URLPattern::ParseResult parse_result = pattern.Parse(unparsed_str); if (parse_result != URLPattern::ParseResult::kSuccess) { LOG(WARNING) << kMalformedPreferenceWarning; LOG(WARNING) << "Invalid URL pattern '" + unparsed_str +