Disable flaky tests in ServiceWorkerBasedBackgroundTest
[email protected]
No-Try: true
Bug: 1003244
Change-Id: I935cf3775817a575d654425e648cf3337641d6a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1800133
Reviewed-by: Makoto Shimazu <[email protected]>
Commit-Queue: Makoto Shimazu <[email protected]>
Cr-Commit-Position: refs/heads/master@{#695948}
diff --git a/chrome/browser/extensions/service_worker_apitest.cc b/chrome/browser/extensions/service_worker_apitest.cc
index fdb6b751..a052df2c 100644
--- a/chrome/browser/extensions/service_worker_apitest.cc
+++ b/chrome/browser/extensions/service_worker_apitest.cc
@@ -314,7 +314,9 @@
// The extension is installed and loaded during this step and it registers
// an event listener for tabs.onCreated event. The step also verifies that tab
// creation correctly fires the listener.
-IN_PROC_BROWSER_TEST_F(ServiceWorkerBasedBackgroundTest, PRE_Basic) {
+//
+// Disabled due to flakiness: https://crbug.com/1003244.
+IN_PROC_BROWSER_TEST_F(ServiceWorkerBasedBackgroundTest, DISABLED_PRE_Basic) {
ExtensionTestMessageListener newtab_listener("CREATED", false);
newtab_listener.set_failure_message("CREATE_FAILED");
ExtensionTestMessageListener worker_listener("WORKER_RUNNING", false);
@@ -339,7 +341,9 @@
// tabs.onCreated event listener to the extension without explicitly loading the
// extension. This is because the extension registered a listener before browser
// restarted in PRE_Basic.
-IN_PROC_BROWSER_TEST_F(ServiceWorkerBasedBackgroundTest, Basic) {
+//
+// Disabled due to flakiness: https://crbug.com/1003244.
+IN_PROC_BROWSER_TEST_F(ServiceWorkerBasedBackgroundTest, DISABLED_Basic) {
ExtensionTestMessageListener newtab_listener("CREATED", false);
newtab_listener.set_failure_message("CREATE_FAILED");
const GURL url = embedded_test_server()->GetURL("/extensions/test_file.html");
@@ -1811,8 +1815,9 @@
}
}
+// Disabled due to flakiness: https://crbug.com/1003244.
IN_PROC_BROWSER_TEST_F(ServiceWorkerBasedBackgroundTest,
- TabsOnUpdatedSpanning) {
+ DISABLED_TabsOnUpdatedSpanning) {
ExtensionTestMessageListener ready_listener("Script started regular", true);
// Open an incognito window.
@@ -2042,8 +2047,9 @@
<< message_;
}
+// Disabled due to flakiness: https://crbug.com/1003244.
IN_PROC_BROWSER_TEST_F(ServiceWorkerBasedBackgroundTest,
- PRE_FilteredEventsAfterRestart) {
+ DISABLED_PRE_FilteredEventsAfterRestart) {
ExtensionTestMessageListener listener_added("ready", false);
const Extension* extension = LoadExtensionWithFlags(
test_data_dir_.AppendASCII("service_worker/worker_based_background/"
@@ -2063,8 +2069,10 @@
// tabs.onCreated event listener to the extension without explicitly loading the
// extension. This is because the extension registered a listener for
// tabs.onMoved before browser restarted in PRE_EventsAfterRestart.
+//
+// Disabled due to flakiness: https://crbug.com/1003244.
IN_PROC_BROWSER_TEST_F(ServiceWorkerBasedBackgroundTest,
- FilteredEventsAfterRestart) {
+ DISABLED_FilteredEventsAfterRestart) {
// Verify there is no RenderProcessHost for the extension.
// TODO(crbug.com/971309): This is currently broken because the test
// infrastructure opens a tab, which dispatches an event to our
