Use rvalue reference instead of extensions::ListBuilder::Pass()
C++ 11 enables rvalue reference with std::move() so that removing legacy ListBuilder::Pass() stuff.
TEST=unit_tests
BUG=563649
[email protected]
Review URL: https://codereview.chromium.org/1497753002
Cr-Commit-Position: refs/heads/master@{#363970}
diff --git a/chrome/browser/extensions/shared_module_service_unittest.cc b/chrome/browser/extensions/shared_module_service_unittest.cc
index 79baa35efa..0f1d1e3 100644
--- a/chrome/browser/extensions/shared_module_service_unittest.cc
+++ b/chrome/browser/extensions/shared_module_service_unittest.cc
@@ -4,6 +4,8 @@
#include "chrome/browser/extensions/shared_module_service.h"
+#include <utility>
+
#include "base/memory/ref_counted.h"
#include "base/memory/scoped_ptr.h"
#include "base/strings/string16.h"
@@ -36,8 +38,8 @@
.Set("version", version)
.Set("manifest_version", 2);
if (!import_id.empty()) {
- builder.Set("import",
- ListBuilder().Append(DictionaryBuilder().Set("id", import_id)));
+ builder.Set("import", std::move(ListBuilder().Append(
+ DictionaryBuilder().Set("id", import_id))));
}
scoped_ptr<base::DictionaryValue> manifest = builder.Build();
@@ -128,8 +130,9 @@
.Set("version", "1.0")
.Set("manifest_version", 2)
.Set("export",
- DictionaryBuilder().Set("resources",
- ListBuilder().Append("foo.js"))).Build();
+ DictionaryBuilder().Set(
+ "resources", std::move(ListBuilder().Append("foo.js"))))
+ .Build();
scoped_refptr<Extension> shared_module =
ExtensionBuilder()
.SetManifest(manifest.Pass())
@@ -168,8 +171,9 @@
.Set("version", "1.0")
.Set("manifest_version", 2)
.Set("export",
- DictionaryBuilder().Set("resources",
- ListBuilder().Append("foo.js"))).Build();
+ DictionaryBuilder().Set(
+ "resources", std::move(ListBuilder().Append("foo.js"))))
+ .Build();
scoped_refptr<Extension> shared_module_1 =
ExtensionBuilder()
.SetManifest(manifest_1.Pass())
@@ -184,8 +188,9 @@
.Set("version", "1.0")
.Set("manifest_version", 2)
.Set("export",
- DictionaryBuilder().Set("resources",
- ListBuilder().Append("foo.js"))).Build();
+ DictionaryBuilder().Set(
+ "resources", std::move(ListBuilder().Append("foo.js"))))
+ .Build();
scoped_refptr<Extension> shared_module_2 =
ExtensionBuilder()
.SetManifest(manifest_2.Pass())
@@ -244,11 +249,11 @@
.Set("version", "1.0")
.Set("manifest_version", 2)
.Set("export",
- DictionaryBuilder().Set("whitelist",
- ListBuilder()
- .Append(whitelisted_id))
- .Set("resources",
- ListBuilder().Append("*"))).Build();
+ DictionaryBuilder()
+ .Set("whitelist",
+ std::move(ListBuilder().Append(whitelisted_id)))
+ .Set("resources", std::move(ListBuilder().Append("*"))))
+ .Build();
scoped_refptr<Extension> shared_module =
ExtensionBuilder()
.SetManifest(manifest.Pass())
