Remove BUG= and TEST= checks from upload commit presubmit check.
Fix PRESUBMIT.py to exclude Makefile.
BUG=none
TEST=presubmit check is less noisy
Review URL: http://codereview.chromium.org/5976009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71622 0039d316-1c4b-4281-b951-d872f2087c98
diff --git a/PRESUBMIT.py b/PRESUBMIT.py
index 0cff3dee..65df224 100644
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -9,10 +9,11 @@
"""
_EXCLUDED_PATHS = (
- r"breakpad[\\\/].*",
- r"net/tools/spdyshark/[\\\/].*",
- r"skia[\\\/].*",
- r"v8[\\\/].*",
+ r"^breakpad[\\\/].*",
+ r"^net/tools/spdyshark/[\\\/].*",
+ r"^skia[\\\/].*",
+ r"^v8[\\\/].*",
+ r".*MakeFile$",
)
_TEXT_FILES = (
@@ -106,10 +107,6 @@
input_api, output_api, source_file_filter=sources))
results.extend(input_api.canned_checks.CheckChangeHasNoStrayWhitespace(
input_api, output_api, source_file_filter=sources))
- results.extend(input_api.canned_checks.CheckChangeHasBugField(
- input_api, output_api))
- results.extend(input_api.canned_checks.CheckChangeHasTestField(
- input_api, output_api))
results.extend(input_api.canned_checks.CheckChangeSvnEolStyle(
input_api, output_api, source_file_filter=text_files))
results.extend(input_api.canned_checks.CheckSvnForCommonMimeTypes(
@@ -171,6 +168,10 @@
'http://build.chromium.org/p/chromium/json/builders?filter=1',
6,
IGNORED_BUILDERS))
+ results.extend(input_api.canned_checks.CheckChangeHasBugField(
+ input_api, output_api))
+ results.extend(input_api.canned_checks.CheckChangeHasTestField(
+ input_api, output_api))
return results
