| commit | 406b918251ac5b6a0e25dc5451589b825ca48a9e | [log] [tgz] |
|---|---|---|
| author | Istiaque Ahmed <[email protected]> | Fri Jul 26 06:28:33 2019 |
| committer | Commit Bot <[email protected]> | Fri Jul 26 06:28:33 2019 |
| tree | 8724be4ce832d9c2c3cfeb182001c28dcbc93657 | |
| parent | 3b9caaa4e5d1147595b1169bfc04d9940417b5a0 [diff] [blame] |
Provide and use a simpler version of ExtensionTabUtil::GetTabById. 14 out of 24 usages of ExtensionTabUtil::GetTabById didn't require |browser|, |tab_strip| and |tab_index| and specified nullptr for them. Provide a simpler version without these params and update callers to use the simplified version. Bug: None Test: No visible changes expected, internal only cleanup. Change-Id: I3cbdeee148c335b49c058b9498be097f43043c8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717458 Reviewed-by: Devlin <[email protected]> Commit-Queue: Istiaque Ahmed <[email protected]> Cr-Commit-Position: refs/heads/master@{#681201}
diff --git a/chrome/browser/extensions/extension_tab_util.h b/chrome/browser/extensions/extension_tab_util.h index 8d51f78..f255bc7c 100644 --- a/chrome/browser/extensions/extension_tab_util.h +++ b/chrome/browser/extensions/extension_tab_util.h
@@ -160,6 +160,10 @@ TabStripModel** tab_strip, content::WebContents** contents, int* tab_index); + static bool GetTabById(int tab_id, + content::BrowserContext* browser_context, + bool include_incognito, + content::WebContents** contents); // Takes |url_string| and returns a GURL which is either valid and absolute // or invalid. If |url_string| is not directly interpretable as a valid (it is