| commit | 428cc3d1c69fbdd0ee9209aea0d168ffd83fe6c7 | [log] [tgz] |
|---|---|---|
| author | Yu Han <[email protected]> | Wed Oct 21 22:42:13 2020 |
| committer | Commit Bot <[email protected]> | Wed Oct 21 22:42:13 2020 |
| tree | c8bd7bf4d753714835c1366ed3c1671751a20524 | |
| parent | 12eb87ad6701fb8ceb61c5884820b92d7e825b19 [diff] |
Reland "[Controls Refresh] Update controls styles for dark mode" This is a reland of 0397ac4eb3cdb0531dd55eb51d4477e59eead6c1 The original CL was reverted because it caused two tests failures on the win7 platform [1]. I think what happened I manually corrected the rebaseline tool's merging of some of the expected files. These led to not removing the expected files for these two tests on win7 platform. And since CQ's win7 builder doesn't auto run, it CL passed where it should have failed. I've since removed these two invalid expected files from win7 platform. In addition, I removed fuchsia/virtual/dark-color-scheme/fast/forms/color-scheme/color/color-picker-appearance-expected.png because its incorrect and I don't see the virtual suite tested on fuchsia. Ran CQ on all platforms and they passed. [1] https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%281%29/b8866243899672370144 Original change's description: > [Controls Refresh] Update controls styles for dark mode > > This CL updates the dark mode styles for the following controls: > 1. <meter> - border color. > 2. multi-select - foreground text color. > 3. Button: Dark mode button design has no border and has unique fill > color. Thus, a specific set of color enums is created for only > buttons. Button's border color is styled to match its fill color > in order to give the appearance of no borders and keep its > dimensions unchanged. This impacts: button, file, and color > controls. > > > Bug: 1107290, 1099624 > Change-Id: I141c199f93acac2b950b8af7195e863f811c2f4c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469357 > Commit-Queue: Yu Han <[email protected]> > Reviewed-by: Elly Fong-Jones <[email protected]> > Reviewed-by: Mason Freed <[email protected]> > Cr-Commit-Position: refs/heads/master@{#818119} Bug: 1107290 Bug: 1099624 Change-Id: I3097043a036da08dc201e0ce78ecc2ed1c94a1a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485039 Reviewed-by: Mason Freed <[email protected]> Reviewed-by: Elly Fong-Jones <[email protected]> Commit-Queue: Yu Han <[email protected]> Cr-Commit-Position: refs/heads/master@{#819549}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
