| commit | 463dba907242e14c5b49b219cfdd81c68f2fb54a | [log] [tgz] |
|---|---|---|
| author | Mark Cogan <[email protected]> | Thu Oct 29 18:02:08 2020 |
| committer | Commit Bot <[email protected]> | Thu Oct 29 18:02:08 2020 |
| tree | a93818a78a77794f42490eaab416386ec38ba18e | |
| parent | 0cbb40a94c4b3f8f6f2cb5915f03c7aa3be113fa [diff] |
[iOS] fix crash when deleting last incognito tab. In some circumstances, |connectedScenes| can contain a scene with no associated SceneController while cleaning up after the last OTR tab. This CL ensures that when this happens, the nil controller isn't added to the controller array. (Root cause for this state is unclear; some comments are added here as well to guide future investigations). Bug: 1142782 Change-Id: I33617e6e2252a2124870430c2eefc2cb4158a28c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506440 Commit-Queue: Mark Cogan <[email protected]> Reviewed-by: Robbie Gibson <[email protected]> Cr-Commit-Position: refs/heads/master@{#822260}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.