Google Git
Sign in
chromium / chromium / src / 4c287d67131d8e55f7148bab5c885341e558c07f
commit4c287d67131d8e55f7148bab5c885341e558c07f[log] [tgz]
authorMatthew Mourgos <[email protected]>Fri Oct 25 22:46:16 2019
committerCommit Bot <[email protected]>Fri Oct 25 22:46:16 2019
treefc14ba3a6713bf64ef3a3ed623944446b9771af7
parentc1be0e8f5b8dad17a4ec1ee5ea7c5585cf8c43b8 [diff]
cros: Correctly record AppListShowSource home button in tablet mode

This change ensures that the home button is not recorded as showing the
app list multiple times once the app list is already shown. Also correctly
records app list shown during transitions between tablet mode and
clamshell mode.

Tests have also been added to ensure that the AppListShowSource metric
is recorded correctly for the fixed cases.

Bug: 1013790
Change-Id: I67bb0f1de8b6bd20c03fd6ac586095d92255119b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869123
Commit-Queue: Matthew Mourgos <[email protected]>
Reviewed-by: Alex Newcomer <[email protected]>
Reviewed-by: Manu Cornet <[email protected]>
Cr-Commit-Position: refs/heads/master@{#709677}
6 files changed
tree: fc14ba3a6713bf64ef3a3ed623944446b9771af7
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. .vpython3
  61. AUTHORS
  62. BUILD.gn
  63. CODE_OF_CONDUCT.md
  64. codereview.settings
  65. DEPS
  66. ENG_REVIEW_OWNERS
  67. LICENSE
  68. LICENSE.chromium_os
  69. OWNERS
  70. PRESUBMIT.py
  71. PRESUBMIT_test.py
  72. PRESUBMIT_test_mocks.py
  73. README.md
  74. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .