commit 50a133b51fa9c6a3dc2b82ce9fedcf074859cd13
author davidben <davidben@chromium.org> Thu Oct 02 02:20:43 2014
committer Commit bot <commit-bot@chromium.org> Thu Oct 02 02:21:01 2014
tree daf57dbe2170a368999ef1839e63c64801d75e5c
parent 0d2885645b7f42e37e1aa09fa6a0794718e3df84

Fix crypto_unittests on Windows BoringSSL port.

MSVC is somewhat pickier about casting things to bool.

BUG=338884

Review URL: https://codereview.chromium.org/618123007

Cr-Commit-Position: refs/heads/master@{#297770}

crypto/signature_creator_openssl.cc

diff --git a/crypto/signature_creator_openssl.cc b/crypto/signature_creator_openssl.cc
index 51cb3c3e..7a1349b5 100644
--- a/crypto/signature_creator_openssl.cc
+++ b/crypto/signature_creator_openssl.cc
@@ -68,9 +68,8 @@
   signature->resize(RSA_size(rsa_key.get()));
 
   unsigned int len = 0;
-  bool success = RSA_sign(ToOpenSSLDigestType(hash_alg), data, data_len,
-                          vector_as_array(signature), &len, rsa_key.get());
-  if (!success) {
+  if (!RSA_sign(ToOpenSSLDigestType(hash_alg), data, data_len,
+                vector_as_array(signature), &len, rsa_key.get())) {
     signature->clear();
     return false;
   }