commit 51b41a6f25281c3d7378eb21a69e4fcacc8d13f2
author raymes <raymes@chromium.org> Fri Apr 24 02:45:04 2015
committer Commit bot <commit-bot@chromium.org> Fri Apr 24 02:45:22 2015
tree 09fcc70edafe59b657ff92cce912051c690c51e5
parent a960578de10cb263de359ec49bd29401f2849b24

Convert PrefSyncStatus into PrefRegistrationFlags

This converts the PrefSyncStatus enum which is passed at registration time of
a syncable pref into a more general "registration flags" mechansim for prefs.
PrefRegistrationFlags is an enum used in a bitmask to indicate different
options which can be passed when registering a pref.

Subclasses of PrefRegistry can use the first 8 bits of PrefRegistrationFlags
to specify their own flags. These are used by PrefRegistrySyncable to
specify whether or not the pref is syncable.

In a subsequent CL we plan to add a flag to indicate whether the pref is
"lossy" (see the bug linked).

BUG=476800

Review URL: https://codereview.chromium.org/1096833003

Cr-Commit-Position: refs/heads/master@{#326727}

base/prefs/pref_registry.h

diff --git a/base/prefs/pref_registry.h b/base/prefs/pref_registry.h
index a500b6e..cc5804e 100644
--- a/base/prefs/pref_registry.h
+++ b/base/prefs/pref_registry.h
@@ -5,6 +5,7 @@
 #ifndef BASE_PREFS_PREF_REGISTRY_H_
 #define BASE_PREFS_PREF_REGISTRY_H_
 
+#include "base/containers/hash_tables.h"
 #include "base/memory/ref_counted.h"
 #include "base/prefs/base_prefs_export.h"
 #include "base/prefs/pref_value_map.h"
@@ -27,10 +28,26 @@
 // also work, but this is being deprecated.
 class BASE_PREFS_EXPORT PrefRegistry : public base::RefCounted<PrefRegistry> {
  public:
+  // Registration flags that can be specified which impact how the pref will
+  // behave or be stored. This will be passed in a bitmask when the pref is
+  // registered. Subclasses of PrefRegistry can specify their own flags. Care
+  // must be taken to ensure none of these overlap with the flags below.
+  enum PrefRegistrationFlags {
+    // No flags are specified.
+    NO_REGISTRATION_FLAGS = 0,
+
+    // The first 8 bits are reserved for subclasses of PrefRegistry to use.
+  };
+
   typedef PrefValueMap::const_iterator const_iterator;
+  typedef base::hash_map<std::string, uint32> PrefRegistrationFlagsMap;
 
   PrefRegistry();
 
+  // Retrieve the set of registration flags for the given preference. The return
+  // value is a bitmask of PrefRegistrationFlags.
+  uint32 GetRegistrationFlags(const std::string& pref_name) const;
+
   // Gets the registered defaults.
   scoped_refptr<PrefStore> defaults();
 
@@ -47,11 +64,17 @@
   friend class base::RefCounted<PrefRegistry>;
   virtual ~PrefRegistry();
 
-  // Used by subclasses to register a default value for a preference.
-  void RegisterPreference(const std::string& path, base::Value* default_value);
+  // Used by subclasses to register a default value and registration flags for
+  // a preference. |flags| is a bitmask of |PrefRegistrationFlags|.
+  void RegisterPreference(const std::string& path,
+                          base::Value* default_value,
+                          uint32 flags);
 
   scoped_refptr<DefaultPrefStore> defaults_;
 
+  // A map of pref name to a bitmask of PrefRegistrationFlags.
+  PrefRegistrationFlagsMap registration_flags_;
+
  private:
   DISALLOW_COPY_AND_ASSIGN(PrefRegistry);
 };